Re: What's cooking in git.git (May 2017, #03; Wed, 10)

On Wed, May 10, 2017 at 7:18 AM, Junio C Hamano wrote: > * mg/status-in-progress-info (2017-04-14) 1 commit > - status: show in-progress info for short status > > "git status" learns an option to report various operations > (e.g. "merging") that the user is in the middle

Re: What's cooking in git.git (May 2017, #03; Wed, 10)

On Wed, May 10, 2017 at 7:18 AM, Junio C Hamano wrote: > [New Topics] > > * ab/compat-regex-update (2017-05-09) 2 commits > - compat/regex: update the gawk regex engine from upstream > - compat/regex: add a README with a maintenance guide > > Will merge to 'next'. [Sent

Re: [PATCH 08/29] grep: add tests for --threads=N and grep.threads

On Thu, May 11, 2017 at 8:36 PM, Brandon Williams <bmw...@google.com> wrote: > On 05/11, Ævar Arnfjörð Bjarmason wrote: >> Add tests for --threads=N being supplied on the command-line, or when >> grep.threads=N being supplied in the configuration. >> >> When the th

Re: [PATCH 21/29] grep: factor test for \0 in grep patterns into a function

On Thu, May 11, 2017 at 10:15 PM, Brandon Williams <bmw...@google.com> wrote: > On 05/11, Ævar Arnfjörð Bjarmason wrote: >> Factor the test for \0 in grep patterns into a function. Since commit >> 9eceddeec6 ("Use kwset in grep", 2011-08-21) any pattern contain

Re: [PATCH 24/29] grep: move two functions to avoid forward declaration

On Thu, May 11, 2017 at 10:14 PM, Brandon Williams <bmw...@google.com> wrote: > On 05/11, Ævar Arnfjörð Bjarmason wrote: >> Move the is_fixed() and has_null() functions which are currently only >> used in compile_regexp() earlier so they can be used in the PCRE >> fam

Re: [PATCH 28/29] grep: given --threads with NO_PTHREADS=YesPlease, warn

On Thu, May 11, 2017 at 10:21 PM, Brandon Williams <bmw...@google.com> wrote: > On 05/11, Ævar Arnfjörð Bjarmason wrote: >> Add a warning about missing thread support when grep.threads or >> --threads is set to a non 0 (default) or 1 (no parallelism) value >>

Re: [PATCH 1/7] grep: don't redundantly compile throwaway patterns under threading

On Fri, May 12, 2017 at 7:35 PM, Brandon Williams wrote: > On 05/11, Ęvar Arnfjörš Bjarmason wrote: >> Change the pattern compilation logic under threading so that grep >> doesn't compile a pattern it never ends up using on the non-threaded >> code path, only to compile it

[PATCH] C style: use standard style for "TRANSLATORS" comments

-#. * "rebase -i". +#. "rebase -i". 1. http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=10af7fe6bd 2. <2ce9ec406501d112e032c8208417f8100bed04c6.1397712142.git.worldhello@gmail.com> (https://public-inbox.org/git/2ce9ec406501d112e032c8208417f8100bed04c6.1397712142.git.w

Re: Possible bug in includeIf / conditional includes

On Wed, May 10, 2017 at 8:58 PM, Sebastian Schuberth wrote: > On 2017-05-10 19:00, raphael.st...@gmail.com wrote: > >> Current configuration which finds the conditional configuration. >> >> ~/.gitconfig >> [includeIf "gitdir:~/Work/git-repos/oss/"] >>path =

Re: send-email: Net::SSLeay failure

On Thu, Jun 8, 2017 at 3:32 AM, Samuel Lijin <sxli...@gmail.com> wrote: > On Wed, Jun 7, 2017 at 8:26 PM, Liam Breck <l...@networkimprov.net> wrote: >> On Wed, Jun 7, 2017 at 5:06 PM, Samuel Lijin <sxli...@gmail.com> wrote: >>> On Wed, Jun 7, 2017 at 4:43

Re: send-email: Net::SMTP::SSL failure

On Thu, Jun 8, 2017 at 2:06 AM, Samuel Lijin <sxli...@gmail.com> wrote: > On Wed, Jun 7, 2017 at 4:43 PM, Ævar Arnfjörð Bjarmason > <ava...@gmail.com> wrote: >> Ah, so you installed Net::SSLeay via CPAN, and then upgraded your Arch >> openssl, breaking the CPAN-bu

Re: send-email: Net::SSLeay failure

On Thu, Jun 8, 2017 at 11:06 AM, Samuel Lijin wrote: > Sorry, I should've been clearer. Currently send-email fails for me > with this error: > > SSLeay.c: loadable library and perl binaries are mismatched (got > handshake key 0xdb80080, needed 0xde00080) > > I thought the

[PATCH v2 1/2] git-compat-util: add a FREEZ() wrapper around free(ptr); ptr = NULL

. The only difference is that free() is called unconditionally, see [1]. 1. <alpine.DEB.2.20.1608301948310.129229@virtualbox> (http://public-inbox.org/git/alpine.DEB.2.20.1608301948310.129229@virtualbox/) Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- git-compat-uti

[PATCH v2 0/2] Add a FREEZ() wrapper macro

nition to be with other similar macros. * Just unconditionally call free(ptr), even if ptr is NULL, as we do everywhere else. Ævar Arnfjörð Bjarmason (2): git-compat-util: add a FREEZ() wrapper around free(ptr); ptr = NULL *.[ch] refactoring: make use of the FREEZ() macro a

[PATCH v2 2/2] *.[ch] refactoring: make use of the FREEZ() macro

Replace occurrences of `free(ptr); ptr = NULL` with `FREEZ(ptr)`. This introduces no functional changes, but reduces the line count and establishes this pattern as a common idiom with a wrapper macro. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- alias.c

Re: [PATCH] strbuf: let strbuf_addftime handle %z and %Z itself

On Mon, Jun 12, 2017 at 5:12 PM, Junio C Hamano wrote: > René Scharfe writes: > >> Am 07.06.2017 um 10:17 schrieb Jeff King: >>> On Sat, Jun 03, 2017 at 12:40:34PM +0200, René Scharfe wrote: Duplicates strbuf_expand to a certain extent, but not too badly, I

[PATCH 1/2] git-compat-util: add a freez() wrapper around free(x); x = NULL

Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- git-compat-util.h | 1 + 1 file changed, 1 insertion(+) diff --git a/git-compat-util.h b/git-compat-util.h index 4b7dcf21ad..21e3710755 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -787,6 +787,7 @@ extern char *xstrdup

[PATCH 2/2] *.[ch] refactoring: make use of the freez() wrapper

Replace occurrences of `free(p); p = NULL` with `freez(p)`. This introduces no functional changes, but cuts the number of lines spent on this cleanup in half. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- alias.c | 6 ++ apply.c

[PATCH 0/2] Add a freez() wrapper

po->commondir); > + freez(repo->objectdir); > + freez(repo->index_file); > + freez(repo->graft_file); > + freez(repo->namespace); It's not a problem with your patch, but something I thought would be nice to have in general, so here's a patch series to

Re: [PATCH] strbuf: let strbuf_addftime handle %z and %Z itself

On Mon, Jun 12, 2017 at 8:20 PM, Jeff King <p...@peff.net> wrote: > On Mon, Jun 12, 2017 at 07:53:21PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> >> Of course we can never know if you were in Tokyo or Seul from the info >> >> in the commit object, but we don

Re: [PATCH] strbuf: let strbuf_addftime handle %z and %Z itself

On Mon, Jun 12, 2017 at 6:56 PM, Ulrich Mueller wrote: >> On Mon, 12 Jun 2017, Ęvar Arnfjörš Bjarmason wrote: > >> On Mon, Jun 12, 2017 at 5:12 PM, Junio C Hamano wrote: >>> René Scharfe writes: Yes, or you could look up a time zone

Re: [PATCH 1/3] Contextually notify user about an initial commit

ndenting issue was introduced when the test was added in commit 1d2f393ac9 ("status/commit: show staged submodules regardless of ignore config", 2014-04-05). Helped-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> Helped-by: Junio C Hamano <gits...@pobox.com>

Re: [PATCH] die routine: change recursion limit from 1 to 1024

On Wed, Jun 21 2017, Simon Ruderich jotted: > On Tue, Jun 20, 2017 at 08:49:59PM +0200, Ævar Arnfjörð Bjarmason wrote: >> If I understand you correctly this on top: >> >> diff --git a/usage.c b/usage.c >> index 1c198d4882..f6d5af2bb4 100644 >> -

Re: [PATCH] die routine: change recursion limit from 1 to 1024

On Tue, Jun 20 2017, Jeff King jotted: > On Mon, Jun 19, 2017 at 10:00:36PM +0000, Ævar Arnfjörð Bjarmason wrote: > >> Change the recursion limit for the default die routine from a *very* >> low 1 to 1024. This ensures that infinite recursions are broken, but >> doe

[PATCH v2] die(): stop hiding errors due to overzealous recursion guard

t at exactly 1024 calls, and for printing the correct error and only one warning most of the time in the face of threaded death this is good enough and a net improvement on the current code. 1. for i in {1..1000}; do git grep -P --threads=8 '(*LIMIT_MATCH=1)-?-?-?---$' 2>&1|perl -pe 's/^

Re: [PATCH v2] die(): stop hiding errors due to overzealous recursion guard

e handler (which we really should be overriding if we're doing threading, but sometimes we're lazy) that it works most of the time, and that we at least don't hide real errors, which is the issue with it right now. > On Wed, Jun 21, 2017 at 4:47 PM, Ævar Arnfjörð Bjarmason > <ava...@gmail.com&

Re: Monitoring a repository for changes

On Wed, Jun 21 2017, Eric Wong jotted: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: >> On Wed, Jun 21 2017, Tim Hutt jotted: >> >> > Hi, >> > >> > Currently if you want to monitor a repository for changes there are >> > t

Re: [PATCH/FINAL] status: contextually notify user about an initial commit

current branch does not have any commits >> * Current branch waiting for initial commit >> >> The most succint one among the alternatives was chosen. >> >> Helped-by: Junio C Hamano <gits...@pobox.com> >> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91...@gm

Re: Monitoring a repository for changes

On Wed, Jun 21 2017, Tim Hutt jotted: > Hi, > > Currently if you want to monitor a repository for changes there are > three options: > > * Polling - run a script to check for updates every 60 seconds. > * Server side hooks > * Web hooks (on Github, Bitbucket etc.) > > Unfortunately for many

[PATCH 1/3] wildmatch: remove unused wildopts parameter

future use. Over 4 years later nothing has made use of it, let's just remove it. It can be added in the future if we find some reason to start using such a parameter. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- apply.c | 2 +- builtin/describe.c|

[RFC/PATCH 2/3] wildmatch: add interface for precompiling wildmatch() patterns

the wildmatch() function to e.g. parse the pattern into opcode as the BSD glob() implementation does, or to drop an alternate wildmatch() backend in which trades parsing slowness for faster matching. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- wildmatch.

[RFC/PATCH 3/3] wildmatch: make use of the interface for precompiling wildmatch() patterns

Make use of the batch wildmatch() interface. As noted in the comment here the main hot codepath is not being touched, but some other invocations where we repeatedly match the same glob against multiple strings have been migrated. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.

[PATCH 0/3] wildmatch refactoring

them. This is prep work for a local series of mine which compiles the wildmatch pattern into JIT-ed PCRE v2 patterns. That may or may not end up going anywhere, but as 2/3 notes just making these changes makes it easier to optimize wildmatch() further down the road. Ævar Arnfjörð Bjarmason (3): wildm

[PATCH] strbuf: change an always NULL/"" strbuf_addftime() param to bool

s be "", so the call to strbuf_addstr() just to add an empty string to the format was pointless. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- date.c | 2 +- strbuf.c | 5 ++--- strbuf.h | 5 +++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/date.c b

Re: [PATCH] strbuf: change an always NULL/"" strbuf_addftime() param to bool

On Fri, Jun 23 2017, Jeff King jotted: > On Fri, Jun 23, 2017 at 02:46:03PM +0000, Ævar Arnfjörð Bjarmason wrote: > >> Change the code for deciding what's to be done about %Z to stop >> passing always either a NULL or "" char * to >> strbuf_addftime(). Inst

[PATCH -v2] strbuf: change an always NULL/"" strbuf_addftime() param to bool

tz_name would always be "", so the call to strbuf_addstr() just to add an empty string to the format was pointless. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- I believe this addresses the comments in the thread so far. Also Re: René's "why const?" in a2673c

Re: your mail

On Thu, Jun 22 2017, Junio C. Hamano jotted: > Simon Ruderich writes: > >> On Thu, Jun 22, 2017 at 01:55:27PM +, Patrick Lehmann wrote: >>> The description on https://github.com/git/git doesn't reflect that policy. >>> >>> a) >>> It explains that discussions take place

Re: [showing-off RFC/PATCH 26/26] diff.c: have a "machine parseable" move coloring

On Tue, Jun 20 2017, Stefan Beller jotted: > + Ævar, who was not part of the email where I copied all recipients > from for this series. I played around with this a bit, it would be great to have something like this on top of --color-moved eventually. It's a lot easier to /^_ in a pager than

Re: What's cooking in git.git (Jun 2017, #06; Thu, 22)

On Thu, Jun 22 2017, Junio C. Hamano jotted: > * sb/diff-color-move (2017-06-21) 25 commits > - diff: document the new --color-moved setting > - diff.c: add dimming to moved line detection > - diff.c: color moved lines differently, plain mode > - diff.c: color moved lines differently > -

Re: What's cooking in git.git (Jun 2017, #06; Thu, 22)

On Thu, Jun 22 2017, Junio C. Hamano jotted: > * sd/branch-copy (2017-06-18) 3 commits > - branch: add a --copy (-c) option to go with --move (-m) > - branch: add test for -m renaming multiple config sections > - config: create a function to format section headers > > "git branch" learned

Re: Compile Error v2.13.2 on Solaris SPARC

&& !defined(__USLC__) && \ !defined(_M_UNIX) && !defined(__sgi) && !defined(__DragonFly__) && \ !defined(__TANDEM) && !defined(__QNX__) && !defined(__MirBSD__) && \ > > Greetings > Michael > > 2017-06-

ANNOUNCE: A mailing list for git packaging discussion

Now that my PCRE v2 patches have landed, I wanted to prod packagers of git to tell them they could build against it since they probably had it packaged already. After E-Mailing Jonathan Nieder about that asking if there was a better way to contact packagers than hunting down their E-Mails

Re: Compile Error v2.13.2 on Solaris SPARC

agnose you as Big Endian if it doesn't work, thus failing horribly on runtime. > Greetings > Michael > > 2017-06-26 14:47 GMT+02:00 Ævar Arnfjörð Bjarmason <ava...@gmail.com>: >> >> On Mon, Jun 26 2017, Michael Kebe jotted: >> >>> No luck with the patc

Re: NULL dereference in ab/wildmatch

On Sun, Jun 25, 2017 at 4:09 PM, Jeff King wrote: > On Sun, Jun 25, 2017 at 02:50:10AM -0700, scan-ad...@coverity.com wrote: > >> >> ** CID 1413016: Null pointer dereferences (FORWARD_NULL) >> /config.c: 213 in include_by_gitdir() >> >> >>

Re: What's cooking in git.git (Jun 2017, #07; Sat, 24)

On Mon, Jun 26 2017, Lars Schneider jotted: >> On 25 Jun 2017, at 01:25, Junio C Hamano wrote: > >> ... > >> * ab/sha1dc (2017-06-07) 2 commits >> - sha1collisiondetection: automatically enable when submodule is populated >> - sha1dc: optionally use sha1collisiondetection as

Re: [RFC/PATCH 2/3] wildmatch: add interface for precompiling wildmatch() patterns

On Sat, Jun 24 2017, Junio C. Hamano jotted: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> +struct wildmatch_compiled *wildmatch_compile(const char *pattern, unsigned >> int flags) >> +{ >> +struct wildmatch_compiled *code = xmalloc(

Re: [PATCH] strbuf: change an always NULL/"" strbuf_addftime() param to bool

On Fri, Jun 23 2017, René Scharfe jotted: > Am 23.06.2017 um 17:23 schrieb Jeff King: >> On Fri, Jun 23, 2017 at 05:13:38PM +0200, Ævar Arnfjörð Bjarmason wrote: >> >>>> The idea was that eventually the caller might be able to come up with a >>>> TZ

[PATCH v3 2/2] strbuf: change an always NULL/"" strbuf_addftime() param to bool

X5OQc45fUyDVayE89rkT=+8m5s4efsxcabcy7upme5...@mail.gmail.com (https://public-inbox.org/git/CACBZZX5OQc45fUyDVayE89rkT=+8m5s4efsxcabcy7upme5...@mail.gmail.com/) Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- On Fri, Jun 23 2017, Jeff King jotted: > On Fri, Jun 23, 2017 at 04:36:06PM +

[PATCH v3 1/2] strbuf.h comment: discuss strbuf_addftime() arguments in order

Change the comment documenting the strbuf_addftime() function to discuss the parameters in the order in which they appear, which makes this easier to read than discussing them out of order. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- I though it was more readable to spl

[PATCH v4 2/2] strbuf: change an always NULL/"" strbuf_addftime() param to bool

X5OQc45fUyDVayE89rkT=+8m5s4efsxcabcy7upme5...@mail.gmail.com (https://public-inbox.org/git/CACBZZX5OQc45fUyDVayE89rkT=+8m5s4efsxcabcy7upme5...@mail.gmail.com/) Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- On Sat, Jun 24, 2017 at 2:02 PM, Jeff King <p...@peff.net> wrote: > On Sa

[PATCH v4 1/2] strbuf.h comment: discuss strbuf_addftime() arguments in order

Change the comment documenting the strbuf_addftime() function to discuss the parameters in the order in which they appear, which makes this easier to read than discussing them out of order. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- strbuf.h | 2 +- 1 file changed, 1 ins

[PATCH v5 2/2] strbuf: change an always NULL/"" strbuf_addftime() param to bool

X5OQc45fUyDVayE89rkT=+8m5s4efsxcabcy7upme5...@mail.gmail.com (https://public-inbox.org/git/CACBZZX5OQc45fUyDVayE89rkT=+8m5s4efsxcabcy7upme5...@mail.gmail.com/) Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- On Sat, Jun 24, 2017 at 2:10 PM, Ævar Arnfjörð Bjarmason <ava...@gmail.com>

[PATCH v5 1/2] strbuf.h comment: discuss strbuf_addftime() arguments in order

Change the comment documenting the strbuf_addftime() function to discuss the parameters in the order in which they appear, which makes this easier to read than discussing them out of order. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- strbuf.h | 2 +- 1 file changed, 1 ins

Re: Restoring detached HEADs after Git operations

On Mon, Jun 19 2017, Patrick Lehmann jotted: > Hello, > > I wrote a Bash script to recover branch names after Git operations have > create detached HEADs in a Git repository containing lots of Git submodules. > The script works recursively. > > I would like to see: > a) that script or

[PATCH] die routine: change recursion limit from 1 to 1024

ecause we're overly paranoid about our recursion check. So let's just set the recursion limit to a number higher than the number of threads we're ever likely to spawn. Now we won't lose errors, and if we have a recursing die handler we'll still die within microseconds. Signed-off-by: Ævar Arnfjörð

[PATCH] grep: fix erroneously copy/pasted variable in check/assert pattern

pply its own context object when matching, and we'd run normally at the trivial expense of not getting a slight speedup by sharing the context object between successive matches. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 1/3] Contextually notify user about an initial commit

--- >> status: contextually notify user about an initial commit >> >> Change the output of "status" to say "No commits yet" when "git >> retaining the current "Initial commit" message displayed in the >> template that's displayed in

Re: [PATCH] die routine: change recursion limit from 1 to 1024

eaningful error, but may of course do so multiple times, which is a subject for a fix in git-grep in particular, but the point is again, to fix the general case for the default handler. Something something sorry about the long mail didn't have time to write a shorter one :) >> Signed-off-b

Re: Compile Error v2.13.2 on Solaris SPARC

>> (defined(_FOO2) && (_FOO2 == _BAR2)) || \ >> (defined(_FOO3) && (_FOO3 == BAR3)) ) >> #define SHA1DC_BIGENDIAN >> #endif >> >> #endif >> -8<-- >> ht

Re: [PATCH 1/3] sha1dc: update from my PR #36

On Tue, Jun 27 2017, Junio C. Hamano jotted: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Update sha1dc from my PR #36[1] which'll hopefully be integrated by >> upstream soon. > > Please be careful about the title of the patch. "log --oneline

Re: [PATCH 1/3] sha1dc: update from my PR #36

On Tue, Jun 27 2017, Junio C. Hamano jotted: > Junio C Hamano <gits...@pobox.com> writes: > >> Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: >> >>> +#else /* Not under GCC-alike or glibc or or >>> */ >>> + >>> +#

Re: [PATCH 1/3] sha1dc: update from my PR #36

On Tue, Jun 27 2017, Junio C. Hamano jotted: > Junio C Hamano writes: > >>> +#if (defined(__ARMEB__) || defined(__THUMBEB__) || defined(__AARCH64EB__) >>> || \ >>> defined(__MIPSEB__) || defined(__MIPSEB) || defined(_MIPSEB) || \ >>> defined(__sparc)) >>> +/* >>>

Re: [PATCH] rebase -i: Add missing newline to end of message

On Fri, May 19, 2017 at 12:13 PM, Phillip Wood wrote: > On 18/05/17 22:21, Johannes Schindelin wrote: >> Hi Phillip, >> >> On Thu, 18 May 2017, Phillip Wood wrote: >> >>> From: Phillip Wood >>> >>> The message that's printed when

Re: [PATCH v2] send-email: Net::SMTP::SSL is obsolete, use only when necessary

On Fri, May 19, 2017 at 10:54 PM, Dennis Kaarsemaker <den...@kaarsemaker.net> wrote: > Second ping. This problem is not going away, so if this solution is not > acceptable, I'd like to know what needs to be improved. FWIW: Reviewed-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com&g

Re: [PATCH v2 5/6] fsmonitor: add documentation for the fsmonitor extension.

On Thu, May 18, 2017 at 10:13 PM, Ben Peart wrote: > This includes the core.fsmonitor setting, the query-fsmonitor hook, > and the fsmonitor index extension. > > Signed-off-by: Ben Peart > --- > Documentation/config.txt | 7 +++ >

[PATCH v2 2/2] sha1dc: optionally use sha1collisiondetection as a submodule

any kinks. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- .gitmodules| 4 Makefile | 12 hash.h | 4 sha1collisiondetection | 1 + 4 files changed, 21 insertions(+) create mode 100644 .gitmodules create mode

[PATCH v2 0/2] Update sha1dc from upstream & optionally make it a submodule

On Sat, May 20, 2017 at 1:13 PM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Replace the forked sha1dc directory with a copy of the upstream code >> imported as a submodule. This is the exact same code

[PATCH v2 1/2] sha1dc: update from upstream

ion/commit/33a694a9ee1b79c24be45f9eab5ac0e1aeeaf271 3. "Git 2.13.0 segfaults on Solaris SPARC due to DC_SHA1=YesPlease being on by default" (https://public-inbox.org/git/cacbzzx6nmkk8af0-upjckwv4r+hv-uk2xwxva5u+_uq3vxu...@mail.gmail.com/) Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile

Re: [PATCH v2 5/6] fsmonitor: add documentation for the fsmonitor extension.

On Mon, May 22, 2017 at 6:18 PM, Ben Peart <peart...@gmail.com> wrote: > On 5/20/2017 8:10 AM, Ævar Arnfjörð Bjarmason wrote: >>> >>> +== File System Monitor cache >>> + >>> + The file system monitor cache tracks files for which the >>>

Re: Another git repo at kernel.org?

On Mon, May 22, 2017 at 8:34 PM, Stefan Beller wrote: > The Git community considers using submodules for some parts of the > code (a third party lib, SHA1DC, computing SHA1s that warn about > potential attachs, see shattered.io) [1]. > > We are also concerned about single

Re: [PATCH] rebase -i: Add missing newline to end of message

On Thu, May 18, 2017 at 3:41 PM, Phillip Wood wrote: > From: Phillip Wood > > The message that's printed when auto-stashed changes are successfully > restored was missing '\n' at the end. Both this and your reflog message really seem like

BUG: The .gitignore rules can't be made to cross submodule boundaries

When I was adding the sha1collisiondetection submodule to git.git I noticed that building git would dirty the submodule. This is because our own Makefile adds .depend/ directories. I hacked around it by just getting the upstream project accept carrying an ignore rule for that around:

Re: [PATCH v2 0/2] Update sha1dc from upstream & optionally make it a submodule

On Tue, May 23, 2017 at 12:27 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> I liked the suggestion to make the URL a relative path, but this would >> require you to maintain a mirror in th

[PATCH v2 7/7] grep: add support for PCRE v2

makes the code look nicer. 1. https://lists.exim.org/lurker/message/20150105.162835.0666407a.en.html 2. https://lists.exim.org/lurker/thread/20170419.172322.833ee099.en.html Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 30 +--- configure.ac | 77 ++

[PATCH v2 6/7] grep: un-break building with PCRE < 8.20

han 7.5 as I'm confident that if the build breaks on those older versions it's not because of my JIT change. See the "un-break" change in this series ("grep: un-break building with PCRE < 8.32", 2017-05-10) for why this isn't squashed into the main PCRE JIT commit. Signed

[PATCH v2 2/7] grep: skip pthreads overhead when using one thread

tirely when 1 thread is requested. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/grep.c b/builtin/grep.c index 12e62fcbf3..bd008cb100 100644 --- a/builtin/grep.c +++ b/builtin/grep.c @@ -1238,6 +1238,

[PATCH v2 5/7] grep: un-break building with PCRE < 8.32

rsions. 1. http://www.pcre.org/original/changelog.txt ("28. Introducing a native interface for JIT. Through this interface, the compiled[...]") 2. https://bugs.exim.org/show_bug.cgi?id=2121 Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 8

[PATCH v2 0/7] PCRE v2, PCRE v1 JIT, log -P & fixes

On Sun, May 21, 2017 at 1:50 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason  <ava...@gmail.com> writes: > >> Easy to review? 29 (I mean 30) patches? Are you kidding me?! >> >> As noted in v1 (<20170511091829.5634-1-ava...@gmai

[PATCH v2 3/7] log: add -P as a synonym for --perl-regexp

ment, as the log command already uses that for -G. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Documentation/rev-list-options.txt | 1 + revision.c | 2 +- t/t4202-log.sh | 12 3 files changed, 14 insertions

[PATCH v2 4/7] grep: add support for the PCRE v1 JIT API

info. There's no graceful fallback if pcre_jit_stack_alloc() fails under PCRE_CONFIG_JIT, instead the program will simply abort. I don't think this is worth handling gracefully, it'll only fail in cases where malloc() doesn't work, in which case we're screwed anyway. Signed-off-by: Ævar Arnfjörð

[PATCH v2 1/7] grep: don't redundantly compile throwaway patterns under threading

before the first thread is started. 1. http://sljit.sourceforge.net/pcre.html Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/builtin/grep.c b/builtin/grep.c index b1095362fb..12

Re: What's cooking in git.git (May 2017, #07; Tue, 23)

On Tue, May 23, 2017 at 9:38 PM, Stefan Beller wrote: > On Tue, May 23, 2017 at 12:08 PM, Stefan Beller wrote: >> On Tue, May 23, 2017 at 1:08 AM, Junio C Hamano wrote: >> >>> * sb/submodule-blanket-recursive (2017-05-23) 6 commits >>>

[PATCH] wildmatch test: remove redundant duplicate test

ntegration with git by accident. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t3070-wildmatch.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh index ef509df351..7ca69f4bed 100755 --- a/t/t3070-wildmatch.sh +++ b/t/t3070-wildma

Re: [PATCH v2 2/2] sha1dc: optionally use sha1collisiondetection as a submodule

On Mon, May 22, 2017 at 4:48 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> But when somebody (like me?) feels strongly enough, such a change >> can always come on top of this patch, so let's have this >> manual-configuration-only version as our

Re: [PATCH v3 05/30] log: make --regexp-ignore-case work with --perl-regexp

On Sun, May 21, 2017 at 1:50 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> Make the --regexp-ignore-case option work with --perl-regexp. This >> never worked, and there was no test for this. Fix the bug and

[PATCH v3 23/30] grep: change the internal PCRE macro names to be PCRE1

code and the USE_LIBPCRE Makefile argument was added in commit 63e7e9d8b6 ("git-grep: Learn PCRE", 2011-05-09). At the time there was no indication that the PCRE project would release an entirely new & incompatible API around 3 years later. Signed-off-by: Ævar Arnfjörð Bjarmason

[PATCH v3 29/30] grep: given --threads with NO_PTHREADS=YesPlease, warn

able via pack.threads, and have long warned about the same under NO_PTHREADS=YesPlease. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 13 + t/t7810-grep.sh | 18 ++ 2 files changed, 31 insertions(+) diff --git a/builtin/grep.c b/builti

[PATCH v3 30/30] grep: assert that threading is enabled when calling grep_{lock,unlock}

n unless we're spawning threads. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/builtin/grep.c b/builtin/grep.c index 3c721b75a5..b1095362fb 100644 --- a/builtin/grep.c +++ b/builtin/gre

[PATCH v3 10/30] grep: amend submodule recursion test for regex engine testing

tests for pattern style options & config", 2017-04-07). The pattern "(.|.)[\d]" will match this content differently under fixed/basic/extended & perl. This test code was originally added in commit 0281e487fd ("grep: optionally recurse into submodules", 2016-1

[PATCH v3 13/30] grep: prepare for testing binary regexes containing rx metacharacters

mp; non-ASCII data. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7008-grep-binary.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t7008-grep-binary.sh b/t/t7008-grep-binary.sh index df93d8e44c..20370d6e0c 100755 --- a/t/t7008-grep-binary.sh +++

[PATCH v3 09/30] grep: add tests for --threads=N and grep.threads

t --threads=N without pthreads still returns expected results. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7810-grep.sh | 16 1 file changed, 16 insertions(+) diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh index daa906b9b0..561709ef6a 100755 --- a/t/t7

[PATCH v3 22/30] grep: factor test for \0 in grep patterns into a function

h) smaller. While I'm at it make the comment conform to the style guide, i.e. add an opening "/*\n". Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/grep.c b/grep.c in

[PATCH v3 15/30] perf: add a GIT_PERF_MAKE_COMMAND for when *_MAKE_OPTS won't do

Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 3 +++ t/perf/README | 19 +-- t/perf/run| 11 +-- 3 files changed, 29 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index eedadb8056..d1587452f1 100644 --- a/Makefile

[PATCH v3 18/30] perf: add a comparison test of grep regex engines with -F

29(0.71+0.53) I'm planning to make that not be the case, this performance test gives a baseline for comparing performance before & after any such change. See commit ("perf: add a comparison test of grep regex engines", 2017-04-19) for details on the machine the above test run was executed o

[PATCH v3 27/30] pack-objects & index-pack: add test for --threads warning

-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t5300-pack-object.sh | 36 1 file changed, 36 insertions(+) diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh index 43a672c345..6ed23ee1d2 100755 --- a/t/t5300-pack-object.sh +++ b/t/t5300-pack

[PATCH v3 25/30] grep: move is_fixed() earlier to avoid forward declaration

Move the is_fixed() function which are currently only used in compile_regexp() earlier so it can be used in the PCRE family of functions in a later change. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 24 1 file changed, 12 insertions(

[PATCH v3 16/30] perf: emit progress output when unpacking & building

what's going on and what revision is being tested as the output scrolls by. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/run | 2 ++ 1 file changed, 2 insertions(+) diff --git a/t/perf/run b/t/perf/run index b61024a830..beb4acc0e4 100755 --- a/t/perf/run +++ b/

[PATCH v3 11/30] grep: add tests for grep pattern types being passed to submodules

long correctly. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7814-grep-recurse-submodules.sh | 49 ++ 1 file changed, 49 insertions(+) diff --git a/t/t7814-grep-recurse-submodules.sh b/t/t7814-grep-recurse-submodules.sh index 1472855e1

[PATCH v3 21/30] grep: remove redundant regflags assignments

There is no reason to do this anymore, so stop doing it, more to reduce "wait this is used under fixed/BRE/PCRE how?" confusion when reading the code, than to to save ourselves trivial CPU cycles by removing one assignment. 1. "built-in "git grep"", 2006-04-30.

[PATCH v3 26/30] test-lib: add a PTHREADS prerequisite

Add a PTHREADS prerequisite which is false when git is compiled with NO_PTHREADS=YesPlease. There's lots of custom code that runs when threading isn't available, but before this prerequisite there was no way to test it. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Ma

<    4   5   6   7   8   9   10   11   12   13   >