Re: [PATCH] mailmap: fix check for freeing memory

On 08/20/2013 03:40 PM, Thomas Rast wrote: Stefan Beller stefanbel...@googlemail.com writes: The condition as it is written in that line was most likely intended to check for the pointer passed to free(), rather than checking for the 'repo_abbrev', which is already checked against being non

Re: [PATCH] mailmap: fix check for freeing memory

On 08/20/2013 04:23 PM, Thomas Rast wrote: Stefan Beller stefanbel...@googlemail.com writes: As I am resending the patch, could somebody please explain me the mechanism of the # repo-abbrev: line? Even git itself doesn't use it in the .mailmap file, but a quick google search shows up only

Re: [RFC PATCHv4] repack: rewrite the shell script in C.

On 08/20/2013 03:31 PM, Johannes Sixt wrote: Are the long forms of options your invention? I tried to keep strong similarity with the shell script for ease of review. In the shellscript the options where put in variables having these names, so for example there was: -f)

Re: [RFC PATCHv4] repack: rewrite the shell script in C.

On 08/20/2013 03:31 PM, Johannes Sixt wrote: +packdir = mkpathdup(%s/pack, get_object_directory()); +packtmp = mkpathdup(%s/.tmp-%d-pack, packdir, getpid()); Should this not be packdir = xstrdup(git_path(pack)); packtmp = xstrdup(git_path(pack/.tmp-%d-pack, getpid()));

Dokumenting api-paths.txt

On 08/20/2013 11:34 PM, Jonathan Nieder wrote: Stefan Beller wrote: On 08/20/2013 03:31 PM, Johannes Sixt wrote: +packdir = mkpathdup(%s/pack, get_object_directory()); +packtmp = mkpathdup(%s/.tmp-%d-pack, packdir, getpid()); Should this not be packdir = xstrdup(git_path(pack

Re: [RFC PATCHv4] repack: rewrite the shell script in C.

require more lines (init, add to buffer, get as char*) Below there is just the diff against RFC PATCHv4, however I'll send the whole patch as well. Thanks, Stefan --8-- From e544eb9b7bdea6c2000c5f0d3043845fb901e90b Mon Sep 17 00:00:00 2001 From: Stefan Beller stefanbel...@googlemail.com Date

[PATCH] repack: rewrite the shell script in C.

This is the beginning of the rewrite of the repacking. All tests are constantly positive now. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- Makefile| 2 +- builtin.h | 1 + builtin/repack.c

Re: [PATCH 0/2] git-config and large integers

On 08/21/2013 12:39 AM, Jeff King wrote: I was playing with a hook for file size limits that wanted to store the limit in git-config. It turns out we don't do a very good job of big integers: $ git config foo.size 2g $ git config --int foo.size -2147483648 Oops. After this series,

Re: [PATCH] repack: rewrite the shell script in C.

On 08/21/2013 10:25 AM, Jonathan Nieder wrote: +static int delta_base_offset = 0; The = 0 is automatic for statics without an initializer. The prevailing style in git is to leave it out. Behavior change: in the script, wasn't the default true? Yes, I was printing out the arguments of

Re: [PATCH] repack: rewrite the shell script in C.

On 08/21/2013 10:49 AM, Matthieu Moy wrote: +if (start_command(cmd)) + return 1; A warning message would be welcome in addition to returning 1. Johannes Sixt proposes to retain the return value of the sub process, which I'd agree on. However why do we need a warning message

Re: [PATCH] repack: rewrite the shell script in C.

On 08/21/2013 10:49 AM, Matthieu Moy wrote: I tend to dislike these set a variable and break twice to exit nested loops. Using an auxiliary function, you could just do int f() { for_each { for () { ... if ()

Re: [PATCH] repack: rewrite the shell script in C.

On 08/21/2013 10:25 AM, Jonathan Nieder wrote: Hi, Stefan Beller wrote: [PATCH] repack: rewrite the shell script in C. Thanks for your work so far. This review will have mostly cosmetic notes. Hopefully others can try it out to see if the actual behavior is good. Thanks for all

[RFC PATCHv6 2/2] repack: retain the return value of pack-objects

, the proposed change is put in this extra commit. The infrastructure however was already setup in the previous commit. (Having a local 'ret' variable) Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- builtin/repack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[RFC PATCHv6 1/2] repack: rewrite the shell script in C

more library facilities, but this patch is meant to be as close to a no-op as possible so it doesn't do that kind of thing. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- Makefile| 2 +- builtin.h | 1

Re: [RFC PATCHv6 1/2] repack: rewrite the shell script in C

On 08/22/2013 12:50 AM, Junio C Hamano wrote: Stefan Beller stefanbel...@googlemail.com writes: +static int delta_base_offset = 1; +char *packdir; Does this have to be global? We could pass it to all the functions, making it not global. Sorry for being unclear; I meant not static

[PATCH] repack: rewrite the shell script in C (squashing proposal)

(wrong variable name) Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- builtin/repack.c | 78 ++-- 1 file changed, 36 insertions(+), 42 deletions(-) diff --git a/builtin/repack.c b/builtin/repack.c index 1f13e0d..e0d1f17 100644

Re: What's cooking in git.git (Aug 2013, #07; Wed, 28)

On 08/29/2013 09:20 AM, Matthieu Moy wrote: it's time to send the squashed and hopefully final version. I will do so tonight. Thanks, Stefan signature.asc Description: OpenPGP digital signature

[PATCH 1/2] repack: rewrite the shell script in C

to be as close to a no-op as possible so it doesn't do that kind of thing. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- Makefile| 2 +- builtin.h | 1 + builtin/repack.c| 379

[PATCHv7 0/2] Rewriting repack in C

) run_command(cmd); argv_array_clear(cmd_args); } + remove_temporary_files(); return 0; } -- 1.8.4 Stefan Beller (2): repack: rewrite the shell script in C repack: retain the return value of pack-objects Makefile

[PATCH 2/2] repack: retain the return value of pack-objects

, the proposed change is put in this extra commit. The infrastructure however was already setup in the previous commit. (Having a local 'ret' variable) Signed-off-by: Stefan Beller stefanbel...@googlemail.com Signed-off-by: Junio C Hamano gits...@pobox.com --- builtin/repack.c | 4 ++-- 1 file changed, 2

Re: [PATCHv7 0/2] Rewriting repack in C

On 08/29/2013 10:53 PM, Junio C Hamano wrote: Stefan Beller stefanbel...@googlemail.com writes: Here is a diff since the last time sending this patch series: This is very readable. There may be people who misread LOOSE as LOSE; the option -A is about making the unreachable ones loose

Re: What's cooking in git.git (Sep 2013, #02; Mon, 9)

On 09/10/2013 12:53 AM, Junio C Hamano wrote: * sb/repack-in-c (2013-08-30) 2 commits - repack: retain the return value of pack-objects - repack: rewrite the shell script in C Any further reviews? Just came home from holiday (with no internet ;) but I'll review my code now that I have

Re: [PATCH 1/2] repack: rewrite the shell script in C

the series as well. --8-- From 63c94df8c74c6643d6291c324661a939b9945619 Mon Sep 17 00:00:00 2001 From: Stefan Beller stefanbel...@googlemail.com Date: Sun, 15 Sep 2013 17:05:49 +0200 Subject: [PATCH 1/2] Suggestions by Rene --- builtin/repack.c | 25 - 1 file changed, 16

[PATCH 2/3] repack: retain the return value of pack-objects

, the proposed change is put in this extra commit. The infrastructure however was already setup in the previous commit. (Having a local 'ret' variable) Signed-off-by: Stefan Beller stefanbel...@googlemail.com Signed-off-by: Junio C Hamano gits...@pobox.com --- builtin/repack.c | 4 ++-- 1 file changed, 2

[PATCH 1/3] repack: rewrite the shell script in C

to be as close to a no-op as possible so it doesn't do that kind of thing. Signed-off-by: Stefan Beller stefanbel...@googlemail.com Signed-off-by: Junio C Hamano gits...@pobox.com --- Makefile | 2 +- builtin.h | 1 + builtin/repack.c | 387

[PATCH 3/3] repack: improve warnings about failure of renaming and removing files

Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- builtin/repack.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/builtin/repack.c b/builtin/repack.c index d345d16..f7e91bf 100644 --- a/builtin/repack.c +++ b/builtin/repack.c @@ -327,7 +327,7 @@ int cmd_repack

git installation fails in home directory on ubuntu 12.04

So I did git fetch git rebase git describe v1.7.12-503-g5976753 ./configure --prefix=/home/sb make make install GEN perl/PM.stamp SUBDIR gitweb SUBDIR ../ SUBDIR perl make[1]: `perl.mak' is up to date. make[2]: `GIT-VERSION-FILE' is up to date. GEN git-instaweb SUBDIR

[PATCH] archive-zip:write_zip_entry: Remove second reset of size variable to zero.

It is set to zero just 3 lines before. Reported by cppcheck. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- archive-zip.c | 1 - 1 file changed, 1 deletion(-) diff --git a/archive-zip.c b/archive-zip.c index b2c4fe0..4bde019 100644 --- a/archive-zip.c +++ b/archive-zip.c @@ -232,7

[PATCH] daemon.c:handle: Remove unneeded check for null pointer.

The handle function has the signature static void handle(int incoming, struct sockaddr *addr, socklen_t addrlen); so the addr pointer may be passed as null syntactically. However there is just one place in daemon.c, which calls the handle function in function service_loop in daemon.c:1044:

[PATCH] fast-import: Remove redundant assignment of 'oe' to itself.

Reported by cppcheck. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- fast-import.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fast-import.c b/fast-import.c index 5f539d7..0142e3a 100644 --- a/fast-import.c +++ b/fast-import.c @@ -2914,7 +2914,7 @@ static

Re: [PATCH] fast-import: Remove redundant assignment of 'oe' to itself.

, Stefan Beller wrote: Reported by cppcheck. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- fast-import.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fast-import.c b/fast-import.c index 5f539d7..0142e3a 100644 --- a/fast-import.c +++ b/fast-import.c

Re: [PATCH] fast-import: Remove redundant assignment of 'oe' to itself.

The line in question was not fixed up, but originally added in 85c6239. However I see your point, it may reintroduce warnings. Regards, Stefan On 05/26/2013 10:17 PM, Stefano Lattarini wrote: On 05/26/2013 10:14 PM, Stefan Beller wrote: It's not done very often. Of course; it's done only

[PATCH] .mailmap: Map H.Merijn Brand to H. Merijn Brand

are indeed the same person. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 48d7acf..345cce6 100644 --- a/.mailmap +++ b/.mailmap @@ -24,6 +24,7 @@ Eric S. Raymond e...@thyrsus.com Erik Faye-Lund

[PATCH 4/6] .mailmap: Multiple mail addresses of Keith Cascio

Capital letters in mail address. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 6d75678..1e94906 100644 --- a/.mailmap +++ b/.mailmap @@ -52,6 +52,7 @@ Junio C Hamano gits...@pobox.com ju

[PATCH 0/6] Corrections to the mailmap file

of different capitalization onto the same entity. (Example n...@mit.edu is the same as n...@mit.edu) I intend to contact each of the persons individually and ask whether just their mail address changed, or if they are indeed different persons. Stefan Beller Stefan Beller (6): .mailmap: Multiple email

[PATCH 2/6] .mailmap: Multiple mail addresses of Alex Riesen

Signed-off-by: Stefan Beller stefanbel...@googlemail.com Signed-off-by: Alex Riesen raa.l...@gmail.com --- .mailmap | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.mailmap b/.mailmap index 3a4dd49..cd46d24 100644 --- a/.mailmap +++ b/.mailmap @@ -6,6 +6,9 @@ # Alejandro R. Sedeño ased

[PATCH 5/6] .mailmap: Multiple mail addresses of Johannes Schindelin

Different capitalization. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 1e94906..d7d7b89 100644 --- a/.mailmap +++ b/.mailmap @@ -38,6 +38,7 @@ Jakub Narębski jna...@gmail.com Jay Soffian

[PATCH 3/6] .mailmap: Multiple mail addresses of Paul Mackerras

This is an obvious one, as the .(none) addresses are not valid mail addresses. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index cd46d24..6d75678 100644 --- a/.mailmap +++ b/.mailmap @@ -76,6

[PATCH 1/6] .mailmap: Multiple email addresses of Alejandro R. Sedeño

This is obvious as its only difference is capital letters in one of the mail addresses. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 345cce6..3a4dd49 100644 --- a/.mailmap +++ b/.mailmap

[PATCH 6/6] .mailmap: Multiple mail addresses of Toby Allsopp

Different capitalization Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index d7d7b89..7e5638d 100644 --- a/.mailmap +++ b/.mailmap @@ -97,6 +97,7 @@ Steven Grimm kor...@midwinter.com Tay Ray Chuan

Re: [PATCH 0/6] Corrections to the mailmap file

shortlog -sne | grep \$trimmed\ done mailmapdoubles mailmapdoubles2 sh mailmapdoubles2 rm mailmapdoubles rm mailmapdoubles2 On 07/04/2013 04:04 PM, Stefan Beller wrote: Hello, I noticed many duplicates in email addresses but having the same name by running: # Finding out duplicates

[PATCH] Documentation on depth option in git clone.

--- Documentation/git-clone.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/git-clone.txt b/Documentation/git-clone.txt index 7fefdb0..e76aa50 100644 --- a/Documentation/git-clone.txt +++ b/Documentation/git-clone.txt @@ -186,7 +186,8 @@ objects from the

[PATCH] git clone depth of 0 not possible.

transport.h) uses value 0 for another meaning, so it would have need changes at all places, where the transport options depth is being used (e.g. fetch) So I documented the current behavior, see attached patch. Stefan Beller (1): Documentation on depth option in git clone. Documentation/git

Re: [PATCH] add warning for depth=0 in git clone.

Hi, I am struggling a little with the development process, is a sign-off strictly required for git as it is for kernel development? If so here would be my sign-off: Signed-off-by: Stefan Beller stefanbel...@googlemail.com This adds a warning and the previous patch adds the documentation

Re: [PATCH] git clone depth of 0 not possible.

On 01/08/2013 03:28 PM, Duy Nguyen wrote: On Tue, Jan 8, 2013 at 2:36 PM, Junio C Hamano gits...@pobox.com wrote: Speaking of --depth, I think in Git 2.0 we should fix the semantics of deepening done with git fetch. Speaking of 2.0, we should support depth per ref. Well we don't have to

Re: On --depth=funny value

On 01/09/2013 03:53 AM, Junio C Hamano wrote: Can people sanity check the reasoning outlined here? Anything I missed? The above outline identifies three concrete tasks that different people can tackle more or less independently, each with updated code, documentation and test: 1. git

Re: [PATCH 1/2] repack: rewrite the shell script in C

On 09/15/2013 05:31 PM, Stefan Beller wrote: Rene, thank you very much for the review! the parameter hex contains the pack- already. The remove_redundant_pack function is called in a loop iterating over elements of existing_packs, which is filled in get_non_kept_pack_filenames, which

Re: What's cooking in git.git (Sep 2013, #07; Mon, 23)

On 09/23/2013 11:10 PM, Jonathan Nieder wrote: You can find the changes described here in the integration branches at https://repo.or.cz/r/git/jrn.git I am still catching up on patches sent since last week. If I have missed yours, do not despair, but feel free to send me a reminder to

[PATCH] repack: Add --version parameter

This is just a direct translation of http://article.gmane.org/gmane.comp.version-control.git/235396 So I don't consider this is ready for inclusion. Some notes: We need to have more error checking, repack shall be 0, 2 or 4 but nothing else. If 0 is given, no argument is passed to pack-objects,

[PATCH] Remove ciabot from contrib

According to http://thread.gmane.org/gmane.comp.version-control.git/212649 Eric, the original author of ciabot, doesn't want the ciabot no longer be included in git.git, hence the removal of the whole directory. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- I found out about

Re: [PATCH] repack: Add --version parameter

On 09/26/2013 12:17 PM, Felipe Contreras wrote: On Thu, Sep 26, 2013 at 3:32 AM, Stefan Beller static const char *const git_repack_usage[] = { @@ -22,6 +23,9 @@ static int repack_config(const char *var, const char *value, void *cb) delta_base_offset = git_config_bool(var

Re: [PATCH] repack: Add --version parameter

On 09/26/2013 01:42 PM, Duy Nguyen wrote: On Thu, Sep 26, 2013 at 3:32 PM, Stefan Beller stefanbel...@googlemail.com wrote: This is just a direct translation of http://article.gmane.org/gmane.comp.version-control.git/235396 So I don't consider this is ready for inclusion. Some notes: We

Re: [PATCH v2 42/44] ruby: remove GIT_PAGER from environment

On 09/29/2013 12:04 AM, Felipe Contreras wrote: We are not calling any git commands any more. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- git-request-pull.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/git-request-pull.rb b/git-request-pull.rb index

Re: [msysGit] [PATCH] mingw-multibyte: fix memory acces violation and path length limits.

On 09/29/2013 04:56 AM, Wataru Noguchi wrote: - gcc optimization level is O2.(fail) - gcc O0, O1 works fine. Maybe you could try to compile with STACK found at http://css.csail.mit.edu/stack/ That tool is designed to find Optimization-unstable code. signature.asc Description: OpenPGP

[PATCH] Makefile: suppress false positive warnings of empty format string.

Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index de3d72c..60afa51 100644 --- a/Makefile +++ b/Makefile @@ -349,7 +349,7 @@ GIT-VERSION-FILE: FORCE # CFLAGS and LDFLAGS

Re: [PATCH] Makefile: suppress false positive warnings of empty format string.

On 09/30/2013 10:14 PM, Jeff King wrote: On Sun, Sep 29, 2013 at 12:00:17PM -0700, Jonathan Nieder wrote: --- a/Makefile +++ b/Makefile @@ -349,7 +349,7 @@ GIT-VERSION-FILE: FORCE # CFLAGS and LDFLAGS are for the users to override from the command line. -CFLAGS = -g -O2 -Wall

Re: Dead links, broken search box, confusing/inconvenient contact

Hi Stefan, On 10/03/2013 07:50 PM, Stefan Pochmann wrote: 1) The links to Matthew's lists on the bottom of http://git-scm.com/downloads/guis are dead (I get 404s). git-scm is an open sourced site and hosted on GitHub. It is providing some information for git, but also on github. (It was

[PATCH] cherry-pick: do not segfault without arguments.

Commit 182d7dc46b (2013-09-05, cherry-pick: allow - as abbreviation of '@{-1}') accesses the first argument without checking whether it exists. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- builtin/revert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] clone: do not segfault when specifying a nonexistent branch

I think we should emit a warning additionally? Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- builtin/clone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/clone.c b/builtin/clone.c index 0aff974..b764ad0 100644 --- a/builtin/clone.c +++ b/builtin

Re: [PATCH] clone: do not segfault when specifying a nonexistent branch

On 10/05/2013 01:55 AM, Duy Nguyen wrote: On Fri, Oct 4, 2013 at 9:20 PM, Stefan Beller stefanbel...@googlemail.com wrote: I think we should emit a warning additionally? Signed-off-by: Stefan Beller stefanbel...@googlemail.com I think it's nice to credit Robert for reporting the fault

[PATCH] clone: do not segfault when specifying a nonexistent branch

in a nice way. Reported-by: Robert Mitwicki robert.mitwi...@opensoftware.pl Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- builtin/clone.c | 50 -- 1 file changed, 28 insertions(+), 22 deletions(-) diff --git a/builtin/clone.c b/builtin

Re: [PATCH] blame: add color

On 10/08/2013 04:18 PM, Chris J Arges wrote: Add colorized text for git blame when color.interactive is enabled. This work is based on the colorization code in builtin/clean.c. Another way to color blame, would be by commit, not by row. Try git gui blame file, to see what I mean. The

Re: [PATCH] git-credential-netrc: fix uninitialized warning

On 10/08/2013 09:55 PM, Ted Zlatanov wrote: JN Sign-off? I didn't realize it was a requirement, must I? Yes, this is a requirement. See Documentation/SubmittingPatches to read what signing off actually means here. Stefan signature.asc Description: OpenPGP digital signature

[PATCH] checkout tests: enable test with complex relative path

directory, so we still need to add a 'cd'. Also a test for the file content has been added. This is already part of the other tests for checkout. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- t/t2008-checkout-subdir.sh | 15 --- 1 file changed, 8 insertions(+), 7 deletions

Re: [PATCH] checkout tests: enable test with complex relative path

On 10/09/2013 09:39 PM, Jonathan Nieder wrote: Stefan Beller wrote: This test was put in, but commented out in fed1b5ca (2007-11-09, git-checkout: Test for relative path use.) It's been a while since 2007 and the intended test case works now. (I could not find the enabling commit in ls

Re: [PATCH] cherry-pick: do not segfault without arguments.

On 10/10/2013 06:41 PM, Jeff King wrote: On Fri, Oct 04, 2013 at 04:09:12PM +0200, Stefan Beller wrote: Commit 182d7dc46b (2013-09-05, cherry-pick: allow - as abbreviation of '@{-1}') accesses the first argument without checking whether it exists. I think this is an obviously correct fix

Re: [PATCH 16/20] revision: trivial style fixes

On 10/12/2013 09:07 AM, Felipe Contreras wrote: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- revision.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/revision.c b/revision.c index 0173e01..4049867 100644 --- a/revision.c +++

[PATCH] git-svn documentation: Use tabs consistently within the ascii doc

While I can understand 4 or 7 white spaces are fancy, we'd rather want to use tabs throughout the whole document. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- Documentation/git-svn.txt | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH] Reword repack documentation to no longer state it's a script

This updates the documentation regarding the changes introduced by a1bbc6c01 (2013-09-15, repack: rewrite the shell script in C). Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- Documentation/git-repack.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2] git-svn docs: Use tabs consistently within the ascii doc

While I can understand 4 or 7 white spaces are fancy, we'd rather want to use tabs throughout the whole document. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- Keshav, thanks for the review. I am answering late, because my mails regarding git are sorted automatically, whether

[PATCH 1/2] refs: remove unused function invalidate_ref_cache

it is not used anymore, as 8bf90dc (2011-10-17, write_ref_sha1(): only invalidate the loose ref cache) and (much) later 506a760 (2013-04-22, refs: change how packed refs are deleted) removed any calls to this function. So it seems as if we don't need that function any more, good bye! Signed-off-by: Stefan

[PATCH 2/2] cache: remove unused function 'have_git_dir'

need to expose this wrapper function any more as a public API. Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- cache.h | 1 - environment.c | 5 - 2 files changed, 6 deletions(-) diff --git a/cache.h b/cache.h index 464c8fb..7e98f9e 100644 --- a/cache.h +++ b/cache.h

Re: [PATCH] commit: Add -f, --fixes commit option to add Fixes: line

On 10/27/2013 09:09 AM, Thomas Rast wrote: Josh Triplett j...@joshtriplett.org writes: On Sun, Oct 27, 2013 at 06:42:44AM +0100, Michael Haggerty wrote: But I don't think that this feature should be given the -f short option, as (a) -f often means force; (b) it will increase the confusion

Re: [PATCH] commit: Add -f, --fixes commit option to add Fixes: line

On 10/27/2013 05:30 PM, Thomas Rast wrote: Stefan Beller stefanbel...@googlemail.com writes: I assembled an overview table, which plots the long options of git commands by the short letters. [...] (In case thunderbird messes it up, here it is again http://pastebin.com/raw.php?i=JBci2Krx

Re: [PATCH] commit: Add -f, --fixes commit option to add Fixes: line

On 10/27/2013 05:30 PM, Thomas Rast wrote: Stefan Beller stefanbel...@googlemail.com writes: I assembled an overview table, which plots the long options of git commands by the short letters. [...] (In case thunderbird messes it up, here it is again http://pastebin.com/raw.php?i=JBci2Krx

[PATCH] Documentation: add a script to generate a (long/short) options overview

as these we need a script to easily generate an overview of all available one letter options, and their long option equivalents. As the list of options was not retrieved fully automated, there might be minor errors or missing items. Signed-off-by: Stefan Beller stefanbel...@googlemail.com

Re: git rm / format-patch / am fails on my file: patch does not apply

On 11.11.2013 20:04, Junio C Hamano wrote: Ken Tanzer ken.tan...@gmail.com writes: ASCII text, with very long lines, with CRLF, CR, LF line terminators I am not very much surprised if such a file misbehaves, because the format-patch | am pipeline is designed to be used on patches that can

Re: git rm / format-patch / am fails on my file: patch does not apply

On 11.11.2013 20:37, Junio C Hamano wrote: Stefan Beller stefanbel...@googlemail.com writes: I do have this global config core.safecrlf=warn regarding line endings. Oh, that sounds very suspicious. If the payload has CRLF, CR and LF mixed, that would immediately violate safecrlf

Re: git rm / format-patch / am fails on my file: patch does not apply

On 11.11.2013 20:43, Stefan Beller wrote: On 11.11.2013 20:37, Junio C Hamano wrote: Stefan Beller stefanbel...@googlemail.com writes: I do have this global config core.safecrlf=warn regarding line endings. Oh, that sounds very suspicious. If the payload has CRLF, CR and LF mixed

error: git-remote-https died of signal 13

Hi, Using the latest git version (1.8.5.rc3), I get this this warning/error: sb@sb:/tmp$ git clone https://github.com/Bertram25/ValyriaTear.git Cloning into 'ValyriaTear'... remote: Counting objects: 21346, done. remote: Compressing objects: 100% (6307/6307), done. remote: Total 21346 (delta

Re: error: git-remote-https died of signal 13

On 24.11.2013 07:54, Jeff King wrote: On Sat, Nov 23, 2013 at 05:36:36PM +0100, Stefan Beller wrote: sb@sb:/tmp$ git clone https://github.com/Bertram25/ValyriaTear.git Cloning into 'ValyriaTear'... remote: Counting objects: 21346, done. remote: Compressing objects: 100% (6307/6307), done

Re: error: git-remote-https died of signal 13

On 24.11.2013 14:33, Jeff King wrote: On Sun, Nov 24, 2013 at 01:54:34PM +0100, Stefan Beller wrote: Here is the output of sb@sb:/tmp$ GIT_TRANSPORT_HELPER_DEBUG=1 git clone https://github.com/Bertram25/ValyriaTear.git tmp Thanks. I think I see what is going on. We finish the helper

Re: error: git-remote-https died of signal 13

On 24.11.2013 16:54, Jeff King wrote: Hmm. The fix in curl's 7d80ed64e435155 seems to involve strategically placed calls to ignore SIGPIPE. I wonder if there is another spot that needs similar treatment. It looks like curl_easy_cleanup is covered, though, and that's where I would expect

Re: error: git-remote-https died of signal 13

On 24.11.2013 16:54, Jeff King wrote: [+cc Daniel, who worked on the curl fix] On Sun, Nov 24, 2013 at 04:01:43PM +0100, Stefan Beller wrote: On 24.11.2013 14:33, Jeff King wrote: On Sun, Nov 24, 2013 at 01:54:34PM +0100, Stefan Beller wrote: Here is the output of sb@sb:/tmp

Re: [PATCH 3/3] cmd_repack(): remove redundant local variable nr_packs

On 17.12.2013 14:43, Michael Haggerty wrote: Its value is the same as the number of entries in the names string_list, so just use names.nr in its place. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu Acked-by: Stefan Beller stefanbel...@googlemail.com --- This is just a trivial

Re: Potential bug in git client

On 11.06.2014 12:21, Wojciech Przybył wrote: Hi All When I was tagging, I think I might have discovered a git client bug. HOW TO REPRODUCE: - Clone a repo into 2 separate directories. Presume there is a tag v0.1 already in there and it is set on say 10 commits ago. - In first directory

Re: [PATCH] l10n: de.po: fix typo

On 12.06.2014 18:12, Ralf Thielow wrote: Signed-off-by: Ralf Thielow ralf.thie...@gmail.com --- po/de.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/de.po b/po/de.po index b777ef4..d7bc424 100644 --- a/po/de.po +++ b/po/de.po @@ -3503,7 +3503,7 @@ msgstr

Re: Idea, Transparent commits, easier code style commits

On 04.07.2014 15:12, Andrius Bentkus wrote: I have worked on projects which only after a while (a year or so) established a consistent code style. After the consensus was established there was still some code left which did not fit the newly established standard. Now the problem is, if I

[PATCH] .mailmap: Map different names with the same email address together

contributed to git.git using different names, but the same email address. Would you mind to acknowledge this change to the mailmap file? Signed-off-by: Stefan Beller stefanbel...@googlemail.com --- .mailmap | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.mailmap b/.mailmap index 11057cb..2edbeb5

Re: [PATCH] .mailmap: Map different names with the same email address together

On 17.07.2014 16:29, Junio C Hamano wrote: If you received a private no to some entries, please advise; otherwise I would say the patch is ready to be picked up. I have received neither a no nor a yes privately. So please pick it up as you like. -- To unsubscribe from this list: send the line

scan.coverity: improve the modeling file of git.git

Hi Sam, John and Jeff, I'm writing to you, as you're listed as the administrator of the git.git project on scan.coverity.com We're currently seeing lots of false positives as the xmalloc/xrealloc function is handled not properly by coverity. There are lots of errors Allocation too small for

[PATCH 2/2] .mailmap: Combine my emails

first appeared in 398dd4bd039680b (2014-07-10, .mailmap: map different names with the same email address together) ironically. Signed-off-by: Stefan Beller stefanbel...@gmail.com --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 2edbeb5..8aefb5a 100644

[PATCH 1/2] General Manpage: Switch homepage for stats

According to http://meta.ohloh.net/2014/07/black-duck-open-hub/ the site name of ohloh changed to openhub. Change the man page accordingly. Signed-off-by: Stefan Beller stefanbel...@gmail.com --- Documentation/git.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Unify subcommand structure; introduce double dashes for all subcommands?

In the user survey 2012 question 23 (In your opinion, which areas in Git need improvement?), the most crucial point identified was the user interface. I wonder if there are any more recent surveys, showing if this has changed. Now when we want to improve the user interface, we're likely talking

Re: [PATCH 0/5] coverity mixed bag

On 24.07.2014 06:39, Jeff King wrote: Since Stefan has recently started feeding git builds to coverity, I spent a few minutes poking through the results. There are tons of false positives, so there is some work to be done there with tweaking our coverity models. But there are some real issues,

[PATCH] Introduce a hook to run after formatting patches

, or have another kind of property. So in my case a hook like the following will help a lot. # Run with on formatted patches. The first argument is the filename to the patch. sed --in-place '/^Change-Id:/d' $1 Signed-off-by: Stefan Beller sbel...@google.com --- Hi Git people, I

Re: [PATCH 2/2] config: clear the executable bits (if any) on $GIT_DIR/config

On 14.11.2014 23:26, Michael Haggerty wrote: There is no reason for $GIT_DIR/config to be executable, plus this change will help clean up repositories affected by the bug that was fixed by the previous commit. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- config.c | 12

Re: [PATCH] Introduce a hook to run after formatting patches

On Sun, Nov 16, 2014 at 10:40 AM, Junio C Hamano gits...@pobox.com wrote: Stefan Beller sbel...@google.com writes: +post-format-patch + + +This hook is called after format-patch created a patch and it is +invoked with the filename of the patch as the first parameter

[PATCH] copy.c: make copy_fd preserve meaningful errno

From: Ronnie Sahlberg sahlb...@google.com Update copy_fd to return a meaningful errno on failure and also preserve the existing errno variable. Signed-off-by: Ronnie Sahlberg sahlb...@google.com Signed-off-by: Jonathan Nieder jrnie...@gmail.com Signed-off-by: Stefan Beller sbel...@google.com

Re: [PATCH] copy.c: make copy_fd preserve meaningful errno

...@pobox.com wrote: Stefan Beller sbel...@google.com writes: This patch was sent previously to the list as part of that series[2], but it seems to be unrelated to me. I am fine to queue obvious and trivial bits first before the larger main course. For now I'll queue this one and also the series

<    1   2   3   4   5   6   7   8   9   10   >