[PATCH] Implement ACL module architecture and sample MySQL ACL module

2012-08-14 Thread Michal Novotny
Hi, this is the patch to introduce the ACL module architecture into git versioning system. The variable of GIT_BASE_DIR is being used to seek for the modules if available. If variable is unset then daemon looks for the /etc/git-daemon.conf file existence and reads the 'base_path' key if it exists

Re: [PATCH] Implement ACL module architecture and sample MySQL ACL module

2012-08-14 Thread Junio C Hamano
Michal Novotny minov...@redhat.com writes: Hi, this is the patch to introduce the ACL module architecture into git versioning system. No, it doesn't. It adds something only to git daemon, but does not affect any other uses of Git. Side note: I am not saying other uses of Git must be ACL

Re: [PATCH] Implement ACL module architecture and sample MySQL ACL module

2012-08-14 Thread Shawn Pearce
On Tue, Aug 14, 2012 at 9:12 AM, Junio C Hamano gits...@pobox.com wrote: Michal Novotny minov...@redhat.com writes: Hi, this is the patch to introduce the ACL module architecture into git versioning system. No, it doesn't. It adds something only to git daemon, but does not affect any

Re: [PATCH] Implement ACL module architecture and sample MySQL ACL module

2012-08-14 Thread Junio C Hamano
Shawn Pearce spea...@spearce.org writes: Parsing the request line of git-daemon is easy. But we could make it easier. An alternative arrangement would be to add a new command line flag to git daemon like --command-filter that names an executable git-daemon will invoke after parsing the

Re: [PATCH] Implement ACL module architecture and sample MySQL ACL module

2012-08-14 Thread Shawn Pearce
On Tue, Aug 14, 2012 at 10:06 AM, Junio C Hamano gits...@pobox.com wrote: Shawn Pearce spea...@spearce.org writes: Parsing the request line of git-daemon is easy. But we could make it easier. An alternative arrangement would be to add a new command line flag to git daemon like

Re: [PATCH] Implement ACL module architecture and sample MySQL ACL module

2012-08-14 Thread Junio C Hamano
Shawn Pearce spea...@spearce.org writes: But seeing this, yes, that is a bad idea. Better to treat that like a hook, where exit status 0 allows the connection to continue, and exit status non-zero causes the connection to be closed. Maybe with an error printed to stderr (if any) being echoed