Re: [PATCH] config: teach git config --file - to read from the standard input

2014-02-18 Thread Jeff King
On Sun, Feb 16, 2014 at 02:13:01PM +0200, Kirill A. Shutemov wrote: The patch extends git config --file interface to allow read config from stdin. Editing stdin or setting value in stdin is an error. Include by absolute path is allowed in stdin config, but not by relative path. Thanks,

Re: [PATCH] config: teach git config --file - to read from the standard input

2014-02-18 Thread Junio C Hamano
Jeff King p...@peff.net writes: +} else { +if (cf-name) +return error(bad config file line %d in %s, +cf-linenr, cf-name); +else +return error(bad config file line %d, cf-linenr); +}

Re: [PATCH] config: teach git config --file - to read from the standard input

2014-02-18 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: I think I preferred the earlier version where you had stdin in the name field, and this hunk could just go away. I know you switched it to NULL here to avoid making bogus relative filenames in includes. Exactly the same comment here. I really like

[PATCH] config: teach git config --file - to read from the standard input

2014-02-16 Thread Kirill A. Shutemov
The patch extends git config --file interface to allow read config from stdin. Editing stdin or setting value in stdin is an error. Include by absolute path is allowed in stdin config, but not by relative path. Signed-off-by: Kirill A. Shutemov kir...@shutemov.name --- builtin/config.c