Re: [PATCH] run-command: use void to declare that functions take no parameters

2014-11-11 Thread Junio C Hamano
Jeff King p...@peff.net writes: I had always just assumed that -Wstrict-prototypes was part of -Wall, but it is not (nor even part of -Wextra!). Maybe it is time to add it to your integration-build flags. :) Yup, I had -Wold-style-definition but not -Wstrict-prototypes in the mix. Thanks for

[PATCH] run-command: use void to declare that functions take no parameters

2014-11-10 Thread René Scharfe
Explicitly declare that git_atexit_dispatch() and git_atexit_clear() take no parameters instead of leaving their parameter list empty and thus unspecified. Signed-off-by: Rene Scharfe l@web.de --- run-command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] run-command: use void to declare that functions take no parameters

2014-11-10 Thread Junio C Hamano
René Scharfe l@web.de writes: Explicitly declare that git_atexit_dispatch() and git_atexit_clear() take no parameters instead of leaving their parameter list empty and thus unspecified. Signed-off-by: Rene Scharfe l@web.de --- Thanks. I was kind of surprised after running a git

Re: [PATCH] run-command: use void to declare that functions take no parameters

2014-11-10 Thread Jeff King
On Mon, Nov 10, 2014 at 02:43:10PM -0800, Junio C Hamano wrote: Explicitly declare that git_atexit_dispatch() and git_atexit_clear() take no parameters instead of leaving their parameter list empty and thus unspecified. [...] I was kind of surprised after running a git blame to find