Re: [PATCH 8/8] git-config: use git_config_with_options

2012-10-24 Thread Johannes Sixt
All looked sane. Thanks for a pleasant read! -- Hannes -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 8/8] git-config: use git_config_with_options

2012-10-24 Thread Ævar Arnfjörð Bjarmason
Yeah same here. Thanks for tackling this bug. Looking forward to using the include mechanism for overriding user.email in future versions. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 8/8] git-config: use git_config_with_options

2012-10-23 Thread Jeff King
The git-config command has always implemented its own file lookup and parsing order. This was necessary because its duplicate-entry handling did not match the way git's internal callbacks worked. Now that this is no longer the case, we are free to reuse the existing parsing code. This saves us a