Re: [PATCH v14 00/21] index-helper/watchman

2016-07-14 Thread Ben Peart
Duy Nguyen gmail.com> writes: > > On Wed, Jul 13, 2016 at 11:59 PM, David Turner novalis.org> wrote: > > On 07/12/2016 02:24 PM, Duy Nguyen wrote: > >> > >> Just thinking out loud. I've been thinking about this more about this. > >> After the move from signal-based to unix socket for

Re: [PATCH v14 00/21] index-helper/watchman

2016-07-14 Thread Duy Nguyen
Big typo.. On Thu, Jul 14, 2016 at 5:56 PM, Duy Nguyen wrote: > For giant-scale repos, you probably want something more efficient than > a script like this. And the good thing is you have freedom to do > whatever you want. You can run one daemon per repo, you can run one >

Re: [PATCH v14 00/21] index-helper/watchman

2016-07-14 Thread Duy Nguyen
On Wed, Jul 13, 2016 at 11:59 PM, David Turner wrote: > On 07/12/2016 02:24 PM, Duy Nguyen wrote: >> >> Just thinking out loud. I've been thinking about this more about this. >> After the move from signal-based to unix socket for communication, we >> probably are better off

Re: [PATCH v14 00/21] index-helper/watchman

2016-07-13 Thread David Turner
On 07/12/2016 02:24 PM, Duy Nguyen wrote: Just thinking out loud. I've been thinking about this more about this. After the move from signal-based to unix socket for communication, we probably are better off with a simpler design than the shm-alike one we have now. What if we send everything

Re: [PATCH v14 00/21] index-helper/watchman

2016-07-12 Thread Duy Nguyen
Just thinking out loud. I've been thinking about this more about this. After the move from signal-based to unix socket for communication, we probably are better off with a simpler design than the shm-alike one we have now. What if we send everything over a socket or a pipe? Sending 500MB over a

Re: [PATCH v14 00/21] index-helper/watchman

2016-07-06 Thread Junio C Hamano
David Turner writes: > This addresses comments on v13: > removed unnecessary no_mmap ifdef > add an ifdef in unix-socket > OS X fix for select() > test improvement Thanks. It seems that what used to be 809fd05a (read-cache.c: fix constness of verify_hdr(), 2016-06-26) is

Re: [PATCH v14 00/21] index-helper/watchman

2016-07-04 Thread Johannes Schindelin
Hi Dave, On Sun, 3 Jul 2016, Johannes Schindelin wrote: > On Sun, 3 Jul 2016, David Turner wrote: > > > This addresses comments on v13: > > removed unnecessary no_mmap ifdef > > add an ifdef in unix-socket > > OS X fix for select() > > test improvement > > Thanks. > > Would you mind

Re: [PATCH v14 00/21] index-helper/watchman

2016-07-03 Thread Johannes Schindelin
Hi Dave, On Sun, 3 Jul 2016, David Turner wrote: > This addresses comments on v13: > removed unnecessary no_mmap ifdef > add an ifdef in unix-socket > OS X fix for select() > test improvement Thanks. Would you mind re-sending 20 & 21, they seem to have gotten lost. Or is there a public

[PATCH v14 00/21] index-helper/watchman

2016-07-03 Thread David Turner
This addresses comments on v13: removed unnecessary no_mmap ifdef add an ifdef in unix-socket OS X fix for select() test improvement Thanks to all for suggestions. David Turner (10): pkt-line: add gentle version of packet_write index-helper: log warnings unpack-trees: preserve index