Re: [PATCH v3 3/3] checkout: reorder option handling

2012-09-07 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: + if (opts-track != BRANCH_TRACK_UNSPECIFIED) + die(_(%s cannot be used with updating paths), --track); I think most of the places we try to enclose these literals inside quotes, so I'd squash in a patch to make this:

[PATCH v3 3/3] checkout: reorder option handling

2012-08-30 Thread Nguyễn Thái Ngọc Duy
checkout operates in three different modes. On top of that it tries to be smart by guessing the branch name for switching. This results in messy option handling code. This patch reorders it so that - cmd_checkout() is responsible for parsing, preparing input and determining mode - Code of

Re: [PATCH v3 3/3] checkout: reorder option handling

2012-08-30 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Changes since v2 (the first two patches are not resent): ... - merge cmd_checkout_entry() into checkout_paths() I didn't think of this when I reviewed the previous one; I think it makes sense. Thanks. -- To unsubscribe from this list: send