Re: [PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension

2017-05-31 Thread Ben Peart
On 5/31/2017 12:33 AM, Christian Couder wrote: +test_expect_success 'refresh_index() invalidates fsmonitor cache' ' + git config core.fsmonitor true && + git config core.untrackedcache true && + clean_repo && + git status && + test_path_is_missing marker && +

Re: [PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension

2017-05-30 Thread Christian Couder
On Tue, May 30, 2017 at 11:21 PM, Ben Peart wrote: > > On 5/30/2017 9:18 AM, Christian Couder wrote: >> >> On Thu, May 25, 2017 at 8:36 PM, Ben Peart wrote: >> >>> + printf "untracked\0" >>> + printf "dir1/untracked\0" >>> + printf

Re: [PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension

2017-05-30 Thread Ben Peart
On 5/30/2017 6:37 PM, Junio C Hamano wrote: Ben Peart writes: I did a quick search through the existing test scripts and the majority do not link commands together with && when they are in a sub function like this. I find not having them linked together is easier to

Re: [PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension

2017-05-30 Thread Junio C Hamano
Ben Peart writes: > I did a quick search through the existing test scripts and the > majority do not link commands together with && when they are in a sub > function like this. I find not having them linked together is easier > to write, maintain and is more readable. I had

Re: [PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension

2017-05-30 Thread Ben Peart
On 5/30/2017 9:18 AM, Christian Couder wrote: On Thu, May 25, 2017 at 8:36 PM, Ben Peart wrote: [...] diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh new file mode 100755 index 00..395db46d55 --- /dev/null +++ b/t/t7519-status-fsmonitor.sh

Re: [PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension

2017-05-30 Thread Christian Couder
On Thu, May 25, 2017 at 8:36 PM, Ben Peart wrote: [...] > diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh > new file mode 100755 > index 00..395db46d55 > --- /dev/null > +++ b/t/t7519-status-fsmonitor.sh > @@ -0,0 +1,158 @@ > +#!/bin/sh > + >

[PATCH v3 4/6] fsmonitor: add test cases for fsmonitor extension

2017-05-25 Thread Ben Peart
Add test cases that ensure status results are correct when using the new fsmonitor extension. Test untracked, modified, and new files by ensuring the results are identical to when not using the extension. Add a test to ensure updates to the index properly mark corresponding entries in the index