Re: [PATCH v4 10/10] rebase -i: rearrange fixup/squash lines using the rebase--helper

2017-05-29 Thread Johannes Schindelin
Hi Liam, On Thu, 25 May 2017, Liam Beguin wrote: > Johannes Schindelin writes: > [...] > > + if (rearranged) { > > + struct strbuf buf = STRBUF_INIT; > > + > > + for (i = 0; i < todo_list.nr; i++) { > > + enum todo_command

[PATCH v4 10/10] rebase -i: rearrange fixup/squash lines using the rebase--helper

2017-05-25 Thread Liam Beguin
Hi Johannes, Johannes Schindelin writes: > This operation has quadratic complexity, which is especially painful > on Windows, where shell scripts are *already* slow (mainly due to the > overhead of the POSIX emulation layer). > > Let's reimplement this with linear

[PATCH v4 10/10] rebase -i: rearrange fixup/squash lines using the rebase--helper

2017-04-28 Thread Johannes Schindelin
This operation has quadratic complexity, which is especially painful on Windows, where shell scripts are *already* slow (mainly due to the overhead of the POSIX emulation layer). Let's reimplement this with linear complexity (using a hash map to match the commits' subject lines) for the common