Re: [PATCH v4 2/7] ref-filter: add function to print single ref_array_item

2016-10-19 Thread Jeff King
On Wed, Oct 19, 2016 at 01:07:34PM -0400, Santiago Torres wrote: > > I guess that may complicate things for the caller you add in this > > series, which may not have a fully-qualified refname (which is obviously > > how filter_ref_kind() figures it out). I'd argue that is a bug, though, > > as

Re: [PATCH v4 2/7] ref-filter: add function to print single ref_array_item

2016-10-19 Thread Santiago Torres
On Wed, Oct 19, 2016 at 05:16:42AM -0400, Jeff King wrote: > On Wed, Oct 19, 2016 at 04:55:43AM -0400, Jeff King wrote: > > > > diff --git a/ref-filter.h b/ref-filter.h > > > index 14d435e..3d23090 100644 > > > --- a/ref-filter.h > > > +++ b/ref-filter.h > > > @@ -107,4 +107,7 @@ struct

Re: [PATCH v4 2/7] ref-filter: add function to print single ref_array_item

2016-10-19 Thread Jeff King
On Fri, Oct 07, 2016 at 05:07:16PM -0400, santi...@nyu.edu wrote: > From: Lukas Puehringer > > ref-filter functions are useful for printing git object information > using a format specifier. However, some other modules may not want to use > this functionality on a

Re: [PATCH v4 2/7] ref-filter: add function to print single ref_array_item

2016-10-19 Thread Jeff King
On Wed, Oct 19, 2016 at 04:55:43AM -0400, Jeff King wrote: > > diff --git a/ref-filter.h b/ref-filter.h > > index 14d435e..3d23090 100644 > > --- a/ref-filter.h > > +++ b/ref-filter.h > > @@ -107,4 +107,7 @@ struct ref_sorting *ref_default_sorting(void); > > /* Function to parse --merged and

[PATCH v4 2/7] ref-filter: add function to print single ref_array_item

2016-10-07 Thread santiago
From: Lukas Puehringer ref-filter functions are useful for printing git object information using a format specifier. However, some other modules may not want to use this functionality on a ref-array but only print a single item. Expose a pretty_print_ref function to