On 4/18/2017 9:23 PM, Junio C Hamano wrote:
Ben Peart writes:
On 4/16/2017 11:31 PM, Junio C Hamano wrote:
Lars Schneider writes:
However, I think it eases code maintainability in the long run if a function is
"as pure as
possible" (IOW does
Ben Peart writes:
> On 4/16/2017 11:31 PM, Junio C Hamano wrote:
>> Lars Schneider writes:
>>
>>> However, I think it eases code maintainability in the long run if a
>>> function is "as pure as
>>> possible" (IOW does rely on global state as less
On 4/16/2017 11:31 PM, Junio C Hamano wrote:
Lars Schneider writes:
-static struct cmd2process *find_multi_file_filter_entry(struct hashmap
*hashmap, const char *cmd)
+static struct subprocess_entry *find_multi_file_filter_entry(const char *cmd)
I am curious why
Lars Schneider writes:
>> -static struct cmd2process *find_multi_file_filter_entry(struct hashmap
>> *hashmap, const char *cmd)
>> +static struct subprocess_entry *find_multi_file_filter_entry(const char
>> *cmd)
>
> I am curious why you removed the hashmap parameter
> On 07 Apr 2017, at 14:03, Ben Peart wrote:
>
> To enable future reuse of the filter..process infrastructure,
> split the cmd2process structure into two separate parts.
>
> subprocess_entry will now contain the generic data required to manage
> the creation and tracking of
To enable future reuse of the filter..process infrastructure,
split the cmd2process structure into two separate parts.
subprocess_entry will now contain the generic data required to manage
the creation and tracking of the child process in a hashmap. Also move
all knowledge of the hashmap into the
6 matches
Mail list logo