Re: [PATCH v5 4/8] convert: Separate generic structures and variables from the filter specific ones

2017-04-20 Thread Ben Peart
On 4/18/2017 9:23 PM, Junio C Hamano wrote: Ben Peart writes: On 4/16/2017 11:31 PM, Junio C Hamano wrote: Lars Schneider writes: However, I think it eases code maintainability in the long run if a function is "as pure as possible" (IOW does

Re: [PATCH v5 4/8] convert: Separate generic structures and variables from the filter specific ones

2017-04-18 Thread Junio C Hamano
Ben Peart writes: > On 4/16/2017 11:31 PM, Junio C Hamano wrote: >> Lars Schneider writes: >> >>> However, I think it eases code maintainability in the long run if a >>> function is "as pure as >>> possible" (IOW does rely on global state as less

Re: [PATCH v5 4/8] convert: Separate generic structures and variables from the filter specific ones

2017-04-18 Thread Ben Peart
On 4/16/2017 11:31 PM, Junio C Hamano wrote: Lars Schneider writes: -static struct cmd2process *find_multi_file_filter_entry(struct hashmap *hashmap, const char *cmd) +static struct subprocess_entry *find_multi_file_filter_entry(const char *cmd) I am curious why

Re: [PATCH v5 4/8] convert: Separate generic structures and variables from the filter specific ones

2017-04-16 Thread Junio C Hamano
Lars Schneider writes: >> -static struct cmd2process *find_multi_file_filter_entry(struct hashmap >> *hashmap, const char *cmd) >> +static struct subprocess_entry *find_multi_file_filter_entry(const char >> *cmd) > > I am curious why you removed the hashmap parameter

Re: [PATCH v5 4/8] convert: Separate generic structures and variables from the filter specific ones

2017-04-10 Thread Lars Schneider
> On 07 Apr 2017, at 14:03, Ben Peart wrote: > > To enable future reuse of the filter..process infrastructure, > split the cmd2process structure into two separate parts. > > subprocess_entry will now contain the generic data required to manage > the creation and tracking of

[PATCH v5 4/8] convert: Separate generic structures and variables from the filter specific ones

2017-04-07 Thread Ben Peart
To enable future reuse of the filter..process infrastructure, split the cmd2process structure into two separate parts. subprocess_entry will now contain the generic data required to manage the creation and tracking of the child process in a hashmap. Also move all knowledge of the hashmap into the