Re: [PATCH v6 3/6] verify-tag: change variable name for readability

2016-04-18 Thread Jeff King
On Sun, Apr 17, 2016 at 06:26:58PM -0400, santi...@nyu.edu wrote: > diff --git a/builtin/verify-tag.c b/builtin/verify-tag.c > index 77f070a..010353c 100644 > --- a/builtin/verify-tag.c > +++ b/builtin/verify-tag.c > @@ -21,20 +21,21 @@ static const char * const verify_tag_usage[] = { > static

Re: [PATCH v6 3/6] verify-tag: change variable name for readability

2016-04-18 Thread Eric Sunshine
On Sun, Apr 17, 2016 at 6:26 PM, wrote: > The run_gpg_verify() function has two variables, size and len. > > This may come off as confusing when reading the code. Clarify which > one pertains to the length of the tag headers by renaming len to > payload_length. The commit

[PATCH v6 3/6] verify-tag: change variable name for readability

2016-04-17 Thread santiago
From: Santiago Torres The run_gpg_verify() function has two variables, size and len. This may come off as confusing when reading the code. Clarify which one pertains to the length of the tag headers by renaming len to payload_length. Signed-off-by: Santiago Torres