Re: Reviews on mailing-list

2012-11-13 Thread Nguyen Thai Ngoc Duy
On Mon, Nov 12, 2012 at 4:15 AM, David Lang da...@lang.hm wrote: Using a web browser requires connectivity at the time you are doing the review. Mailing list based reviews can be done at times when you don't have connectivity. I am not against email-based reviews but I'd like to point out

Re: Reviews on mailing-list

2012-11-11 Thread suvayu ali
would be interested in. I have spoken to Shawn Pearce (gerrit project lead, google) and he said he is OK with hosting the gerrit instance. I would like to hear your thoughts on this. Personally I think reviews on the mailing list is far superior than any other review methods. I've even

Re: Reviews on mailing-list

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 2:13 AM, Thiago Farina tfrans...@gmail.com wrote: On Sat, Nov 10, 2012 at 9:40 PM, Felipe Contreras Personally I think reviews on the mailing list is far superior than any other review methods. I've even blogged about it and all the reasons[1]. Gerrit is better than

Re: Reviews on mailing-list

2012-11-11 Thread Felipe Contreras
be interested in. I have spoken to Shawn Pearce (gerrit project lead, google) and he said he is OK with hosting the gerrit instance. I would like to hear your thoughts on this. Personally I think reviews on the mailing list is far superior than any other review methods. I've even blogged

Re: Reviews on mailing-list

2012-11-11 Thread Thiago Farina
On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Requiring everyone to use a web browser would limit the amount of ways people can review patches. I don't see that as a limitation as I think everyone has access to a web browser these days, don't have? How

Re: Reviews on mailing-list

2012-11-11 Thread Felipe Contreras
On Sun, Nov 11, 2012 at 2:09 PM, Thiago Farina tfrans...@gmail.com wrote: On Sun, Nov 11, 2012 at 10:14 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Requiring everyone to use a web browser would limit the amount of ways people can review patches. I don't see that as a limitation as

Re: Reviews on mailing-list

2012-11-11 Thread Deniz Türkoglu
I understand from the feedback that gerrit should get better on making it possible to review code via e-mail, as pointed out in Nguyen's mail, a flow like Shawn mentioned[1] can be a good solution. FWIW, I can fetch the change(s) from gerrit I am interested in and review it any time I want. I

Re: Reviews on mailing-list

2012-11-11 Thread David Lang
On Sun, 11 Nov 2012, Deniz Türkoglu wrote: I understand from the feedback that gerrit should get better on making it possible to review code via e-mail, as pointed out in Nguyen's mail, a flow like Shawn mentioned[1] can be a good solution. FWIW, I can fetch the change(s) from gerrit I am

Re: Reviews on mailing-list

2012-11-10 Thread Felipe Contreras
your thoughts on this. Personally I think reviews on the mailing list is far superior than any other review methods. I've even blogged about it and all the reasons[1]. Gerrit is better than bugzilla, but it still requires a web browser, and logging in. I love to be able to just hit 'reply' with my

Re: Reviews on mailing-list

2012-11-10 Thread Thiago Farina
, google) and he said he is OK with hosting the gerrit instance. I would like to hear your thoughts on this. Personally I think reviews on the mailing list is far superior than any other review methods. I've even blogged about it and all the reasons[1]. Gerrit is better than bugzilla, but it still

Re: Reviews on mailing-list

2012-11-10 Thread Deniz Türkoglu
, google) and he said he is OK with hosting the gerrit instance. I would like to hear your thoughts on this. Personally I think reviews on the mailing list is far superior than any other review methods. I've even blogged about it and all the reasons[1]. Gerrit is better than bugzilla, but it still

Re: Reviews on mailing-list

2012-11-10 Thread Junio C Hamano
Thiago Farina tfrans...@gmail.com wrote: Requiring a web browser is a huge requirement, ham?? No, but requiring reviews and discussions typed in the browser is. Pardon terseness, typo and HTML from a tablet. -- To unsubscribe from this list: send the line unsubscribe git in the body of a

Re: Reviews on mailing-list

2012-11-10 Thread Ramkumar Ramachandra
Deniz Türkoglu wrote: I have spoken to Shawn Pearce (gerrit project lead, google) and he said he is OK with hosting the gerrit instance. I would like to hear your thoughts on this. I personally think email is by far the best interface for patches, reviews, and discussions. Git patches are