On 28/12/13 10:00, Jeff King wrote:
On Wed, Dec 25, 2013 at 11:08:57PM +0100, Erik Faye-Lund wrote:
On Sat, Dec 21, 2013 at 3:00 PM, Jeff King p...@peff.net wrote:
From: Ramsay Jones ram...@ramsay1.demon.co.uk
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
Signed-off-by: Junio C
Commit f2c681cf (send-pack: support pushing from a shallow clone
via http, 05-12-2013) adds the 'advertise_shallow_grafts_buf'
function as an external symbol.
Noticed by sparse. ('advertise_shallow_grafts_buf' was not declared.
Should it be static?)
Signed-off-by: Ramsay Jones ram...@ramsay1
algorithm. However, this function has no
callers. (The commented out call sites would need to change, in
order to provide information required by the function.)
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
This should, perhaps, be marked as RFC; if the patch to actually
use
core.excludesfile. ;-)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
This patch is marked RFC because, as I was just about to send this
email, I realized it wouldn't always work:
$ touch git.rc
$ make V=1 GIT_VERSION=1.9.dirty git.res
windres -O coff \
-DMAJOR=1 -DMINOR=9
On 21/01/14 21:36, Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
If the git version number consists of less than three period
separated numbers, then the windows resource file compilation
issues a syntax error:
$ touch
into the implementation file.
Noticed by sparse ('process_trailers' was not declared. Should it
be static?).
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
trailer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/trailer.c b/trailer.c
index b5de616..95d5874 100644
--- a/trailer.c
+++ b/trailer.c
::
+-v,--valgrind=tool::
The -v short option is taken, above ... :-P
Execute all Git binaries under valgrind tool tool and exit
with status 126 on errors (just like regular tests, this will
only stop the test script when running under -i).
ATB,
Ramsay Jones
--
To unsubscribe
are
worth it?
Indeed. I haven't seen any numbers.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
threads 27.75(36.46+1.98)
5302.5: index-pack 4 threads 27.93(37.24+2.82)
5302.6: index-pack 8 threads 29.34(38.23+3.04)
5302.7: index-pack default number of threads 26.25(36.55+1.84)
$
HTH
ATB,
Ramsay Jones
--
To unsubscribe from
On 16/04/14 00:18, Duy Nguyen wrote:
On Tue, Apr 15, 2014 at 11:45 PM, Junio C Hamano gits...@pobox.com wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
On 11/04/14 23:22, Junio C Hamano wrote:
[...]
[New Topics]
* nd/index-pack-one-fd-per-thread (2014-04-09) 1 commit
- index-pack
to something like:
690 if (the_index.cache_changed index_lock.fd = 0) {
... but I haven't spent any time investigating this, so take this
suggestion which a large pinch of salt! :-P
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Alexey,
If you need to re-roll your 'as/pretty-truncate' branch, could
you please squash the relevant parts of this patch into the
corresponding patches of your patch series. (ie this is a patch
against the head of the current pu
On 20/05/14 15:19, Alexey Shumkin wrote:
On Tue, May 20, 2014 at 02:54:20PM +0100, Ramsay Jones wrote:
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Alexey,
If you need to re-roll your 'as/pretty-truncate' branch, could
you please squash the relevant parts of this patch
-by: Alexey Shumkin alex.crez...@gmail.com
Suggested-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
t/t6006-rev-list-format.sh | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/t/t6006-rev-list-format.sh b/t/t6006-rev-list-format.sh
index c6e9a73..19434ad 100755
On 20/05/14 17:02, Alexey Shumkin wrote:
On Tue, May 20, 2014 at 04:01:22PM +0100, Ramsay Jones wrote:
On 20/05/14 15:19, Alexey Shumkin wrote:
On Tue, May 20, 2014 at 02:54:20PM +0100, Ramsay Jones wrote:
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Alexey,
If you need
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
The test suite has been failing for me on the pu branch for
a while now. I finally found a few minutes to take a look.
This failure is specific to the dash shell (/bin/sh) on my
system (ie it may well affect other shells, but I haven't
On 20/05/14 22:40, Jonathan Nieder wrote:
Ramsay Jones wrote:
--- a/t/t-basic.sh
+++ b/t/t-basic.sh
@@ -296,8 +296,9 @@ test_expect_success 'test --verbose-only' '
'
test_expect_success 'GIT_SKIP_TESTS'
-GIT_SKIP_TESTS='git.2' \
-run_sub_test_lib_test git
On 20/05/14 23:44, Jonathan Nieder wrote:
Hi,
Ramsay Jones wrote:
On 20/05/14 22:40, Jonathan Nieder wrote:
What should happen if I have set GIT_SKIP_TESTS explicitly to run
only some of the tests in t-basic?
A quick test (with the above patch applied) shows that
it works as I
-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com
Reviewed-by: Ramsay Jones ram...@ramsay1.demon.co.uk
Hmm, I didn't really review these patches. I simply noted a problem
on my system and provided you with an extended bug-report and
assisted you in fixing it up. So, if it even warrants a mention
the declaration in config.c until it is needed.
(To make it easier to see if it is necessary in the context of the
patch which will make use of it).
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info
which introduces the
struct in cache.h does not make use of that struct in any interface.
It *is* an implementation detail of some code in config.c only.
I do not know how that structure will be used in future patches. ;-)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe
On 10/08/14 18:29, Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
On 08/08/14 15:07, Tanay Abhra wrote:
...
(cc to Ramsay)
The discussion in both threads (v8 and v9), boils down to this,
is the `key_value_info` struct really required to be declared public
upgraded to Linux Mint 17 since
then, so my toolchain may be up to the job now, so perhaps I should
build it myself. ;-)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
on this).
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
HTH
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 24/08/14 12:13, tsuna wrote:
On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
Hmm, which version of OS X are we talking about?
OS X 10.9.4:
$ uname -a
Darwin damogran.local 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun 3
21:27:35 PDT 2014; root:xnu
On 24/08/14 22:09, tsuna wrote:
On Sun, Aug 24, 2014 at 12:49 PM, Torsten Bögershausen tbo...@web.de wrote:
On 2014-08-24 18.18, Ramsay Jones wrote:
On 24/08/14 12:13, tsuna wrote:
On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
Hmm, which version of OS X
On 25/08/14 02:54, tsuna wrote:
On Sun, Aug 24, 2014 at 5:32 PM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
Again, I don't have access to an OS X system, so I don't know
which package provides libintl/gettext, but it seems to be missing
on your system.
Probably yeah, those libraries
/
format it into a temporary buffer and copy it to the final
flex-array).
Signed-off-by: Jeff King p...@peff.net
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
in these
two examples, I'm inclined to give up this line of inquiry.
Indeed. :-D
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 26/08/14 13:14, Jeff King wrote:
On Tue, Aug 26, 2014 at 12:57:21PM +0100, Ramsay Jones wrote:
+ ret = xcalloc(1, base + extra);
+ va_start(ap, fmt);
+ vsnprintf(ret + offset, extra, fmt, ap);
What is the relationship between 'base' and 'offset'?
Let me assume that base
On 26/08/14 13:43, Jeff King wrote:
On Tue, Aug 26, 2014 at 01:37:44PM +0100, Ramsay Jones wrote:
On my 64-bit system using gcc, sizeof() returns 16; it has to pad the
whole thing to 64-bit alignment in case I put two of them in an array.
But offsetof(name) is 12, since the array of char
that the bug is still
present?
For example, if I anonymized git.git, and did 'git branch -v' (say), how
easy would it be for me to recognise which branch was 'next'?
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More
? Unless you also change each '.c' file which
includes cache.h to also include git-compat-util.h first, then I suspect
(if nothing else) file I/O may be broken. (see _FILE_OFFSET_BITS).
Also, see Documentation/CodingGuidelines (lines 331-333).
ATB,
Ramsay Jones
--
To unsubscribe from this list: send
within a conditional such that !log_all_ref_updates is true, so
that the above can be simplified!)
I guess 'create_reflog' should be called 'maybe_create_reflog' :-D
HTH
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
a
sparse warning), rather than add an extern declaration to cache.h (which would
also suppress sparse).
ATB,
Ramsay Jones
+{
+uint32_t i;
+int r = 0;
+
+for (i = 0; i p-num_objects; i++) {
+const unsigned char *sha1 = nth_packed_object_sha1(p, i);
+
+if (!sha1
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Jeff,
I noticed that your 'jk/prune-mtime' branch removes the last caller
of the add_object() function; specifically commit 5f78a431a
(reachable: use traverse_commit_list instead of custom walk, 15-10-2014).
If you need to re-roll
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Jeff,
I noticed that your 'jk/prune-mtime' branch also removes the only
call to the add_object_array_with_mode() function outside of the
object.c file; specifically commit 75ac69fa (traverse_commit_list:
support pending blobs/trees
On 19/10/14 02:36, Jeff King wrote:
On Sat, Oct 18, 2014 at 10:36:12PM +0100, Ramsay Jones wrote:
I noticed that your 'jk/prune-mtime' branch removes the last caller
of the add_object() function; specifically commit 5f78a431a
(reachable: use traverse_commit_list instead of custom walk, 15-10
On 19/10/14 03:03, Jeff King wrote:
On Sun, Oct 19, 2014 at 12:19:07AM +0100, Ramsay Jones wrote:
[snip]
I actually wondered while writing this series whether anyone actually
_uses_ the mode in object_array (the new code I added sets it to the
appropriate value to be on the safe side
Commit 8796e182 (receive-pack.c: use a single transaction when
atomic-push is negotiated, 21-10-2014) added the 'transaction'
and 'err' variables as external symbols.
Noticed by sparse. ('err' was not declared. Should it be static?)
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi
Commit b74884b86 (untracked cache: make a wrapper around
{open,read,close}dir(), 27-10-2014) added the read_cached_dir()
function as an external symbol.
Noticed by sparse. ('read_cached_dir' was not declared. Should it
be static?).
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi
use the same
solution used in commit 9371322a6 (sparse: suppress some using
sizeof on a function warnings, 06-10-2013) which solved exactly
this problem for the other commands using libcurl.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Bernhard,
If you need to re-roll your 'br
.
ATB,
Ramsay Jones
---
Documentation/git-imap-send.txt | 15 +++-
INSTALL | 15 ++--
Makefile| 18 +++-
imap-send.c | 176
++--
4 files changed, 187 insertions(+), 37 deletions
. (I don't think so).
- Is the 5% slowdown on MinGW a real problem? (are the
static inline functions being in-lined?)
- I need to double check that I have replaced all relevant
lstat() calls.
ATB,
Ramsay Jones
Ramsay Jones (1):
cygwin: Add fast_lstat() and fast_fstat
, 924aaf3e, 05bab3ea and 0117c2f0.
In order to limit the adverse effects caused by this implementation,
we provide a new fast stat interface, which allows us to use this
only for interactions with the index (i.e. the cached stat data).
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
Torsten Bögershausen wrote:
On 30.06.13 19:28, Ramsay Jones wrote:
[ ... ]
You have just described my second patch! :D
Unfortunately, I have not had any time to work on the patch this weekend.
However, despite the patch being a bit rough around the edges, I decided
to send it out (see below
the initialiser expression with '{NULL}'.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Jeff,
If you need to re-roll the patches in your 'jk/in-pack-size-measurement'
branch, could you please squash this (or something like it) into the
patches equivalent to commit 7c07385d (zero-initialize
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Jeff,
One of the three gcc compilers that I use does not understand the
sentinel function attribute. (so, it spews 108 warning messages)
Is this, or something like it, too ugly for you to squash into
your patch? :-D
ATB,
Ramsay
Mark Levedahl wrote:
On 07/10/2013 04:23 PM, Ramsay Jones wrote:
Commit adbc0b6b (cygwin: Use native Win32 API for stat, 30-09-2008)
added a Win32 specific implementation of the stat functions. In order
to handle absolute paths, cygwin mount points and symbolic links, this
implementation may
= UnfortunatelyYes
NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease
# There are conflicting reports about this.
# On some boxes NO_MMAP is needed, and not so elsewhere.
Should you revert commit c869753e (Force core.filemode to false
on Cygwin., 30-12-2006) instead?
ATB,
Ramsay Jones
twice, with unpredictable results.
I wrote a patch to address this at the time (Hmm, seems to be built
on v1.8.1), but didn't submit it since your patch didn't progress. :-D
I have included the patch below.
ATB,
Ramsay Jones
-- 8 --
From: Ramsay Jones ram...@ramsay1.demon.co.uk
Date: Sun, 9 Sep 2012
Jonathan Nieder wrote:
Ramsay Jones wrote:
One of the three gcc compilers that I use does not understand the
sentinel function attribute. (so, it spews 108 warning messages)
Do you know what version of gcc introduced the sentinel attribute?
Would it make sense for the ifdef in git-compat
the sentinel attribute
for gcc v4.0 and newer.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
This was built on the next branch
ATB,
Ramsay Jones
argv-array.h | 2 +-
builtin/revert.c | 4 ++--
exec_cmd.h| 2 +-
git-compat-util.h | 7 +++
run-command.h | 2 +-
5
SED_STRIPS_CR SED_OPTIONS=-b
test_have_prereq MINGW export GREP_OPTIONS=-U
which may explain why it works for me on MinGW, but not why it works on
cygwin 1.5.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
Jeff King wrote:
On Tue, Jul 16, 2013 at 07:57:20AM +0200, Johannes Sixt wrote:
Am 7/15/2013 19:31, schrieb Ramsay Jones:
Sparse issues three Using plain integer as NULL pointer warnings.
Each warning relates to the use of an '{0}' initialiser expression
in the declaration of an 'struct
this
only for interactions with the index (i.e. the cached stat data).
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
I've tested this on Cygwin 1.7 on WIndows 7 , comparing to the results
using your prior patch (removing the Cygwin specific lstat entirely)
and get the same results
...
# passed all 11 test(s)
1..11
$
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
mleved...@gmail.com
---
This replaces my earlier patch against t3032 (8896b287 on pu)
Yep, this looks good and (as expected) it works on cygwin 1.5 too. :-D
Thanks.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
setting
need to change from the current setup.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jeff King wrote:
On Thu, Jul 18, 2013 at 09:25:50PM +0100, Ramsay Jones wrote:
Sparse issues some Using plain integer as NULL pointer warnings.
Each warning relates to the use of an '{0}' initialiser expression
in the declaration of an 'struct object_info'. The first field of
this structure
Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
The sentinel function attribute is not understood by versions of
the gcc compiler prior to v4.0. At present, for earlier versions
of gcc, the build issues 108 warnings related to the unknown
attribute. In order
it.
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
: *** [test-url-normalize.o] Error 1
In order to fix the error, we simply protect the use of the 'max_requests'
variable with an preprocessor conditional.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Kyle,
When you next update the patches in your 'km/http-curl-config-per-url'
branch
of this simpler solution. Comments?
Me too, thanks to all contributors
Thank you for taking the time to help address this issue!
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
physical address.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
While looking into a sparse warning, which involved the use of the
commit-slab.h header file, I noticed some problems with that code.
(at least I _think_ I did! ;-)
I was convinced, just by reading the code
Sparse issues an symbol 'saved_parents_slab' was not declared. Should
it be static? warning. In order to suppress the warning, since this
symbol does not require more than file visibility, we simply add the
static modifier to its declaration.
Signed-off-by: Ramsay Jones ram...@ramsay1
is still very much broken.
ATB,
Ramsay Jones
[1] I do have another patch, patch #0 actually, which I said I didn't
want applied! :-P
[2] I ran the test suite on v1.8.4-rc0 + 1 patch, like so:
$ GIT_SKIP_TESTS='t0061.3' make test test-outp16 21
$ tail -17 test-outp16
[22:33:53] t9902
the patch before building the next and pu branches; OK it's not
too onerous, but still ... :-P
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
I am personally in favor of this simpler solution. Comments?
I had expected this to me marked for 'master'.
Has this simply been overlooked, or do you have reservations about
applying this patch?
I am just being
of the public API, so we can't just remove it. It would
require a deprecation period, etc,. (Adding/documenting $sm_path as an
alternative *may* be worth doing. dunno.)
HTH
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
is no longer necessary and
can simply be dropped from this series.
[I have not had time to read your new patches yet, but I seem to remember
being concerned about those platforms which have UNRELIABLE_FSTAT set.
(ie cygwin, MinGW and Windows.)]
ATB,
Ramsay Jones
Signed-off-by: Thomas Gummerer
Sparse issues an 'prepare_transport' was not declared. Should it
be static? warning. In order to suppress the warning, since this
symbol only requires file scope, we simply add the static modifier
to it's declaration.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
When
the user to specify the correct tool, introduce
the GIT_TEST_HIGHLIGHT_BIN variable. Also, add '/dev/null' to the
command line of the highlight invocation; this avoids hanging the
test if the filter script is used nonetheless.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
I
to do so in the last 10 days. So, I'm just giving you a heads up ... ;-P
HTH
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
I had the same problem (or at least it *looks* like the same problem) on
Linux
last year (May 2011), which turned out to be a bug in the regex routines in
an
old version of glibc.
I don't know OS X at all, so
Florian Achleitner wrote:
On Sunday 19 August 2012 16:29:02 Ramsay Jones wrote:
Ok, I'll add it to the next version. This warning only occurs when building
for 32bit, thus I never saw it. There would be a format flag for printf that
sprecifies the platform's size_t integer type: z
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Florian,
The build on pu is currently broken:
CC remote-testsvn.o
LINK git-remote-testsvn
cc: vcs-svn/lib.a: No such file or directory
make: *** [git-remote-testsvn] Error 1
This is caused by a dependency
Jones ram...@ramsay1.demon.co.uk
---
Hi Florian,
Could you please squash this into commit 0320cef0 (remote-svn: add
marks-file regeneration, 22-08-2012).
ATB,
Ramsay Jones
remote-testsvn.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/remote-testsvn.c b/remote
remove the extraneous '/'
character from the urls.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Florian,
This test fails on cygwin. Could you please squash this into
commit 2d597d73 (Add a test script for remote-svn, 20-08-2012).
Thanks!
ATB,
Ramsay Jones
t/t9020-remote
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Florian,
Since python is not installed on MinGW, this test fails with
an unable to spawn script type message when attempting to
execute svnrdump. So, could you, in addition to the previous
patch, squash this into commit 2d597d73 (Add
Erik Faye-Lund wrote:
On Sat, Aug 25, 2012 at 7:13 PM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
The getline() function is a GNU extension (you need to define
_GNU_SOURCE before including stdio.h) and is, therefore, not
portable. In particular, getline() is not available on MinGW
Junio C Hamano wrote:
Erik Faye-Lund kusmab...@gmail.com writes:
On Sat, Aug 25, 2012 at 7:13 PM, Ramsay Jones
ram...@ramsay1.demon.co.uk wrote:
The getline() function is a GNU extension (you need to define
_GNU_SOURCE before including stdio.h) and is, therefore, not
portable
be *32-bit* Linux,
cygwin and MinGW, of course. ;-)
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Junio C Hamano wrote:
Ramsay Jones ram...@ramsay1.demon.co.uk writes:
[snip]
diff --git a/test-regex.c b/test-regex.c
new file mode 100644
index 000..9259985
--- /dev/null
+++ b/test-regex.c
@@ -0,0 +1,35 @@
+#include stdlib.h
+#include stdio.h
+#include stdarg.h
+#include sys
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
.gitignore | 1 +
Makefile | 1 +
t/t0070-fundamental.sh | 5 +
test-regex.c | 20
4 files changed, 27 insertions(+)
create mode 100644 test-regex.c
diff --git
the time ...
[BTW, the pu branch is *very* broken on cygwin (it's the v5 index
branch). I have a patch to fix it up; I just need to write it up.]
Ramsay Jones (6):
t3300-*.sh: Fix a TAP parse error
t3902-*.sh: Skip all tests rather than each test
t4016-*.sh: Skip all tests rather than each test
=1, Tests=0, 2 wallclock secs ( 0.02 usr 0.03 sys + \
0.84 cusr 0.41 csys = 1.29 CPU)
Result: NOTESTS
$
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
t/t3300-funny-names.sh | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff
Each test in this file is skipped if the TABS_IN_FILENAMES test
prerequisite is set. Use the 'skip_all' facility at the head of
the file to skip all of the tests instead.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
t/t3902-quoted.sh | 31 +++
1 file
Each test in this file is skipped if the TABS_IN_FILENAMES test
prerequisite is set. Use the 'skip_all' facility at the head of
the file to skip all of the tests instead.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
t/t4016-diff-quote.sh | 20 +---
1 file changed
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
t/test-lib.sh | 60 +--
1 file changed, 38 insertions(+), 22 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 78c4286..56b028c 100644
--- a/t/test-lib.sh
+++ b/t/test
the test with an
error message to alert the test author.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
t/test-lib.sh | 4
1 file changed, 4 insertions(+)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 56b028c..283d27a 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -383,6 +383,10
all 0 test(s) comment line, while correct, looks a little
strange. Add a check to suppress this message if no tests have actually
been run.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
Hi Junio,
I suspect some people would disagree with this one. Indeed, this only
irritates me when
Hi Junio,
These patches are from another unfinished branch. However, this
time I can't remember why it's unfinished! ;-)
ATB,
Ramsay Jones
Ramsay Jones (5):
path.c: Remove the 'git_' prefix from a file scope function
path.c: Don't discard the return value of vsnpath()
path.c: Use vsnpath
In particular, the git_vsnpath() function, despite the 'git_' prefix
suggesting otherwise, is (correctly) declared with file scope.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
path.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/path.c b/path.c
index
with git_snpath() and git_pathdup(), we reimplement the
git_path() function using vsnpath().
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
path.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/path.c b/path.c
index 741ae77..cbbdf7d 100644
--- a/path.c
+++ b
that the required cleanup happens, we use the
pointer returned by vsnpath(), rather than the buffer passed into
vsnpath(), to derive the return value from git_snpath() and
git_pathdup().
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
path.c | 11 ++-
1 file changed, 6 insertions
In addition to updating the xstrdup(mkpath(...)) call sites with
mkpathdup(), we also fix a memory leak (in merge_3way()) caused by
neglecting to free the memory allocated to the 'base_name' variable.
Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk
---
builtin/branch.c | 2 +-
builtin
, anyway!).
The other two patches don't affect the correctness of the code, so please
feel free to ignore them if you like.
ATB,
Ramsay Jones
Ramsay Allan Jones (3):
read-cache.c: Fix index reading breakage on cygwin
read-cache.c: Pass 'struct stat' parameters by reference
read-cache.c
1 - 100 of 940 matches
Mail list logo
