Re: [PATCH] pretty: add extra headers and MIME boundary directly

2017-03-26 Thread Jeff King
On Sun, Mar 26, 2017 at 03:41:14PM +0200, René Scharfe wrote: > Am 25.03.2017 um 22:11 schrieb Jeff King: > > The most correct way is that the caller of log_write_email_headers() and > > diff_flush() should have a function-local strbuf which holds the data, > > gets passed to diff_flush() as some

Re: [PATCH] pretty: add extra headers and MIME boundary directly

2017-03-26 Thread René Scharfe
Am 25.03.2017 um 22:11 schrieb Jeff King: > The most correct way is that the caller of log_write_email_headers() and > diff_flush() should have a function-local strbuf which holds the data, > gets passed to diff_flush() as some kind opaque context, and then is > freed afterwards. We don't have

Re: [PATCH] pretty: add extra headers and MIME boundary directly

2017-03-25 Thread Jeff King
On Sat, Mar 25, 2017 at 05:56:55PM +0100, René Scharfe wrote: > Am 25.03.2017 um 17:17 schrieb Jeff King: > > On Sat, Mar 25, 2017 at 01:16:42PM +0100, René Scharfe wrote: > > > @@ -374,26 +372,9 @@ void log_write_email_headers(struct rev_info *opt, > > > struct commit *commit, > > >

Re: [PATCH] pretty: add extra headers and MIME boundary directly

2017-03-25 Thread René Scharfe
Am 25.03.2017 um 17:17 schrieb Jeff King: On Sat, Mar 25, 2017 at 01:16:42PM +0100, René Scharfe wrote: @@ -374,26 +372,9 @@ void log_write_email_headers(struct rev_info *opt, struct commit *commit, graph_show_oneline(opt->graph); } if (opt->mime_boundary) { -

Re: [PATCH] pretty: add extra headers and MIME boundary directly

2017-03-25 Thread Jeff King
On Sat, Mar 25, 2017 at 01:16:42PM +0100, René Scharfe wrote: > Use the after_subject member of struct pretty_print_context to pass the > extra_headers unchanged, and construct and add the MIME boundary headers > directly in pretty.c::pp_title_line() instead of writing both to a > static buffer