Re: [PATCH v2 1/2] read-cache: skip index SHA verification

2017-03-28 Thread Jeff King
On Tue, Mar 28, 2017 at 11:27:19AM -0400, Jeff Hostetler wrote: > > Hrm, there shouldn't be any dependency of the config on the index (and > > there are a handful of options which impact the index already). Did you > > try it and run into problems? > > Yeah, I tried adding a new

Re: [PATCH v2 1/2] read-cache: skip index SHA verification

2017-03-28 Thread Jeff Hostetler
On 3/27/2017 6:44 PM, Jeff King wrote: On Mon, Mar 27, 2017 at 09:09:38PM +, g...@jeffhostetler.com wrote: From: Jeff Hostetler Teach git to skip verification of the index SHA in read_index(). This is a performance optimization. The index file SHA verification

Re: [PATCH v2 1/2] read-cache: skip index SHA verification

2017-03-27 Thread Jeff King
On Mon, Mar 27, 2017 at 04:32:10PM -0700, Jonathan Nieder wrote: > Jeff King wrote: > > > Hrm, there shouldn't be any dependency of the config on the index (and > > there are a handful of options which impact the index already). Did you > > try it and run into problems? > > > > In general, I'd

Re: [PATCH v2 1/2] read-cache: skip index SHA verification

2017-03-27 Thread Jonathan Nieder
Jeff King wrote: > Hrm, there shouldn't be any dependency of the config on the index (and > there are a handful of options which impact the index already). Did you > try it and run into problems? > > In general, I'd much rather see us either: > > 1. Rip the code out entirely if it is not meant

Re: [PATCH v2 1/2] read-cache: skip index SHA verification

2017-03-27 Thread Jeff King
On Mon, Mar 27, 2017 at 09:09:38PM +, g...@jeffhostetler.com wrote: > From: Jeff Hostetler > > Teach git to skip verification of the index SHA in read_index(). > > This is a performance optimization. The index file SHA verification > can be considered an ancient