Re: [BUG] git send-email: incorrectly parses email address with comma

2018-05-12 Thread Heinrich Schuchardt
On 05/12/2018 11:48 AM, Jeff King wrote: > On Sat, May 12, 2018 at 10:21:46AM +0200, Heinrich Schuchardt wrote: > >> Git send-email allows to combine multiple email addresses in one >> parameter, e.g. >> >> --to="a...@example.com, b...@example.com" >> >> But email addresses may contain commas

Re: [BUG] git send-email: incorrectly parses email address with comma

2018-05-12 Thread Jeff King
On Sat, May 12, 2018 at 10:21:46AM +0200, Heinrich Schuchardt wrote: > Git send-email allows to combine multiple email addresses in one > parameter, e.g. > > --to="a...@example.com, b...@example.com" > > But email addresses may contain commas themselves: > > --to="LASTNAME, firstname

[PATCH v2] send-email: Net::SMTP::starttls was introduced in v2.34 (Re: [BUG] git-send-email broken: Can't locate object method "starttls")

2017-05-31 Thread Jonathan Nieder
Subject: send-email: Net::SMTP::starttls was introduced in v2.34 We cannot rely on the starttls method being present in Net::SMTP until c274b798e6881a941d941808c6d89966975cb8c8 (Merge branch 'ipv6_ssl' of https://github.com/noxxi/perl-libnet into noxxi-ipv6_ssl, 2014-06-02), which set the module

Re: [PATCH] send-email: Net::SMTP::starttls was introduced in v3.01 (Re: [BUG] git-send-email broken: Can't locate object method "starttls")

2017-05-31 Thread Jonathan Nieder
Eric Biggers wrote: > On Wed, May 31, 2017 at 03:44:15PM -0700, Jonathan Nieder wrote: >> Subject: send-email: Net::SMTP::starttls was introduced in v3.01 >> >> We cannot rely on the starttls method being present in the copy >> of Net::SMTP shipped with perl until v5.21.5~169 (Update libnet to >>

Re: [PATCH] send-email: Net::SMTP::starttls was introduced in v3.01 (Re: [BUG] git-send-email broken: Can't locate object method "starttls")

2017-05-31 Thread Eric Biggers
On Wed, May 31, 2017 at 03:44:15PM -0700, Jonathan Nieder wrote: > Subject: send-email: Net::SMTP::starttls was introduced in v3.01 > > We cannot rely on the starttls method being present in the copy > of Net::SMTP shipped with perl until v5.21.5~169 (Update libnet to > CPAN version 3.01,

Re: [PATCH] send-email: Net::SMTP::starttls was introduced in v3.01 (Re: [BUG] git-send-email broken: Can't locate object method "starttls")

2017-05-31 Thread Junio C Hamano
Jonathan Nieder writes: > Subject: send-email: Net::SMTP::starttls was introduced in v3.01 > > We cannot rely on the starttls method being present in the copy > of Net::SMTP shipped with perl until v5.21.5~169 (Update libnet to > CPAN version 3.01, 2014-10-10). > >

[PATCH] send-email: Net::SMTP::starttls was introduced in v3.01 (Re: [BUG] git-send-email broken: Can't locate object method "starttls")

2017-05-31 Thread Jonathan Nieder
Subject: send-email: Net::SMTP::starttls was introduced in v3.01 We cannot rely on the starttls method being present in the copy of Net::SMTP shipped with perl until v5.21.5~169 (Update libnet to CPAN version 3.01, 2014-10-10). Reported-by: Brandon Williams Reported-by: Eric

Re: bug (?) in send email

2012-07-30 Thread Christoph Miebach
Hello! Removing this line s/_/ /g; here https://github.com/git/git/blob/master/git-send-email.perl#L867 Solves this problem for me. But I really don't have any clue, what kind of side effects this modification on sub unquote_rfc2047 might have. Regards Christoph On 28.07.2012 23:33,

Re: bug (?) in send email

2012-07-30 Thread Junio C Hamano
Thomas Rast tr...@student.ethz.ch writes: It would prevent spaces from being decoded correctly if the encoding program chooses to make the '_'. git-format-patch does not actually do this, see the big comment around pretty.c:304. I think this patch would be a better match for what RFC2047

Re: bug (?) in send email

2012-07-30 Thread Jeff King
On Mon, Jul 30, 2012 at 02:30:35PM +0200, Thomas Rast wrote: Removing this line s/_/ /g; here https://github.com/git/git/blob/master/git-send-email.perl#L867 Solves this problem for me. But I really don't have any clue, what kind of side effects this modification on sub

Re: bug (?) in send email

2012-07-30 Thread Jeff King
On Mon, Jul 30, 2012 at 08:38:21AM -0700, Junio C Hamano wrote: I think this patch would be a better match for what RFC2047 specifies. On the one hand it avoids substituting _ outside of encodings, but OTOH it also handles more than one encoded-word. Yeah, I think it is an improvement.