Yes agree, but any scenario that is possible _can_ occur, and the case of the
user closes document while dialog open has been reported already, and see #2599
for a non-KDE example.
Since we don't have many occurrences its not something that needs rushing into,
just put it on the eternal todo
Closed #3839 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3839#event-12780298369
You are receiving this because you are subscribed to this thread.
Message ID:
Alright, I made the suggested changes:
1. I made GtkFileChooserNative configurable, by default enabled on macOS and
Windows, disabled on Linux.
2. I went through all GtkFileChooser occurrences in Geany and added the native
variant
3. Not sure if intentional or if it's some left-over but
@techee pushed 1 commit.
2d8d4f2edacbfc82743a4d020d9c22bc6526b92b Use GTK_RESPONSE_ACCEPT which is also
used by GtkFileChooserNative
--
View it on GitHub:
https://github.com/geany/geany/pull/3861/files/4dff3767b9f80719dab3d1a83443be52cd377fa8..2d8d4f2edacbfc82743a4d020d9c22bc6526b92b
You are
@techee pushed 3 commits.
91fb8850281979356cdc38b5ea2b97e1b7132461 Use GtkFileChooserNative depending on
user configuration
ee8f885acf554c494b00f0f3a80a3c17676838ca Remove usage of windows-native
dialogs from ui_utils.c and win32.c/h
4dff3767b9f80719dab3d1a83443be52cd377fa8 Use
Yes, but I think (3) is really rare - closing documents is typically done by
users; if plugins do that, it would be very unexpected. That doesn't mean there
couldn't be some races like that when a user closes a document, opens another,
and only after that an asynchronous operation with a doc
> checking the ID would be better.
No, actually checking `id` is essential. I didn't really realise how much
until now. Consider for example the sequence:
1. Geany function gets `doc` pointer
2. does something that results in a signal
3. plugin callback is called by signal and it closes the
Python has different extension files. Apart from .py it has one with an "i" at
the end: ".pyi" files.
How to configure Geany to allow Format > Comment in types Geany do not
recognize? How would I configure for a new filetype wheter to use // or # or "
in comments ?
--
Reply to this email
@elextr Thanks for the answer.
> Document objects are never freed, so you will never get an invalid pointer,
> so thats one less worry. So no need to check if its in the document array, it
> will be.
Alright, that's the piece of information I was missing - I never actually
looked at the
Closed #3872 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3872#event-12778480824
You are receiving this because you are subscribed to this thread.
Message ID:
10 matches
Mail list logo
