[Gnash-dev] Should gnash::rtmp::RTMP::connect throw exceptions?

2014-04-24 Thread Petter Reinholdtsen
Hi. While looking at the Coverity report on unhandled exceptions, I ran into a few questions. A handful ignored exceptions is in the utilities/rtmpget.cpp file, and this email is about one particular set. The file contain this part: gnash::rtmp::RTMP r; [...] log_debug(Initial

[Gnash-dev] Why do FBAggGlue::init() have code after its return statement?

2014-04-24 Thread Petter Reinholdtsen
Anyone know what is going on in this function from fb_glue_agg.cpp? This is Coverity CID 1149302 - Structurally dead code, and there is a large block of code after the return statement in the middle. The code was written by Rob and last touched in 2011 (except a warning fix by Bastiaan in 2012).