[gwt-contrib] Change in gwt[master]: Move arrow key functions from Tree to KeyCodes

2013-07-09 Thread Daniel Kurka
Daniel Kurka has posted comments on this change. Change subject: Move arrow key functions from Tree to KeyCodes .. Patch Set 5: (3 comments) File

[gwt-contrib] Change in gwt[master]: Move arrow key functions from Tree to KeyCodes

2013-07-09 Thread Daniel Kurka
Hello Matthew Dempsky, Thomas Broyer, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3662 to look at the new patch set (#6). Change subject: Move arrow key functions from Tree to KeyCodes

[gwt-contrib] Change in gwt[master]: Move arrow key functions from Tree to KeyCodes

2013-07-09 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Move arrow key functions from Tree to KeyCodes .. Patch Set 5: (1 comment) File

[gwt-contrib] Change in gwt[master]: Move arrow key functions from Tree to KeyCodes

2013-07-09 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Move arrow key functions from Tree to KeyCodes .. Patch Set 6: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3662 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: Utility to store multiple HandlerRegistrations

2013-07-09 Thread Daniel Kurka
Daniel Kurka has posted comments on this change. Change subject: Utility to store multiple HandlerRegistrations .. Patch Set 3: (3 comments) File

[gwt-contrib] Change in gwt[master]: Utility to store multiple HandlerRegistrations

2013-07-09 Thread Daniel Kurka
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3661 to look at the new patch set (#4). Change subject: Utility to store multiple HandlerRegistrations ..

[gwt-contrib] Change in gwt[master]: Utility to store multiple HandlerRegistrations

2013-07-09 Thread Daniel Kurka
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3661 to look at the new patch set (#5). Change subject: Utility to store multiple HandlerRegistrations ..

[gwt-contrib] Change in gwt[master]: Move arrow key functions from Tree to KeyCodes

2013-07-09 Thread Daniel Kurka
Hello Matthew Dempsky, Thomas Broyer, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3662 to look at the new patch set (#7). Change subject: Move arrow key functions from Tree to KeyCodes

[gwt-contrib] Change in gwt[master]: Utility to store multiple HandlerRegistrations

2013-07-09 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Utility to store multiple HandlerRegistrations .. Patch Set 5: Code-Review+1 (2 comments) Nits only. I think I like that approach better than the previous one

[gwt-contrib] Change in gwt[master]: Move arrow key functions from Tree to KeyCodes

2013-07-09 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Move arrow key functions from Tree to KeyCodes .. Patch Set 7: Code-Review+2 (1 comment) File

[gwt-contrib] Change in gwt[master]: Add static is(...) to complement as as(...).

2013-07-09 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Add static is(...) to complement as as(...). .. Patch Set 6: Code-Review+2 (1 comment) I find it strange that CheckStyle didn't flag more whitespace

[gwt-contrib] Change in gwt[master]: Move arrow key functions from Tree to KeyCodes

2013-07-09 Thread Daniel Kurka
Hello Matthew Dempsky, Thomas Broyer, Leeroy Jenkins, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3662 to look at the new patch set (#8). Change subject: Move arrow key functions from Tree to KeyCodes

[gwt-contrib] Change in gwt[master]: Move arrow key functions from Tree to KeyCodes

2013-07-09 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Move arrow key functions from Tree to KeyCodes .. Patch Set 8: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3662 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: Utility to store multiple HandlerRegistrations

2013-07-09 Thread Jens Nehlmeier
Jens Nehlmeier has posted comments on this change. Change subject: Utility to store multiple HandlerRegistrations .. Patch Set 5: Code-Review+1 Beside the JavaDoc nits pointed out by Thomas: LGTM -- To view, visit

[gwt-contrib] Change in gwt[master]: Utility to store multiple HandlerRegistrations

2013-07-09 Thread Daniel Kurka
Hello Thomas Broyer, Leeroy Jenkins, Jens Nehlmeier, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3661 to look at the new patch set (#6). Change subject: Utility to store multiple HandlerRegistrations

[gwt-contrib] Change in gwt[master]: Utility to store multiple HandlerRegistrations

2013-07-09 Thread Daniel Kurka
Daniel Kurka has posted comments on this change. Change subject: Utility to store multiple HandlerRegistrations .. Patch Set 5: (2 comments) File

[gwt-contrib] Change in gwt[master]: Utility to store multiple HandlerRegistrations

2013-07-09 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Utility to store multiple HandlerRegistrations .. Patch Set 6: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3661 To unsubscribe, visit

[gwt-contrib] how to call the gwt method from html a href

2013-07-09 Thread Prabhu Kumar Gade
I have writen one program using gwt-visulization to gwt table. In that table it is allow html code.In that code to how to call the gwt method see the following program: package com.sample.client; import com.google.gwt.core.client.EntryPoint; import com.google.gwt.i18n.client.NumberFormat;

[gwt-contrib] Re: how to call the gwt method from html a href

2013-07-09 Thread Thomas Broyer
Please use https://groups.google.com/d/forum/google-web-toolkit to ask for support. This group is for contributions to GWT. On Tuesday, July 9, 2013 4:26:07 PM UTC+2, Prabhu Kumar Gade wrote: I have writen one program using gwt-visulization to gwt table. In that table it is allow html

[gwt-contrib] Change in gwt[master]: Fix SingleSelectionModel.getSelectedSet()

2013-07-09 Thread Matthew Dempsky
Matthew Dempsky has uploaded a new change for review. https://gwt-review.googlesource.com/3680 Change subject: Fix SingleSelectionModel.getSelectedSet() .. Fix SingleSelectionModel.getSelectedSet() Ensure that if recent

[gwt-contrib] Change in gwt[master]: Fixes Exception wrapping/unwrapping in compiler

2013-07-09 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Fixes Exception wrapping/unwrapping in compiler .. Patch Set 3: Actually, I briefly discussed this issue with you before when I asked you putting try/catch

[gwt-contrib] Change in gwt[master]: Move arrow key functions from Tree to KeyCodes

2013-07-09 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Move arrow key functions from Tree to KeyCodes .. Patch Set 8: Code-Review+1 (1 comment) File

[gwt-contrib] Change in gwt[master]: Utility to store multiple HandlerRegistrations

2013-07-09 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Utility to store multiple HandlerRegistrations .. Patch Set 6: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/3661 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: Fix SingleSelectionModel.getSelectedSet()

2013-07-09 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Fix SingleSelectionModel.getSelectedSet() .. Patch Set 1: (2 comments) File

[gwt-contrib] Change in gwt[master]: Fix SingleSelectionModel.getSelectedSet()

2013-07-09 Thread Matthew Dempsky
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3680 to look at the new patch set (#2). Change subject: Fix SingleSelectionModel.getSelectedSet() .. Fix

[gwt-contrib] Change in gwt[master]: Fix SingleSelectionModel.getSelectedSet()

2013-07-09 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Fix SingleSelectionModel.getSelectedSet() .. Patch Set 1: (2 comments) File

Re: [gwt-contrib] Working on a patch to fix Exception wrapping/unwrapping in compiler

2013-07-09 Thread Ray Cromwell
To me clear, if I put catch(Exception), catch(Throwable), or catch(RuntimeException), I would expect to catch JavaScriptExceptions. I would only expect a JS exception to escape if and only if, there are no catch blocks for it, or any of it's supertypes, and no uncaught exception handler is

[gwt-contrib] Change in gwt[master]: Fix SingleSelectionModel.getSelectedSet()

2013-07-09 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Fix SingleSelectionModel.getSelectedSet() .. Patch Set 2: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3680 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: Fix SingleSelectionModel.getSelectedSet()

2013-07-09 Thread Matthew Dempsky
Matthew Dempsky has submitted this change and it was merged. Change subject: Fix SingleSelectionModel.getSelectedSet() .. Fix SingleSelectionModel.getSelectedSet() Ensure that if recent changes have been made to the model,

Re: [gwt-contrib] Working on a patch to fix Exception wrapping/unwrapping in compiler

2013-07-09 Thread Ray Cromwell
What I mean is, uncaught native JS exceptions should still be caught by a catch(Throwable) being somewhere on the stack frame. Techncially, the stack trace wasn't lost, as it was available on JavaScriptException.getException().stack, but I get the point, I implemented a similar unwrap for