Re: [gwt-contrib] Class literals for JsTypes in superdevmode

2015-06-09 Thread 'Roberto Lublinerman' via GWT Contributors
I have uploaded the real fix for review at https://gwt-review.googlesource.com/#/c/12920. It should fix your situation but could you verify? On Tue, Jun 9, 2015 at 10:08 AM, 'Chris DiGiano' via GWT Contributors google-web-toolkit-contributors@googlegroups.com wrote: Roberto, if it's any hint

Re: [gwt-contrib] Class literals for JsTypes in superdevmode

2015-06-09 Thread 'Ray Cromwell' via GWT Contributors
Chris, My change actually fixed a bug which may have obscured a problem. There were duplicate class literals being generated. So you'd get InterfaceFoo.class twice in the output, and it may be in SDM you'd be covered, but in regular compiled mode you'd get the duplicates which were causing

Re: [gwt-contrib] Class literals for JsTypes in superdevmode

2015-06-09 Thread 'Chris DiGiano' via GWT Contributors
Roberto, if it's any hint to the underlying problem: you're right that that the class is not reference anywhere elseā€”it is used solely for the purpose of type coercion. Chris On Tue, Jun 9, 2015 at 10:48 AM 'Ray Cromwell' via GWT Contributors google-web-toolkit-contributors@googlegroups.com

Re: [gwt-contrib] Class literals for JsTypes in superdevmode

2015-06-09 Thread 'Chris DiGiano' via GWT Contributors
@Ray, rolling back your change indeed fixed the problem ( https://gwt-review.googlesource.com/#/c/12311/). How do you recommend we proceed? Anything I can do to help? @Roberto, thanks for your suggestion, but I had already tried restarting the code server and clearing the cache. This did not fix

Re: [gwt-contrib] Class literals for JsTypes in superdevmode

2015-06-09 Thread 'Ray Cromwell' via GWT Contributors
ok, taking a look On Tue, Jun 9, 2015 at 11:38 AM, 'Roberto Lublinerman' via GWT Contributors google-web-toolkit-contributors@googlegroups.com wrote: I tweaked the code a bit and now it should never output duplicated class literals. @Ray, Could you review the patch? On Tue, Jun 9, 2015 at

Re: [gwt-contrib] Class literals for JsTypes in superdevmode

2015-06-09 Thread 'Roberto Lublinerman' via GWT Contributors
SDM expects that classes/interfaces get generated as a whole either all of it or none. As you know, class literals are not really part of the class but they are field in a separate synthetic class). Even SDM (with all optimizations off, no pruning at UnifyAST) if a reference to the class literal

Re: [gwt-contrib] Class literals for JsTypes in superdevmode

2015-06-09 Thread 'Roberto Lublinerman' via GWT Contributors
I tweaked the code a bit and now it should never output duplicated class literals. @Ray, Could you review the patch? On Tue, Jun 9, 2015 at 10:31 AM, 'Ray Cromwell' via GWT Contributors google-web-toolkit-contributors@googlegroups.com wrote: I don't think it's an issue that blocks since people

Re: [gwt-contrib] Class literals for JsTypes in superdevmode

2015-06-09 Thread 'Ray Cromwell' via GWT Contributors
I don't think it's an issue that blocks since people are most likely to use SDM in uncompiled mode, and the 'error' can always be suppressed and turned into a warning. At best, it might inhibit a const optimization in Closure where it sees the same variable declared/assigned twice I think. On