Re: [PATCH v1 2/2] Fix prefix and root on ppc64le CDs

2023-01-13 Thread Vladimir 'phcoder' Serbinenko
} > >grub_free (device); > -- > 2.39.0 > > > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/1] gentpl.py: Remove .interp section from .img files.

2023-01-13 Thread Vladimir 'phcoder' Serbinenko
ags -R .reginfo -R .rel.dyn -R .note.gnu.gold-version -R > .note.gnu.property -R .ARM.exidx -R .interp $< $@; \ > fi > """) > > -- > 2.39.0 > > > ___ > Grub-devel mailing list > Grub-devel@gnu.org

Re: clang appends an extra string to Grub2 making it not work with MBR systems

2023-01-12 Thread Vladimir 'phcoder' Serbinenko
h to help debugging this one but > if you can think of any please ask for them. > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2 1/6] ieee1275: request memory with ibm, client-architecture-support

2022-12-13 Thread Vladimir 'phcoder' Serbinenko
> + > + if (grub_strncmp (tmp, "IBM,", 4) == 0) > + grub_ieee1275_set_flag > (GRUB_IEEE1275_FLAG_CAN_TRY_CAS_FOR_MORE_MEMORY); > } Does it work on all IBM? IBM has a long history of PPC machines. What happens when it doesn't? ___

Re: [PATCH v2 2/6] ieee1275: drop len -= 1 quirk in heap_init

2022-12-13 Thread Vladimir 'phcoder' Serbinenko
e, > addr = 0x18; > } > } > - len -= 1; /* Required for some firmware. */ > >/* Never exceed HEAP_MAX_SIZE */ >if (*total + len > HEAP_MAX_SIZE) > -- > 2.25.1 > > > ___ > Grub-devel

Re: Grub saved my Laptop, and made it usable. so i wanted to say thanks to everybody that worked on it.

2022-11-06 Thread Vladimir 'phcoder' Serbinenko
option is not a GRUB command at all and has nothing to do with similarly named GRUB facility that can be used to achieve the same result. This is a linux option that you need to add to the end of linux line > > But on bootable live flashdrive in boot/grub/grub.cfg im not sure how i am >

Re: Grub saved my Laptop, and made it usable. so i wanted to say thanks to everybody that worked on it.

2022-11-06 Thread Vladimir 'phcoder' Serbinenko
___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: Re: [PATCH] term: keymapforce command for lack of at_keyboard

2022-10-11 Thread Vladimir 'phcoder' Serbinenko
Le mar. 11 oct. 2022, 02:20, Daniel Tang a écrit : > I tried putting this in EFI and BIOS console code but was met with a bunch > of header of linker errors. It involved trying to get the console to name > keymap functions or data. I will try coding this again next week or later. > This time I'm

Re: [PATCH] term: keymapforce command for lack of at_keyboard

2022-10-10 Thread Vladimir 'phcoder' Serbinenko
Le lun. 10 oct. 2022, 07:36, Daniel Tang a écrit : > From ba4dfde5037743561bafab617f48163e72989d5c Mon Sep 17 00:00:00 2001 > From: Daniel Tang > Date: Fri, 23 Sep 2022 23:15:16 -0400 > Subject: [PATCH] term: keymapforce command for lack of at_keyboard > > This adds a command named

Re: error symbol 'grub_disk_native_sectors' not found

2022-09-19 Thread Vladimir 'phcoder' Serbinenko
You run grub-install on wrong drive Le lun. 19 sept. 2022, 22:05, PetaFLOPS Computing Ltd. a écrit : > Hello, > > Please check this MX-Linux forum thread: > > http://forum.mxlinux.org/viewtopic.php?p=696219 > > (my post there is #10) > > as well as this earlier communication: > >

Re: [PATCH] Remove HFS support

2022-08-26 Thread Vladimir 'phcoder' Serbinenko
Le ven. 26 août 2022, 17:46, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> a écrit : > Hi Vladimir! > > On 8/19/22 21:01, Vladimir 'phcoder' Serbinenko wrote: > > But booting old machines is still desirable for GRUB. Is there a reason > why > > HFS is ac

Re: [PATCH] Remove HFS support

2022-08-19 Thread Vladimir 'phcoder' Serbinenko
Le ven. 19 août 2022, 21:05, Dimitri John Ledkov < dimitri.led...@canonical.com> a écrit : > There is no need for that code on any signed grubs or upstream. Ports that > want to support this patch can have it conditionally compiled / enabled > only on that arch, but not other. > > For example, in

Re: [PATCH] Remove HFS support

2022-08-19 Thread Vladimir 'phcoder' Serbinenko
Le ven. 19 août 2022, 20:11, Steve McIntyre a écrit : > On Fri, Aug 19, 2022 at 04:03:38PM +0200, John Paul Adrian Glaubitz wrote: > >> On Aug 19, 2022, at 3:59 PM, Daniel Kiper wrote: > >> > >> If I do not hear any major objections in the following weeks I will > >> merge this patch or a

Re: [PATCH v3 2/8] efi: move MS-DOS stub out of generic PE header definition

2022-08-19 Thread Vladimir 'phcoder' Serbinenko
Looks good to me Le jeu. 18 août 2022, 16:54, Ard Biesheuvel a écrit : > The PE/COFF spec permits the COFF signature and file header to appear > anywhere in the file, and the actual offset is recorded in 4 byte > little endian field at offset 0x3c of the image. > > When GRUB is emitted as a

Re: [PATCH] Remove HFS support

2022-08-19 Thread Vladimir 'phcoder' Serbinenko
No go from me either. Older macs may not be able to read HFS+ /boot. Also HFS+ presents couple of problems the biggest one is that in case of sudden reboot HFS+ often needs to be mounted by OSX or cleaning dirty flag manually before it becomes writeable. Le ven. 19 août 2022, 16:05, John Paul

Re: [PATCH 2/2] util: confirm directory creation in grub_install_mkdir_p

2022-08-09 Thread Vladimir 'phcoder' Serbinenko
Did you test the case when some of components exist and are symlinks? E.g. /temp being a symlinkto /var/tmp Le mar. 9 août 2022, 15:30, Darren Kenny a écrit : > Because grub_util_mkdir() is implemented to not return a value on any > platform, grub_instal_mkdir_p can test for success by

Re: [PATCH v2 1/1] Add support for grub-emu to kexec Linux menu entries

2022-08-08 Thread Vladimir 'phcoder' Serbinenko
I like it in general however I had a comment: in future GRUB could be able to do the same through second approach: load a constructed kexec blob with all the parts. This would allow to e.g. kexec FreeBSD. This didn't have to be implemented now. Meanwhile can we use "kexec" as command name? It's

Re: Fix keyboard layouts other than us

2022-07-31 Thread Vladimir 'phcoder' Serbinenko
Le dim. 31 juil. 2022, 12:41, Fabio Pugliese Ornellas < fabio.ornel...@gmail.com> a écrit : > Hi there, > > I've been trying to set up my grub for my Dvorak keyboard. It seems > that everywhere I look points to something like: > > insmod keylayouts > keymap /boot/grub/bepo.gkb > > In practice

Re: grub-mkimage ignores compression option

2022-06-15 Thread Vladimir 'phcoder' Serbinenko
Documentation states that it works only on some platforms. Currently only on MIPS. i386-pc always uses lzma Le mer. 15 juin 2022, 00:39, Eugene Bright via Grub-devel < grub-devel@gnu.org> a écrit : > Option --compression doesn't affect the core image size. > Does it work at all? > > Running it

Re: [PATCH 1/1] gensymlist: fix clang build with exporting of __builtin_trap

2022-06-14 Thread Vladimir 'phcoder' Serbinenko
Correct solution is to provide __builtin_trap ourselves. Likely it would be a wrapper around grub_abort Le mar. 14 juin 2022, 15:37, Darren Kenny a écrit : > clang expands the abort function to __builtin_trap, but that cannot be > exported. > > The script that generates the symlist.c file

Re: [PATCH 1/1] gensymlist: fix clang build with exporting of __builtin_trap

2022-06-14 Thread Vladimir 'phcoder' Serbinenko
> Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Add some randomness to TCP source port selection.

2022-06-06 Thread Vladimir 'phcoder' Serbinenko
Le lun. 6 juin 2022, 19:25, Vladimir 'phcoder' Serbinenko a écrit : > 256 is a bad modulo. A prime would be a much better one for those > purposes. Also get_time_ms counts up from arbitrary point in time, often > boot. I suggest using some combination of etc > RTC, not etc >

Re: [PATCH] Add some randomness to TCP source port selection.

2022-06-06 Thread Vladimir 'phcoder' Serbinenko
256 is a bad modulo. A prime would be a much better one for those purposes. Also get_time_ms counts up from arbitrary point in time, often boot. I suggest using some combination of etc and get_time to seed an LFSR algorithm Le lun. 6 juin 2022, 18:37, Robert LeBlanc a écrit : > GRUB uses a

Re: [PATCH 1/2] font: Add font scaling feature to grub_font_draw_glyph()

2022-05-31 Thread Vladimir 'phcoder' Serbinenko
We should avoid mallocs on every character as mallocs can be slow. Can we instead save scaled versions and reuse them so that we need to do mallocs only once per glyph instead of every time it's used? Le mar. 31 mai 2022, 13:21, Zhang Boyang a écrit : > This patch adds an argument 'scale' to

Re: [PATCH] efidisk: pass buffers with higher alignment

2022-05-05 Thread Vladimir 'phcoder' Serbinenko
Le jeu. 5 mai 2022, 15:55, Stefan Agner a écrit : > Despite the UEFI specification saying "the requirement is that the > start address of a buffer must be evenly divisible by IoAlign with > no remainder.", it seems that a higher alignment requirement is > neecssary on some system (e.g. a Intel

Re: How to boot Windows when Bitlocker enabled with key sealed in TPM

2022-03-25 Thread Vladimir 'phcoder' Serbinenko
h new values? Then it will get unsealed when booted through GRUB > > -- > Chris Murphy > > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- R

Re: Sorry to bother you

2022-03-19 Thread Vladimir 'phcoder' Serbinenko
devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 3/6] commands/i386/pc/sendkey: Fix "writing 1 byte into a region of size 0" build error

2022-03-11 Thread Vladimir 'phcoder' Serbinenko
char *) 0x41c) = keylen + 0x1e; >grub_memcpy ((char *) 0x41e, sendkey, 0x20); > >/* Transform "any ctrl" to "right ctrl" flag. */ > -- > 2.11.0 > > > _______ > Grub-devel mailing list > Grub-devel@gnu.

Re: [PATCH 1/6] osdep/windows/platform: Disable gcc9 -Waddress-of-packed-member

2022-03-10 Thread Vladimir 'phcoder' Serbinenko
path8_len, 0); > + > +#if __GNUC__ >= 9 > +#pragma GCC diagnostic pop > +#endif > + >filep->path_name[path16_len] = 0; >filep->header.length = sizeof (*filep) + (path16_len + 1) * sizeof > (grub_uint16_t); >pathptr = >path_name[path16_l

Re: [PATCH 1/1] fat: fix listing the root directory

2022-01-22 Thread Vladimir 'phcoder' Serbinenko
1; > +} > + >/* The conversion below allows seconds=60, so don't trust its validation. > */ >if ((time & 0x1F) > 29) > return 0; > -- > 2.33.1 > > > _______ > Grub-devel mailing list > Grub-devel@gnu.org

Re: [PATCH] Fix authentication not working in multi-level menus

2021-12-09 Thread Vladimir 'phcoder' Serbinenko
Why not just add "export superusers" to the config file? Le jeu. 9 déc. 2021, 15:42, 周子隆 a écrit : > Since GRUB supports multi-level menu entries: >In order to enable authentication support, the "superusers" variable > and "--unrestricted" in menu entry has been set, but GRUB

Re: [PATCH 1/2] powerpc-ieee1275: load grub at 8MB, not 2MB

2021-11-16 Thread Vladimir 'phcoder' Serbinenko
th 128 MiB or more, loading at 2MiB or 8 MiB shouldn't be much of a difference probably (still needs to be tested). However I wonder of the impact on 32 MiB and 64 MiB machines but not able to test outside of emulator > > Be well, > --Robbie -- Regards Vladimir 'phcoder' Serbinenko

Re: [PATCH 1/2] powerpc-ieee1275: load grub at 8MB, not 2MB

2021-11-16 Thread Vladimir 'phcoder' Serbinenko
= '-Wl,-Ttext,$(TARGET_LINK_ADDR)'; >mips_qemu_mips_ldflags= '-Wl,-Ttext,0x8020'; > diff --git a/include/grub/offsets.h b/include/grub/offsets.h > index 871e1cd4c38c..8b2d6ab971be 100644 > --- a/include/grub/offsets.h > +++ b/include/grub/offsets.h > @@ -63,7 +63,7 @@ > #define GRUB_KERNEL_SP

Re: About the code style requirement

2021-10-01 Thread Vladimir 'phcoder' Serbinenko
On Fri, Oct 1, 2021 at 2:13 AM Qu Wenruo wrote: > > > > On 2021/9/30 18:51, Qu Wenruo wrote: > > > > > > On 2021/9/30 18:20, Vladimir 'phcoder' Serbinenko wrote: > >> > >> > >> Le jeu. 30 sept. 2021, 00:24, Qu Wenruo >> <mailto:w.

Re: About the code style requirement

2021-09-29 Thread Vladimir 'phcoder' Serbinenko
Le mer. 29 sept. 2021, 07:42, Qu Wenruo via Grub-devel a écrit : > Hi, > > I'm recently considering to cross-port btrfs-progs/U-boot btrfs code to > GRUB, so that we can have more unified code base, with more features > (and of-course bug fixes) > Did you check the license compatibility first?

Re: [PATCH] loader/i386/linux: Add device tree support

2021-09-21 Thread Vladimir 'phcoder' Serbinenko
2_t payload_length; > - grub_uint64_t setup_data; > + grub_uint64_t setup_data;/* linked list of additional boot > parameters (E820, DTB, PCI)*/ >grub_uint64_t pref_address; >grub_uint32_t init_size; >grub_uint32_t handover_offset; > -- > 1.8.3.1

Re: submenu fails to see variables

2021-09-06 Thread Vladimir 'phcoder' Serbinenko
Le lun. 6 sept. 2021 à 12:49, Olaf Hering a écrit : > For some reason global variables are not seen in a submenu {} section. > Does anyone happen to know why this behavior is useful? > You need to export variable to make it visible in submenu > > Pseudocode: > > set var=val > menuentry "me" { >

Re: [PATCH 5/5] powerpc: remove GRUB_IEEE1275_FLAG_NO_ANSI

2021-09-06 Thread Vladimir 'phcoder' Serbinenko
Le lun. 6 sept. 2021 à 08:53, Vladimir 'phcoder' Serbinenko < phco...@gmail.com> a écrit : > Any reason to drop OpenHackware? > I've just seen the other mail thread. Will answer there > > Le lun. 6 sept. 2021 à 07:48, Daniel Axtens a écrit : > >> Open Hack'Ware was

Re: [PATCH 5/5] powerpc: remove GRUB_IEEE1275_FLAG_NO_ANSI

2021-09-06 Thread Vladimir 'phcoder' Serbinenko
Any reason to drop OpenHackware? Le lun. 6 sept. 2021 à 07:48, Daniel Axtens a écrit : > Open Hack'Ware was the only user. > > Signed-off-by: Daniel Axtens > --- > grub-core/term/ieee1275/console.c | 4 +--- > include/grub/ieee1275/ieee1275.h | 3 --- > 2 files changed, 1 insertion(+), 6

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

2021-04-22 Thread Vladimir 'phcoder' Serbinenko
Filesystems are not mounted in GRUB. This patch will result in GRUB outputting a warning on every access to any XFS that has this flag set, even if it is not related to further booting. It will create an excessive noise. FS drivers shouldn't print anything except dprintf's Le lun. 19 avr. 2021 à

Re: GRUB 2.06~rc1 released

2021-03-12 Thread Vladimir 'phcoder' Serbinenko
Erwin, can you upload new pot file please? Le ven. 12 mars 2021 à 21:02, Daniel Kiper a écrit : > Hi all, > > The GRUB maintainers are proud to announce the GRUB 2.06~rc1 that has > been just released. > > We would like to thank all the people who have contributed to the project. > > The

Re: i386/biosdisk - int 13h/service 48h response buffer issue?

2021-03-12 Thread Vladimir 'phcoder' Serbinenko
Please try to print/save arguments and results as close to the calling site as reasonable. Maybe Linux passes some other argument differently Le ven. 12 mars 2021 à 19:00, Vladimir 'phcoder' Serbinenko < phco...@gmail.com> a écrit : > Most likely the issue is the BIOS giving wrong val

Re: i386/biosdisk - int 13h/service 48h response buffer issue?

2021-03-12 Thread Vladimir 'phcoder' Serbinenko
Most likely the issue is the BIOS giving wrong values. It's interesting that you get different values from Linux BIOS info but my guess is that Linux corrects wrong BIOS data by comparing with data reported by native driver. This being said If like to be proven wrong. I would modify Linux to save

Re: How-to make grub play a sound when it asks a passphrase and/or in case of an issue.

2021-02-04 Thread Vladimir 'phcoder' Serbinenko
чт, 4 февр. 2021 г., 16:25 Lennart Sorensen : > On Wed, Feb 03, 2021 at 10:54:28PM -0800, Hanson Char wrote: > > I don't know if Grub currently has any sound or accessibility support. > How > > about having a config option to send some ASCII bell characters "\x07" to > > the terminal upon the

Re: [PATCH] Make EFI minimum heap size configurable via --enable-efi-min-heap-mb

2021-01-05 Thread Vladimir 'phcoder' Serbinenko
We try to avoid build time config as much as possible as it creates slightly different binary versions and so far we've been successful. There's only one config that changes resulting binary (besides platform obviously). Please check why relocate is not able to process large ramdisk instead пн, 4

Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes

2020-12-11 Thread Vladimir 'phcoder' Serbinenko
On Fri, Dec 4, 2020 at 5:53 AM Renaud Métrich wrote: > > Hi, > > Testing the proposed patch on my old Asus N53SN in Legacy failed: as soon as > at_keyboard is selected, the keys are corrupted and it's impossible to do > anything. > > Digging into this, it appears that query_mode() returns 2 (so

Re: Mips-arc tests ever work?

2020-12-09 Thread Vladimir 'phcoder' Serbinenko
I have added -M indy in my own branch but never released it сб, 5 дек. 2020 г., 13:34 Glenn Washburn : > Hi, > > I'm looking into getting grub qemu testing working for the "mis-arc" > target. Is anyone running these tests successfully? In grub-shell that > target passed the -M indy arguments to

[PATCH v5 2/2] Document new limitations on MBR gap support

2020-11-13 Thread Vladimir 'phcoder' Serbinenko
performance advantage to align partitions on larger boundaries anyway, so the first partition might start 1 MiB from the start of the disk. -- 2.20.1 -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v5 1/2] Warn if MBR gap is small and user uses advanced modules

2020-11-13 Thread Vladimir 'phcoder' Serbinenko
Signed-off-by: Vladimir Serbinenko On Fri, Nov 13, 2020 at 9:27 PM Vladimir 'phcoder' Serbinenko wrote: > > From 515ee70c0a289624f71f43cbd09be2a1b929f574 Mon Sep 17 00:00:00 2001 > From: Vladimir Serbinenko > Date: Mon, 27 Apr 2020 17:50:04 +0200 > Subject: [PATCH 1/2] Warn if M

[PATCH v5 1/2] Warn if MBR gap is small and user uses advanced modules

2020-11-13 Thread Vladimir 'phcoder' Serbinenko
sparc64 */ + int add_rs_codes __attribute__ ((unused)), /* unused on sparc64 */ + int warn_small) { char *core_path; char *boot_img, *core_img, *boot_path; @@ -530,7 +531,7 @@ SETUP (const char *dir, GRUB_EMBED_PCBIOS, ); else if (ctx.dest_partmap) err = ctx.dest_partmap->embed (dest_dev->disk, , maxsec, - GRUB_EMBED_PCBIOS, ); + GRUB_EMBED_PCBIOS, , warn_small); else err = fs->fs_embed (dest_dev, , maxsec, GRUB_EMBED_PCBIOS, ); -- 2.20.1 -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v4 2/2] Document new limitations on MBR gap support

2020-11-13 Thread Vladimir 'phcoder' Serbinenko
performance advantage to align partitions on larger boundaries anyway, so the first partition might start 1 MiB from the start of the disk. -- 2.20.1 -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH v4 1/2] Warn if MBR gap is small and user uses advanced modules

2020-11-13 Thread Vladimir 'phcoder' Serbinenko
/* unused on sparc64 */ + int add_rs_codes __attribute__ ((unused)), /* unused on sparc64 */ + int warn_small) { char *core_path; char *boot_img, *core_img, *boot_path; @@ -530,7 +531,7 @@ SETUP (const char *dir, GRUB_EMBED_PCBIOS, ); else if (ctx.dest_partmap) err = ctx.dest_partmap->embed (dest_dev->disk, , maxsec, - GRUB_EMBED_PCBIOS, ); + GRUB_EMBED_PCBIOS, , warn_small); else err = fs->fs_embed (dest_dev, , maxsec, GRUB_EMBED_PCBIOS, ); -- 2.20.1 -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 1/2] Warn on small MBR gaps on complicated setups

2020-11-13 Thread Vladimir 'phcoder' Serbinenko
On Wed, 11 Nov 2020, 04:39 Michael Chang, wrote: > On Tue, Nov 10, 2020 at 08:49:52PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > From: Vladimir Serbinenko > > Date: Tue, 10 Nov 2020 20:42:12 +0100 > > Subject: [PATCH 1/2] Warn on small MBR gaps on complicated s

[PATCH 1/2] Warn on small MBR gaps on complicated setups

2020-11-10 Thread Vladimir 'phcoder' Serbinenko
est, int force, int fs_probe, int allow_floppy, - int add_rs_codes __attribute__ ((unused))) /* unused on sparc64 */ + int add_rs_codes __attribute__ ((unused)), /* unused on sparc64 */ + int warn_small __attribute__ ((unused))) /* unused on sparc64 */ { char *core_path

[PATCH 2/2] Document new limitations on MBR gap support

2020-11-10 Thread Vladimir 'phcoder' Serbinenko
performance advantage to align partitions on larger boundaries anyway, so the first partition might start 1 MiB from the start of the disk. -- 2.20.1 -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: Why Lua support was removed

2020-10-14 Thread Vladimir 'phcoder' Serbinenko
Here is the repo: https://savannah.nongnu.org/git/?group=grub-extras As to why is not in main repo: 1) it's a different license 2) it's a large codebase compared to grub itself 3) it's useful only in edge cases So it was kept in separate repo If you have any trouble please let me know On Wed,

Re: Why Lua support was removed

2020-10-14 Thread Vladimir 'phcoder' Serbinenko
Lua is not part of official grub. You need to add grub-contrib for it to work. If you still have problem even with grub-contrib enabled please let me know On Wed, 14 Oct 2020, 10:34 Tianjia Zhang, wrote: > Hi everyone, > > I want to use lua to do some logic on grub, which needs to be embedded >

Re: grub-mkstandalone Error

2020-09-21 Thread Vladimir 'phcoder' Serbinenko
with official source? > > Above command works fine if I use linaro-5.4.1 toolchain. > Can somebody please help to know why the issues is coming with newer > toolchain (like GCC 7.4-2019.02) and any fix for that ? > > > Regards, > Wasim > -- Regards Vladimir 'phcoder' Ser

Re: Usb device detection in grub

2020-08-25 Thread Vladimir 'phcoder' Serbinenko
You need to insmod the usb controller driver вт, 25 авг. 2020 г., 18:06 Arindam Khan : > Hi, > >I am working on a custom STM32 board and have configured the board's > USB OTG as a serial modem device. In Linux, it is getting detected as a > "/dev/ttyACM" and all read and write is working

Re: [PATCH] grub2/btrfs: Add ability to boot from subvolumes

2020-07-11 Thread Vladimir 'phcoder' Serbinenko
Why is this patch needed? Can't subvolumes be reached from real root? Isn't autogenerated grub.cfg use the names based on real root On Sat, Jul 11, 2020, 05:52 wrote: > From: Jeff Mahoney > > This patch adds the ability to specify a different root on a btrfs > filesystem too boot from other

Re: Re: [PATCH 1/1] grub-menulst2cfg.c

2020-07-11 Thread Vladimir 'phcoder' Serbinenko
On Sat, Jul 11, 2020, 13:01 Vladimir 'phcoder' Serbinenko wrote: > > > On Fri, Jul 10, 2020, 11:19 朱光宏 wrote: > >> >> In many cases, entryname is null, so there is no need to call this >> function often, it is faster to do this, what do you think?

[PATCH 3/3] Add tests for cmdline module

2020-06-12 Thread Vladimir 'phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0003-Add-tests-for-cmdline-module.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 2/3] cmdline: Make arguments const

2020-06-12 Thread Vladimir 'phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0002-cmdline-Make-arguments-const.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 1/3] Put quote after equal sign when it makes sense

2020-06-12 Thread Vladimir 'phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko 0001-Put-quote-after-equal-sign-when-it-makes-sense.patch Description: Binary data ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 0/3] cmdline fixes for acpi_osi

2020-06-12 Thread Vladimir 'phcoder' Serbinenko
This patch series introduces an escaping of spaces that is compatible with linux parameter parsing. Also it adds some needed tests for this part of code -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https

Re: [RFC PATCH 3/3] efi: mm: implement runtime addition of pages

2020-06-02 Thread Vladimir 'phcoder' Serbinenko
On Mon, Jun 1, 2020, 21:34 Patrick Steinhardt wrote: > Adjust the interface of `grub_efi_mm_add_regions ()` to take a set of > `GRUB_MM_REGION_*` flags, which most notably is currently only the > `CONSECUTVE` flag. This allows us to set the function up as callback for > the memory subsystem and

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Vladimir 'phcoder' Serbinenko
On Tue, Jun 2, 2020, 13:21 Dimitri John Ledkov wrote: > On Tue, 2 Jun 2020 at 12:12, Vladimir 'phcoder' Serbinenko > wrote: > > > > > > > > On Mon, Jun 1, 2020, 15:21 Chris Coulson > wrote: > >> > >> When a file is verified, the entire content

Re: [PATCH] tests: remove cmdline_cat and gfxterm_menu tests

2020-06-02 Thread Vladimir 'phcoder' Serbinenko
On Tue, Jun 2, 2020, 10:40 Daniel Axtens wrote: > cmdline_cat takes a checksum of a screen that includes the grub > version number, so it has been broken since commit 94d9926a6640 > ("Release 2.04~rc1"). That was in April 2019. > > I have not been able to get the gfxterm_menu tests to pass under

Re: [PATCH] disk/loopback: Don't verify loopback images

2020-06-02 Thread Vladimir 'phcoder' Serbinenko
On Mon, Jun 1, 2020, 15:21 Chris Coulson wrote: > When a file is verified, the entire contents of the verified file are > loaded in to memory and retained until the file handle is closed. A > consequence of this is that opening a loopback image can incur a > significant memory cost. > > As

Re: [PATCH v2] Warn if MBR gap is small and user uses advanced modules

2020-05-29 Thread Vladimir 'phcoder' Serbinenko
Signed-off-by: Bladimir Serbinenko On Fri, May 29, 2020 at 3:09 PM Vladimir 'phcoder' Serbinenko wrote: > > On Tue, May 12, 2020 at 1:48 PM Daniel Kiper wrote: > > > > On Mon, Apr 27, 2020 at 05:51:34PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > W

Re: [PATCH v2] Warn if MBR gap is small and user uses advanced modules

2020-05-29 Thread Vladimir 'phcoder' Serbinenko
On Tue, May 12, 2020 at 1:48 PM Daniel Kiper wrote: > > On Mon, Apr 27, 2020 at 05:51:34PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > We don't want to support small MBR gap in pair with anything but > > the simplest config of biosdisk+part_msdos+simple filesystem. In thi

[PATCH v2] Warn if MBR gap is small and user uses advanced modules

2020-04-27 Thread Vladimir 'phcoder' Serbinenko
st char *dest, int force, int fs_probe, int allow_floppy, - int add_rs_codes __attribute__ ((unused))) /* unused on sparc64 */ + int add_rs_codes __attribute__ ((unused)), /* unused on sparc64 */ + int warn_small) { char *core_path; char *boot_img, *core_img, *boot_path; @@ -530,7 +531,7 @@ SETUP (const char *dir, GRUB_EMBED_PCBIOS, ); else if (ctx.dest_partmap) err = ctx.dest_partmap->embed (dest_dev->disk, , maxsec, - GRUB_EMBED_PCBIOS, ); + GRUB_EMBED_PCBIOS, , warn_small); else err = fs->fs_embed (dest_dev, , maxsec, GRUB_EMBED_PCBIOS, ); -- 2.20.1 -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Warn if MBR gap is small and user uses advanced modules

2020-04-27 Thread Vladimir 'phcoder' Serbinenko
This is first step in this journey. We think that we > have to build some warnings into the code and extend documentation. > Please chime in what you think about that... > > On Tue, Mar 10, 2020 at 01:23:10PM +0100, Vladimir 'phcoder' Serbinenko wrote: > > Daniel, do you want to adjust

[PATCH] mips/cache: Add missing nop's in delay slots

2020-04-27 Thread Vladimir 'phcoder' Serbinenko
$ra + nop -- 2.20.1 -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] efi: add missed space in GRUB_EFI_GLOBAL_VARIABLE_GUID

2020-03-27 Thread Vladimir 'phcoder' Serbinenko
Could you explain why we would need this patch? It changes nothing AFAICT On Fri, Mar 27, 2020, 12:01 Flavio Suligoi wrote: > Signed-off-by: Flavio Suligoi > --- > include/grub/efi/api.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/grub/efi/api.h

Re: [PATCH] Warn if MBR gap is small and user uses advanced modules

2020-03-11 Thread Vladimir 'phcoder' Serbinenko
nvinced me to phase out small MBR gaps > > support gradually. This is first step in this journey. We think that we > > have to build some warnings into the code and extend documentation. > > Please chime in what you think about that... > > > > On Tue, Mar 10, 2020 at 01:23

[PATCH] Warn if MBR gap is small and user uses advanced modules

2020-03-10 Thread Vladimir 'phcoder' Serbinenko
up.c +++ b/util/setup.c @@ -254,7 +254,8 @@ SETUP (const char *dir, const char *boot_file, const char *core_file, const char *dest, int force, int fs_probe, int allow_floppy, - int add_rs_codes __attribute__ ((unused))) /* unused on sparc64 */

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
> It would be best to use a boot partition so the core.img space is > reserved by the GPT, but I once wanted to tack i386-pc GRUB onto an > existing UEFI GPT disk, so I wrote the commands that do what you're > describing here: > >

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
t; > I just hope this question is not too silly... > > Best regards, > Didier > > > [1]https://uefi.org/sites/default/files/resources/UEFI_Spec_2_8_A_Feb14.pdf > § 5.3.1 GPT overview > > _______ > Grub-

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
Le ven. 6 mars 2020 à 13:43, Daniel Kiper a écrit : > Re-adding grub-devel@gnu.org... > > On Fri, Mar 06, 2020 at 12:44:05PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > Le ven. 6 mars 2020 à 12:42, Daniel Kiper a écrit > : > > > > > On Thu, Mar 05

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
Le ven. 6 mars 2020 à 12:38, Javier Martinez Canillas a écrit : > Hello Vladimir, > > Thanks a lot for your feedback. > > On 3/5/20 3:22 PM, Vladimir 'phcoder' Serbinenko wrote: > > Please evaluate size increase for this. In the past passing file and line > > number

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-05 Thread Vladimir 'phcoder' Serbinenko
Please evaluate size increase for this. In the past passing file and line number to grub_dprintf was a huge source of increased Kern and core size Le mer. 4 mars 2020 à 13:01, Javier Martinez Canillas a écrit : > From: Peter Jones > > Add file and line to grub_error() output to make

Re: [PATCH] ofnet: Fix incorrect mask for ppc64

2019-12-13 Thread Vladimir 'phcoder' Serbinenko
On Fri, 13 Dec 2019, 15:56 Vladimir 'phcoder' Serbinenko, wrote: > > -- Forwarded message - > From: Vladimir 'phcoder' Serbinenko > Date: Fri, 13 Dec 2019, 15:56 > Subject: Re: [PATCH] ofnet: Fix incorrect mask for ppc64 > To: Javier Martinez Canillas > &

Fwd: [PATCH] ofnet: Fix incorrect mask for ppc64

2019-12-13 Thread Vladimir 'phcoder' Serbinenko
-- Forwarded message - From: Vladimir 'phcoder' Serbinenko Date: Fri, 13 Dec 2019, 15:56 Subject: Re: [PATCH] ofnet: Fix incorrect mask for ppc64 To: Javier Martinez Canillas On Fri, 13 Dec 2019, 15:33 Javier Martinez Canillas, wrote: > Hello Vladimir, > > Tha

Re: Disable CLI in submenu but allow users to access it

2019-12-03 Thread Vladimir 'phcoder' Serbinenko
Can you update the documentation? On Tue, 3 Dec 2019, 12:32 Paul Menzel, wrote: > Dear Vladimir, > > > On 2019-11-29 16:34, Vladimir 'phcoder' Serbinenko wrote: > > On Fri, 29 Nov 2019, 15:17 Paul Menzel, wrote: > > >> Is it possible to allow unprivil

Re: Disable CLI in submenu but allow users to access it

2019-11-29 Thread Vladimir 'phcoder' Serbinenko
On Fri, 29 Nov 2019, 15:17 Paul Menzel, wrote: > Dear GRUB folks, > > > Is it possible to allow unprivileged users to access a submenu but > not enter the command-line interface? > > Reading the documentation [1] it’s not clear to me how to do that, > and my tests to do that also failed. > > The

Re: Transfering Data from GRUB to userspace?

2019-11-14 Thread Vladimir 'phcoder' Serbinenko
Did you look at cpio generation facility in initrd command? This may be what your are looking for On Mon, 28 Oct 2019, 03:59 Max Tottenham via Grub-devel, wrote: > Hi Folks > > I've often found myself in a position where I've needed to perform some > debugging of remote hardware that does not

Re: workaround for MS Windows' insanity (ignores partition types / hidden flag since 2018)

2019-11-13 Thread Vladimir 'phcoder' Serbinenko
On Wed, 13 Nov 2019, 17:12 Marcel Partap, wrote: > Dear grub devs, > as we have just last week released a hundred of our debian-based > https://github.com/fsfw-dresden/usb-live-linux/ sticks .. and at the > moment are rolling out a version for primary schools, I have stumbled over > the pure

Re: [PATCH] btrfs: disable zstd support for i386-pc

2019-11-06 Thread Vladimir 'phcoder' Serbinenko
On Wed, 6 Nov 2019, 20:55 Michael Chang, wrote: > On Wed, Nov 06, 2019 at 11:15:04AM -0800, Vladimir 'phcoder' Serbinenko > wrote: > > Please don't do it this way. The right solution is to move it to separate > > module and include zstd module when needed. > > I fully ag

Re: [PATCH] btrfs: disable zstd support for i386-pc

2019-11-06 Thread Vladimir 'phcoder' Serbinenko
Please don't do it this way. The right solution is to move it to separate module and include zstd module when needed. Not everybody uses btrfs embedded area. I recommend not to use it. Using mbr gap or BBP is the recommended way. On Tue, 5 Nov 2019, 01:25 Michael Chang, wrote: > The zstd

Re: [PATCH] arm64: make sure fdt has #address-cells and #size-cells properties

2019-10-31 Thread Vladimir 'phcoder' Serbinenko
This patch looks incomplete. What if "chosen" is there but does not contain the relevant fields? On Thu, 31 Oct 2019, 11:39 Javier Martinez Canillas, wrote: > From: Mark Salter > > Recent upstream changes to kexec-tools relies on #address-cells > and #size-cells properties in the FDT. If grub2

Re: [PATCH v3 1/2] Add grub_util_readlink()

2019-10-31 Thread Vladimir 'phcoder' Serbinenko
This patch LGTM On Wed, 30 Oct 2019, 11:49 Javier Martinez Canillas, wrote: > From: Peter Jones > > Currently grub-editenv and related tools are not able to follow symbolic > links when finding their config file. For example the grub-editenv create > command will wrongly overwrite a symlink in

Re: [PATCH] tftp: Normalize slashes in tftp paths

2019-10-31 Thread Vladimir 'phcoder' Serbinenko
Having // at the beginning of the path may have special meaning according to posix. I don't know if it applies in particular case and if the special meaning is useful for grub to begin with, just something to check On Thu, 31 Oct 2019, 11:37 Javier Martinez Canillas, wrote: > From: Lenny

Re: [PATCH] ofnet: Fix incorrect mask for ppc64

2019-10-31 Thread Vladimir 'phcoder' Serbinenko
Please don't chain swap_bytes32 with le_to_cpu32 as it's a less readable equivalent of be_to_cpu32 On Thu, 31 Oct 2019, 11:38 Javier Martinez Canillas, wrote: > From: Masahiro Matsuya > > The netmask configured in firmware is not respected on ppc64 (big endian). > When 255.255.252.0 is set as

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-30 Thread Vladimir 'phcoder' Serbinenko
Oct 2019, 11:40 Javier Martinez Canillas, wrote: > Hello Vladimir, > > On 10/29/19 5:18 PM, Vladimir 'phcoder' Serbinenko wrote: > > What is the problem with main grub.cfg just including the files based on > > environment variables? > > > > Do you mean having a

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-29 Thread Vladimir 'phcoder' Serbinenko
What is the problem with main grub.cfg just including the files based on environment variables? On Tue, 29 Oct 2019, 15:16 Javier Martinez Canillas, wrote: > From: Paulo Flabiano Smorigo > > This patch implements a search for a specific configuration when the config > file is on a

Re: [PATCH] Enable pager by default

2019-10-25 Thread Vladimir 'phcoder' Serbinenko
On Fri, 25 Oct 2019, 08:20 Michael Chang, wrote: > On Thu, Oct 24, 2019 at 04:39:09PM +0200, Daniel Kiper wrote: > > On Thu, Oct 24, 2019 at 06:54:53AM +, Michael Chang wrote: > > > On Tue, Oct 22, 2019 at 04:04:28PM +0200, Daniel Kiper wrote: > > > > On Tue, Oct 22, 2019 at 10:30:20AM

Re: [PATCH] Enable pager by default

2019-10-24 Thread Vladimir 'phcoder' Serbinenko
mp;& > > cmd->flags & GRUB_COMMAND_FLAG_EXTCMD) > > ret = grub_extcmd_dispatcher (cmd, argc, args, ctxt->script); > >else > > ret = (cmd->func) (cmd, argc, args); > > + > > + if (cmd->flags & GRUB_COMMAND_FLAG_PAGINATED) > > +grub_disable_temp_more (); > > } > >else > > ret = grub_errno; > > diff --git a/grub-core/normal/term.c b/grub-core/normal/term.c > > index a1e5c5a0daf..7d4021ff8be 100644 > > --- a/grub-core/normal/term.c > > +++ b/grub-core/normal/term.c > > @@ -57,6 +57,7 @@ static struct term_state *term_states = NULL; > > > > /* If the more pager is active. */ > > static int grub_more; > > +static int temp_more; > > > > static void > > putcode_real (grub_uint32_t code, struct grub_term_output *term, int > > fixed_tab); > > @@ -128,6 +129,22 @@ grub_set_more (int onoff) > >grub_normal_reset_more (); > > } > > > > +void > > +grub_enable_temp_more (void) > > +{ > > + temp_more = grub_more; > > + > > + if (!temp_more) > > +grub_set_more (1); > > Does it change pager variable value? If yes I think > that you should store its original value here and > restore below. > > > +} > > + > > +void > > +grub_disable_temp_more (void) > > +{ > > + if (!temp_more) > > +grub_set_more (0); > > Daniel > > ___ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'phcoder' Serbinenko ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Fix security issue when reading username and password

2019-10-24 Thread Vladimir 'phcoder' Serbinenko
On Thu, 24 Oct 2019, 18:11 Daniel Kiper, wrote: > Hi Hector, > > On Thu, Oct 24, 2019 at 03:22:43PM +0100, Hector Marco wrote: > > Hello Daniel, > > > > Something went wrong in my last email, what I wanted to say is: > > > > The patch prevents that "cur_len" underflows. No negative values for >

Re: [PATCH] Fix security issue when reading username and password

2019-10-24 Thread Vladimir 'phcoder' Serbinenko
; - if (key == GRUB_TERM_BACKSPACE) > + if (key == GRUB_TERM_BACKSPACE && cur_len) > { > if (cur_len) > { > -- > 2.21.0 > > > _______ > Grub-devel mailing list > Grub-devel@gnu.org >

<    1   2   3   4   5   6   7   8   9   10   >