Re: [PATCH v2 4/6] multiboot2: Add tags used to pass ImageHandle to loaded image

2015-11-09 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 09.11.2015 20:15, Vladimir 'phcoder' Serbinenko wrote: > Lgtm > > Le 20 juil. 2015 4:36 PM, "Daniel Kiper" <daniel.ki...@oracle.com > <mailto:daniel.ki...@oracle.com>> a écrit : > > Add tags used to pass ImageHandle to loaded image. It is used >

Re: [PATCH] ofdisk: allocate space for vscsi table

2015-11-09 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 09.11.2015 02:33, Paulo Flabiano Smorigo wrote: > + /* 64 entries should be enough */ > + table_size = sizeof (grub_uint64_t) * 64; Can we do something better than assuming a particular upper limit? You don't even pass this limit to the function in any way. You basically get a buffer

Re: [PATCH] ofdisk: allocate space for vscsi table

2015-11-09 Thread Vladimir 'phcoder' Serbinenko
Le 9 nov. 2015 1:00 PM, "Paulo Flabiano Smorigo" <pfsmor...@gmail.com> a écrit : > > On Mon, Nov 9, 2015 at 8:46 AM, Vladimir 'φ-coder/phcoder' Serbinenko > <phco...@gmail.com> wrote: > > On 09.11.2015 02:33, Paulo Flabiano Smorigo wrote: >

Re: [PATCH v2] ofdisk: add sas disks to the device list

2015-11-09 Thread Vladimir 'phcoder' Serbinenko
Le 9 nov. 2015 8:39 AM, "Paulo Flabiano Smorigo" < pfsmor...@linux.vnet.ibm.com> a écrit : > > All SAS disks attached will be added to the device list. This is the second > version of a patch that I send a while ago [1]. > > [1] https://lists.gnu.org/archive/html/grub-devel/2015-08/msg0.html >

Re: [PATCH] unix/getroot: remove unused MAJOR definition

2015-11-07 Thread Vladimir 'phcoder' Serbinenko
Go ahead Le 7 nov. 2015 7:45 AM, "Andrei Borzenkov" a écrit : > We use major() everywhere, these definitions just add to confusion. > > --- > grub-core/osdep/unix/getroot.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/grub-core/osdep/unix/getroot.c >

Re: [PATCH] doc: document config_directory and config_file variables

2015-11-07 Thread Vladimir 'phcoder' Serbinenko
Go ahead Le 7 nov. 2015 11:22 AM, "Andrey Borzenkov" a écrit : > People are using this variable and it should be documented. > > --- > docs/grub.texi | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/docs/grub.texi b/docs/grub.texi > index

Re: [PATCH] efinet: add efinet_multicast_filter command

2015-11-06 Thread Vladimir 'phcoder' Serbinenko
Le 6 nov. 2015 7:43 PM, "Andrei Borzenkov" <arvidj...@gmail.com> a écrit : > > 06.11.2015 02:47, Vladimir 'phcoder' Serbinenko пишет: > >> If we can't figure out which ones we need to filter out, then it's >> unrealistic to expect our users to be able to confi

Re: [PATCH] arm64: Fix the bug in fdt module

2015-11-05 Thread Vladimir 'phcoder' Serbinenko
; >enable = noemu; > @@ -1674,7 +1673,9 @@ module = { > module = { >name = fdt; >arm64 = loader/arm64/fdt.c; > - enable = arm64; > + arm = loader/arm/fdt.c; Where does this file come from? > + common = lib/fdt.c; > + enable = fdt; > }; > > module = { &

Re: [PATCH] arm64: Fix the bug in fdt module

2015-11-05 Thread Vladimir 'phcoder' Serbinenko
Le 5 nov. 2015 10:48 AM, "Fu Wei" <fu@linaro.org> a écrit : > > Hi Vladimir > > On 5 November 2015 at 17:45, Vladimir 'phcoder' Serbinenko > <phco...@gmail.com> wrote: > > > > Le 5 nov. 2015 9:51 AM, "Fu Wei" <fu@linaro.or

Re: [PATCH] efinet: add efinet_multicast_filter command

2015-11-05 Thread Vladimir 'phcoder' Serbinenko
to promiscuous mode to network interface structure On 11/05/2015 03:28 PM, Vladimir 'phcoder' Serbinenko wrote: > I don't have EFI spec under my hand now. Can we get away with making it > a default or at least for the case when no interface overrides mac > address. Extra config to workaround firm

Re: [PATCH] efinet: add efinet_multicast_filter command

2015-11-05 Thread Vladimir 'phcoder' Serbinenko
I don't have EFI spec under my hand now. Can we get away with making it a default or at least for the case when no interface overrides mac address. Extra config to workaround firmware bugs is usually harmful Le 5 nov. 2015 9:17 PM, "Josef Bacik" a écrit : > We have some hardware

Re: [PATCH] arm64: Fix the bug in fdt module

2015-11-05 Thread Vladimir 'phcoder' Serbinenko
Le 5 nov. 2015 2:39 PM, "Fu Wei" <fu@linaro.org> a écrit : > > Hi Vladimir, > > > On 5 November 2015 at 18:00, Vladimir 'phcoder' Serbinenko > <phco...@gmail.com> wrote: > > > > Le 5 nov. 2015 10:48 AM, "Fu Wei" <fu@linaro.

Re: Kernel panics (in QEMU) when booting with GRUB2 + OVMF + QEMU.

2015-11-04 Thread Vladimir 'phcoder' Serbinenko
Le 17 août 2015 5:26 PM, "Mark Lee" a écrit : > > On Monday, August 17, 2015 05:22:43 PM Andrei Borzenkov wrote: > > Error itself simply says that kernel cannot find root fs. It does not > > say anything about why it happened. > Yes. It boots on hardware (dd if=test.img of=).

Re: [PATCH] file: ignore host disk in blocklist check

2015-11-04 Thread Vladimir 'phcoder' Serbinenko
Le 18 sept. 2015 8:09 PM, "Andrei Borzenkov" a écrit : > > It cannot work anyway because host disk cannot be read. This fixes hostfs access > on native Windows build where filenames start with '\' or do not have initial > separator at all (d:\foo). > > Issue was observed when

Re: modules size in mkimage

2015-11-04 Thread Vladimir 'phcoder' Serbinenko
Le 31 oct. 2015 8:02 AM, "Andrei Borzenkov" a écrit : > > mkimage sets module size to aligned value; later it is used to actually process it which /may/ lead to inconsistency (as any comparison is against stored aligned size, not actual module size). > Which inconsistency do

Re: [PATCH v2 1/6] gitignore: Ignore *.orig, *.rej and *.swp files

2015-11-04 Thread Vladimir 'phcoder' Serbinenko
Le 12 août 2015 11:04 AM, "Ian Campbell" a écrit : > > > (Having written the below I see too late that this is a grub patch not a > Xen one, a tag in the subject for such cross posted patches would be useful > please. Anyway, my opinion counts for very little in this

Re: [PATCH] arm64: Fix the bug in fdt module

2015-11-04 Thread Vladimir 'phcoder' Serbinenko
Le 4 nov. 2015 12:03 PM, "Fu Wei" <fu@linaro.org> a écrit : > > Hi Vladimir, > > > On 4 November 2015 at 18:47, Vladimir 'phcoder' Serbinenko > <phco...@gmail.com> wrote: > > > > Le 4 nov. 2015 10:48 AM, "Fu Wei" <fu@li

Re: [PATCH] arm64: Fix the bug in fdt module

2015-11-04 Thread Vladimir 'phcoder' Serbinenko
Le 4 nov. 2015 12:09 PM, "Fu Wei" <fu@linaro.org> a écrit : > > Hi Vladimir, > > On 4 November 2015 at 19:06, Fu Wei <fu@linaro.org> wrote: > > Hi Vladimir, > > > > On 4 November 2015 at 18:47, Vladimir 'phcoder' Serbinenko > > &l

Re: [PATCH] arm64: Fix the bug in fdt module

2015-11-04 Thread Vladimir 'phcoder' Serbinenko
Le 4 nov. 2015 12:12 PM, "Vladimir 'phcoder' Serbinenko" <phco...@gmail.com> a écrit : > > > Le 4 nov. 2015 12:09 PM, "Fu Wei" <fu@linaro.org> a écrit : > > > > Hi Vladimir, > > > > On 4 November 2015 at 19:06, Fu Wei <fu

Re: [PATCH grub-core/kern/xen/init.c] pvgrub2 xen cmdline xenstore var to grubenv

2015-11-04 Thread Vladimir 'phcoder' Serbinenko
. > > I think that is a fine > behaviour to be starting with. > Whatever we do now, we're stuck with it. It's interface and almost impossible to retire. We need a sane interface from day 1 ___ Grub-devel mailing list Grub-devel@gnu.org

Re: Dell Dimension 8300 reboots when grub2 cbfs module is loaded

2015-11-03 Thread Vladimir 'phcoder' Serbinenko
Which platform is it? i386-pc, i386-efi or x86_64-efi? The behavior is actually will defined, just different between cpu modes Le 3 nov. 2015 6:08 PM, "Andrei Borzenkov" <arvidj...@gmail.com> a écrit : > 03.11.2015 19:28, Vladimir 'phcoder' Serbinenko пишет: > >>

Re: [coreboot] Dell Dimension 8300 reboots when grub2 cbfs module is loaded

2015-11-03 Thread Vladimir 'phcoder' Serbinenko
Le 3 nov. 2015 6:46 PM, "Aaron Durbin" <adur...@google.com> a écrit : > > On Tue, Nov 3, 2015 at 10:28 AM, Vladimir 'phcoder' Serbinenko > <phco...@gmail.com> wrote: > > The code itself looks good but I'd like more details. Reading 0x > > sh

Re: C.UTF-8 may not be present resulting in failed build

2015-11-03 Thread Vladimir 'phcoder' Serbinenko
Le 2 nov. 2015 7:48 PM, "Andrei Borzenkov" a écrit : > > Extra catalogs added in da0d5b3f explicitly require C.UTF-8 locale. This locale may not be present (e.g. openSUSE does not have it). > > Upstream gettext (and hence en@quot rules) does not use it. Is forcing this locale

Re: Dell Dimension 8300 reboots when grub2 cbfs module is loaded

2015-11-03 Thread Vladimir 'phcoder' Serbinenko
The code itself looks good but I'd like more details. Reading 0x shouldn't cause reboot. Why does it? Le 1 nov. 2015 3:53 PM, "Andrei Borzenkov" a écrit : > I was debugging problem reported by user on Dell Dimension 8300 - it > rebooted when doing "ls -l". It turned

Re: Anonymous commit (empty Author and Committer)

2015-11-01 Thread Vladimir 'phcoder' Serbinenko
Opened Savannah support ticket Le 31 oct. 2015 2:54 PM, "Andrei Borzenkov" <arvidj...@gmail.com> a écrit : > 30.10.2015 23:19, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> >>> On

Re: [PATCH V2] mkimage: zero fill alignment space

2015-11-01 Thread Vladimir 'phcoder' Serbinenko
Go ahead Le 31 oct. 2015 9:39 AM, "Andrei Borzenkov" a écrit : > This did not cause real problem but is good for reproducible builds. I hit > it with recent bootinfoscript that displays embedded config; I was puzzled > by random garbage at the end. > > Prezero memory buffer

Re: [PATCH V2] mkimage: zero fill alignment space

2015-11-01 Thread Vladimir 'phcoder' Serbinenko
Le 2 nov. 2015 8:25 AM, "Vladimir 'phcoder' Serbinenko" <phco...@gmail.com> a écrit : > > Go ahead > Actually please wait till Savannah admins kill the empty commit > Le 31 oct. 2015 9:39 AM, "Andrei Borzenkov" <arvidj...@gmail.com> a écrit : >&

Re: Anonymous commit (empty Author and Committer)

2015-10-30 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 30.10.2015 15:26, Andrei Borzenkov wrote: >>> See >>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb85

Re: Anonymous commit (empty Author and Committer)

2015-10-30 Thread Vladimir 'phcoder' Serbinenko
On 30 Oct 2015 9:06 pm, "Vladimir 'φ-coder/phcoder' Serbinenko" < phco...@gmail.com> wrote: > > On 30.10.2015 15:26, Andrei Borzenkov wrote: > > See > > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665a

Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64

2015-10-30 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 30.10.2015 09:44, Fu Wei wrote: > Hi Vladimir, > > Great thanks for your suggestion! :-) > > On 29 October 2015 at 23:25, Vladimir 'φ-coder/phcoder' Serbinenko > <phco...@gmail.com> wrote: >>> +if [ "x$machine" != xaarch64 ]; then >>> +

Re: Anonymous commit (empty Author and Committer)

2015-10-30 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 30.10.2015 15:26, Andrei Borzenkov wrote: > See > http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac > > > I was not even aware that this is possible. Is there anything on server > side that can prevent it? > > Would be good if commit were amended

Re: Anonymous commit (empty Author and Committer)

2015-10-30 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 30.10.2015 15:26, Andrei Borzenkov wrote: >> See >> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac >> >> >> I was not even aware that this is poss

Re: [PATCH] mkimage: zero fill alignment space

2015-10-30 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 30.10.2015 16:49, Andrei Borzenkov wrote: > This did not cause real problem but is good for reproducible builds. I hit > it with recent bootinfoscript that displays embedded config; I was puzzled > by random garbage at the end. > > Also remove redundant zeroing code where we fill in the whole

Re: [PATCH v3 1/4] arm64: Add and export some accessor functions for xen boot

2015-10-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 23.07.2015 07:16, fu@linaro.org wrote: > From: Fu Wei > > Add accessor functions of "loaded" flag in > grub-core/loader/arm64/linux.c. > > Export accessor functions of "loaded" flag and > grub_linux_get_fdt function in include/grub/arm64/linux.h. > > Purpose: Reuse

Re: [edk2] [grub PATCH] efinet: disable MNP background polling

2015-10-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.10.2015 17:39, Seth Goldberg wrote: > > >> On Oct 14, 2015, at 4:08 AM, Daniel Kiper wrote: >> >>> On Wed, Oct 14, 2015 at 05:19:32AM +, Ye, Ting wrote: >>> Hi all, >>> >>> If I understand the issue correctly, I don't quite agree that UEFI >>> spec is

Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64

2015-10-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> +if [ "x$machine" != xaarch64 ]; then > + multiboot_cmd="multiboot" > + module_linux_cmd="module" > + module_initrd_cmd="module --nounzip" > +else > + multiboot_cmd="xen_hypervisor" > + module_linux_cmd="xen_linux" > + module_initrd_cmd="xen_initrd" > +fi > + Please do

Re: [PATCH v3 2/4] arm64: Add xen_boot module file

2015-10-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Committed without the xen_module command. Its argument parsing was non-trivial and I don't quite get what its intent is. Can you resubmit? On 23.07.2015 07:16, fu@linaro.org wrote: > From: Fu Wei > > grub-core/loader/arm64/xen_boot.c > > - This adds support for the Xen

Re: Be File System identified as bfs

2015-10-29 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> As you can see, it thinks /dev/sda6 a 'bfs' partition, causing script > 83haiku to fail. > 12 befs|befs_be) debug "$partition is a BeFS partition" ;; Looks like this is a simple one-line change. befs|befs_be is a name used by old driver which had to be removed signature.asc

Re: Be File System identified as bfs

2015-10-29 Thread Vladimir 'phcoder' Serbinenko
On 29 Oct 2015 8:51 pm, "Andrei Borzenkov" <arvidj...@gmail.com> wrote: > > 29.10.2015 18:12, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> >>> As you can see, it thinks /dev/sda6 a 'bfs' partition, causing script >>> 83haiku to fail. >>

Re: Plain dm-crypt

2015-10-29 Thread Vladimir 'phcoder' Serbinenko
. > > Chris > > > On 2015-10-27 11:10, Vladimir 'phcoder' Serbinenko wrote: >> >> There are patches for it but they will not be integrated as plain dm-crypt >> has no advantages compared to LUKS and cannot be configured reliably when >> device names change a

Re: [PATCH] sparc64: boot performance improvements

2015-10-28 Thread Vladimir 'phcoder' Serbinenko
Le 27 oct. 2015 5:34 PM, "Eric Snowberg" <eric.snowb...@oracle.com> a écrit : > > > > On Oct 25, 2015, at 9:20 AM, Vladimir 'φ-coder/phcoder' Serbinenko < phco...@gmail.com> wrote: > > > > On 11.10.2015 18:49, Eric Snowberg wrote: > >&g

Re: Plain dm-crypt

2015-10-27 Thread Vladimir 'phcoder' Serbinenko
There are patches for it but they will not be integrated as plain dm-crypt has no advantages compared to LUKS and cannot be configured reliably when device names change as they have no UUID Le 27 oct. 2015 8:20 AM, a écrit : > Hello; > I apologize if this question

Re: [PATCH v2] Suport for bi-endianess in elf file

2015-10-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 23.07.2015 16:10, Paulo Flabiano Smorigo wrote: > Updated version with the suggestions from Andrei Borzenkov. > > * grub-core/kern/elf.c: check and switch endianess with grub_{be,le}_to > cpu functions. > * grub-core/kern/elfXX.c: Likewise. Applied after fixing following problems: * Since you

Re: [PATCH 3/3] ieee1275: ofdisk - don't continue to query block-size after we have it

2015-10-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 26.10.2015 22:43, Eric Snowberg wrote: > Within commit: 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue > to query block-size if disk doesn't have it.” Disks that returned 0 to the > block-size query, still get queried every time. > > Fix logic in grub_ofdisk_get_block_size so the

Re: [PATCH 1/3] ieee1275: ofdisk dangling pointer

2015-10-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 26.10.2015 22:43, Eric Snowberg wrote: > Within commit: 87ec3b7fa9061f470616ed927fc140e995831c00 - > "Don't continue to query block-size if disk doesn't have it.” > a dangling pointer was introduced. > > Fix dangling pointer issue in grub_ofdisk_open where devpath is freed > and then used

Re: [PATCH 2/3] ieee1275: ofdisk memory leak

2015-10-26 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 26.10.2015 22:43, Eric Snowberg wrote: > Fix memory leak added within commit: > 87ec3b7fa9061f470616ed927fc140e995831c00 - "Don't continue to > query block-size if disk doesn't have it.” > Committed, thanks > Signed-off-by: Eric Snowberg > --- >

Re: [PATCH] sparc64: boot performance improvements

2015-10-25 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 11.10.2015 18:49, Eric Snowberg wrote: > >> On Oct 10, 2015, at 1:35 AM, Vladimir 'phcoder' Serbinenko >> <phco...@gmail.com> wrote: >> >> >> Le 10 oct. 2015 3:31 AM, "Eric Snowberg" <eric.snowb...@oracle.com> a écrit : >>>

Re: [PATCH] Make CTRL and ALT keys work as expected on EFI systems (version 5).

2015-10-25 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 25.02.2014 23:12, Peter Jones wrote: > This is version 4. > > Changes from version 1: > - handles SHIFT as a modifier > - handles F11 and F12 keys > - uses the handle provided by the system table to find our _EX protocol. > > Changes from version 2: > - eliminate duplicate keycode

Re: Add check when store disk cache

2015-10-13 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 19.09.2015 09:00, Andrei Borzenkov wrote: > 18.09.2015 12:07, Arch Stack пишет: >> I want to use the part of the filesystem codes in GRUB to read different >> filesystems on Windows. I have almost completed it and I will release >> it in >> a few days. >> But it crash sometimes because of the

Re: Keyboard not working with QEMU and coreboot and GRUB payload

2015-10-13 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 18.08.2015 14:11, Andrei Borzenkov wrote: > On Tue, Aug 18, 2015 at 12:41 AM, Paul Menzel > wrote: >> Dear GRUB folks, >> >> >> just a note that using QEMU with coreboot and GRUB payload, I am unable >> to enter anything. >> >> Using libpayload based

Re: GNU GRUB maintenance

2015-10-09 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 08.10.2015 21:34, Konrad Rzeszutek Wilk wrote: > On October 8, 2015 10:52:25 AM EDT, Andrei Borzenkov <arvidj...@gmail.com> > wrote: >> On Thu, Oct 8, 2015 at 12:14 AM, Vladimir 'φ-coder/phcoder' Serbinenko >> <phco...@gmail.com> wrote: >>> Hello, all.

Re: [PATCH v2] Ensure that MIPS target code is compiled for the O32 ABI.

2015-10-09 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 09.10.2015 23:14, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 13.09.2015 08:32, Andrei Borzenkov wrote: >> 08.09.2015 20:11, Vladimir 'φ-coder/phcoder' Serbinenko пишет: >>> On 23.08.2015 23:50, Mark H Weaver wrote: >>>> Include -mabi=32 in CFLAGS_P

Re: GNU GRUB maintenance

2015-10-09 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 08.10.2015 16:52, Andrei Borzenkov wrote: > On Thu, Oct 8, 2015 at 12:14 AM, Vladimir 'φ-coder/phcoder' Serbinenko > <phco...@gmail.com> wrote: >> Hello, all. I'm sorry for not being available to do enough maintenance >> for GRUB in last time but I was overbooked.

Re: [PATCH v2] Ensure that MIPS target code is compiled for the O32 ABI.

2015-10-09 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 13.09.2015 08:32, Andrei Borzenkov wrote: > 08.09.2015 20:11, Vladimir 'φ-coder/phcoder' Serbinenko пишет: >> On 23.08.2015 23:50, Mark H Weaver wrote: >>> Include -mabi=32 in CFLAGS_PLATFORM and CCASFLAGS_PLATFORM to compile >>> code for the O32 ABI when targ

Re: [PATCH] sparc64: boot performance improvements

2015-10-09 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 06.10.2015 19:39, Eric Snowberg wrote: > Keep of devices open. This can save 6 - 7 seconds per open call and > can decrease boot times from over 10 minutes to 29 seconds on > larger SPARC systems. The open/close calls with some vendors' > SAS controllers cause the entire card to be

Re: GNU GRUB maintenance

2015-10-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 07.10.2015 23:36, SevenBits wrote: > > > On Wednesday, October 7, 2015, Vladimir 'φ-coder/phcoder' Serbinenko > <phco...@gmail.com <mailto:phco...@gmail.com>> wrote: > > Hello, all. I'm sorry for not being available to do enough maintenance >

GNU GRUB maintenance

2015-10-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Hello, all. I'm sorry for not being available to do enough maintenance for GRUB in last time but I was overbooked. Yet there is a good news. At Google there is a 20% project and GRUB has been approved as 20% project for me. The goal is to have 2.02 released before the end of this year. Other than

Re: cryptodisk: teach grub_cryptodisk_insert() about partitions (bug #45889)

2015-09-08 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 06.09.2015 21:10, TJ wrote: > https://savannah.gnu.org/bugs/index.php?45889 > > Boot disk with 3 LUKS/dm-crypt GPT partitions > > (hd0,gpt3) (hd0,gpt4) (hd0,gpt5) > > grub is in (hd0,gpt3). The others have a LVM VG each. > > Using GRUB_ENABLE_CRYPTODISK=y I deliberately fail the first

Re: [PATCH] Remove unconditional disablement of the watchdog

2015-09-08 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 01.09.2015 07:51, Arthur Mesh wrote: > Starting with d9a0c9413e81d3c0affc6383693bdd28dc863a5c, GRUB unconditionally > disables watchdog on EFI platforms. This opens up a window (starting at GRUB's > grub_efi_init(), until OS re-enables it) when EFI system operates w/o > watchdog. > If an EFI

Re: [PATCH v2] Ensure that MIPS target code is compiled for the O32 ABI.

2015-09-08 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 23.08.2015 23:50, Mark H Weaver wrote: > Include -mabi=32 in CFLAGS_PLATFORM and CCASFLAGS_PLATFORM to compile > code for the O32 ABI when targetting MIPS, since the MIPS assembly code > in GRUB assumes this. Could you be more precise where we assume this? Why not fix the assembly instead? >

Re: [PATCH 1/3] efinet: handle get_status() properly

2015-08-05 Thread Vladimir 'phcoder' Serbinenko
This patch improperly assumes that GRUB is the only thing in EFI that transmits. Your patch surely fixed your machine but likely breaks some other machines. Could you instead make an explicit check for (void *)1 and add a comment on which machine it's necessary? Le 5 août 2015 10:28 PM, Josef

Re: [PATCH 1/3] efinet: handle get_status() properly

2015-08-05 Thread Vladimir 'phcoder' Serbinenko
Making user aware of such deeply technical stuff is almost always bad thing. Moreover it's not always easy to set this variable early enough Le 5 août 2015 10:50 PM, Josef Bacik jba...@fb.com a écrit : On 08/05/2015 04:39 PM, Josef Bacik wrote: On 08/05/2015 04:32 PM, Vladimir 'phcoder

Re: GRUB release schedule?

2015-07-29 Thread Vladimir 'phcoder' Serbinenko
i386-ieee1275 and some other ports still fail the tests Le 29 juil. 2015 9:09 PM, Bruce Dubbs bruce.du...@gmail.com a écrit : Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 20.07.2015 21:25, Vladimir 'phcoder' Serbinenko wrote: I'll do next beta tomorrow and will assess current open bugs

Re: Cryptomount enhancements - revised

2015-07-28 Thread Vladimir 'phcoder' Serbinenko
Other than 3 and 5 they require difficult configuration. Mapping devices in GRUB isn't trivial. Those features are difficult to autoconfigure. Consider plain mode: how will you find which disk is yours when you have 5 disks all looking as random data? Le 28 juil. 2015 8:59 PM, John Lane

Re: ELF check: GRUB_ERR_BAD_FILE_TYPE vs. GRUB_ERR_BAD_OS

2015-07-25 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 24.07.2015 20:50, Andrei Borzenkov wrote: There are two places using GRUB_ERR_BAD_FILE_TYPE and other are using GRUB_ERR_BAD_OS when EFL class check fails. I am not sure about exact semantics of either but probably they should be the same? BAD_FILE_TYPE is only for errors like EISDIR and

Re: GRUB release schedule?

2015-07-24 Thread Vladimir 'phcoder' Serbinenko
Le 24 juil. 2015 06:20, Andrei Borzenkov arvidj...@gmail.com a écrit : В Mon, 20 Jul 2015 14:22:45 -0400 Peter Jones pjo...@redhat.com пишет: Hi everyone, Is there a plan for when upcoming GNU GRUB releases will happen? As far as I can tell, the last official release on

Re: [PATCH v2] Suport for bi-endianess in elf file

2015-07-24 Thread Vladimir 'phcoder' Serbinenko
Le 23 juil. 2015 16:11, Paulo Flabiano Smorigo pfsmor...@linux.vnet.ibm.com a écrit : Updated version with the suggestions from Andrei Borzenkov. * grub-core/kern/elf.c: check and switch endianess with grub_{be,le}_to cpu functions. * grub-core/kern/elfXX.c: Likewise. Also-by: Tomohiro B

Re: GRUB release schedule?

2015-07-22 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 20.07.2015 21:25, Vladimir 'phcoder' Serbinenko wrote: I'll do next beta tomorrow and will assess current open bugs to see how far we're from release Fixing tests takes longer than expected. I'll continue tomorrow. Le 20 juil. 2015 20:23, Peter Jones pjo...@redhat.com mailto:pjo

Re: On MIPS clang default to different arch than GNU

2015-07-21 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 19.07.2015 09:33, Andrei Borzenkov wrote: clang -cc1 version 3.8.0 based upon LLVM 3.8.0svn default target x86_64-unknown-linux-gnu ignoring nonexistent directory /include #include ... search starts here: #include ... search starts here: /usr/local/include

Re: GRUB release schedule?

2015-07-20 Thread Vladimir 'phcoder' Serbinenko
I'll do next beta tomorrow and will assess current open bugs to see how far we're from release Le 20 juil. 2015 20:23, Peter Jones pjo...@redhat.com a écrit : Hi everyone, Is there a plan for when upcoming GNU GRUB releases will happen? As far as I can tell, the last official release on

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

2015-07-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 15.07.2015 18:52, Leif Lindholm wrote: On Wed, Jul 15, 2015 at 05:47:50PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Go ahead The below was more of an RFC than something committable - are you OK with me splitting the types.h changes out as a separate patch? Actually I think

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

2015-07-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 15.07.2015 18:52, Leif Lindholm wrote: On Wed, Jul 15, 2015 at 05:47:50PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Go ahead The below was more of an RFC than something committable - are you OK with me splitting the types.h changes out as a separate patch? I've fixed

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

2015-07-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 16.07.2015 05:46, Andrei Borzenkov wrote: В Wed, 15 Jul 2015 17:49:30 +0200 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 03.07.2015 21:05, Andrei Borzenkov wrote: I do not claim I understand why clang complains, but this patch does fix it. fs/xfs.c:452:25: error

Re: [RFD] diskfilter stale RAID member detection vs. lazy scanning

2015-07-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 16.07.2015 05:42, Andrei Borzenkov wrote: В Wed, 15 Jul 2015 20:05:56 +0200 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: On 28.06.2015 20:06, Andrei Borzenkov wrote: I was looking at implementing detection of outdated RAID members. Unfortunately it appears

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-07-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 16.07.2015 20:55, Andrei Borzenkov wrote: В Wed, 15 Jul 2015 19:42:39 +0200 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com пишет: It is possible to compile using --target=powerpc -Wl,-EB - this works on all three ppc, ppc64 and ppc64le, but this means hardcoding GNU ld

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 30.06.2015 20:28, Andrei Borzenkov wrote: В Tue, 30 Jun 2015 15:05:46 -0300 Paulo Flabiano Smorigo pfsmor...@linux.vnet.ibm.com пишет: On 2015-06-30 11:33, Vladimir 'phcoder' Serbinenko wrote: What about clang? Not good news about clang support. This is what the toolchain team said

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 04.07.2015 08:46, Andrei Borzenkov wrote: В Tue, 30 Jun 2015 21:34:10 +0200 Vladimir 'phcoder' Serbinenko phco...@gmail.com пишет: I think those flags disable only runtime libraries, not the code generation Yes, you are right. Clang seems to be built for the whole family, i.e. PowerPC

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 15.07.2015 18:52, Leif Lindholm wrote: On Wed, Jul 15, 2015 at 05:47:50PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Go ahead The below was more of an RFC than something committable - are you OK with me splitting the types.h changes out as a separate patch? Yes On 07.07.2015

Re: [RFD] diskfilter stale RAID member detection vs. lazy scanning

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 28.06.2015 20:06, Andrei Borzenkov wrote: I was looking at implementing detection of outdated RAID members. Unfortunately it appears to be fundamentally incompatible with lazy scanning as implemented currently by GRUB. We simply cannot stop scanning for other copies of metadata once enough

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
It is possible to compile using --target=powerpc -Wl,-EB - this works on all three ppc, ppc64 and ppc64le, but this means hardcoding GNU ld dependency. Thanks for this info. See attached patch So I'd rather try to produce patch for proper support of -mbig-endian/-mlittle-endian (including

Re: [PATCH 3/5] i386/relocator: Remove unused avoid_efi_bootservices argument

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 30.05.2015 07:25, Andrei Borzenkov wrote: В Fri, 29 May 2015 22:58:43 +0200 Daniel Kiper daniel.ki...@oracle.com пишет: Another questions is why grub_relocator_alloc_chunk_addr() does not consult EFI memory map if grub_relocator_alloc_chunk_align() does. Should not we fix it? My best

Re: [RFD] diskfilter stale RAID member detection vs. lazy scanning

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 15.07.2015 20:05, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 28.06.2015 20:06, Andrei Borzenkov wrote: I was looking at implementing detection of outdated RAID members. Unfortunately it appears to be fundamentally incompatible with lazy scanning as implemented currently by GRUB. We

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 03.07.2015 21:05, Andrei Borzenkov wrote: I do not claim I understand why clang complains, but this patch does fix it. fs/xfs.c:452:25: error: cast from 'struct grub_xfs_btree_node *' to 'grub_uint64_t *' (aka 'unsigned long long *') increases required alignment from 1 to 8

Re: [PATCH v2 0/3] arm64: Add multiboot support (via fdt) for Xen boot

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 13.07.2015 10:53, fu@linaro.org wrote: From: Fu Wei fu@linaro.org - This adds support for the Xen boot on ARM specification for arm64. - The implementation for Xen is following Multiboot on ARM Specification:

Re: [PATCH] zfs: fix compilation failure with clang due to alignment

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Go ahead On 07.07.2015 19:17, Leif Lindholm wrote: On Fri, Jul 03, 2015 at 10:05:47PM +0300, Andrei Borzenkov wrote: I do not claim I understand why clang complains, but this patch does fix it. fs/xfs.c:452:25: error: cast from 'struct grub_xfs_btree_node *' to 'grub_uint64_t *' (aka

Re: [PATCH v2 1/3] arm64: Add Xen boot support file

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 13.07.2015 10:53, fu@linaro.org wrote: From: Fu Wei fu@linaro.org This patch adds Xen boot support file: grub-core/loader/arm64/xen_boot.c include/grub/arm64/xen_boot.h This patch also adds commands register code and hearder file into grub-core/loader/arm64/linux.c - This

Re: [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.07.2015 15:09, Fu Wei wrote: Hi Andrei, Great thanks for your review. So Are you suggesting this: (1) in util/grub.d/20_linux_xen.in, we only use xen_hypervisor/xen_module. (2) in xen_boot.c, we only register command xen_hypervisor/xen_module. (3) in grub-core/loader/i386/xen.c, we

Re: CentOS 7 - gfxterm does not work during Kernel boot

2015-07-15 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 02.07.2015 16:55, Abdelghani Ouchabane wrote: Hallo, my system is installed with CentOS 7 (7.1.1503), and it has: 1. grub2-2.02-0.16.el7.centos.x86_64 2. kernel-3.10.0-229.1.2.el7.x86_64 3. xorg-x11-drv-catalyst-14.4-1.eldel7.2.3r.1.x86_64 I want to configure grub2 to use GRUB

Re: [PATCH 0/4] Implement the 'setkey' command to allow changing the keyboard map

2015-07-14 Thread Vladimir 'phcoder' Serbinenko
Le 14 juil. 2015 19:25, Luc Van Rompaey luc.vanromp...@gmail.com a écrit : Just a few quick notes: I have just retried to integrate my 'setkey' and 'setnumpad' commands into my input terminal module, and it works. I have no idea what I did wrong when I tried it earlier on, but it obviously

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-06-30 Thread Vladimir 'phcoder' Serbinenko
Which compilers support these flags? I'm concerned of breaking old compilers Le 30 juin 2015 14:57, Paulo Flabiano Smorigo pfsmor...@linux.vnet.ibm.com a écrit : libgcc dependency was removed *just* for this target because the distros that use ppc64el doesn't have 32-bit support on it. *

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-06-30 Thread Vladimir 'phcoder' Serbinenko
What about clang? Le 30 juin 2015 16:30, Andrei Borzenkov arvidj...@gmail.com a écrit : On Tue, Jun 30, 2015 at 5:03 PM, Vladimir 'phcoder' Serbinenko phco...@gmail.com wrote: Which compilers support these flags? I'm concerned of breaking old compilers -static and -mbig-endian are listed

Re: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

2015-06-30 Thread Vladimir 'phcoder' Serbinenko
I think those flags disable only runtime libraries, not the code generation Le 30 juin 2015 20:29, Andrei Borzenkov arvidj...@gmail.com a écrit : В Tue, 30 Jun 2015 15:05:46 -0300 Paulo Flabiano Smorigo pfsmor...@linux.vnet.ibm.com пишет: On 2015-06-30 11:33, Vladimir 'phcoder' Serbinenko

Re: [PATCH] core/partmap: Add El Torito boot catalog parsing

2015-06-20 Thread Vladimir 'phcoder' Serbinenko
I agree with Andrei. El torito catalog contains bootable binaries. The fact that this binary follows FAT format is purely tangential and we should not put additional files there or access it either Le 20 juin 2015 13:17, Ross Lagerwall rosslagerw...@gmail.com a écrit : On Mon, Jun 08, 2015 at

Re: [PATCH] broken ESC navigation if authentication is used

2015-06-10 Thread Vladimir 'phcoder' Serbinenko
This patch may allow to escape to shell if menu was called from context without menu entries. This may happen inadvertently I.a. when using configfile. You need to add an additional parameter to indicate whether it's OK to break from menu Le 10 juin 2015 21:32, Andrei Borzenkov arvidj...@gmail.com

Re: [PATCH] broken ESC navigation if authentication is used

2015-06-10 Thread Vladimir 'phcoder' Serbinenko
Please fix mime type. I can't view your attachment on the phone Le 10 juin 2015 19:00, Florian Kaiser florian_kai...@genua.de a écrit : Hi, we are using grub2 with authentication enabled and multiple submenus. Unfortunately it is not possible to return to a previous menu with ESC without

Re: Set a bootdrive environment variable.

2015-06-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
What's the problem with extracting this from $prefix ? This seems to be a better match if what you want is location of GRUB. On 31.05.2015 08:42, Andrei Borzenkov wrote: В Wed, 27 May 2015 08:55:09 -0400 Mathieu Trudel-Lapierre mathieu...@gmail.com пишет: On Wed, May 27, 2015 at 12:04 AM,

Re: multiboot2.h multiboot_header_tag_module_align

2015-06-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 04.06.2015 14:18, Toomas Soome wrote: hi! i know this tag (multiboot_header_tag_module_align) is not really used, but it still would be nice if the copy/paste error of the actual structure would be fixed;) Can you propose a patch? rgds, toomas

Re: [PATCH] PATA: Add data transfer by DMA

2015-06-04 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 01.06.2015 02:52, Heiher wrote: Hi, I implemented DMA data transfer mode for PATA. It works fine in QEMU(x86) and Loongson3A+RS780E. Please review. Please fix your MIME type (usually by renaming to .diff). Did you apply any other patches for loongson3A? Last I remember there were still

Re: arm64 softfloat

2015-06-03 Thread Vladimir 'phcoder' Serbinenko
Ok with me as well. Go ahead On Jun 3, 2015 8:10 PM, Andrei Borzenkov arvidj...@gmail.com wrote: В Wed, 3 Jun 2015 17:52:12 +0100 Leif Lindholm leif.lindh...@linaro.org пишет: https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html --- Generate code which uses only the general

Re: arm64 softfloat

2015-06-02 Thread Vladimir 'phcoder' Serbinenko
Please give more details as to where we have floats. We shouldn't have any On Jun 2, 2015 14:09, Leif Lindholm leif.lindh...@linaro.org wrote: Hi, As I mentioned yeaterday, I ran into some toolchain issues yesterday. When attempting my first build on Fedora 22, which uses GCC5.1, the build

<    3   4   5   6   7   8   9   10   11   12   >