Re: [Patch] Cursor cache

2009-01-27 Thread Sven Herzberg
Hi, Am Montag, den 19.01.2009, 03:08 -0500 schrieb Matthias Clasen: On Sun, Jan 18, 2009 at 12:24 PM, Dr. David Alan Gilbert gilbe...@treblig.org wrote: * Matthias Clasen (matthias.cla...@gmail.com) wrote: On Sat, Jan 17, 2009 at 8:19 PM, Dr. David Alan Gilbert gilbe...@treblig.org wrote:

Re: [Patch] Cursor cache

2009-01-27 Thread Matthias Clasen
On Tue, Jan 27, 2009 at 9:18 AM, Sven Herzberg herzi...@gnome-de.org wrote: PS: I can also try to come up with a patch for adding a test case once this is committed. Awaiting your patch then :-) ___ gtk-devel-list mailing list

Re: [Patch] Cursor cache

2009-01-24 Thread Dr. David Alan Gilbert
* Matthias Clasen (matthias.cla...@gmail.com) wrote: On Sun, Jan 18, 2009 at 12:24 PM, Dr. David Alan Gilbert OK, attached is a new patch that hopefully fixes the formatting; if you spot any others I'll be happy to fix them (even if I do feel sorry for the {'s lonely on the line by

Re: [Patch] Cursor cache

2009-01-19 Thread Matthias Clasen
On Sun, Jan 18, 2009 at 12:24 PM, Dr. David Alan Gilbert gilbe...@treblig.org wrote: * Matthias Clasen (matthias.cla...@gmail.com) wrote: On Sat, Jan 17, 2009 at 8:19 PM, Dr. David Alan Gilbert gilbe...@treblig.org wrote: * Matthias Clasen (matthias.cla...@gmail.com) wrote: Thanks for the

Re: [Patch] Cursor cache

2009-01-18 Thread Bastien Nocera
On Sat, 2009-01-17 at 22:06 +, Dr. David Alan Gilbert wrote: The other observation is that various things get a blank cursor by doing a 1x1 pixmap cursor fully transparent; this ends up going all the way through the theming code looking for a file called 00...00 which is a hash of the

Re: [Patch] Cursor cache

2009-01-18 Thread Dr. David Alan Gilbert
* Matthias Clasen (matthias.cla...@gmail.com) wrote: On Sat, Jan 17, 2009 at 8:19 PM, Dr. David Alan Gilbert gilbe...@treblig.org wrote: * Matthias Clasen (matthias.cla...@gmail.com) wrote: Thanks for the patch. It looks good in general, just a couple of notes: * There are some stylistic

[Patch] Cursor cache

2009-01-17 Thread Dr. David Alan Gilbert
Hi, Attached is a patch that adds a cache to the cursor code in gdk/x11/gdkcursor-x11.c - I'd appreciate comments. Thanks for Matthias Clasen for some pointers after my initial mail. As I mentioned in a mail a few weeks ago I'd been looking at the code that deals with themeing of cursors and

Re: [Patch] Cursor cache

2009-01-17 Thread Matthias Clasen
Thanks for the patch. It looks good in general, just a couple of notes: * There are some stylistic issues (mostly missing spaces here and there) * We need to purge cursors from the cache when their display is closed * Do you have any data how big the cache grows in cursor-heavy apps ? Wrt. to

Re: [Patch] Cursor cache

2009-01-17 Thread Matthias Clasen
On Sat, Jan 17, 2009 at 8:19 PM, Dr. David Alan Gilbert gilbe...@treblig.org wrote: * Matthias Clasen (matthias.cla...@gmail.com) wrote: Thanks for the patch. It looks good in general, just a couple of notes: * There are some stylistic issues (mostly missing spaces here and there) No