Re: Tooltips patch [take 1]

2007-03-22 Thread Damon Chaplin
On Sun, 2007-03-18 at 01:22 +0100, Tim Janik wrote: the main reason for ::has-tooltip is efficiency, because the new tooltips potentially do many tip checks currently (ca. on every mouse motion, however we might implement some coalescing to limit the number of tip checks to 16-25 per second),

Re: Tooltips patch [take 1]

2007-03-17 Thread Kristian Rietveld
Damon Chaplin wrote: Is there any real need for the has-tooltip property? From a quick look at the API it doesn't seem that useful to me. Only if the has-tooltip property is TRUE, the query-tooltip signal will be emitted for that widget. When has-tooltip is set to TRUE, the event masks of

Re: Tooltips patch [take 1]

2007-03-17 Thread Tim Janik
On Sat, 17 Mar 2007, Kristian Rietveld wrote: Damon Chaplin wrote: Is there any real need for the has-tooltip property? From a quick look at the API it doesn't seem that useful to me. Only if the has-tooltip property is TRUE, the query-tooltip signal will be emitted for that widget. When

Re: Tooltips patch [take 1]

2007-03-16 Thread Damon Chaplin
Is there any real need for the has-tooltip property? From a quick look at the API it doesn't seem that useful to me. The developer either wants to set a simple tooltip with tooltip-markup or connect to the signal-query signal to set context-sensitive tooltips. Have I missed something? Damon

Re: Tooltips patch [take 1]

2007-01-19 Thread Kristian Rietveld
Hi Tim, I've taken over most of the changes and left those out of this mail. Replies to relevant snippets below ... On Tue, Jan 09, 2007 at 02:51:56PM +0100, Tim Janik wrote: +static gboolean +gtk_tooltip_paint_window (GtkTooltip *tooltip) +{ + GtkRequisition req; + +

Re: Tooltips patch [take 1]

2007-01-09 Thread Tim Janik
On Thu, 26 Oct 2006, Kristian Rietveld wrote: On Wed, Oct 11, 2006 at 04:42:02PM +0200, Kristian Rietveld wrote: I think I finally managed to process Tim's comments, so here is another iteration of the tooltips patch. Biggest changes are: - Event handling and widget finder have basically

Re: Tooltips patch [take 1]

2007-01-05 Thread Tim Janik
On Wed, 1 Nov 2006, Xan López wrote: Hi, just a small comment: If we want the new tooltip code to be really useful on touchscreen mode, we need a way to emit the query-tooltip signal on insensitive widgets on button press. The current behaviour is not very useful in a touchscreen device. this

Re: Tooltips patch [take 1]

2006-11-01 Thread Xan López
Hi, just a small comment: If we want the new tooltip code to be really useful on touchscreen mode, we need a way to emit the query-tooltip signal on insensitive widgets on button press. The current behaviour is not very useful in a touchscreen device. BR, Xan El jue, 26-10-2006 a las 16:37

Re: Tooltips patch [take 1]

2006-10-12 Thread Tim Janik
On Wed, 11 Oct 2006, Kristian Rietveld wrote: On Wed, Sep 27, 2006 at 03:31:21PM +0200, Tim Janik wrote: On Thu, 20 Jul 2006, Kristian Rietveld wrote: * What to do with gtk_tooltip_force_query_tooltip() and gtk_tooltip_force_query_tooltip_for_widget(). The former will look up the

Re: Tooltips patch [take 1]

2006-09-27 Thread Tim Janik
On Thu, 20 Jul 2006, Kristian Rietveld wrote: Hey, So I finally managed to get the event handling and all in the new tooltips code right. Attached is a patch with a first attempt at an implementation. Of course there's also some TODO items left: * The tooltip handling code in

Tooltips patch [take 1]

2006-07-20 Thread Kristian Rietveld
Hey, So I finally managed to get the event handling and all in the new tooltips code right. Attached is a patch with a first attempt at an implementation. Of course there's also some TODO items left: * The tooltip handling code in gtktooltip.c probably needs to be modified to be per