Re: When deprecating, always say what the replacement is.

2010-02-26 Thread Stefan Kost
Am 23.02.2010 20:28, schrieb Claudio Saavedra: El mar, 23-02-2010 a las 19:17 +0100, Javier Jardón escribió: 2010/2/23 Murray Cumming murr...@murrayc.com: When we deprecate API, please remember to document what the replacement is. People forget this quite often. A small recent example that

Re: When deprecating, always say what the replacement is.

2010-02-26 Thread Stefan Kost
Am 25.02.2010 18:58, schrieb Dan Winship: On 02/25/2010 10:52 AM, Christian Dywan wrote: In this case I don't know what someone would use flags for. If you need to test a value such as visibility or sensitivity, you normally use the specific macros. Deprecated: use the specific macro for

Re: When deprecating, always say what the replacement is.

2010-02-25 Thread Christian Dywan
Am Tue, 23 Feb 2010 23:13:51 +0100 schrieb Murray Cumming murr...@murrayc.com: On Tue, 2010-02-23 at 22:36 +0100, Michael Natterer wrote: On Tue, 2010-02-23 at 19:59 +0100, Murray Cumming wrote: No, Deprecated: 2.20: Do not use it. is not good enough. As a matter of fact, it is. There

Re: When deprecating, always say what the replacement is.

2010-02-25 Thread Murray Cumming
On Thu, 2010-02-25 at 16:52 +0100, Christian Dywan wrote: But Do not use it does not even make that clear. The reader has no idea whether it is something that should never have been used (and why not) or something that has a replacement. It shouldn't take much empathy to realize that, or

When deprecating, always say what the replacement is.

2010-02-23 Thread Murray Cumming
When we deprecate API, please remember to document what the replacement is. People forget this quite often. A small recent example that doesn't do this: http://git.gnome.org/browse/gtk +/commit/?id=bb1824c131f247c2ef64f3c5f8b9ffe3885c9d90 -- murr...@murrayc.com www.murrayc.com www.openismus.com

Re: When deprecating, always say what the replacement is.

2010-02-23 Thread Javier Jardón
2010/2/23 Murray Cumming murr...@murrayc.com: When we deprecate API, please remember to document what the replacement is. People forget this quite often. A small recent example that doesn't do this: http://git.gnome.org/browse/gtk +/commit/?id=bb1824c131f247c2ef64f3c5f8b9ffe3885c9d90

Re: When deprecating, always say what the replacement is.

2010-02-23 Thread Claudio Saavedra
El mar, 23-02-2010 a las 19:17 +0100, Javier Jardón escribió: 2010/2/23 Murray Cumming murr...@murrayc.com: When we deprecate API, please remember to document what the replacement is. People forget this quite often. A small recent example that doesn't do this:

Re: When deprecating, always say what the replacement is.

2010-02-23 Thread Murray Cumming
On Tue, 2010-02-23 at 19:17 +0100, Javier Jardón wrote: 2010/2/23 Murray Cumming murr...@murrayc.com: When we deprecate API, please remember to document what the replacement is. People forget this quite often. A small recent example that doesn't do this: http://git.gnome.org/browse/gtk

Re: When deprecating, always say what the replacement is.

2010-02-23 Thread Michael Natterer
On Tue, 2010-02-23 at 19:59 +0100, Murray Cumming wrote: On Tue, 2010-02-23 at 19:17 +0100, Javier Jardón wrote: 2010/2/23 Murray Cumming murr...@murrayc.com: When we deprecate API, please remember to document what the replacement is. People forget this quite often. A small recent

Re: When deprecating, always say what the replacement is.

2010-02-23 Thread Morten Welinder
As a matter of fact, it is. There is not supposed to be any replacement for the stuff that says Do not use it. Everything that has a replacement is however documented. So please, a little research before bashing perfectly good commits. How about a research before bashing perfectly good

Re: When deprecating, always say what the replacement is.

2010-02-23 Thread Murray Cumming
On Tue, 2010-02-23 at 22:36 +0100, Michael Natterer wrote: On Tue, 2010-02-23 at 19:59 +0100, Murray Cumming wrote: No, Deprecated: 2.20: Do not use it. is not good enough. As a matter of fact, it is. There is not supposed to be any replacement for the stuff that says Do not use it.