Re: padding cleanup

2010-09-15 Thread Matthias Clasen
On Wed, Sep 15, 2010 at 5:21 AM, Murray Cumming murr...@murrayc.com wrote: I haven't followed this in detail, but I see the new GtkWidget align and margin-* properties and functions: http://git.gnome.org/browse/gtk +/commit/?id=474f80442a6f3cf72a3c3b9efc5a846e7664d758 So will things like

Re: padding cleanup

2010-09-14 Thread Stefan Kost
On 13.09.2010 04:50, Havoc Pennington wrote: Hi, I merged the main patch to master. I wrote docs (see attached) but did not push them yet because I can't figure out how to actually document a non-signal virtual function in a non-interface. Yes, docuemnt is as part of the class structure.

Re: padding cleanup

2010-09-12 Thread Benjamin Otte
On Sun, Sep 12, 2010 at 6:21 AM, Havoc Pennington h...@pobox.com wrote: Something that occurred to me mid-bisect is that with Benjamin's draw() work, it would probably be straightforward to write the following test program: * instantiate every widget type in GTK (or even various modes of

Re: padding cleanup

2010-09-12 Thread Havoc Pennington
Hi, On Sun, Sep 12, 2010 at 6:44 AM, Benjamin Otte o...@gnome.org wrote: Uh, you've found out about one of my secret projects. Actually, what I'm aiming at is reftests (see http://weblogs.mozillazine.org/roc/archives/2008/12/reftests.html for a description). They are independant of font

Re: padding cleanup

2010-09-12 Thread Matthias Clasen
On Sun, Sep 12, 2010 at 1:19 PM, Havoc Pennington h...@pobox.com wrote: Hi, I pushed a widget-padding-2 branch which has everything cleaned up. Both widget-padding and widget-padding-2 can be deleted once this is merged. (I can merge if you like or feel free. or let me know what else to

Re: padding cleanup

2010-09-12 Thread Havoc Pennington
Hi, I merged the main patch to master. I wrote docs (see attached) but did not push them yet because I can't figure out how to actually document a non-signal virtual function in a non-interface. What I have here puts the text of the docs in the HTML but it doesn't look nice. Does gtk-doc just not

Re: padding cleanup

2010-09-11 Thread Havoc Pennington
Hi, On Sat, Sep 11, 2010 at 11:41 PM, Matthias Clasen matthias.cla...@gmail.com wrote: Turns out this is unrelated to your branch. I've bisected this to Oops, I just burnt a hole in my lap bisecting this too. At least _one_ of those checkouts could have managed not to rebuild the whole tree...

Re: padding cleanup

2010-09-07 Thread Thomas Wood
On Sat, 2010-09-04 at 15:59 -0400, Havoc Pennington wrote: Hi, On Sat, Sep 4, 2010 at 1:40 PM, Thomas Wood t...@gnome.org wrote: It might be worth re-using the CSS box model¹ nomenclature here to avoid confusion. In the CSS box model: * margin: extra spacing around the element,

Re: padding cleanup

2010-09-07 Thread Havoc Pennington
Cool. So I'm inclined to search-and-replace the patch and make the properties: margin-left margin-right margin-top margin-bottom margin /* sets all four at once */ I'll give it a couple more days though in case this turns out to be controversial so I don't do too much busywork ;-) Havoc

Re: padding cleanup

2010-09-07 Thread Matthias Clasen
On Tue, Sep 7, 2010 at 9:41 AM, Havoc Pennington h...@pobox.com wrote: Cool. So I'm inclined to search-and-replace the patch and make the properties: margin-left margin-right margin-top margin-bottom margin   /* sets all four at once */ I'll give it a couple more days though in case this

Re: padding cleanup

2010-09-05 Thread Havoc Pennington
https://bugzilla.gnome.org/show_bug.cgi?id=628828 has a patch ready for review. Havoc ___ gtk-devel-list mailing list gtk-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/gtk-devel-list

Re: padding cleanup

2010-09-04 Thread Thomas Wood
On Thu, 2010-09-02 at 19:58 -0400, Havoc Pennington wrote: And here are some of the 'layout' style properties: I think we could add style props on GtkWidget that would modify the padding on the widget (I don't know if they'd just replace the programmer-set padding, or be an adjustment to

Re: padding cleanup

2010-09-02 Thread Havoc Pennington
Hi, On Thu, Sep 2, 2010 at 6:14 PM, Matthias Clasen matthias.cla...@gmail.com wrote: Of course, this only handles the size_request side of things. It would be up to individual containers to respect the h/v-align in their size_allocate (basically replacing their current child properties),

Re: padding cleanup

2010-09-01 Thread Shaun McCance
On Sun, 2010-08-29 at 19:02 -0400, Havoc Pennington wrote: Hi, Matthias's mention of padding props got me thinking about how this could be mopped up (based shamelessly on what we did in HippoCanvas and then BigBox) I'm attaching a patch that I haven't even tried to compile (my jhbuild

Re: padding cleanup

2010-09-01 Thread Havoc Pennington
Hi, On Wed, Sep 1, 2010 at 12:24 PM, Shaun McCance sha...@gnome.org wrote: Would it be better to have padding-start and padding-end, rather than -left and -right, and have it do the right thing in RTL locales? I've often wished CSS did it that way, and GTK+ does do most things with start and

Re: padding cleanup

2010-09-01 Thread Havoc Pennington
Hi, On Wed, Sep 1, 2010 at 2:03 PM, Shaun McCance sha...@gnome.org wrote: Well, all of the packing functions use start and end, but I guess that's just to make the term orientation-neutral. Looking through the docs, I do see properties like left-attach, left-margin, and left-padding. So it

Re: padding cleanup

2010-09-01 Thread Matthias Clasen
On Wed, Sep 1, 2010 at 2:52 PM, Havoc Pennington h...@pobox.com wrote: Hi, On Wed, Sep 1, 2010 at 2:03 PM, Shaun McCance sha...@gnome.org wrote: Well, all of the packing functions use start and end, but I guess that's just to make the term orientation-neutral. Looking through the docs, I do

Re: padding cleanup

2010-08-30 Thread Steve Frécinaux
On 08/30/2010 01:02 AM, Havoc Pennington wrote: In brief it adds to GtkWidget: h-align, v-align = FILL, CENTER, START, END padding-left,padding-right,padding-top, padding-bottom = int16 A small point to keep in mind when implementing something like that is the scrollbar behaviour,

Re: padding cleanup

2010-08-30 Thread Havoc Pennington
would be to be smart about whether events on padding go to widgets, possibly including a rule that the widget only gets padding events if the padding is against a Fitt's edge. These features all seem like elaborations of padding cleanup but I do think a padding cleanup (and having padding generally

Re: padding cleanup

2010-08-30 Thread Havoc Pennington
Hi, On Sun, Aug 29, 2010 at 7:02 PM, Havoc Pennington h...@pobox.com wrote: 2. supporting superclasses deriving from GtkWidget that want to add more padding area stuff to their subclasses on top of what GtkWidget already does. GtkMisc would be an example - maybe the only example? I forgot

Re: padding cleanup

2010-08-30 Thread Havoc Pennington
Looking at ClutterBoxLayout, they separate x and y fill, which may be worth adding here. void clutter_box_layout_pack (ClutterBoxLayout*layout, ClutterActor*actor, gboolean expand,

Re: padding cleanup

2010-08-30 Thread Behdad Esfahbod
On 08/29/10 19:02, Havoc Pennington wrote: - is it called padding or border (border is nice perhaps since it contrasts with all the existing stuff called padding) Why not copy the CSS box model to the extent that it's relevant? behdad ___

Re: padding cleanup

2010-08-30 Thread Havoc Pennington
Hi, On Mon, Aug 30, 2010 at 1:26 PM, Behdad Esfahbod beh...@behdad.org wrote: On 08/29/10 19:02, Havoc Pennington wrote:  - is it called padding or border (border is nice perhaps since it contrasts with all the existing stuff called padding) Why not copy the CSS box model to the extent that

Re: padding cleanup

2010-08-30 Thread Behdad Esfahbod
On 08/30/10 14:01, Havoc Pennington wrote: Hi, On Mon, Aug 30, 2010 at 1:26 PM, Behdad Esfahbod beh...@behdad.org wrote: On 08/29/10 19:02, Havoc Pennington wrote: - is it called padding or border (border is nice perhaps since it contrasts with all the existing stuff called padding) Why

Re: padding cleanup

2010-08-30 Thread Havoc Pennington
Hi, On Mon, Aug 30, 2010 at 5:00 PM, Behdad Esfahbod beh...@behdad.org wrote: Well, I was implicitly suggesting that we take all of CSS margin, border, padding and then some. I see. Yeah, that could be cool. I thought about it a little but you have to figure out what background and border

padding cleanup

2010-08-29 Thread Havoc Pennington
Hi, Matthias's mention of padding props got me thinking about how this could be mopped up (based shamelessly on what we did in HippoCanvas and then BigBox) I'm attaching a patch that I haven't even tried to compile (my jhbuild setup is kinda hosed, don't ask) illustrating what I might like to