Re: reftests

2011-05-11 Thread Kristian Rietveld
On May 9, 2011, at 7:07 PM, Benjamin Otte wrote: I think this only makes sense if we want to continue to maintain this division between frequently and less frequently run tests. What is a frequently run test? I can tell you that no treeview test qualifies as frequently run to me when I'm

Re: reftests

2011-05-11 Thread Kristian Rietveld
On May 9, 2011, at 7:57 PM, Matthias Clasen wrote: I don't have a fear of toplevel dirs. If people insist on having tests outside of the source tree (I personally like things in gtk/tests ...), then what is wrong with just having reftests/ as a toplevel directory ? We already have perf

Re: reftests

2011-05-09 Thread Benjamin Otte
On Fri, May 6, 2011 at 12:04 PM, Kristian Rietveld k...@gtk.org wrote: Which raises another question, would it be a good idea or make sense to merge the image differ into the GTK+ test utils so that other tests (e.g. the tree view scrolling test suite) can make use of it? I did not spend any

Re: reftests

2011-05-06 Thread Kristian Rietveld
) can make use of it? Another question: why was gtk-reftest put in gtk+/tests/reftests/gtk-reftest instead of in gtk+/gtk/tests/gtk-reftest, with a subdirectory reftests containing the glade files? Then on make check for the GTK+ unit tests, the reftests would automatically be executed

Re: reftests

2011-05-05 Thread Kristian Rietveld
Hi Benjamin, On May 3, 2011, at 10:01 PM, Benjamin Otte wrote: with the latest commits[1] I have added reftests to GTK. Reftests are my approach at getting layout and rendering behavior of gtk tested. I've added a bunch of tests already for the things I have fixed and will continue to add

gtestutils Re: reftests

2011-05-05 Thread Behdad Esfahbod
On 05/05/11 04:18, Kristian Rietveld wrote: g_assert (allocation.y == rect.y + ((rect.height - allocation.height) / 2)); The output of this failed assertion is not really nice to the eyes. It would be nice if the assertion macros could be improved to also accept a human-readable

Re: reftests

2011-05-05 Thread Benjamin Otte
As an update: http://blogs.gnome.org/otte/2011/05/05/reftests/ has a tutorial for writing reftests. I put it in my blog as it's nicer to layout things there, I didn't want to send large GIF attachments via email and it's reasonably easy for me to show it to anyone in the future if I want them

Re: reftests

2011-05-05 Thread Benjamin Otte
better, because it's very easy. I guess having tests written in Python would come closest to this. Another question: why was gtk-reftest put in gtk+/tests/reftests/gtk-reftest instead of in gtk+/gtk/tests/gtk-reftest, with a subdirectory reftests containing the glade files?  Then on make check

reftests

2011-05-03 Thread Benjamin Otte
Hey, with the latest commits[1] I have added reftests to GTK. Reftests are my approach at getting layout and rendering behavior of gtk tested. I've added a bunch of tests already for the things I have fixed and will continue to add tests for bugs I fix. For what the test runner does, see

Re: reftests

2011-05-03 Thread Behdad Esfahbod
On 05/03/11 16:01, Benjamin Otte wrote: (Pango doesn't ellipsize every row, only the last one. Bad Pango - and Behdad hasn't even applied my patch for this, I need to poke him again as I've just committed that test, ooops.) You see. No Pango test suite means little confidence that an