Re: [Patch 1/7] tabled: cleanup tabled.conf

2010-01-20 Thread Jeff Garzik
On 01/14/2010 11:03 PM, Pete Zaitcev wrote: The lib/ is a vestige of days when we stored files in a local filesystem, not Chunk. Just kill it. And as for CLD, it's a last resort configuration, not something we should encourage. So comment it out. Signed-Off-By: Pete Zaitcevzait...@redhat.com

Re: [Patch 2/7] tabled: add Cell element

2010-01-20 Thread Jeff Garzik
On 01/14/2010 11:11 PM, Pete Zaitcev wrote: Make the cell configurable. Among other things we need this for is that you cannot migrate a tabled over when DB format changes, short of running 2 CLDs. We also add a few thoughts to the documentation, prompted by re-reading of the document while

Re: [Patch 3/7] tabled: add the status display

2010-01-20 Thread Jeff Garzik
On 01/14/2010 11:12 PM, Pete Zaitcev wrote: I find it too tiresome to monitor the status with kill -USR1. This is more fun. The patch seems not too ugly regarding the factoring of the cli_xxx methods. Signed-Off-By: Pete Zaitcevzait...@redhat.com --- doc/etc.tabled.conf |3

Re: [Patch 4/7] tabled: retry conflicting locks

2010-01-20 Thread Jeff Garzik
On 01/14/2010 11:13 PM, Pete Zaitcev wrote: This problem was with us for a while, and even with this fix our start-up is not reliable. But at least we will not be 100% guaranteed to hang as before when restarting too quickly. So although the whole area needs some serious reworking, this specific

Re: [Patch 5/7] tabled: suppress repeating messages

2010-01-20 Thread Jeff Garzik
On 01/14/2010 11:13 PM, Pete Zaitcev wrote: Every time CLD crashes, I find my logs filled up with error messages. But running without them is no good either, so I don't want to remove this message entirely. Let us try some filtering. Actually, I am still considering if we should not reset the

Re: [PATCHv2] cld: use XDR for all messages

2010-01-20 Thread Colin McCabe
On Wed, Jan 20, 2010 at 5:38 PM, Jeff Garzik j...@garzik.org wrote: On 01/15/2010 12:49 PM, Colin McCabe wrote: This patch moves CLD from using manual data serialization to using XDR (via rpcgen). Both the packet header and the message body are now serialized and deserialized using XDR.