Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Jeff Garzik
On 02/07/2010 02:15 PM, Pete Zaitcev wrote: The traditional CLD API is too difficult to program. In particular, switching from a rigid Group policy to arbitrary paths in existing clients in Chunk and tabled turned out to be next to impossible. The issue is due to the fundamental nature of the

Does this work on BSD too?

2010-02-08 Thread Pete Zaitcev
When I run autogen.sh, this message is printed: lib/Makefile.am:13: `%'-style pattern rules are a GNU make extension It's because of this: %_rpc.h: %_rpc.x rpcgen -h $ $@ Is the above a concern? -- Pete -- To unsubscribe from this list: send the line unsubscribe hail-devel in the

Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Jeff Garzik
On 02/08/2010 08:46 PM, Pete Zaitcev wrote: On Mon, 08 Feb 2010 07:32:56 -0500 Jeff Garzikj...@garzik.org wrote: - log param in cldc-dns should not be made conditional as an undocumented side effect of ncld I pulled, and it appears that you merged a code that crashes at the first error

Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Pete Zaitcev
On Mon, 08 Feb 2010 21:06:17 -0500 Jeff Garzik j...@garzik.org wrote: - if (cldc_getaddr(host_list, hostb, NULL)) + if (cldc_getaddr(host_list, hostb, ncld_log)) return 1001; Logging pointer should be supplied by the caller... that is the larger bug. Needing a no-op

Re: Does this work on BSD too?

2010-02-08 Thread Jeff Garzik
On 02/08/2010 08:49 PM, Pete Zaitcev wrote: When I run autogen.sh, this message is printed: lib/Makefile.am:13: `%'-style pattern rules are a GNU make extension It's because of this: %_rpc.h: %_rpc.x rpcgen -h $$@ Is the above a concern? It is likely a concern, yes. For

[Patch 1/1] tabled: switch to ncld

2010-02-08 Thread Pete Zaitcev
No new function just yet, only a switch-over. Signed-Off-By: Pete Zaitcev zait...@redhat.com --- server/cldu.c | 789 +--- 1 file changed, 215 insertions(+), 574 deletions(-) diff --git a/server/cldu.c b/server/cldu.c index 7e176d4..aecf336 100644

Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Jeff Garzik
On 02/08/2010 09:17 PM, Pete Zaitcev wrote: On Mon, 08 Feb 2010 21:06:17 -0500 Jeff Garzikj...@garzik.org wrote: - if (cldc_getaddr(host_list, hostb, NULL)) + if (cldc_getaddr(host_list, hostb,ncld_log)) return 1001; Logging pointer should be supplied by the

Re: [Patch 1/1] tabled: switch to ncld

2010-02-08 Thread Jeff Garzik
On 02/08/2010 11:42 PM, Pete Zaitcev wrote: No new function just yet, only a switch-over. Signed-Off-By: Pete Zaitcevzait...@redhat.com --- server/cldu.c | 789 +--- 1 file changed, 215 insertions(+), 574 deletions(-) Looks good, but needs a

Re: [Patch 1/1] CLD: Introduce the New CLD API

2010-02-08 Thread Pete Zaitcev
On Mon, 08 Feb 2010 23:55:03 -0500 Jeff Garzik j...@garzik.org wrote: - if (cldc_getaddr(host_list, hostb, NULL)) + if (cldc_getaddr(host_list, hostb,ncld_log)) return 1001; Logging pointer should be supplied by the caller... that is the larger bug. Needing a no-op