On Fri, 31 Jul 2009 18:00:46 -0400, Jeff Garzik j...@garzik.org wrote:
I updated the chunkd page with API and design notes, capturing some of
the emails to Rick and others:
http://hail.wiki.kernel.org/index.php/Chunkd
This looks pretty good.
Ironically, I am thinking about adding a mode
Signed-off-by: Pete Zaitcev zait...@redhat.com
diff --git a/tools/cldcli.c b/tools/cldcli.c
index bb5c4cc..90ae601 100644
--- a/tools/cldcli.c
+++ b/tools/cldcli.c
@@ -437,12 +437,12 @@ static bool cld_p_timer_ctl(void *private, bool add,
static int cld_p_pkt_send(void *priv, const void *addr
This seems copy-pasted from a daemon like Chunk that has a comment
to the tune of now that we have arguments parsed we can switch
to syslog. But in cldcli it's meaningless.
Signed-off-by: Pete Zaitcev zait...@redhat.com
diff --git a/tools/cldcli.c b/tools/cldcli.c
index 90ae601..c9b7130 100644
Produce more specific error messages for those who think that host
does not necesserily imply port. Also, clean up a bit.
Signed-Off-By: Pete Zaitcev zait...@redhat.com
diff --git a/tools/cldcli.c b/tools/cldcli.c
index 1060d3f..2945596 100644
--- a/tools/cldcli.c
+++ b/tools/cldcli.c
@@ -9,13
The .known is the array management item which has no business in
a list-managed struct. Phase 1: return it where it was. In phase 2
we will drop it from cldc_host. Then perhaps change array to a
circular list.
Signed-off-by: Pete Zaitcev zait...@redhat.com
diff --git a/server/cldu.c b/server
We do not rely on precise placement of fields in unrelated structs anymore.
Signed-Off-By: Pete Zaitcev zait...@redhat.com
diff --git a/include/cld_msg.h b/include/cld_msg.h
index 124acbb..89ab066 100644
--- a/include/cld_msg.h
+++ b/include/cld_msg.h
@@ -188,10 +188,6 @@ struct cld_msg_get
of elements by hand).
Signed-Off-By: Pete Zaitcev zait...@redhat.com
diff --git a/doc/api.txt b/doc/api.txt
index 1afe3de..002a55f 100644
--- a/doc/api.txt
+++ b/doc/api.txt
@@ -36,3 +36,34 @@ username==password, the minimum level of authentication
necessary to prove
that it works. It does not yet
of -app_log arguments as a pledge that it has to change
again anyway.
Long story short, this should be safe to build in Koji without
resorting to chain builds.
Signed-off-by: Pete Zaitcev zait...@redhat.com
diff --git a/include/cldc.h b/include/cldc.h
index f625d5e..712e7c7 100644
--- a/include/cldc.h
We abandon the wasteful strategy of gradual changes and simply change
to applog-style API wholesale, to put the whole issue behind.
Applications need to be rebuilt after new cld-devel is installed.
Signed-off-by: Pete Zaitcev zait...@redhat.com
diff --git a/server/chunkd.h b/server/chunkd.h
Signed-off-by: Pete Zaitcev zait...@redhat.com
diff --git a/server/cldu.c b/server/cldu.c
index da08d1b..fc746e4 100644
--- a/server/cldu.c
+++ b/server/cldu.c
@@ -422,7 +422,7 @@ static int cldu_lock_cb(struct cldc_call_opts *carg, enum
cle_err_codes errc)
int rc;
if (errc
-Off-By: Pete Zaitcev zait...@redhat.com
diff --git a/include/cld_msg.h b/include/cld_msg.h
index 89ab066..e4c8f28 100644
--- a/include/cld_msg.h
+++ b/include/cld_msg.h
@@ -167,6 +167,7 @@ struct cld_msg_open {
uint32_tmode; /** open mode, COM_xxx
a strncat, but it's more concise.
Signed-off-by: Pete Zaitcev zait...@redhat.com
diff --git a/tools/cldcli.c b/tools/cldcli.c
index eb4ebc4..60ab301 100644
--- a/tools/cldcli.c
+++ b/tools/cldcli.c
@@ -131,8 +131,8 @@ static void applog(int prio, const char *fmt, ...)
va_list ap
the switch. This patch
demonstrates how to flip the two configuration files atomically.
Signed-off-by: Pete Zaitcev zait...@redhat.com
diff --git a/test/chunkd-test.conf b/test/chunkd-test.conf
index 119aa00..9256b9d 100644
--- a/test/chunkd-test.conf
+++ b/test/chunkd-test.conf
@@ -9,11 +9,7 @@
/Listen
On Tue, 13 Oct 2009 10:27:00 -0700 (PDT), Zack Perry zack.pe...@sbcglobal.net
wrote:
While trying to find a less expensive way to validate my application
targeting AWS S3, I stumbled across Project Hail.
I'm not sure if the assumptions are sound. The S3 is extremely
cheap. For example, my
With the last fixes to the timer code, CLD does not crash often anymore,
but it still does, and it's still related to timers.
Program received signal SIGSEGV, Segmentation fault.
0x in ?? ()
(gdb) where
#0 0x in ?? ()
#1 0x080511be in timers_run () at util.c:207
#2 0x0804edfa
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/bucket.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/bucket.c b/server/bucket.c
index c13ec05..b3c73de 100644
--- a/server/bucket.c
+++ b/server/bucket.c
@@ -591,7 +591,7 @@ bool bucket_del(struct
too much from benchmarks (but if it
does, it's only honest to take the hit). It is indispensible.
However, there's a plan to add useful monitoring of jobs and other
state, such as available nodes.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/Makefile.am |4
server/replica.c
Mostly, add IDs so we can see which job and which node fails.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/storage.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/server/storage.c b/server/storage.c
index f1822f7..fdb3fc1 100644
--- a/server
On Sat, 14 Nov 2009 03:37:50 -0500, Jeff Garzik j...@garzik.org wrote:
On 11/14/2009 01:32 AM, Pete Zaitcev wrote:
1) remove it
2) switch to cld's -D debuglevel option format, and bury the logging
statements under a debug level that produces a higher verbosity.
Anything
too much from benchmarks (but if it
does, it's only honest to take the hit). It is indispensible.
However, there's a plan to add useful monitoring of jobs and other
state, such as available nodes.
This implementation uses a separate thread.
Signed-off-by: Pete Zaitcev zait...@redhat.com
On Fri, 27 Nov 2009 15:20:36 -0800
cmcc...@alumni.cmu.edu wrote:
When doing a raw read(2) in cld_readport(), resume after EINTR.
Also resume if we read less than the requested amount.
if ((fd = open(fname, O_RDONLY)) == -1)
return -errno;
- rc = read(fd, buf, LEN);
.
Signed-Off-By: Pete Zaitcev zait...@redhat.com
---
configure.ac |4 -
include/cldc.h |7 --
include/libtimer.h |3 -
lib/cldc-udp.c | 27 -
pkg/cld.spec |2
test/.gitignore|1
test/Makefile.am |9 ++-
test
On Sun, 29 Nov 2009 06:11:44 -0500 Jeff Garzik j...@garzik.org wrote:
hmmm... cld now segfaults reliably in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1836079
Curious. It works fine here, of course (make distcheck).
Did you try to build locally?
-- Pete
--
To unsubscribe from
On Sun, 29 Nov 2009 15:36:53 -0500, Jeff Garzik j...@garzik.org wrote:
On 11/29/2009 02:34 PM, Pete Zaitcev wrote:
On Sun, 29 Nov 2009 06:11:44 -0500 Jeff Garzikj...@garzik.org wrote:
hmmm... cld now segfaults reliably in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1836079
Fedora 13 comes with db4.8 and apparently the compat-db4.7 is bust.
Let us link with 4.8 as a workaround.
Signed-Off-By: Pete Zaitcev zait...@redhat.com
---
configure.ac |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Not sure how safe or desirable this is, but it seems to work
On Sun, 29 Nov 2009 20:38:45 -0500, Jeff Garzik j...@garzik.org wrote:
On 11/29/2009 08:17 PM, Pete Zaitcev wrote:
Fedora 13 comes with db4.8 and apparently the compat-db4.7 is bust.
Let us link with 4.8 as a workaround.
Interesting... I recall the root cause clearly, now: /usr/include
On Sun, 29 Nov 2009 20:38:45 -0500
Jeff Garzik j...@garzik.org wrote:
Interesting... I recall the root cause clearly, now: /usr/include/db.h
always refers to the latest installed db4, even if compat-db{,45,46} is
installed. Our configure recipe links with the most recent db4 listed
in
I need a way to scan all objects that an Chunk node keeps. There's
a function that does it already: fs_list_objs. Looking at it, is there
a reason why it uses readdir instead of tchdbiternext? In case of
self-checking, scanning directories is undesirable, because if an
object somehow (e.g. a
On Thu, 03 Dec 2009 00:42:47 -0500
Jeff Garzik j...@garzik.org wrote:
On 11/26/2009 09:39 PM, Pete Zaitcev wrote:
It seems to me you should
a) leave current main-thread libevent code unchanged
b) call event_base_new() for the new thread, passing that newly-created
event_base to replica
On Tue, 8 Dec 2009 16:11:55 -0800
Colin McCabe cmcc...@alumni.cmu.edu wrote:
@@ -161,8 +153,8 @@ static void push_host(GList **host_list, struct cldc_host
*hp_in)
* This is not reentrant. Better be called before any other threads
* are started.
*/
-int cldc_getaddr(GList
On Mon, 14 Dec 2009 18:18:47 -0800
Colin McCabe cmcc...@alumni.cmu.edu wrote:
Also my new patch creates a hail_log.h. It didn't really seem right to
force everyone who wanted to use HAIL_LOG to include cldc.h.
I'll convert over the rest of chunkd and tabled to the new macros if
this patch
Less clutter is good.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/cldu.c |3 ---
server/storage.c | 16
server/storparse.c |1 -
3 files changed, 20 deletions(-)
Jeff, if you recall, I promised to do this as a condition for a past merge.
commit
We replace a comment with code to better show the intent. Once we have
several threads, we can plug TLS easier into this.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/replica.c | 69 ++---
1 file changed, 41 insertions(+), 28 deletions
On Fri, 18 Dec 2009 10:57:45 -0500
Jeff Darcy jda...@redhat.com wrote:
On 12/18/2009 05:14 AM, Jeff Garzik wrote:
Is there anyone that would be interested in copying (or directly use)
/usr/lib/python2.6/site-packages/boto/tests/test_s3connection.py as a
tabled boto-works test?
On Fri, 18 Dec 2009 10:57:45 -0500
Jeff Darcy jda...@redhat.com wrote:
Boto can accept non-Amazon hostnames, but there's a bit of a trick to
making it work with tabled. As of September 10, this was the magic formula.
I see what happened, the fix was later than 9/10:
Existing code writes checksums of something other than the object data.
Fix by summing the object data.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/object.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This seems too obvious... Where is the trap?
diff -urpN -X
I'm looking into adding self-checking to chunkd. This involves basically
a process that re-reads everything stored in the chunkserver and verifies
that it's still ok. Nothing can be simpler, right?
So, current problems for which I'd like input are:
- Scheduling and deconflicting with normal
On Tue, 22 Dec 2009 17:43:58 -0500
Jeff Garzik j...@garzik.org wrote:
It is normal and reasonable to maintain global information about all
in-progress operations. Caching systems do that, for example, to ensure
multiple cache requests for object A do not initiate multiple
simultaneous
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/be-fs.c |2 --
server/chunkd.h |2 --
2 files changed, 4 deletions(-)
commit 039dba4ecca0f7edb049f6397d98c139da6bef4d
Author: Master zait...@lembas.zaitcev.lan
Date: Fri Dec 25 21:56:07 2009 -0700
Unused defines, drop
Documentation says this is necessary for multi-threaded access.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/be-fs.c |3 +++
1 file changed, 3 insertions(+)
commit 8245bc23aa4608a666b8dda767f18ca03a110906
Author: Master zait...@lembas.zaitcev.lan
Date: Fri Dec 25 22:14:37
1. Don't try to save a call in a function where normal and error unfolding
sequences are different.
2. Use exception labels linked to what caused them, not to what cleanup
has to be done.
3. Balance fs_open - fs_close.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/be-fs.c
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/chunkd.h |1 -
1 file changed, 1 deletion(-)
commit 6fe147ad2f8833e162d92277ec6827520c5497ba
Author: Master zait...@lembas.zaitcev.lan
Date: Fri Dec 25 23:18:50 2009 -0700
Unused forward declaration, drop.
diff --git a/server
This way we create a set of methods that can be used by self-check
to list existing objects.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/be-fs.c | 361 +-
server/chunkd.h | 16 ++
2 files changed, 244 insertions(+), 133 deletions
This version leaves fs_free alone and preserves the quick-quit mechanism.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/be-fs.c | 10 ++
server/server.c | 15 ---
2 files changed, 14 insertions(+), 11 deletions(-)
commit
This a mechanism by which self-check may know what objects were updated
and thus should not be disturbed if their checksums fail.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
include/Makefile.am |2
include/objcache.h | 72 +++
server/Makefile.am |3
with the self-checking. The intent is to let
the performance of checking to scale with the number of objects and
amount of data stored in the cell.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/Makefile.am|2
server/be-fs.c| 126 +++-
server/chunkd.h
The main point here is to kill gmtime, but since we're at it, may as well
fix the API and add safety (observe, that not all timestr arguments were
64 bytes long in the original code).
Signed-Off-By: Pete Zaitcev zait...@redhat.com
---
include/httputil.h |2 +-
lib/httpstor.c | 12
For some reason we were printing the user which were executing the
request instead of the owner of the key in question, even before the
changeove to obj_vitals.
Signed-Off-By: Pete Zaitcev zait...@redhat.com
---
server/bucket.c |6 --
1 file changed, 4 insertions(+), 2 deletions
We rely on CLD for builds (on all platforms), so we do not need the
StorageNode clause anymore.
Signed-Off-By: Pete Zaitcev zait...@redhat.com
---
doc/etc.tabled.conf | 14 +--
server/config.c | 77 +-
2 files changed, 6 insertions(+), 85
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/server.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/server.c b/server/server.c
index c3e77f9..7c9c07a 100644
--- a/server/server.c
+++ b/server/server.c
@@ -706,7 +725,7 @@ static int net_open_any(void
On Sun, 03 Jan 2010 03:27:59 -0500
Jeff Garzik j...@garzik.org wrote:
- sprintf(datestr, Date: %s, time2str(timestr, time(NULL)));
+ sprintf(datestr, Date: %s, time2str(timestr, 64, time(NULL)));
applied 1-3, and then added sizeof() to the above time2str calls... The
hardcoded sizes
Existing tests only excercised operations with relatively small objects.
It did not test pipelining of object data in sufficient degree. So, let's
have a better test case for this (large-object.c).
We also change the existing basic-object.c to match.
Signed-Off-By: Pete Zaitcev zait
On Tue, 05 Jan 2010 04:14:08 -0500
Jeff Garzik j...@garzik.org wrote:
a follow-up patch that checks the checksums of the data sent/received
would be nice...
That would require more coding than using single check bytes because
a checksum can span a block boundary. But ok, you're right, I'll do
On Tue, 22 Dec 2009 22:36:16 -0500
Jeff Garzik j...@garzik.org wrote:
Seems like a mutex-wrapped GLib hash table would work...
I dunno about this... See, I think it's like kernel timers: there's a
lot of premium on having add and remove quick, and the rest is whatever.
The important part is not
On Tue, 05 Jan 2010 16:02:58 -0500
Jeff Garzik j...@garzik.org wrote:
On 01/05/2010 03:47 PM, Pete Zaitcev wrote:
On Tue, 22 Dec 2009 22:36:16 -0500
Jeff Garzikj...@garzik.org wrote:
Seems like a mutex-wrapped GLib hash table would work...
I dunno about this... See, I think it's like
On Tue, 05 Jan 2010 16:53:55 -0500
Jeff Garzik j...@garzik.org wrote:
If you have a constant pointer value [for the lifetime of the hash table
entry], use g_direct_hash. If you have a nul-terminated string, GLib
also has g_str_hash.
Of course I considered these, but thanks to our keys
The block numbers do not give us comlete enough coverage, so add a simple
checksum that includes all transmitted bytes. Keep block numbers though:
they are invaluable when comparing specific damage with a traces of
events inside tabled.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
test
On Thu, 07 Jan 2010 17:10:49 -0500
Jeff Garzik j...@garzik.org wrote:
I was thinking specifically that chunkd may want the in-progress xfer
codes changes in your patch. chunkd, tabled, nfs4d (and ancient
storaged) all share the same basic write-in-progress and TCP data xfer code.
I'll
On Tue, 12 Jan 2010 09:21:24 -0500
Jeff Garzik j...@garzik.org wrote:
sleep(n)
self_check()
algorithm seems less useful to the average admin than a slightly more
complex one that solves the problem defined as guarantee an object is
checked at least every N days. Because, as
On Wed, 13 Jan 2010 16:03:45 -0500
Jeff Garzik j...@garzik.org wrote:
Well, this definitely does not build as-is. lib/Makefile.am needs
BUILT_SOURCES = cld_msg_rpc.h
otherwise nothing builds at all, because cld_msg_rpc.h does not exist.
test/Makefile.am and
The lib/ is a vestige of days when we stored files in a local filesystem,
not Chunk. Just kill it.
And as for CLD, it's a last resort configuration, not something we should
encourage. So comment it out.
Signed-Off-By: Pete Zaitcev zait...@redhat.com
---
doc/etc.tabled.conf |8 +---
1
Make the cell configurable. Among other things we need this for is
that you cannot migrate a tabled over when DB format changes, short
of running 2 CLDs.
We also add a few thoughts to the documentation, prompted by re-reading
of the document while adding the clause for Cell.
Signed-Off-By: Pete
.
Signed-Off-By: Pete Zaitcev zait...@redhat.com
---
server/cldu.c | 38 ++
1 file changed, 34 insertions(+), 4 deletions(-)
commit fa910aacff5118664177f988029cc5f8e6ef886d
Author: Master zait...@lembas.zaitcev.lan
Date: Thu Jan 14 19:56:13 2010 -0700
The structure server_socket is not even referenced anywhere in tabled.h.
Some kind of atavism, apparently.
Signed-Off-By: Pete Zaitcev zait...@redhat.com
---
server/tabled.h |1 -
1 file changed, 1 deletion(-)
commit ffcd630f41450d37493b6cad52a6ee11e5db7965
Author: Master zait
I was changing it one by one, but honestly it was just stupid.
Let us change over to the sane checking once and for all.
Signed-Off-By: Pete Zaitcev zait...@redhat.com
---
server/config.c | 41 +
1 file changed, 33 insertions(+), 8 deletions(-)
commit
-By: Pete Zaitcev zait...@redhat.com
---
include/libtimer.h | 19 ---
lib/Makefile.am|4 ++--
lib/libtimer.c | 25 ++---
server/Makefile.am |4 ++--
server/cld.h |8
server/server.c| 20
On Sat, 16 Jan 2010 17:54:36 -0800
Colin McCabe cmcc...@alumni.cmu.edu wrote:
On Sat, Jan 16, 2010 at 3:21 PM, Pete Zaitcev zait...@redhat.com wrote:
Shouldn't ncld_unlock and ncld_close return an error code rather than
just eating all errors? The server certainly does sometimes send back
Hi, Jeff Colin:
It looks like you broke something in CLD, not sure if server or client.
There are two possibly related bugs. But first, here's the messages
(The chunkd is run with -D). Note that I have 2 servers listed in DNS
(both on port 4499), but only one is up.
Feb 6 23:36:10 hitlain
When I run autogen.sh, this message is printed:
lib/Makefile.am:13: `%'-style pattern rules are a GNU make extension
It's because of this:
%_rpc.h: %_rpc.x
rpcgen -h $ $@
Is the above a concern?
-- Pete
--
To unsubscribe from this list: send the line unsubscribe hail-devel in
the
On Mon, 08 Feb 2010 21:06:17 -0500
Jeff Garzik j...@garzik.org wrote:
- if (cldc_getaddr(host_list, hostb, NULL))
+ if (cldc_getaddr(host_list, hostb, ncld_log))
return 1001;
Logging pointer should be supplied by the caller... that is the larger
bug. Needing a no-op
No new function just yet, only a switch-over.
Signed-Off-By: Pete Zaitcev zait...@redhat.com
---
server/cldu.c | 789 +---
1 file changed, 215 insertions(+), 574 deletions(-)
diff --git a/server/cldu.c b/server/cldu.c
index 7e176d4..aecf336 100644
On Mon, 08 Feb 2010 23:55:03 -0500
Jeff Garzik j...@garzik.org wrote:
- if (cldc_getaddr(host_list, hostb, NULL))
+ if (cldc_getaddr(host_list, hostb,ncld_log))
return 1001;
Logging pointer should be supplied by the caller... that is the larger
bug. Needing a no-op
On Tue, 09 Feb 2010 04:38:21 -0500
Jeff Garzik j...@garzik.org wrote:
On 02/09/2010 04:20 AM, Jeff Garzik wrote:
Useful per-packet cld [the daemon] verbose output seems to have
disappeared? Or did I miss a knob somewhere?
cldcli no longers dumps per-packet debug info at maximum verbosity,
Signed-Off-By: Pete Zaitcev zait...@redhat.com
---
server/cldu.c |9 ++---
server/server.c | 11 ---
server/tabled.h |3 +--
3 files changed, 15 insertions(+), 8 deletions(-)
commit 820e53ea5ec85a69f6e1648e8d445a0d87ea6a72
Author: Master zait...@lembas.zaitcev.lan
Date
On Thu, 01 Apr 2010 19:01:59 +0800
Samba - BoYang boy...@samba.org wrote:
CLD doesn't build on db-4.3 on suse 11, since db-4.3 uses deprecated
structure members DBC-c_xxx(c_close(), etc) instead of DBC-xxx. :-)
That's unexpected. Jeff is our portability expert, but he's busy
with the baby,
version of output, but failed to add the new stats to the standard
stat dump facility.
Your wish is my command.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/replica.c | 28 +
server/server.c | 47 ++
server
every source of events. In other words,
every function that is passed to event_set must invoke
cli_write_run_compl. Mind that storage.c contains calls to
event_set.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/object.c |4 +++
server/server.c | 52
, but is pre-empted before ncld_sess_open returns, the
same situation may occur legitimately. So this check is still
needed, unless we radically change the locking strategy.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/cldu.c |7 +--
1 file changed, 5 insertions(+), 2
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/object.c |9 +
server/server.c |4 ++--
server/status.c |2 +-
server/tdbadm.c |2 +-
4 files changed, 9 insertions(+), 8 deletions(-)
commit f21ca8985bc7ba2b6e02fb0e58c79bcb96ab844f
Author: Pete Zaitcev zait
Enums and sizeofs are unsigned. V. annoying because of int i;.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/status.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -urp -X dontdiff tabled-m/server/status.c tabled-tip/server/status.c
--- tabled-m/server/status.c
server/storage.c |9 -
1 file changed, 9 deletions(-)
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
commit 32b1a2e9d8c481dfbf31222464aa2b6ef937ec4f
Author: Pete Zaitcev zait...@yahoo.com
Date: Thu Apr 1 19:20:09 2010 -0600
Dead function.
diff --git a/server/storage.c b
On Tue, 06 Apr 2010 12:57:57 -0400
Jeff Garzik j...@garzik.org wrote:
applied, thanks. I will endeavor to make the stats dump more like nfs4d
in the future, FWIW.
I was going to look into it too, but there's now some stuff
I urgently need to address in Darcy's report on tabled's faults.
So I
On Wed, 07 Apr 2010 00:36:32 -0400
Jeff Garzik j...@garzik.org wrote:
On 04/06/2010 11:32 PM, Pete Zaitcev wrote:
On Tue, 06 Apr 2010 10:40:33 -0400
Jeff Garzikj...@garzik.org wrote:
The debug levels are
0: key messages affecting server operation, only
1: debugging output
Here's yet another take on the precice verbosity control, this
time with -D 2 replacing -v. Everywhere, not just in CLD. Uniformity!
BTW, someone forgot to update all the examples when -D with an
argument was introduced, so this patch does it now.
These patches have an API change, so as usual CLD
A prototype is not included again.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
lib/common.c |1 +
1 file changed, 1 insertion(+)
diff --git a/lib/common.c b/lib/common.c
index fb0aae6..e399ec9 100644
--- a/lib/common.c
+++ b/lib/common.c
@@ -26,6 +26,7 @@
#include errno.h
#include
-off-by: Pete Zaitcev zait...@redhat.com
---
test/lock-file.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/test/lock-file.c b/test/lock-file.c
index 36cc62c..3bbe49b 100644
--- a/test/lock-file.c
+++ b/test/lock-file.c
@@ -31,6 +31,15 @@
#include ncld.h
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
lib/cldc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Looks like I confused myself with patch numbering. This one is
out of order, or maybe a duplicate? Sending on the premise that
it's easier to drop.
diff --git b/lib/cldc.c
On Fri, 16 Apr 2010 13:16:56 -0400
Jeff Garzik j...@garzik.org wrote:
Build #1 (fails on x86_64):
http://koji.fedoraproject.org/koji/taskinfo?taskID=2119825
PASS: prep-db
chunkd[17774]: Waiting for CLD PortFile cld.port
cld[17773]: databases up
cld[17773]: Listening on port 34671
cld[17773]:
Is there a reason why the main_loop in chunkd uses a naked
g_hash_table_lookup instead of srv_poll_lookup? Performance?
@@ -1681,8 +1681,7 @@ static int main_loop(void)
fired++;
- sp = g_hash_table_lookup(chunkd_srv.fd_info,
-
. No execution list is kept. The integrity of the main list
is assured by never walking it and always referring to the head
anew at each iteration.
This patch appears to fix the problem and stands up to use that
crashed the old code.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
include
Add and fix some comments regarding the reasons behind the pipe etc.
No code changes.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
lib/cldc.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
commit e675f2f316bbb24ca84c1bc23e4d1c6d53b029de
Author
.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/cldu.c | 77 +++-
1 file changed, 69 insertions(+), 8 deletions(-)
commit d30028b4c681e99f7934ca264a175548c827ff04
Author: Master zait...@lembas.zaitcev.lan
Date: Sat Apr 17 19:46:35 2010
be a bad idea, or may be not.
We may yet change the retries to be infinite, but for now it's
better if builds terminate somehow in case of unexpected problems.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/cldu.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions
The message makes no sense. It was a carry-over from cldc where there
were many failure modes (fh is NULL, fh-valid false, etc.).
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/cldu.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit
wastes screen space.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
lib/tdb.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
commit eb60e6e5c97fe316d23b9b21ba020bca924e879e
Author: Master zait...@lembas.zaitcev.lan
Date: Sat Apr 17 20:31:56 2010 -0600
Fix double tagging
-by: Pete Zaitcev zait...@redhat.com
---
server/server.c |4
1 file changed, 4 insertions(+)
commit b340bd6bbf9d7a82b69ad620f43799b616348a45
Author: Master zait...@lembas.zaitcev.lan
Date: Sat Apr 17 20:40:12 2010 -0600
Deconfuse -D -E.
diff --git a/server/server.c b/server/server.c
This code clearly was obsolete and wishful thinking. Let's just be
simple. Most importantly print something that tells the sysadmin
what node is the problem.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/storage.c | 19 +++
server/tabled.h |2 +-
2 files
On Sun, 18 Apr 2010 23:46:07 -0400
Jeff Garzik j...@garzik.org wrote:
[tabled patch 1/1] update Makefile.am
or
[cld patch 1/1] libcldc: add nncld API, the new new CLD API
That looks simple enough.
-- Pete
--
To unsubscribe from this list: send the line unsubscribe
No, we did not mean anything in particular by using a naked hash
lookup here, just forgot to convert.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
server/server.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/server/server.c b/server/server.c
index f367676
We stopped using libevent in Chunk a while ago, but for some reason
not all references were removed. I tested this patch by building
on a fresh Fedora 13 system without libevent.
Signed-off-by: Pete Zaitcev zait...@redhat.com
---
configure.ac |3 ---
pkg/chunkd.spec|2
1 - 100 of 156 matches
Mail list logo
