Jeff Garzik wrote:
...
But even if curl were requiring some suboptimal signature,
it would be nice not to impose that on all projects that use hail.
Are there older curl headers that do require the const-free signature?
If there are and you want to support them, too, let me know -- maybe
I
On 10/20/2010 04:53 AM, Jim Meyering wrote:
Jeff Garzik wrote:
...
Hi Jeff.
Sorry I didn't notice that the first time.
I built with ./autogen.sh ./configure make.
It looks like you recommend -Wall -Wshadow.
The two warnings above are the only ones I see with the patch,
and they're easy to
Jeff Garzik wrote:
On 10/06/2010 08:07 AM, Jim Meyering wrote:
Make write_cb callback's buffer parameter const, like all write-like
functions.
Give a few char * parameters the const attribute.
Signed-off-by: Jim Meyeringmeyer...@redhat.com
---
It looks like most of hail's interfaces are
On 10/20/2010 04:00 AM, Jim Meyering wrote:
Jeff Garzik wrote:
On 10/06/2010 08:07 AM, Jim Meyering wrote:
Make write_cb callback's buffer parameter const, like all write-like
functions.
Give a few char * parameters the const attribute.
Signed-off-by: Jim Meyeringmeyer...@redhat.com
---
It
Jeff Garzik wrote:
...
Hi Jeff.
Sorry I didn't notice that the first time.
I built with ./autogen.sh ./configure make.
It looks like you recommend -Wall -Wshadow.
The two warnings above are the only ones I see with the patch,
and they're easy to fix. When storing const pointer params
On 10/06/2010 08:07 AM, Jim Meyering wrote:
Make write_cb callback's buffer parameter const, like all write-like
functions.
Give a few char * parameters the const attribute.
Signed-off-by: Jim Meyeringmeyer...@redhat.com
---
It looks like most of hail's interfaces are const-correct,
but one
Jeff Garzik wrote:
On 10/06/2010 08:07 AM, Jim Meyering wrote:
...
It looks like most of hail's interfaces are const-correct,
but one stood out because it provokes a warning when I tried to
pass a const-correct write_cb function to hstor_get from iwhd:
...
include/hstor.h |4 ++--
