Re: [PATCH] BUILD: ssl: Build with new cryptographic library AWS-LC

2023-09-06 Thread Hopkins, Andrew
I tried it and HAProxy doesn’t build with AWS-LC when quic is turned on. There are at least two issues: 1. AWS-LC’s TLS 1.3 cipher suite names are a little different, this is easy to fix and I opened https://github.com/aws/aws-lc/pull/1175 2. ChaCha Poly and AES CCM are not usable through the

Re: [PATCH] BUILD: ssl: Build with new cryptographic library AWS-LC

2023-09-06 Thread Hopkins, Andrew
Thanks for looking at this. I couldn't figure out what in CodeBuild was sending a different signal to the processes so I moved the HAPRoxy job to GitHub actions like your CI in https://github.com/aws/aws-lc/pull/1174 and it's all passing over here too! On 9/6/23, 5:26 AM, "William Lallemand"

Re: Request for feedback: Add support for txn args as arguments in converter "bytes"

2023-09-06 Thread Lokesh Jindal
PFA the patch. I have two questions: 1. Can you explain what this method does and why is it needed? (I used it in my patch following the pattern in the converter "sub") - *smp_set_owner(_arg0, smp->px, smp->sess, smp->strm, smp->opt);* 2. In my patch, *sample_conv_bytes* returns 0 in case of an

[PATCH 0/2] CI: musl pipeline improvement

2023-09-06 Thread Ilya Shipitsin
it has been figured out that it is hard to find gdb backtraces on musl, because corresponding section is not highlighted. let us fix that Ilya Shipitsin (2): CI: musl: highlight section if there are coredumps CI: musl: drop shopt in workflow invocation .github/workflows/musl.yml | 6 +-

[PATCH 1/2] CI: musl: highlight section if there are coredumps

2023-09-06 Thread Ilya Shipitsin
previously, section was collapsed, thus it was harder to find that there's something to look at --- .github/workflows/musl.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/.github/workflows/musl.yml b/.github/workflows/musl.yml index 4017affb9..af358981f 100644 ---

[PATCH 2/2] CI: musl: drop shopt in workflow invocation

2023-09-06 Thread Ilya Shipitsin
"shopt" is bash specific, while musl uses bourne shell. /__w/_temp/1b0f5f5d-c71b-4a66-8be3-e1fe51c10993.sh: line 7: shopt: not found --- .github/workflows/musl.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/musl.yml b/.github/workflows/musl.yml index

Re: [PATCH] CI: Update to actions/checkout@v4

2023-09-06 Thread Willy Tarreau
Hi Tim! On Wed, Sep 06, 2023 at 04:57:29PM +0200, Tim Duesterhus wrote: > No functional change, but we should keep this current. Now merged, thank you! Willy

[PATCH] CI: Update to actions/checkout@v4

2023-09-06 Thread Tim Duesterhus
No functional change, but we should keep this current. see 5f4ddb54b05ae0355b1f64c22263a6bc381410df --- .github/workflows/aws-lc.yml | 2 +- .github/workflows/codespell.yml| 2 +- .github/workflows/compliance.yml | 2 +- .github/workflows/contrib.yml

Re: [PATCH 0/1] Introduce 'NOROOM' status for srv_state metric

2023-09-06 Thread Willy Tarreau
On Wed, Sep 06, 2023 at 12:44:56PM +, Cedric Paillet wrote: > >I think that it might be more suitable to use the term "FULL" > Ok, no problem with that. (Perhaps we can also rename server_has_room to > !server_is_full ?) You're right, it might be clearer! > > Also, a more accurate metric

RE: [PATCH 0/1] Introduce 'NOROOM' status for srv_state metric

2023-09-06 Thread Cedric Paillet
Thanks for your review. >I think that it might be more suitable to use the term "FULL" Ok, no problem with that. (Perhaps we can also rename server_has_room to !server_is_full ?) > Also, a more accurate metric that is generally watched is the queue (both > server and backend): My first use

Re: [PATCH] BUILD: ssl: Build with new cryptographic library AWS-LC

2023-09-06 Thread Илья Шипицин
based on USE_OPENSSL_AWSLC quic may be enabled ? ср, 6 сент. 2023 г. в 14:26, William Lallemand : > On Tue, Sep 05, 2023 at 11:56:26PM +, Hopkins, Andrew wrote: > > I split up the remaining CI changes into 4 new attached patches. The > > latest changes are still passing on my fork > >

Re: [PATCH] BUILD: ssl: Build with new cryptographic library AWS-LC

2023-09-06 Thread William Lallemand
On Tue, Sep 05, 2023 at 11:56:26PM +, Hopkins, Andrew wrote: > I split up the remaining CI changes into 4 new attached patches. The > latest changes are still passing on my fork > https://github.com/andrewhop/haproxy/actions/runs/6090899582. > Thanks, I just merged them! > I was hoping to

Re: [PATCH 0/1] Introduce 'NOROOM' status for srv_state metric

2023-09-06 Thread Willy Tarreau
Hi Cedric, On Tue, Sep 05, 2023 at 01:40:14PM +, Cedric Paillet wrote: > We are using Prometheus to provide feedback to our users about the status of > backend servers. Currently, we have no means of informing them if a server > exceeds the maxconn limit, and consequently why it's no longer

[HAPPRIVACY #YXL-289-28996]: China FO bearing export

2023-09-06 Thread HAProxy Privacy
ash@fobearings, Thank you for contacting us. This is an automated response confirming the receipt of your ticket. One of our agents will get back to you as soon as possible. For your records, the details of the ticket are listed below. When replying, please make sure that the ticket ID is kept

[HAPPRIVACY #TKN-189-63462]: China FO bearing export

2023-09-06 Thread HAProxy Privacy
ash@fobearings, Thank you for contacting us. This is an automated response confirming the receipt of your ticket. One of our agents will get back to you as soon as possible. For your records, the details of the ticket are listed below. When replying, please make sure that the ticket ID is kept