Re: [PATCH] BUG/MINOR: dns: allow srv record weight set to 0

2019-10-22 Thread Christopher Faulet
Le 22/10/2019 à 13:42, Baptiste a écrit : My comment is wrong. A server weight can have a value of 256. Please update the comment :) Ok, thanks. Merged now. -- Christopher Faulet

Re: [PATCH] BUG/MINOR: dns: allow srv record weight set to 0

2019-10-22 Thread Baptiste
Hi Luke, I remember I first did that intentionally to avoid values below 255 being "rounded" to 0... And I assumed people would remove servers from their DNS if they want a weight to 0. Now, with some feedback, I can see I was wrong. Next time, don't hesitate to ask the question on the ML, or on

Re: [PATCH] BUG/MINOR: dns: allow srv record weight set to 0

2019-10-22 Thread Baptiste
My comment is wrong. A server weight can have a value of 256. Please update the comment :) Baptiste On Mon, Oct 21, 2019 at 4:35 PM Christopher Faulet wrote: > Le 21/10/2019 à 16:20, Baptiste a écrit : > > Thx to 2 people who spotted a bug in my patch, (missing parenthesis). > > > > here is

Re: [PATCH] BUG/MINOR: dns: allow srv record weight set to 0

2019-10-21 Thread Luke Seelenbinder
Thank you for this bug fix…we're more than a little excited! When I initially found it, I was under the assumption it was on purpose. :-) Best, Luke — Luke Seelenbinder Stadia Maps | Founder stadiamaps.com > On 21 Oct 2019, at 16:35, Christopher Faulet wrote: > > Le 21/10/2019 à 16:20,

Re: [PATCH] BUG/MINOR: dns: allow srv record weight set to 0

2019-10-21 Thread Christopher Faulet
Le 21/10/2019 à 16:20, Baptiste a écrit : Thx to 2 people who spotted a bug in my patch, (missing parenthesis). here is the updated version. On Mon, Oct 21, 2019 at 3:59 PM Baptiste > wrote: hi there, Following up some recent discussion about SRV record's

Re: [PATCH] BUG/MINOR: dns: allow srv record weight set to 0

2019-10-21 Thread Baptiste
21 Oct 2019 15:13:48 +0200 Subject: [PATCH] BUG/MINOR: dns: allow srv record weight set to 0 Processing of SRV record weight was inaccurate and when a SRV record's weight was set to 0, HAProxy enforced it to '1'. This patch aims at fixing this without breaking compability with previous behavior.

[PATCH] BUG/MINOR: dns: allow srv record weight set to 0

2019-10-21 Thread Baptiste
From 35598ed8ffce74e4cc834566566957dde5ede167 Mon Sep 17 00:00:00 2001 From: Baptiste Assmann Date: Mon, 21 Oct 2019 15:13:48 +0200 Subject: [PATCH] BUG/MINOR: dns: allow srv record weight set to 0 Processing of SRV record weight was inaccurate and when a SRV record's weight was set to 0, HAProxy