Regarding commit #61ecf2838:
There's no point taking the variables locks for sess/txn/req/res
contexts since these ones always run inside the same thread anyway.
--
Miroslav Zagorac
Senior Developer
>From 099ed5a7cf021d7144aff009a5baa91912375509 Mon Sep 17 00:00:00 2001
From: Miroslav
In case of using parameter 'OT_USE_VARS=1', the value of the OT_DEFINE
variable is set incorrectly (i.e. the previous value was deleted and a
new one set instead of adding new content).
--
Miroslav Zagorac
Senior Developer
>From c84aea9ff85cdbacddf2207c50b3263c23f2e238 Mon Sep 17 00:00:00 2001
This reverts commit 6c9f7faa62a00a4d028704d7b11e290c83f8a49d.
This warning is no longer needed because source code can be compiled
with enabled support for OpenTracing context transfer via HAProxy
variables.
--
Miroslav Zagorac
Senior Developer
>From 068153bae147beba4f8bba3cd2c467f68d1c19ac Mon
On Thu, Apr 07, 2022 at 11:50:33AM +0200, Willy Tarreau wrote:
> And in an ideal world, the applet's init code could be the one responsible
> for creating its stream. Historically it wasn't even possible because both
> contexts were strongly tied. But with the changes Christopher recently did
> to
The flag_cpy parameter has been added to the flt_ot_normalize_name()
function, through which we can determine whether the function converts
special characters (which are part of that name) when copying a variable
name.
--
Miroslav Zagorac
Senior Developer
>From
Several comments in the function descriptions have been corrected.
--
Miroslav Zagorac
Senior Developer
>From 0b7cd96bbda98e10108316d087fc1828b9f1f564 Mon Sep 17 00:00:00 2001
From: Miroslav Zagorac
Date: Tue, 1 Mar 2022 19:18:34 +0100
Subject: [PATCH 08/16] DOC: opentracing: corrected comments
The same variable should not be used to store multiple different
results, because it can be confusing. Therefore, the var_name_len
variable has been added in several functions, in order to avoid the use
of the retval variable for several different purposes.
--
Miroslav Zagorac
Senior Developer
Since commit 3a4bedccc ("MEDIUM: vars: replace the global name index
with a hash") the names of HAProxy variables are no longer saved, ie
their 64-bit hashes are saved instead.
This is very convenient for the HAProxy itself, but for the OpenTracing
module it is a problem because the names of the
Function flt_ot_var_set() did not check whether the variable was
successfully set or not. In case of failure, the value -1 is returned.
--
Miroslav Zagorac
Senior Developer
>From 731892071c47540e2ed04d539121546194322731 Mon Sep 17 00:00:00 2001
From: Miroslav Zagorac
Date: Tue, 1 Mar 2022
On Thu, Apr 07, 2022 at 11:07:41AM +0500, Илья Шипицин wrote:
> ср, 6 апр. 2022 г. в 14:08, William Lallemand :
>
> > On Wed, Apr 06, 2022 at 09:45:02AM +0100, David CARLIER wrote:
> > > > I recall there is a openssl3 port ongoing perhaps ?
> > >
> > > I was trying to see if the said 3.x portage
Hello all,
I am sending you a set of patches that return the ability to use
haproxy variables to transfer opentracing context.
01 Revert "MINOR: opentracing: change the scope of the variable
'ot.uuid' from 'sess' to 'txn'"
02 MINOR: opentracing: only takes the variables lock on shared
A display of the contents of the err variable has been added to the
FLT_OT_ERR() macro, once it has been set.
--
Miroslav Zagorac
Senior Developer
>From e38e00f8eb67010cd607429ece16d39c4b9e0f73 Mon Sep 17 00:00:00 2001
From: Miroslav Zagorac
Date: Tue, 8 Mar 2022 01:21:04 +0100
Subject: [PATCH
This reverts commit 560c7b874aef5922199e36a7f31466af323f489f.
The ot.uuid variable should have the 'sess' scope because it is created
when an OpenTracing filter is attached to a stream. After that, the
stream processing is started and on that occasion the contexts for the
variables that have
When calling the 'basename' command, the argument ${0} is enclosed in
quotation marks. This is necessary if the path of the executable script
(contained in that argument) has "non-standard" elements, such as space
and the like.
Also, in the script 'test-speed.sh' the function sh_exit() has been
Hello,
On Sat, Apr 02, 2022 at 03:46:58AM +0500, Arslan Kabeer wrote:
> Hello Team,
> I am a security researcher and I founded this vulnerability.
> I just sent a forged email to my email address that appears to originate
> from haproxy@formilux.org
> I was able to do this because of the
The flt_ot_smp_init() function has been added to make initializing the
sample structure easier. The contents of the structure in question are
set in several places in the source of the OpenTracing filter, so it is
better to do this in one place.
--
Miroslav Zagorac
Senior Developer
>From
Hi Maciej,
On Wed, Apr 06, 2022 at 11:17:44AM +0200, Maciej Zdeb wrote:
> Hi Willy,
>
> I've managed to implement the easy part (attached patches).
Thanks for this! I'm having a minor comment on the 3rd patch, see at
the end.
> However this is
> not enough to get it to work properly. I'm stuck
The flt_ot_var_get() function is not used anywhere and is unnecessary
in the existing implementation of the OpenTracing filter.
--
Miroslav Zagorac
Senior Developer
>From 1faf31cb0ed0cb41e89dc189cee3c753aa1cba55 Mon Sep 17 00:00:00 2001
From: Miroslav Zagorac
Date: Tue, 1 Mar 2022 18:39:18
The flt_ot_var_unset() function is not used anywhere and is unnecessary
in the existing implementation of the OpenTracing filter.
--
Miroslav Zagorac
Senior Developer
>From 6f75cb4adc0d2ffa661fe861cc0986aaf99450b5 Mon Sep 17 00:00:00 2001
From: Miroslav Zagorac
Date: Tue, 1 Mar 2022 18:38:37
If the OpenTracing filter is compiled using the 'OT_DEBUG=1' option,
then log messages are printed to stderr when the filter is running. In
the log one can then find (among other things) the order in which the
function is called and the value that the function returns (if it is
not a void type).
It's always good to replace "hard-coded" values with something that
looks less "hard-coded" (even though that doesn't change anything in
the code). This is done here using FLT_OT_PARSE_INVALID_enum enum.
--
Miroslav Zagorac
Senior Developer
>From 4db45aefc8152947a6c6a97df435c7082313a7cf Mon Sep
On Thu, Apr 07, 2022 at 07:15:21PM +0200, Miroslav Zagorac wrote:
> On 07.04.2022 18:27, Willy Tarreau wrote:
> > Hi Miroslav!
> >
>
> Hello Willi,
>
> at first I would generally say that I did not think that some of these
> patches could be backported to older versions of haproxy. I will look
Hi Miroslav!
On Thu, Apr 07, 2022 at 01:12:19PM +0200, Miroslav Zagorac wrote:
> Hello all,
>
> I am sending you a set of patches that return the ability to use
> haproxy variables to transfer opentracing context.
>
Thanks. I'm having just a few minor questions (and I'll eventually
complete
Hi Willy,
I adjusted the 3rd patch to use HA_ATOMIC_INC/HA_ATOMIC_DEC. Thanks!
czw., 7 kwi 2022 o 14:02 Willy Tarreau napisał(a):
> There are some ongoing changes in that area that are about to be merged
> (probably early
> next week) and that will help for this task, so we'll have a closer
On 07.04.2022 18:27, Willy Tarreau wrote:
Hi Miroslav!
Hello Willi,
at first I would generally say that I did not think that some of these
patches could be backported to older versions of haproxy. I will look
at what can be applied to older versions and send group patches for
each of them
On 07.04.2022 20:02, Willy Tarreau wrote:
No, really, do not bother doing that. Just tell me which ones are bug
fixes that need to be backported, as we'll backport them the usual way
as part of the regular maintenance process anyway. If you tell me "those
marked bugs ought to be backported
I wouldf also suggest BIMI record (
https://mailchimp.com/marketing-glossary/bimi/ ) to have recognizable logo
in major email systems.
(maybe for "haproxy.com" as well )
Ilya
чт, 7 апр. 2022 г. в 17:11, Willy Tarreau :
> Hello,
>
> On Sat, Apr 02, 2022 at 03:46:58AM +0500, Arslan Kabeer wrote:
ср, 6 апр. 2022 г. в 14:08, William Lallemand :
> On Wed, Apr 06, 2022 at 09:45:02AM +0100, David CARLIER wrote:
> > > I recall there is a openssl3 port ongoing perhaps ?
> >
> > I was trying to see if the said 3.x portage work is close to be merged
> > to master then yes my patch is useless.
> >
28 matches
Mail list logo
