Re: [PATCH] MAJOR: ssl: add 'tcp-fallback' bind option for SSL listeners

2016-04-11 Thread Willy Tarreau
Hi Pieter, On Mon, Apr 11, 2016 at 09:14:56PM +0200, PiBa-NL wrote: > Hi Willy, Emeric, > Op 11-3-2016 om 16:25 schreef Christopher Faulet: > >Hi, > > > >I've slightly updated my patch to improve it and to fix some > >inconsistencies. > > > >First of all, now "ssl-upgrade" and "no-ssl-upgrade"

Re: [PATCH] MAJOR: ssl: add 'tcp-fallback' bind option for SSL listeners

2016-03-11 Thread Christopher Faulet
Hi, I've slightly updated my patch to improve it and to fix some inconsistencies. First of all, now "ssl-upgrade" and "no-ssl-upgrade" actions can be used on "tcp-request content" rules _AND_ "tcp-request connection" rules, in a frontend _OR_ a backend definition. Then, these actions are now

Re: [PATCH] MAJOR: ssl: add 'tcp-fallback' bind option for SSL listeners

2016-03-05 Thread PiBa-NL
Hi Christopher, Emeric, Op 4-3-2016 om 10:44 schreef Christopher Faulet: Hi guys, Sorry for the delay, I was pretty busy. I've checked your patch. It is quite interesting. First of all, I think that "tcp fallback" option and "conditional SSL offloading" are redundant. Your way to do is more

Re: [PATCH] MAJOR: ssl: add 'tcp-fallback' bind option for SSL listeners

2016-03-04 Thread Christopher Faulet
Le 28/02/2016 23:32, PiBa-NL a écrit : > Hi Christopher, Willy, > > I've created a patch that can be applied on top of your tcp-fallback > patch to allow for 'conditional' offloading. > It shows 'ability' to have both offloading and pass-trough for ssl > depending on a sni name or other acl

Re: [PATCH] MAJOR: ssl: add 'tcp-fallback' bind option for SSL listeners

2016-02-28 Thread PiBa-NL
Hi Christopher, Willy, I've created a patch that can be applied on top of your tcp-fallback patch to allow for 'conditional' offloading. It shows 'ability' to have both offloading and pass-trough for ssl depending on a sni name or other acl criteria. -I resorted rather heavily to changing

Re: [PATCH] MAJOR: ssl: add 'tcp-fallback' bind option for SSL listeners

2016-02-09 Thread Willy Tarreau
Hi Christopher, thanks for this. It looks clean enough to be merged. I'm a little bit concerned with the addition of conn->ssl_detection_exp because we try to keep the connection struct as small as possible. But in this case there's no other place to store it. Thus I would change it to "exp" and

Re: [PATCH] MAJOR: ssl: add 'tcp-fallback' bind option for SSL listeners

2016-02-09 Thread Christopher Faulet
Le 09/02/2016 09:04, Willy Tarreau a écrit : thanks for this. It looks clean enough to be merged. I'm a little bit concerned with the addition of conn->ssl_detection_exp because we try to keep the connection struct as small as possible. But in this case there's no other place to store it. Thus

[PATCH] MAJOR: ssl: add 'tcp-fallback' bind option for SSL listeners

2016-02-04 Thread Christopher Faulet
>From a3b372da2463e98b13e016c9b56344757b0e94bc Mon Sep 17 00:00:00 2001 From: Christopher Faulet <cfau...@qualys.com> Date: Wed, 29 Jul 2015 16:01:57 +0200 Subject: [PATCH] MAJOR: ssl: add 'tcp-fallback' bind option for SSL listeners This option can be use to fall back on TCP when