Re: another cppcheck finding

2017-10-05 Thread Baptiste
I also fixed it in a patch set to make the resolution pool dynamic :) Baptiste

Re: another cppcheck finding

2017-10-04 Thread Christopher Faulet
Le 04/10/2017 à 11:54, Илья Шипицин a écrit : Hi, I'm working on the DNS part to make it thread-safe. In my patch set, among other things, I fixed this one. I will send everything to Willy in few days. So don't bother with it. ... using ThreadSanitizer from google ? No. We

Re: another cppcheck finding

2017-10-04 Thread Илья Шипицин
2017-10-04 14:00 GMT+05:00 Christopher Faulet : > Le 04/10/2017 à 07:49, Илья Шипицин a écrit : > >> >> >> 2017-10-04 9:15 GMT+05:00 Willy Tarreau >: >> >> Hi Ilya, >> >> [also CCing Baptiste] >> >> On Tue, Oct 03, 2017 at

Re: another cppcheck finding

2017-10-04 Thread Christopher Faulet
Le 04/10/2017 à 07:49, Илья Шипицин a écrit : 2017-10-04 9:15 GMT+05:00 Willy Tarreau >: Hi Ilya, [also CCing Baptiste] On Tue, Oct 03, 2017 at 05:25:17PM +0500, ??? wrote: > [src/dns.c:2502]: (error) Memory leak: buffer > >

Re: another cppcheck finding

2017-10-03 Thread Илья Шипицин
2017-10-04 9:15 GMT+05:00 Willy Tarreau : > Hi Ilya, > > [also CCing Baptiste] > > On Tue, Oct 03, 2017 at 05:25:17PM +0500, ??? wrote: > > [src/dns.c:2502]: (error) Memory leak: buffer > > > > > > I do not see any "buffer" usage except conditional free. > > should we just

Re: another cppcheck finding

2017-10-03 Thread Willy Tarreau
Hi Ilya, [also CCing Baptiste] On Tue, Oct 03, 2017 at 05:25:17PM +0500, ??? wrote: > [src/dns.c:2502]: (error) Memory leak: buffer > > > I do not see any "buffer" usage except conditional free. > should we just remove "buffer" from there ? I think you're referring to this part :

another cppcheck finding

2017-10-03 Thread Илья Шипицин
hello! [src/dns.c:2502]: (error) Memory leak: buffer I do not see any "buffer" usage except conditional free. should we just remove "buffer" from there ? Cheers, Ilya Shipitsin