[HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Tom Hacohen
Hey, Is it just me, or do vowels break shaping in Arabic? If so, what should be done to fix it? I can't think of a way of solving it, maybe only removing the vowels, shaping without them and then adding previously shaped glyphs, and then vowels and then the glyphs again and reshaping, but that's

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Khaled Hosny
On Wed, Oct 27, 2010 at 01:28:38PM +0200, Tom Hacohen wrote: Hey, Is it just me, or do vowels break shaping in Arabic? It shouldn't, either the font is broken or you are not doing it right. Regards, Khaled -- Khaled Hosny Arabic localiser and member of Arabeyes.org team Free font

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
On 10/27/10 07:28, Tom Hacohen wrote: Hey, Is it just me, or do vowels break shaping in Arabic? Pango has code to work around Arabic fonts that have no GDEF table, and no GPOS table. I've had planned to implement that in HarfBuzz but been putting it off for a while. I'll go ahead and do

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
Maybe you can attach a screenshot at least? On 10/27/10 09:19, Tom Hacohen wrote: On Wed, 2010-10-27 at 14:26 +0200, Khaled Hosny wrote: On Wed, Oct 27, 2010 at 01:28:38PM +0200, Tom Hacohen wrote: Hey, Is it just me, or do vowels break shaping in Arabic? It shouldn't, either the font is

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Tom Hacohen
On Wed, 2010-10-27 at 09:48 -0400, Behdad Esfahbod wrote: Maybe you can attach a screenshot at least? I just get isolated forms of all of them, anyhow, screenshot attached. But please also look at the bottom of the previous message where I described a SEGFAULT I was getting and also what I

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
On 10/27/10 09:58, Tom Hacohen wrote: On Wed, 2010-10-27 at 09:48 -0400, Behdad Esfahbod wrote: Maybe you can attach a screenshot at least? I just get isolated forms of all of them, anyhow, screenshot attached. I fixed that bug and pushed out this morning. Please check with master. But

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Behdad Esfahbod
On 10/27/10 09:19, Tom Hacohen wrote: because c-buffer-info[i].gproperty == 65535 So I think there's still an issue. Fixed that too. Pushed out. behdad ___ HarfBuzz mailing list HarfBuzz@lists.freedesktop.org

Re: [HarfBuzz] Arabic vowels and shaping - incomplete behavior

2010-10-27 Thread Tom Hacohen
On Wed, 2010-10-27 at 10:41 -0400, Behdad Esfahbod wrote: On 10/27/10 09:19, Tom Hacohen wrote: because c-buffer-info[i].gproperty == 65535 So I think there's still an issue. Fixed that too. Pushed out. Cool to know my assumptions were correct. Thank you very much, works like a charm.