Re: [HarfBuzz] hangul shaper patches

2014-01-23 Thread Behdad Esfahbod
On 14-01-23 02:46 AM, Jonathan Kew wrote: I just want to note that by applying the jamo features only to one character at a time, we disallow contextual rules, Is this true? I thought we ignored the mask when matching context, and only used it for the actual input string. You are of-course

Re: [HarfBuzz] hangul shaper patches

2014-01-22 Thread Behdad Esfahbod
Thanks Jonathan. I've merged these. A few points: /* Same order as the feature array below */ enum { NONE, LJMO, VJMO, TJMO, FIRST_HANGUL_FEATURE = LJMO, HANGUL_FEATURE_COUNT = TJMO + 1 }; Do you really need the NONE? I don't see where / how that's used. I just want to note

Re: [HarfBuzz] hangul shaper patches

2014-01-22 Thread Dohyun Kim
I've just found that jieubsida fonts [1] from Tsukurimashou Font Project [2] do not work well with current hangul shaper. ~$ hb-unicode-encode AC00 | hb-shape --script=hang JieubsidaBatang.otf [uni1100=0+0|uni1161=0+833] Expected output is: ~$ hb-unicode-encode AC00 | hb-shape --script=latn

Re: [HarfBuzz] hangul shaper patches

2014-01-22 Thread Jonathan Kew
On 22/1/14 12:53, Behdad Esfahbod wrote: Thanks Jonathan. I've merged these. A few points: /* Same order as the feature array below */ enum { NONE, LJMO, VJMO, TJMO, FIRST_HANGUL_FEATURE = LJMO, HANGUL_FEATURE_COUNT = TJMO + 1 }; Do you really need the NONE? I don't see

Re: [HarfBuzz] hangul shaper patches

2014-01-20 Thread Jonathan Kew
On 20/1/14 02:21, Roozbeh Pournader wrote: Jonathan, I was wondering if the new patches would have all the canonically equivalent characters sequences rendered the same way. Microsoft people have said publicly that their Hangul shaper intentionally doesn't do that. The intention is that

Re: [HarfBuzz] hangul shaper patches

2014-01-20 Thread Dohyun Kim
And I found a minor bug: --- hb-ot-shape-complex-hangul.cc.orig2014-01-21 01:00:25.0 +0900 +++ hb-ot-shape-complex-hangul.cc2014-01-21 00:57:44.0 +0900 @@ -214,7 +214,7 @@ if (font-has_glyph (0x25cc)) { hb_codepoint_t chars[2]; - if

Re: [HarfBuzz] hangul shaper patches

2014-01-20 Thread Jonathan Kew
On 20/1/14 16:02, Dohyun Kim wrote: And I found a minor bug: --- hb-ot-shape-complex-hangul.cc.orig2014-01-21 01:00:25.0 +0900 +++ hb-ot-shape-complex-hangul.cc2014-01-21 00:57:44.0 +0900 @@ -214,7 +214,7 @@ if (font-has_glyph (0x25cc)) {

Re: [HarfBuzz] hangul shaper patches

2014-01-20 Thread Dohyun Kim
2014/1/21 Jonathan Kew jfkth...@googlemail.com: On 20/1/14 15:26, Dohyun Kim wrote: I just have tested this kind of input string and the result is a little disappointing: Input string U+1107,U+1109,U+1110,U+1161 does not rendered well. The output of current (patched) harfbuzz with UnBatang

[HarfBuzz] hangul shaper patches

2014-01-19 Thread Jonathan Kew
Hi Behdad, I'm attaching a series of patches for improvements to the Hangul shaper. These provide support for Old Hangul sequences that do not have a precomposed Unicode form, and handle the tone-mark reordering. With these patches, we exactly match uniscribe on the wikipedia test corpus

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-12-31 Thread Jonathan Kew
On 31/12/13 09:53, Behdad Esfahbod wrote: I've now pushed a Hangul shaper out to HarfBuzz master. Here's the comments explaining what it tries to do: ... Thanks for working on this. Looks good so far (though I haven't tested in any real depth). The one thing I don't see here is any

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-12-31 Thread Behdad Esfahbod
On 13-12-31 07:35 PM, Jonathan Kew wrote: On 31/12/13 09:53, Behdad Esfahbod wrote: I've now pushed a Hangul shaper out to HarfBuzz master. Here's the comments explaining what it tries to do: ... Thanks for working on this. Looks good so far (though I haven't tested in any real depth).

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-17 Thread Behdad Esfahbod
confusing this thread has become, please create a Google Doc, and write down what you think the HarfBuzz Hangul shaper should do. Modify it as much as you want, but keep it as short as possible. Please make the doc commentable by the public, and send the link here. Thanks, behdad On 13-04

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-17 Thread Dohyun Kim
you think the HarfBuzz Hangul shaper should do. Modify it as much as you want, but keep it as short as possible. Please make the doc commentable by the public, and send the link here. Thanks, behdad On 13-04-16 10:10 AM, Dohyun Kim wrote: 2013/4/16 Dohyun Kim nomosno...@gmail.com: 2013/4

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-16 Thread Dohyun Kim
2013/4/15 Dohyun Kim nomosno...@gmail.com: The behavior of new Uniscribe is quote confusing and seems to be inconsistant on some points. I cannot describe concisely what it does. But it is evident that it renders correctly only those input sequence which is compliant to KS X 1026-1. OK.

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-16 Thread Behdad Esfahbod
Ok, given how confusing this thread has become, please create a Google Doc, and write down what you think the HarfBuzz Hangul shaper should do. Modify it as much as you want, but keep it as short as possible. Please make the doc commentable by the public, and send the link here. Thanks, behdad

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-16 Thread Dohyun Kim
http://ktug.org/~nomos/harfbuzz-hangul/hangulshaper.pdf Regards, 2013/4/17 Behdad Esfahbod beh...@behdad.org: Ok, given how confusing this thread has become, please create a Google Doc, and write down what you think the HarfBuzz Hangul shaper should do. Modify it as much as you want

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-16 Thread Behdad Esfahbod
what you think the HarfBuzz Hangul shaper should do. Modify it as much as you want, but keep it as short as possible. Please make the doc commentable by the public, and send the link here. Thanks, behdad On 13-04-16 10:10 AM, Dohyun Kim wrote: 2013/4/16 Dohyun Kim nomosno...@gmail.com

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-14 Thread Dohyun Kim
2013/4/13 Dohyun Kim nomosno...@gmail.com: 2013/4/13 Behdad Esfahbod beh...@behdad.org: On 13-04-12 01:03 PM, Dohyun Kim wrote: In short, Uniscribe in Windows 8 is completely following KS X 1026-1 only and no more. Really? That's a bit odd since Windows typically doesn't break backwards

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-12 Thread Dohyun Kim
Please ignore my previous mail. Latest version of Uniscribe does not work that way. I was using rather outdated version of Uniscribe until yesterday. At last today I had a chance to access a Windows 8 machine and used it for a while. In short, Uniscribe in Windows 8 is completely following KS

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-11 Thread Behdad Esfahbod
Ok, I'm more confused now :). I'll find some time to put something together and take it from there. In the mean time, if you can compile a list of sequences that would test all the corner cases you can think of, that would immensely help with the implementation. Thanks, b On 13-04-10 02:45 AM,

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-10 Thread Dohyun Kim
2013/4/10 Dohyun Kim nomosno...@gmail.com: 2013/4/10 Behdad Esfahbod beh...@behdad.org: Hi, Ok, what you describe sounds very close to the OpenType spec: http://www.microsoft.com/typography/otfntdev/hangulot/ and what the ICU Layout Hangul shaper does. The one part I don't understand

[HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-09 Thread Behdad Esfahbod
Hi, Ok, what you describe sounds very close to the OpenType spec: http://www.microsoft.com/typography/otfntdev/hangulot/ and what the ICU Layout Hangul shaper does. The one part I don't understand is the section Compose Old Hangul Jamo combinations under:

Re: [HarfBuzz] Hangul Shaper (was Re: an issue regarding discrepancy between Korean and Unicode standards

2013-04-09 Thread Dohyun Kim
2013/4/10 Behdad Esfahbod beh...@behdad.org: Hi, Ok, what you describe sounds very close to the OpenType spec: http://www.microsoft.com/typography/otfntdev/hangulot/ and what the ICU Layout Hangul shaper does. The one part I don't understand is the section Compose Old Hangul Jamo

Re: [HarfBuzz] Hangul shaper

2010-11-23 Thread Changwoo Ryu
Hello, 2010-11-18 (목), 16:51 -0500, Behdad Esfahbod: Hi Changwoo, As I'm developing HarfBuzz to replace the shapers in Pango I'm planning on removing the Hangul shaping functionality that is in Pango, and rely on a generic shaper that can handle Hangul Jamo composition/decomposition

Re: [HarfBuzz] Hangul shaper

2010-11-23 Thread Behdad Esfahbod
On 11/23/10 12:28, Changwoo Ryu wrote: Hello, 2010-11-18 (목), 16:51 -0500, Behdad Esfahbod: Hi Changwoo, As I'm developing HarfBuzz to replace the shapers in Pango I'm planning on removing the Hangul shaping functionality that is in Pango, and rely on a generic shaper that can handle