Re: [HarfBuzz] Order of combining diacriticals

2019-06-20 Thread Eli Zaretskii
> From: Khaled Hosny > Date: Thu, 20 Jun 2019 22:09:24 +0200 > Cc: Behdad Esfahbod , Harfbuzz > > > I mean whether you are using HarfBuzz with FreeType font functions, > internal ones or something custom does not matter for fallback Hebrew > shaping. > > If you want to additionally use

Re: [HarfBuzz] Order of combining diacriticals

2019-06-20 Thread Eli Zaretskii
> From: Khaled Hosny > Date: Thu, 20 Jun 2019 17:33:47 +0200 > Cc: Behdad Esfahbod , Harfbuzz > > > > >. For fonts that have no 'hebr' features, Emacs performs > > > substitution of known precomposed characters before it invokes the > > > shaping engine. In this case, it

Re: [HarfBuzz] Order of combining diacriticals

2019-06-20 Thread Khaled Hosny
On Fri, Jun 14, 2019 at 9:06 PM Eli Zaretskii wrote: > > > From: Behdad Esfahbod > > Date: Fri, 14 Jun 2019 11:34:17 -0700 > > Cc: Khaled Hosny , > > "harfbuzz@lists.freedesktop.org" > > > > On Thu, Jun 13, 2019 at 2:18 AM Eli Zaretskii wrote: > > > >. For fonts that have no 'hebr'

Re: [HarfBuzz] Order of combining diacriticals

2019-06-14 Thread Eli Zaretskii
> From: Behdad Esfahbod > Date: Fri, 14 Jun 2019 11:34:17 -0700 > Cc: Khaled Hosny , > "harfbuzz@lists.freedesktop.org" > > On Thu, Jun 13, 2019 at 2:18 AM Eli Zaretskii wrote: > >. For fonts that have no 'hebr' features, Emacs performs > substitution of known precomposed

Re: [HarfBuzz] Order of combining diacriticals

2019-06-14 Thread Behdad Esfahbod
On Thu, Jun 13, 2019 at 2:18 AM Eli Zaretskii wrote: > . For fonts that have no 'hebr' features, Emacs performs > substitution of known precomposed characters before it invokes the > shaping engine. In this case, it substituted U+FB31 for the > sequence U+05D1,U+05BC, and passed

Re: [HarfBuzz] Order of combining diacriticals

2019-06-12 Thread Khaled Hosny
On Wed, Jun 12, 2019 at 10:22:48PM +0300, Eli Zaretskii wrote: > In Emacs, we use HB_BUFFER_CLUSTER_LEVEL_MONOTONE_GRAPHEMES cluster > level, because HB_BUFFER_CLUSTER_LEVEL_MONOTONE_CHARACTERS produced > incorrect display. The cluster levels shouldn’t affect display, the glyph positions are

[HarfBuzz] Order of combining diacriticals

2019-06-12 Thread Eli Zaretskii
In Emacs, we use HB_BUFFER_CLUSTER_LEVEL_MONOTONE_GRAPHEMES cluster level, because HB_BUFFER_CLUSTER_LEVEL_MONOTONE_CHARACTERS produced incorrect display. With this level, whenever I type a Hebrew base character with more than one diacritical, I need to type them in certain order, otherwise the