Re: [HarfBuzz] Zero-width joiner has width

2015-08-09 Thread Simon Cozens
On 08/08/2015 16:31, Behdad Esfahbod wrote: The 'm' has advance of 1645 units in a 2048-unit font. At 10pt, that means: 1645 / 2048. * 10 8.0322265625 So we're losing something on the way. How do you setup the font scale? Show me the code. In general, for something like Sile, you

Re: [HarfBuzz] Zero-width joiner has width

2015-08-09 Thread Behdad Esfahbod
On 15-08-09 10:15 AM, Simon Cozens wrote: { { codepoint = 77, depth = 0, height = 4.6875, name = m, x_advance = 514, }, } Should be 1645, right? I am not sure where 514 is coming from. So what was the problem? ___

Re: [HarfBuzz] Zero-width joiner has width

2015-08-09 Thread Behdad Esfahbod
How do you measure? When I get time to build Sile, I'm first going to remove FreeType dep... On Aug 9, 2015 4:58 PM, Simon Cozens si...@simon-cozens.org wrote: On 09/08/2015 09:15, Simon Cozens wrote: OK, I'm now trying to set the scaling to the font upem, but I'm not getting that working

Re: [HarfBuzz] Zero-width joiner has width

2015-08-09 Thread Simon Cozens
On 09/08/2015 09:15, Simon Cozens wrote: OK, I'm now trying to set the scaling to the font upem, but I'm not getting that working either. After a bit of fiddling I have now got it working, using: hb_face_t* hbFace = hb_ft_face_create_cached(face); hb_ft_font = hb_font_create (hbFace);

Re: [HarfBuzz] Zero-width joiner has width

2015-08-08 Thread Jonathan Kew
On 8/8/15 15:50, Simon Cozens wrote: On 08/08/2015 15:25, Behdad Esfahbod wrote: Ok, that makes sense. And yes, I was ignoring the advance for glyphs and instead using Freetype to return the glyph width. I think I stole that bit of code from xetex. :-) Really? It may not be totally true.

Re: [HarfBuzz] Zero-width joiner has width

2015-08-08 Thread Behdad Esfahbod
On 15-08-08 04:50 PM, Simon Cozens wrote: On 08/08/2015 15:25, Behdad Esfahbod wrote: Ok, that makes sense. And yes, I was ignoring the advance for glyphs and instead using Freetype to return the glyph width. I think I stole that bit of code from xetex. :-) Really? It may not be totally

Re: [HarfBuzz] Zero-width joiner has width

2015-08-08 Thread Khaled Hosny
On Sat, Aug 08, 2015 at 04:25:07PM +0200, Behdad Esfahbod wrote: On 15-08-02 07:42 PM, Simon Cozens wrote: On Aug 2, 2015, at 18:08, Jonathan Kew jfkth...@gmail.com wrote: Which suggests there's something odd about how you're using harfbuzz. Ok, that makes sense. And yes, I was

Re: [HarfBuzz] Zero-width joiner has width

2015-08-02 Thread Simon Cozens
On Aug 2, 2015, at 18:08, Jonathan Kew jfkth...@gmail.com wrote: Which suggests there's something odd about how you're using harfbuzz. Ok, that makes sense. And yes, I was ignoring the advance for glyphs and instead using Freetype to return the glyph width. I think I stole that bit of code