Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Spark Shen
Paulex Yang 写道: Nathan Beyer wrote: Here are a few things that I think might help with getting through some of the older outstanding issues, as well as new ones. * If an issue is old (over a month???), then verify that it's still an issue with the latest code and note this with a JIRA

Re: [drlvm] Need help debugging

2006-09-13 Thread Vladimir Gorr
vm\vmcore\src\kernel_classes\native\org_apache_harmony_vm_VMStack.cpp ... * /* *// skip Thread.runImpl() size--; // skip the VMStart$MainThread if one exits from the bottom of the stack // along with 2 reflection frames used to invoke method main static String* starter_String =

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Alexey Petrenko
I think that we should close non-bug defferencies as wont fix or something like that. 2006/9/13, Spark Shen [EMAIL PROTECTED]: Paulex Yang 写道: Nathan Beyer wrote: Here are a few things that I think might help with getting through some of the older outstanding issues, as well as new ones.

Re: [drlvm] putting kernel.jar in jre/bin/default

2006-09-13 Thread Alexey Varlamov
2006/9/13, Paulex Yang [EMAIL PROTECTED]: Alexey Varlamov wrote: Looks like sending my reply failed, here is a second try: I'm not sure I catch up what you mean, about Emma, Harmony's current test coverage exclude list[1] shows that not all classes can be instrumented, I don't think it is

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Spark Shen
Nathan Beyer 写道: Here are a few things that I think might help with getting through some of the older outstanding issues, as well as new ones. * If an issue is old (over a month???), then verify that it's still an issue with the latest code and note this with a JIRA comment. * Obviously

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Geir Magnusson Jr.
Spark Shen wrote: Paulex Yang 写道: Nathan Beyer wrote: Here are a few things that I think might help with getting through some of the older outstanding issues, as well as new ones. * If an issue is old (over a month???), then verify that it's still an issue with the latest code and

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Geir Magnusson Jr.
Spark Shen wrote: Paulex Yang 写道: Nathan Beyer wrote: Here are a few things that I think might help with getting through some of the older outstanding issues, as well as new ones. * If an issue is old (over a month???), then verify that it's still an issue with the latest code and

Re: [drlvm] Need help debugging

2006-09-13 Thread Geir Magnusson Jr.
I'm a little skeptical, as I had that change in before you first tested and found a problem, right? geir Vladimir Gorr wrote: vm\vmcore\src\kernel_classes\native\org_apache_harmony_vm_VMStack.cpp ... * /* *// skip Thread.runImpl() size--; // skip the VMStart$MainThread if one

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Spark Shen
Geir Magnusson Jr. 写道: Spark Shen wrote: Paulex Yang 写道: Nathan Beyer wrote: Here are a few things that I think might help with getting through some of the older outstanding issues, as well as new ones. * If an issue is old (over a month???), then verify that it's

Re: [drlvm] Need help debugging

2006-09-13 Thread Anton Luht
Hello, With a very fresh build: DRLVM + classlib svn = r442859, (Sep 13 2006), Windows/ia32/msvc 1310, debug build I see no problems with 'java -version' (and I've never seen) but still see the problems with '-jar ...' launching . On 9/13/06, Geir Magnusson Jr. [EMAIL PROTECTED] wrote: I'm a

Re: [general] Marking JIRA issues before creation of patches.

2006-09-13 Thread Denis Kishenko
If I am going to work with whole module then Harmony class library development status[1] page is useful but if I want to work with several classes, for example fix some JAPI issues or make serious changes, then existing wiki page can't be used. I agree with creating JIRA issue and sending

Re: [drlvm] Need help debugging

2006-09-13 Thread Vladimir Gorr
Probably, you didn't note I've commented this fragment of code (firts last lines). Sorry I didn't mention about this before. After these changes I could sucessfully start the ActiveMQ. Before I have the following error: Assertion failed: size = skip Trying to skip 6 frames but there are only 5

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Alexey Varlamov
2006/9/13, Spark Shen [EMAIL PROTECTED]: Nathan Beyer 写道: Here are a few things that I think might help with getting through some of the older outstanding issues, as well as new ones. * If an issue is old (over a month???), then verify that it's still an issue with the latest code and note

Re: [drlvm] putting kernel.jar in jre/bin/default

2006-09-13 Thread Paulex Yang
Alexey Varlamov wrote: 2006/9/13, Paulex Yang [EMAIL PROTECTED]: Alexey Varlamov wrote: Looks like sending my reply failed, here is a second try: I'm not sure I catch up what you mean, about Emma, Harmony's current test coverage exclude list[1] shows that not all classes can be

[classlib][pack200] Patch in queue

2006-09-13 Thread Alex Blewitt
Is anyone able to apply http://issues.apache.org/jira/browse/HARMONY-1386 into the codebase? It's basically more of the same; but I'm waiting until it's applied and I've updated before continuing with development. Thanks, Alex.

Re: [jira] Commented: (HARMONY-1439) [classlib][swing] javax.swing.JEditorPaneTest failed

2006-09-13 Thread Denis Kishenko
Mikhail, I have looked at this issue again and others testing issues. Let's stay this issue as is. Yesterday I didn't clearly understand build - test - ci component meaning. Could you change component name to classlib and summary prefix to [classlib][awt] for H-1441? Thanks a lot 2006/9/12,

Re: [classlib][corba] How are we doing?

2006-09-13 Thread Mark Hindess
Using a latest link wouldn't work well since the md5sum checking would keep breaking. I like using named versions and planned/controlled changes. -Mark. On 13 September 2006 at 1:20, Geir Magnusson Jr. [EMAIL PROTECTED] wrote: +1 Mikhail Loenko wrote: Actually on other externals we are

Re: [general] Marking JIRA issues before creation of patches.

2006-09-13 Thread Paulex Yang
Denis Kishenko wrote: If I am going to work with whole module then Harmony class library development status[1] page is useful but if I want to work with several classes, for example fix some JAPI issues or make serious changes, then existing wiki page can't be used. Anyone can create detail page

Re: [vm] ArgoUML application crashes IBM VME

2006-09-13 Thread Paulex Yang
Oliver Deakin wrote: Thanks for the link Paulex - sorry it's taken a while to reply. I have added ArgoUML to the list of apps on the page you linked, and have put in the details at [1]. If there's anything that needs adding, please let me know. Nice page! Thank you:). Hopefully the problem

Re: [classlib][TestNG] Use tweaked TestNG

2006-09-13 Thread Mark Hindess
On 12 September 2006 at 14:44, Alexei Zakharov [EMAIL PROTECTED] wrote: Hi Richard, If this tweaking doesn't affect visible TestNG user interface then I see nothing bad about converting the sample module. Especially in case if we have volunteers who cannot stand without it any longer :)

Re: [classlib][swing] set of passed swing tests

2006-09-13 Thread Mikhail Loenko
I've committed the changes to exclude list. Now the tests should pass on both linux and windows Thanks, Mikhail 2006/9/13, Geir Magnusson Jr. [EMAIL PROTECTED]: And? :) How did it turn out? geir Mikhail Loenko wrote: I've not tried. Right after I've send the previous mail all swing

Re: [classlib][TestNG] Use tweaked TestNG

2006-09-13 Thread Richard Liang
On 9/13/06, Mark Hindess [EMAIL PROTECTED] wrote: On 12 September 2006 at 14:44, Alexei Zakharov [EMAIL PROTECTED] wrote: Hi Richard, If this tweaking doesn't affect visible TestNG user interface then I see nothing bad about converting the sample module. Especially in case if we have

Re: [general] Marking JIRA issues before creation of patches.

2006-09-13 Thread Denis Kishenko
Most of wiki module pages were updated last time several months ago. Do they have actual information? 2006/9/13, Paulex Yang [EMAIL PROTECTED]: Discussion on dev-list is generally first choice, I totally agree with that. Wiki is just supplement to record somewhat significant work needs longer

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Oliver Deakin
Spark Shen wrote: Alexey Varlamov 写道: 2006/9/13, Spark Shen [EMAIL PROTECTED]: Nathan Beyer 写道: Here are a few things that I think might help with getting through some of the older outstanding issues, as well as new ones. * If an issue is old (over a

Re: [general] Marking JIRA issues before creation of patches.

2006-09-13 Thread Paulex Yang
Denis Kishenko wrote: Most of wiki module pages were updated last time several months ago. Do they have actual information? It is easier for Wiki to be out-dated, that's why it needs to be taken care of more:). Specific for the module page, AFAIK, the 5.0 bring up work on many modules are

[JIRA]what is non-bug difference issue?

2006-09-13 Thread Tony Wu
When I looked though the old JIRA issues I noticed that many non-bug difference issues had patches and some of them was fixed already. e.g. harmony-401 836 1050 and so on. IMHO the non-bug difference indicates that it is an acceptable difference between RI and Harmony and won't be fixed. Am I

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Alexey Varlamov
So I suggest to split JIRA 921 into two JIRAs. One for DRLVM, one for IBM vm. Did you check this is applicable to both VMs? If it is for DRLVM only, then better just change component (and summary prefix ;)). Sorry, what do you mean by applicable? Do you mean will this bug reoccur on both

[doc] multiple unresolved JIRAs for website waiting for someone to apply them

2006-09-13 Thread Morozova, Nadezhda
All, We have not been paying too much attention to documentation for existing code. Here is a compilation of doc-related activities and discussions. It would be great if unresolved JIRAs were propagated and more discussion happened on the existing issues. This will help us make the website

Re: [jira] Updated: (HARMONY-1409) [classlib][beans] add missing get/setSource methods to PropertyEditorSupport

2006-09-13 Thread Alexei Zakharov
Ok, Stepan, in this case I suggest to leave the check and rise the additional Non-bug differences from RI JIRA (I can do if no one objects). I don't really think there are many applications that rely on this silent RI behavior, and IMHO we should not care until we encounter one. Regards,

Re: [jira] Updated: (HARMONY-1409) [classlib][beans] add missing get/setSource methods to PropertyEditorSupport

2006-09-13 Thread Stepan Mishura
On 9/13/06, Alexei Zakharov wrote: Ok, Stepan, in this case I suggest to leave the check and rise the additional Non-bug differences from RI JIRA (I can do if no one objects). I don't really think there are many applications that rely on this silent RI behavior, and IMHO we should not care

Re: [jira] Created: (HARMONY-1447) [classlib][awt] RI Polygon.add(int,int) throws exception after Polygon(new int[2], new int[2], 0)

2006-09-13 Thread Ilya Okomin
On 9/12/06, Denis Kishenko [EMAIL PROTECTED] wrote: Hi all This issue looks like RI bug so I filed it as Non-bug differences from RI. Spec doesn't say about any exceptions. Even if Polygon created with empty point buffer (not null but zero length), method addPoint() should reallocate buffer

Re: [classlib][security] problem processing SHA signatures in JBoss installer manifest

2006-09-13 Thread Yuri Kropachev
Collegues, thanks a lot for identifying the bug !!! The fix you propose is correct. Thanks, Yuri Nice work all. You guys are amazing. Definitely create that patch and attach to the initial JIRA. geir Jimmy, Jing Lv wrote: Richard Liang wrote: After two-day struggling with

[classlib] missing underscores in native dll exports?

2006-09-13 Thread Andrey Chernyshev
I've noticed that the vast majority of the exported function names in the classlib native libraries do not have underscores. For example, for luni.dll the export table looks like: dumpbin /EXPORTS hyluni.dll ... 233 E6 C230 Java_org_apache_harmony_math_util_BigInteger_subImpl On the other

Re: [classlib][corba] How are we doing?

2006-09-13 Thread Geir Magnusson Jr.
Yes, that is what Mikhail was saying, and I was supporting. geir Mark Hindess wrote: Using a latest link wouldn't work well since the md5sum checking would keep breaking. I like using named versions and planned/controlled changes. -Mark. On 13 September 2006 at 1:20, Geir Magnusson Jr.

Re: [drlvm] [jvmti] Question about JVMTI calling Java code

2006-09-13 Thread Andrey Chernyshev
On 9/13/06, Jimmy, Jing Lv [EMAIL PROTECTED] wrote: Gregory Shimansky wrote: Hello I have recently identified a problem which may potentially lead to an infinite recursion with the current implementation of some JVMTI functions in DRLVM. The functions like GetThreadInfo or

Re: [classlib][TestNG] Use tweaked TestNG

2006-09-13 Thread Geir Magnusson Jr.
Richard Liang wrote: Hello, I have been discussing with the author of TestNG (Cedric) about Harmony using a tweaked TestNG which does not require java.util.concurrent. The feedback is we could use the tweaked TestNG as long as we do not re-distributed it. So now it's possible to deploy TestNG

Re: [doc] multiple unresolved JIRAs for website waiting for someone to apply them

2006-09-13 Thread Geir Magnusson Jr.
Thank you! :) Morozova, Nadezhda wrote: All, We have not been paying too much attention to documentation for existing code. Here is a compilation of doc-related activities and discussions. It would be great if unresolved JIRAs were propagated and more discussion happened on the existing

RE: [doc] multiple unresolved JIRAs for website waiting for someone to apply them

2006-09-13 Thread Morozova, Nadezhda
You're welcome :) Do you need any help from me? I have been doing things pretty much on my own, so I could have missed something important. If you have some ideas on what needs to be done for the docs that we have, go ahead and share. I'll see what I can do. Cheers, Nadya Morozova

Re: [classlib][corba] How are we doing?

2006-09-13 Thread Alexey Petrenko
2006/9/13, Mark Hindess [EMAIL PROTECTED]: Using a latest link wouldn't work well since the md5sum checking would keep breaking. This would not be a problem.Since they post md5 as files. I like using named versions and planned/controlled changes. Agree here. SY, Alexey -Mark. On 13

Re: [JIRA]what is non-bug difference issue?

2006-09-13 Thread Stepan Mishura
On 9/13/06, Tony Wu wrote: When I looked though the old JIRA issues I noticed that many non-bug difference issues had patches and some of them was fixed already. e.g. harmony-401 836 1050 and so on. IMHO the non-bug difference indicates that it is an acceptable difference between RI and Harmony

Re: [jira] Updated: (HARMONY-1392) Different properties are used to run awt and swing tests

2006-09-13 Thread Geir Magnusson Jr.
Mark Hindess wrote: On 11 September 2006 at 16:29, Alexey Petrenko [EMAIL PROTECTED] wrote: Mark, I did not get your point... What is the problem with the same property for both awt and swing tests? I understand that we need to set dome property to run them since we got problems with

Re: [classlib][internationalization]Are log messages and tools usage text to be internationalized?

2006-09-13 Thread Oleg Khaschansky
Hi, Are there any non-exception messages in the other modules which are already internationalized? I think, if there are any, they should be modified to follow the new convention. -- Oleg On 9/12/06, Alexei Zakharov [EMAIL PROTECTED] wrote: Hi, Jimmy, Jing Lv wrote: 2. add a prefix to the

Re: [classlib][internationalization]Are log messages and tools usage text to be internationalized?

2006-09-13 Thread Alexey Petrenko
I believe it could be done in lazy way... But it defenetly should be done. SY, Alexey 2006/9/13, Oleg Khaschansky [EMAIL PROTECTED]: Hi, Are there any non-exception messages in the other modules which are already internationalized? I think, if there are any, they should be modified to follow

Re: [classlib][swing] set of passed swing tests

2006-09-13 Thread Denis Kishenko
AFAIK some of tests wrongly release resources which are necessary for the next one. So each single test passes, but if you run series - it fails. Using flag forkmode=perTest allows avoid this. 2006/9/13, Mikhail Loenko [EMAIL PROTECTED]: I've committed the changes to exclude list. Now the tests

Re: [classlib][swing] set of passed swing tests

2006-09-13 Thread Alexey Petrenko
And this is already done for swing tests as Mikhail said. 2006/9/13, Denis Kishenko [EMAIL PROTECTED]: AFAIK some of tests wrongly release resources which are necessary for the next one. So each single test passes, but if you run series - it fails. Using flag forkmode=perTest allows avoid this.

[j9] Doesn't deal with -showversion

2006-09-13 Thread Geir Magnusson Jr.
Oliver and Co : I don't know if you caught this in another thread, but I recently changed the launcher to pass the -showversion cmd line param through to the VM after the launcher prints out its version, so that we can also know the version of the VM. The problem with this brilliant

Re: [drlvm] [jvmti] Question about JVMTI calling Java code

2006-09-13 Thread Weldon Washburn
Gregory, You might want to look closely at the code paths in the JVMTI functions. If the functions in question happen to be arbitrary Java code, then these code paths could lead to many other parts of the JVM which in turn might be written in Java. In the future the JIT runtime helpers or the

Re: Re: Re: [classlib][TestNG] groups of Harmony test

2006-09-13 Thread Alexei Zakharov
Stepan, All, This is not a good argument for using os.any. Even more it may sound like we are going to choose wrong tool - why we have to add os.any to 99% of classlib tests? just because the harness can not do without it? Well, we have to add the new stuff to these 99% anyway, I mean the

Re: [j9] Doesn't deal with -showversion

2006-09-13 Thread Oliver Deakin
Hi Geir, I just spotted that in the other thread as Im catching up with my mail. Ill take a look at it and see if we can get it fixed in the next VME version. Regards, Oliver Geir Magnusson Jr. wrote: Oliver and Co : I don't know if you caught this in another thread, but I recently changed

Re: [JIRA]what is non-bug difference issue?

2006-09-13 Thread Andrew Zhang
On 9/13/06, Stepan Mishura [EMAIL PROTECTED] wrote: On 9/13/06, Tony Wu wrote: When I looked though the old JIRA issues I noticed that many non-bug difference issues had patches and some of them was fixed already. e.g. harmony-401 836 1050 and so on. IMHO the non-bug difference indicates

Re: [j9] Doesn't deal with -showversion

2006-09-13 Thread Oliver Deakin
Is it just me, or does something similar happen with -version? I get: $ java -version Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable. JVMJ9VM007E Command-line option unrecognised: -version HMYEXEL062E Internal VM error: Failed

Re: [j9] Doesn't deal with -showversion

2006-09-13 Thread Geir Magnusson Jr.
You are correct. As I recall, I've never seen J8 actually output a version, ever. It's always been the launcher's version msg. geir Oliver Deakin wrote: Is it just me, or does something similar happen with -version? I get: $ java -version Apache Harmony Launcher : (c) Copyright 1991, 2006

Re: [JIRA]what is non-bug difference issue?

2006-09-13 Thread Alexey Petrenko
I vote for closing non-bug issues. 2006/9/13, Andrew Zhang [EMAIL PROTECTED]: On 9/13/06, Stepan Mishura [EMAIL PROTECTED] wrote: On 9/13/06, Tony Wu wrote: When I looked though the old JIRA issues I noticed that many non-bug difference issues had patches and some of them was fixed

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Tony Wu
I have opened a new page at harmony wiki, http://wiki.apache.org/harmony/OLDJIRAS You can get the guideline, the process and a list of old jira issues there. In the list there is a column called ASSIGNEE, you can sign your name there if you are working on that issue. And you may check from this

Re: [classlib][internationalization]Are log messages and tools usage text to be internationalized?

2006-09-13 Thread Oleg Khaschansky
It is unclear what do you mean by the lazy way. If it means that every new message will follow the new convention, then we will never be consistent. If you mean that this task have low priority, then I agree, but, probably, somebody have to open a JIRA issue for this. On 9/13/06, Alexey Petrenko

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Geir Magnusson Jr.
My suggestion is to use the wiki page to augment rather than replace what the JIRA can do. For example, I'd suggest that people who are working on a given JIRA note that *in the JIRA*. geir Tony Wu wrote: I have opened a new page at harmony wiki, http://wiki.apache.org/harmony/OLDJIRAS You

Re: [classlib][internationalization]Are log messages and tools usage text to be internationalized?

2006-09-13 Thread Alexey Petrenko
Low priority. As far as I know Ilya creates subtasks for one JIRA issue to internationalize each module. I think that reinternationalization can be done in same way. SY, Alexey 2006/9/13, Oleg Khaschansky [EMAIL PROTECTED]: It is unclear what do you mean by the lazy way. If it means that every

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Tony Wu
Yes, This wiki page is just a place to record who are working on a given old JIRA issue for avoiding duplicate work. maybe the ASSIGNEE causes misunderstanding. I have replaced it to VOLUNTEER :) On 9/13/06, Geir Magnusson Jr. [EMAIL PROTECTED] wrote: My suggestion is to use the wiki page to

Re: [JIRA]what is non-bug difference issue?

2006-09-13 Thread Oleg Khaschansky
+1. My understanding is that when the non-bug difference is discussed it should be opened, but when there's an agreement on it it should be closed. On 9/13/06, Alexey Petrenko [EMAIL PROTECTED] wrote: I vote for closing non-bug issues. 2006/9/13, Andrew Zhang [EMAIL PROTECTED]: On 9/13/06,

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Alexey Petrenko
+1 2006/9/13, Geir Magnusson Jr. [EMAIL PROTECTED]: My suggestion is to use the wiki page to augment rather than replace what the JIRA can do. For example, I'd suggest that people who are working on a given JIRA note that *in the JIRA*. geir Tony Wu wrote: I have opened a new page at

Re: [classlib][internationalization]Are log messages and tools usage text to be internationalized?

2006-09-13 Thread Ilya Okomin
Agree, we should follow the conventions we've reached. For future updates I'll add the convention to the HARMONY-1308 comments, where the way to internationalize messages is described. As for already processed modules, I've found only few error strings and console messages in beans, auth,

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Tony Wu
oops! may be just record *someone is in the JIRA* is more lightweight. I'll fix it. any suggest is welcome: ) On 9/13/06, Geir Magnusson Jr. [EMAIL PROTECTED] wrote: My suggestion is to use the wiki page to augment rather than replace what the JIRA can do. For example, I'd suggest that people

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Oleg Khaschansky
Put comment to the jira issue when you start work on it. You may also change the wiki page if you like, but, please, add a comment right into the jira. And another comment if you can't provide a patch for some reason. It was discussed already. On 9/13/06, Tony Wu [EMAIL PROTECTED] wrote: Yes,

Re: [JIRA]what is non-bug difference issue?

2006-09-13 Thread Denis Kishenko
2006/9/13, Andrew Zhang [EMAIL PROTECTED]: I suggest that if the bug was fixed for some reason, we should change the component too, i.e, classlib instead of non-bug difference from RI. +1 Another question is for those real non-bug difference from RI JIRAs, what should be the final status,

Re: [classlib]volunteer to supply patches for old JIRAs

2006-09-13 Thread Tony Wu
Ok, I'll write into guideline and comply with it. On 9/13/06, Oleg Khaschansky [EMAIL PROTECTED] wrote: Put comment to the jira issue when you start work on it. You may also change the wiki page if you like, but, please, add a comment right into the jira. And another comment if you can't

Re: [JIRA]what is non-bug difference issue?

2006-09-13 Thread Ilya Okomin
On 9/13/06, Oleg Khaschansky [EMAIL PROTECTED] wrote: +1. My understanding is that when the non-bug difference is discussed it should be opened, but when there's an agreement on it it should be closed. +1 from me. On 9/13/06, Alexey Petrenko [EMAIL PROTECTED] wrote: I vote for closing

[jira] Good issue resolution guideline (was: [classlib]volunteer to supply patches for old JIRAs)

2006-09-13 Thread Alexey Petrenko
Guys, I think that we need to create something like Good issue resolution guideline and post it on Harmony site or wiki. It will help community to prepare good fixes and will help committers to spend less time on applying other's patches. As a start we can take Nathan's post with additions from

Re: [jira] Good issue resolution guideline (was: [classlib]volunteer to supply patches for old JIRAs)

2006-09-13 Thread Andrew Zhang
On 9/13/06, Alexey Petrenko [EMAIL PROTECTED] wrote: Guys, I think that we need to create something like Good issue resolution guideline and post it on Harmony site or wiki. It will help community to prepare good fixes and will help committers to spend less time on applying other's patches.

Re: [drlvm] Cleaning insides of Class.h header

2006-09-13 Thread Alexey Varlamov
2006/9/11, Weldon Washburn [EMAIL PROTECTED]: On 9/10/06, Alexey Varlamov [EMAIL PROTECTED] wrote: 2006/9/10, Pavel Pervov [EMAIL PROTECTED]: Weldon, one of good examples is static_method_block member variable of struct Class. Its size if calculated, memory is allocated for it, but it

Re: [jira] Good issue resolution guideline (was: [classlib]volunteer to supply patches for old JIRAs)

2006-09-13 Thread Oleg Khaschansky
And the resolution provider should not forget to add a comment when he is starting development of the patch to prevent collisions. If the resolution provider is a committer he simply assigns the bug. On 9/13/06, Andrew Zhang [EMAIL PROTECTED] wrote: On 9/13/06, Alexey Petrenko [EMAIL PROTECTED]

Re: [general] svn:eol-style = native (LF vs CRLF)

2006-09-13 Thread Ilya Okomin
On 8/17/06, Tim Ellison [EMAIL PROTECTED] wrote: Sure -- just blat them all in one go. Regards, Tim Nathan Beyer wrote: Does anyone have objections to setting the svn:eol-style to native for *.java, *.c, *.h, *.cpp, *.xml as we move forward with updates and changes? I believe this is the

Re: [drlvm] [jvmti] Implementation of SingleStep event through TRAP breakpoints

2006-09-13 Thread Gregory Shimansky
2006/9/13, Pavel Rebriy [EMAIL PROTECTED]: I'm starting the implementation of Single Step event for JIT mode. The initial draft is filed in H-1422 [1]. The implemented function jvmti_SingleStepLocation predicts the next execution bytecode which can be used from Single Step event. [1]

Re: [drlvm] Cleaning insides of Class.h header

2006-09-13 Thread Pavel Pervov
Not sure C++ friends are good design. Although class format is something one might want to localize to be known to only one entity (like ClassFileParser), it is much better to provide format extractor to anybody interested in its use and let them manage their content by themselves. This is how

Re: [jira] Good issue resolution guideline (was: [classlib]volunteer to supply patches for old JIRAs)

2006-09-13 Thread Tony Wu
and resolution provider should verify the application. On 9/13/06, Alexey Petrenko [EMAIL PROTECTED] wrote: Guys, I think that we need to create something like Good issue resolution guideline and post it on Harmony site or wiki. It will help community to prepare good fixes and will help

Re: [jira] Good issue resolution guideline (was: [classlib]volunteer to supply patches for old JIRAs)

2006-09-13 Thread Richard Liang
On 9/13/06, Alexey Petrenko [EMAIL PROTECTED] wrote: Guys, I think that we need to create something like Good issue resolution guideline and post it on Harmony site or wiki. It will help community to prepare good fixes and will help committers to spend less time on applying other's patches. As

Re: [jira] Good issue resolution guideline (was: [classlib]volunteer to supply patches for old JIRAs)

2006-09-13 Thread Oleg Khaschansky
and resolution provider should verify the application. Or, probably, the reporter may do it also. On 9/13/06, Tony Wu [EMAIL PROTECTED] wrote: and resolution provider should verify the application. On 9/13/06, Alexey Petrenko [EMAIL PROTECTED] wrote: Guys, I think that we need to create

Re: [drlvm]A subject to profiling instrumenting

2006-09-13 Thread Mikhail Fursov
Qiong, I tried to build your vm.tar.bz2 file and have the following problems: 1) RUNTIME_OBJ_PATTERN_FILE_NAME is not defined but used 2) open/write_thread.h file is absent 3) mutex_write_thread is used in jit_runtime_support.cpp but is not declared. Can you post only diffs file to JIRA with

Re: [drlvm] putting kernel.jar in jre/bin/default

2006-09-13 Thread Alexey Varlamov
2006/9/13, Paulex Yang [EMAIL PROTECTED]: Alexey Varlamov wrote: 2006/9/13, Paulex Yang [EMAIL PROTECTED]: Alexey Varlamov wrote: Looks like sending my reply failed, here is a second try: I'm not sure I catch up what you mean, about Emma, Harmony's current test coverage exclude list[1]

Re: [drlvm] putting kernel.jar in jre/bin/default

2006-09-13 Thread Alexey Varlamov
2006/9/13, Alexey Varlamov [EMAIL PROTECTED]: 2006/9/13, Paulex Yang [EMAIL PROTECTED]: Alexey Varlamov wrote: 2006/9/13, Paulex Yang [EMAIL PROTECTED]: Alexey Varlamov wrote: Looks like sending my reply failed, here is a second try: I'm not sure I catch up what you mean, about

Re: [general] svn:eol-style = native (LF vs CRLF)

2006-09-13 Thread Tony Wu
I noticed that there are some .java files in security module has set the svn:eol-style to native, that is, a EOL marker will be added to every line of this file when commit to repository. And when you checkout them, the EOL marker will be replaced according your os, CRLF on windows and LF on

Re: [classlib][luni] Put setInterruptAction() in our j.l.Thread stub?

2006-09-13 Thread Oliver Deakin
Geir Magnusson Jr. wrote: This came up in another thread. Currently, java.nio.channels.spi.AbstractInterruptibleChannel depends on there being a setInterruptAction() method on java.lang.Thread. I certainly think that this kind of thing should be documented, so the question - should we add

[jira] Updated: (HARMONY-1453) [classlib][awt] Incorrect behavior of methods Graphics.draw3DRect and Graphics.fill3DRect

2006-09-13 Thread Oleg Khaschansky
Committers, Could someone be so kind and change the component for this issue to the classlib, please? Unfortunately, I forgot to set it when created the issue and unable to change. And, probably, apply the patch also :) thanks, -- Oleg -- Forwarded message -- From: Oleg

Re: [general] svn:eol-style = native (LF vs CRLF)

2006-09-13 Thread Tony Wu
After going through this thread, I realize there is another possibility to encounter the problem even you are working on single platform, 1.the file you are working on does not have eol-style property and the latest commit is performed on Unix system. 2.you create a patch. 3.when applying the

Re: [drlvm] Cleaning insides of Class.h header

2006-09-13 Thread Weldon Washburn
Alexey, I agree with what Pavel Pervov says below. In looking at the code in vmcore/src/class_support, creating another class adds another layer of complexity and will make removal of unnecessary code more difficult. C++ friends should be used very sparingly. Can you try Pavel's suggestion

Re: [general] svn:eol-style = native (LF vs CRLF)

2006-09-13 Thread Alexey Petrenko
2006/9/13, Tony Wu [EMAIL PROTECTED]: I noticed that there are some .java files in security module has set the svn:eol-style to native, that is, a EOL marker will be added to every line of this file when commit to repository. And when you checkout them, the EOL marker will be replaced according

Re: [jira] Good issue resolution guideline (was: [classlib]volunteer to supply patches for old JIRAs)

2006-09-13 Thread Alexey Petrenko
2006/9/13, Richard Liang [EMAIL PROTECTED]: On 9/13/06, Alexey Petrenko [EMAIL PROTECTED] wrote: Guys, I think that we need to create something like Good issue resolution guideline and post it on Harmony site or wiki. It will help community to prepare good fixes and will help committers to

Re: [drlvm] Cleaning insides of Class.h header

2006-09-13 Thread Alexey Varlamov
2006/9/13, Pavel Pervov [EMAIL PROTECTED]: Not sure C++ friends are good design. Umm, what is wrong with friends? Although class format is something one might want to localize to be known to only one entity (like ClassFileParser), it is much better to provide format extractor to anybody

Re: [drlvm] Need help debugging

2006-09-13 Thread Geir Magnusson Jr.
I'd like to understand why this is no longer necessary. (Just provide some background for all of us to help start understanding the structure and operation of DLRVM) geir Vladimir Gorr wrote: Probably, you didn't note I've commented this fragment of code (firts last lines). Sorry I

Re: [jira] Resolved: (HARMONY-1386) Update to Pack200 decoding libraries

2006-09-13 Thread Alex Blewitt
Yes, the HelloWorld.pack is different and needs to be replaced with the one in the bug report. Thanks, Alex. On 13/09/06, Mikhail Loenko (JIRA) [EMAIL PROTECTED] wrote: [ http://issues.apache.org/jira/browse/HARMONY-1386?page=all ] Mikhail Loenko resolved HARMONY-1386.

Re: [result] Re: [vote] HARMONY-1363 - DRLVM fixes and additions

2006-09-13 Thread Weldon Washburn
Anyone having problems building patch 1363 on Linux? I can get 1363 to work on WinXP without problem. I first do: svn update -r {2006-08-31} Then a: patch -p0 -i BBC.patch The build is successful and build test is successful When I roll back the Linux tree to {2006-08-31} the build

Re: [result] Re: [vote] HARMONY-1363 - DRLVM fixes and additions

2006-09-13 Thread Weldon Washburn
Where do I find regression tests for the recent drlvm patches? Right now, I am trying to drill down on Harmony-1417. I look in drlvm/trunk/vm/tests but don't see regression tests that look like they verify that lazy exception optimization works correctly. Maybe I overlooked something? --

Re: [result] Re: [vote] HARMONY-1363 - DRLVM fixes and additions

2006-09-13 Thread Gregory Shimansky
On Thursday 14 September 2006 00:12 Weldon Washburn wrote: Anyone having problems building patch 1363 on Linux? I can get 1363 to work on WinXP without problem. I first do: svn update -r {2006-08-31} Then a: patch -p0 -i BBC.patch The build is successful and build test is

Re: [drlvm] [jvmti] Question about JVMTI calling Java code

2006-09-13 Thread Gregory Shimansky
On Wednesday 13 September 2006 09:19 Alexey Varlamov wrote: The Thread.getContextClassLoader() just performs access restriction checks and return the corresponding field value. I think the only problematic function is ThreadGroup.enumerate() - unless security access control is applicable to

Re: [drlvm] [jvmti] Question about JVMTI calling Java code

2006-09-13 Thread Gregory Shimansky
On Wednesday 13 September 2006 16:14 Weldon Washburn wrote: Gregory, You might want to look closely at the code paths in the JVMTI functions. If the functions in question happen to be arbitrary Java code, then these code paths could lead to many other parts of the JVM which in turn might be

Re: [jira] Good issue resolution guideline (was: [classlib]volunteer to supply patches for old JIRAs)

2006-09-13 Thread Gregory Shimansky
On Wednesday 13 September 2006 18:09 Andrew Zhang wrote: On 9/13/06, Alexey Petrenko [EMAIL PROTECTED] wrote: Guys, I think that we need to create something like Good issue resolution guideline and post it on Harmony site or wiki. It will help community to prepare good fixes and will

Re: [drlvm] [jvmti] Question about JVMTI calling Java code

2006-09-13 Thread Rana Dasgupta
Weldon, It may be a little early to guard for architectural impact of large parts of the VM being written in Java? I don't think that we are quite there yet or need to consciously design to enable this till we have completed the MMTk integration and done exhaustive perf work. In addition to

RE: [jira] Updated: (HARMONY-1453) [classlib][awt] Incorrect behavior of methods Graphics.draw3DRect and Graphics.fill3DRect

2006-09-13 Thread Nathan Beyer
Done. -Original Message- From: Oleg Khaschansky [mailto:[EMAIL PROTECTED] Sent: Wednesday, September 13, 2006 10:36 AM To: harmony-dev@incubator.apache.org Subject: [jira] Updated: (HARMONY-1453) [classlib][awt] Incorrect behavior of methods Graphics.draw3DRect and

Re: [classlib][luni] java.net.URL(String, String, int, String) constructor exception thrown sequence (was re: [jira] Commented: (HARMONY-1158) [classlib][luni]Compatibility: java.net.URL new URL(ss,

2006-09-13 Thread Andrew Zhang
Would any commiter like to confirm and close this non-bug differences from RI jira? Thanks! On 9/13/06, Andrew Zhang [EMAIL PROTECTED] wrote: From: Andrew Zhang (JIRA) [EMAIL PROTECTED] Date: Sep 13, 2006 11:02 AM Subject: [jira] Commented: (HARMONY-1158) [classlib][luni]Compatibility:

[OLD JIRA]Deal with 780 866 1367 according to discussion

2006-09-13 Thread Spark Shen
Hi All: Component attribute of JIRA 780 has been left as none, can any committer change it to [classlib]. The patch has already outdated and seems incorrect, I will provide a new patch. According to the 'Fighting Old JIRA Issues' guideline, I suggest to change component of JIRA 866 from

[General VM] GC strategy:how to garbage collect short-lived objects quickly.

2006-09-13 Thread Leo Li
Hi,all: As we all know, java objects are allocated on heap instead of stack, thus there is a problem about how to garbage collect short-lived objects quickly. In a recent real project I involved, a server built on java tries to send thousands of messages to client per second. A lot of

  1   2   >