Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-22 Thread Stepan Mishura
Hi Richard, On 3/21/06, Richard Liang wrote: Geir Magnusson Jr wrote: Good unit tests are going to be testing things that are package protected. You can't do that if you aren't in the same package (obviously). With the custom of putting in things in o.a.h.t are we implicitly

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-22 Thread Geir Magnusson Jr
Etienne Gagnon wrote: Just a random idea... Why not have a special testing mode in the VM that would trigger special permissions to code in .test packages? You wouldn't need that when testing in the VM. :) That's why Tim suggested o.a.h.test. so then you stay out of package namespace

sorry (was: Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code)

2006-03-22 Thread Tim Ellison
Geir Magnusson Jr wrote: Tim Ellison wrote: snip Geir Magnusson Jr wrote: snip With the custom of putting in things in o.a.h.t are we implicitly discouraging good testing practice? This is laughable. You are going to have to explain why it's laughable. If you are testing a.b.c.Foo and

RE: sorry (was: Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code)

2006-03-22 Thread Magnusson, Geir
No worries. I figured it was something like that, although i'll be the first to admit that I do and say laughable things. Focus on the talk. Do we say 'good luck' or 'break a leg', show biz style? Too bad we don't have swing and awt yet. Would be memorable to demonstrate IDEA running in

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Tim Ellison
Mikhail Loenko wrote: Hi Richard Did I understand your 1. correctly that this suite (Test for APIs) would be something competing with Sun's TCK? Not sure how you got there from Richard's comments. As others have said no, we need API tests to test our code is working as we intended. When it

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Richard Liang
Geir Magnusson Jr wrote: Good unit tests are going to be testing things that are package protected. You can't do that if you aren't in the same package (obviously). With the custom of putting in things in o.a.h.t are we implicitly discouraging good testing practice? Given that this

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Mikhail Loenko
Hi Richard Did I understand your 1. correctly that this suite (Test for APIs) would be something competing with Sun's TCK? Thanks, Mikhail 2006/3/21, Richard Liang [EMAIL PROTECTED]: Geir Magnusson Jr wrote: Good unit tests are going to be testing things that are package protected. You

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Geir Magnusson Jr
Mikhail Loenko wrote: Hi Richard Did I understand your 1. correctly that this suite (Test for APIs) would be something competing with Sun's TCK? No - nothing we do would compete. it could be the same functionality, but it's not competing in the sense of trying to surpass or displace. The

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Chris Gray
On Tuesday 21 March 2006 15:53, Dalibor Topic wrote: But alas, Sun currently sees other implementations as a threat to its business model as a proprietary Java vendor, so one has to deal with such things until they stop having a business interest in being a proprietary Java vendor (yeah,

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Dalibor Topic
On Tue, Mar 21, 2006 at 04:17:26PM +0100, Chris Gray wrote: On Tuesday 21 March 2006 15:53, Dalibor Topic wrote: But alas, Sun currently sees other implementations as a threat to its business model as a proprietary Java vendor, so one has to deal with such things until they stop having a

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Fernando Cassia
On 3/21/06, Dalibor Topic [EMAIL PROTECTED] wrote: Java is so depressingly backwards. We're solving problems over and over again that would not be problems in the first place if Java was managed competently, by people who have a clue about involving communities, and placed the platform

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Geir Magnusson Jr
Tim Ellison wrote: Just to clarify terminology -- unit tests are a 'style' of test that focus on particular units of functionality. Unit tests can be both implementation tests and API tests. Implementation tests are specific to our implementation (the mechanism, hidden to the end user, by

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Geir Magnusson Jr
Dalibor Topic wrote: On Tue, Mar 21, 2006 at 02:48:25PM -0300, Fernando Cassia wrote: On 3/21/06, Dalibor Topic [EMAIL PROTECTED] wrote: Java is so depressingly backwards. We're solving problems over and over again that would not be problems in the first place if Java was managed

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Etienne Gagnon
Just a random idea... Why not have a special testing mode in the VM that would trigger special permissions to code in .test packages? Actually, this mechanism could act differently: simply consider some.package and some.package.test as being the *same* package (so, erase, at loading time, the

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Mikhail Loenko
As I understood the main Tim's concern with running tests in bootclasspath is that real apps wont run that way. If we test in special VM mode then we go far away from how real apps are running. $0.02 Thanks, Mikhail 2006/3/22, Etienne Gagnon [EMAIL PROTECTED]: Just a random idea... Why not

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-21 Thread Anton Avtamonov
On 3/22/06, Mikhail Loenko [EMAIL PROTECTED] wrote: As I understood the main Tim's concern with running tests in bootclasspath is that real apps wont run that way. If we test in special VM mode then we go far away from how real apps are running. Agree. Besides, VM will have to be even more

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-20 Thread Geir Magnusson Jr
I just committed. There was some delay because of a missing CCLA. Sorry. I've committed the code as is from the JIRA. I'm going to do some basic cleanup and then look at hte patches to integrate. Looking at this (and 88?) I think that this add patches approach is a bad one, because it

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-20 Thread Mark Hindess
Fair enough. Mind if I redo the script/patch to split the three modules to match the structure of the others? That is, into separate modules/math, modules/beans, modules/regex directories? Regards, Mark. On 3/20/06, Geir Magnusson Jr [EMAIL PROTECTED] wrote: I just committed. There was some

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-20 Thread Mark Hindess
Don't worry, you'd have to be less subtle for me to take something as criticism. I've had an attempt at moving beans out - HARMONY-218. If that gets committed I'll do the other too. -Mark. On 3/20/06, Geir Magnusson Jr [EMAIL PROTECTED] wrote: That wasn't a criticism, btw. It seemed like a

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-20 Thread Mark Hindess
I thought the crucial thing was that tests should be in a separate namespace not in the namespace of the package they are testing (at least not unless it was absolutely necessary). -Mark. On 3/20/06, Geir Magnusson Jr [EMAIL PROTECTED] wrote: I'm doing it now. I need to go back and stare at

Re: [result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-03-19 Thread Richard Liang
Geir Magnusson Jr wrote: Despite a touch of trouble with the packaging of the contribution, it passed with flying colors ( or 'colours', for our UK friends...) +1 from : Geir Stefano Dims Tim Leo In it comes Geir Magnusson Jr wrote: I have received the ACQs and the BCC for Harmony-39,

[result] Re: [vote] Acceptance of HARMONY-39 : Contribution of beans, regex and math class library code

2006-02-13 Thread Geir Magnusson Jr
Despite a touch of trouble with the packaging of the contribution, it passed with flying colors ( or 'colours', for our UK friends...) +1 from : Geir Stefano Dims Tim Leo In it comes Geir Magnusson Jr wrote: I have received the ACQs and the BCC for Harmony-39, so I can assert that the