Re: HARMONY-1752: patch review

2006-10-20 Thread Ilya Okomin
PROTECTED] Sent: Thursday, October 19, 2006 2:05 PM To: harmony-dev@incubator.apache.org Subject: Re: HARMONY-1752: patch review On 10/19/06, Ilya Okomin [EMAIL PROTECTED] wrote: On 10/19/06, Andrew Zhang [EMAIL PROTECTED] wrote: On 10/19/06, Fedotov, Alexei A [EMAIL PROTECTED] wrote: Hello

RE: HARMONY-1752: patch review

2006-10-20 Thread Fedotov, Alexei A
:[EMAIL PROTECTED] Sent: Thursday, October 19, 2006 2:05 PM To: harmony-dev@incubator.apache.org Subject: Re: HARMONY-1752: patch review On 10/19/06, Ilya Okomin [EMAIL PROTECTED] wrote: On 10/19/06, Andrew Zhang [EMAIL PROTECTED] wrote: On 10/19/06, Fedotov, Alexei A [EMAIL PROTECTED

Re: HARMONY-1752: patch review

2006-10-19 Thread Ilya Okomin
On 10/19/06, Andrew Zhang [EMAIL PROTECTED] wrote: On 10/19/06, Fedotov, Alexei A [EMAIL PROTECTED] wrote: Hello Ilya, I really like your patch from http://issues.apache.org/jira/browse/HARMONY-1752. Let me participate in a way I'm able to. I cannot say why calling free(send_buf)

Re: HARMONY-1752: patch review

2006-10-19 Thread Andrew Zhang
On 10/19/06, Ilya Okomin [EMAIL PROTECTED] wrote: On 10/19/06, Andrew Zhang [EMAIL PROTECTED] wrote: On 10/19/06, Fedotov, Alexei A [EMAIL PROTECTED] wrote: Hello Ilya, I really like your patch from http://issues.apache.org/jira/browse/HARMONY-1752. Let me participate in a way

RE: HARMONY-1752: patch review

2006-10-19 Thread Fedotov, Alexei A
Ilya, Shouldn't we change OSNetworkSystemLinux.c as well? With best regards, Alexei Fedotov, Intel Java XML Engineering -Original Message- From: Andrew Zhang [mailto:[EMAIL PROTECTED] Sent: Thursday, October 19, 2006 2:05 PM To: harmony-dev@incubator.apache.org Subject: Re: HARMONY-1752

Re: HARMONY-1752: patch review

2006-10-19 Thread Andrew Zhang
regards, Alexei Fedotov, Intel Java XML Engineering -Original Message- From: Andrew Zhang [mailto:[EMAIL PROTECTED] Sent: Thursday, October 19, 2006 2:05 PM To: harmony-dev@incubator.apache.org Subject: Re: HARMONY-1752: patch review On 10/19/06, Ilya Okomin [EMAIL PROTECTED] wrote

Re: HARMONY-1752: patch review

2006-10-18 Thread Andrew Zhang
On 10/19/06, Fedotov, Alexei A [EMAIL PROTECTED] wrote: Hello Ilya, I really like your patch from http://issues.apache.org/jira/browse/HARMONY-1752. Let me participate in a way I'm able to. I cannot say why calling free(send_buf) when send_buf == NULL makes me feel a bit uncomfortable.