Re: [Haskell-cafe] Code critique - Was [Maybe Int] sans Nothings

2011-05-30 Thread Neil Mitchell
Hi Michael, You've used quite a few entirely redundant brackets. The tool HLint ( http://community.haskell.org/~ndm/hlint) will tell you which ones. Thanks, Neil On Wed, May 25, 2011 at 12:09 AM, michael rice nowg...@yahoo.com wrote: The input file: http://dl.dropbox.com/u/27842656/psalms

Re: [Haskell-cafe] Code critique - Was [Maybe Int] sans Nothings

2011-05-30 Thread michael rice
Nice tool. I'll be using it a lot from now on, I'm sure. Thanks, Neil. Michael --- On Mon, 5/30/11, Neil Mitchell ndmitch...@gmail.com wrote: From: Neil Mitchell ndmitch...@gmail.com Subject: Re: [Haskell-cafe] Code critique - Was [Maybe Int] sans Nothings To: michael rice nowg...@yahoo.com Cc

Re: [Haskell-cafe] Code critique - Was [Maybe Int] sans Nothings

2011-05-25 Thread Henning Thielemann
Alexander Solla schrieb: buildMap :: GeneratorState1 (Map Prefix [String]) buildMap = do (mp,(pfx1,pfx2),words) - get if (Prelude.null words) then {- No more words. Return final map (adding non_word for final prefix). -}

Re: [Haskell-cafe] Code critique - Was [Maybe Int] sans Nothings

2011-05-25 Thread michael rice
Yes, very nice. Thanks. Michael --- On Wed, 5/25/11, Henning Thielemann schlepp...@henning-thielemann.de wrote: From: Henning Thielemann schlepp...@henning-thielemann.de Subject: Re: [Haskell-cafe] Code critique - Was [Maybe Int] sans Nothings To: michael rice nowg...@yahoo.com Cc: Haskell Cafe

Re: [Haskell-cafe] Code critique - Was [Maybe Int] sans Nothings

2011-05-24 Thread michael rice
The input file: http://dl.dropbox.com/u/27842656/psalms The Markov chain exercise from The Practice of Programming, Kermighan/Pike. Sample runs at the end. Michael   import System.Environment(getArgs)import System.Randomimport Control.Applicativeimport

Re: [Haskell-cafe] Code critique - Was [Maybe Int] sans Nothings

2011-05-24 Thread Alexander Solla
My comments are in-line, marked off with On Tue, May 24, 2011 at 4:09 PM, michael rice nowg...@yahoo.com wrote: The input file: http://dl.dropbox.com/u/27842656/psalms The Markov chain exercise from The Practice of Programming, Kermighan/Pike. Sample runs at the end. Michael

Re: [Haskell-cafe] Code critique - Was [Maybe Int] sans Nothings

2011-05-24 Thread michael rice
a Haskell program (lines.hs) to turn them into lines. Michael --- On Tue, 5/24/11, Alexander Solla alex.so...@gmail.com wrote: From: Alexander Solla alex.so...@gmail.com Subject: Re: [Haskell-cafe] Code critique - Was [Maybe Int] sans Nothings To: michael rice nowg...@yahoo.com Cc: Haskell Cafe