Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
Stefan, Data.Derive is a most awesome piece of code! Is there soemething in DrIFT that you did not like that made you write it? Thanks a lot! On Apr 5, 2007, at 12:48 AM, Stefan O'Rear wrote: Data.Derive can do this. In an attempt to avoid munging the relevent files they are attached. -- http://wagerlabs.com/ ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
Stefan, What version of ghc are you using? Mine is 6.6. Data/Derive/Play.hs:9:7: Could not find module `Control.Monad.State': it is a member of package mtl-1.0, which is hidden I commented out that import line. Preprocessing library derive-0.1... Preprocessing executables for derive-0.1... Building derive-0.1... [1 of 9] Compiling Data.Derive.FixedPpr ( Data/Derive/FixedPpr.hs, dist/build/Data/Derive/FixedPpr.o ) [2 of 9] Compiling Data.Derive ( Data/Derive.hs, dist/build/Data/ Derive.o ) [3 of 9] Compiling Data.Derive.SYB ( Data/Derive/SYB.hs, dist/build/ Data/Derive/SYB.o ) [4 of 9] Compiling Data.Derive.TH ( Data/Derive/TH.hs, dist/build/ Data/Derive/TH.o ) Data/Derive/TH.hs:25:26: No instance for (Functor Q) arising from use of `fmap' at Data/Derive/TH.hs:25:26-31 Possible fix: add an instance declaration for (Functor Q) In the first argument of `(.)', namely `fmap f' In the expression: (fmap f) . deriveOne In the definition of `derive': derive (Derivation f _) = (fmap f) . deriveOne This I don't know how to deal with. Thanks, Joel -- http://wagerlabs.com/ ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
On Apr 5, 2007, at 11:04 AM, Joel Reymont wrote: This is in Language.Haskell.TH.Syntax which is imported at the top of Data/Derive/TH.hs so I don't understand the cause of the error Apparently instance Functor Q was added to 6.6 very recently and it's not in MacPorts yet. I decided to throw down the gauntlet and run 6.7 instead. -- http://wagerlabs.com/ ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
That did it, thanks! On Apr 5, 2007, at 12:07 PM, Twan van Laarhoven wrote: instance Functor Q where fmap = liftM -- http://wagerlabs.com/ ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
Joel Reymont wrote: This is in Language.Haskell.TH.Syntax which is imported at the top of Data/Derive/TH.hs so I don't understand the cause of the error instance Functor Q where fmap f (Q x) = Q (fmap f x) ... Any suggestions? Since Q is a Monad, you can make the instance instance Functor Q where fmap = liftM But Q is exported by Languave.Haskell.TH.Syntax !!! Only the type constructor is exported, not the data constructor. Twan ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
This is in Language.Haskell.TH.Syntax which is imported at the top of Data/Derive/TH.hs so I don't understand the cause of the error instance Functor Q where fmap f (Q x) = Q (fmap f x) Copying the above into TH.hs gives me Preprocessing library derive-0.1... Preprocessing executables for derive-0.1... Building derive-0.1... [4 of 9] Compiling Data.Derive.TH ( Data/Derive/TH.hs, dist/build/ Data/Derive/TH.o ) Data/Derive/TH.hs:23:10: Not in scope: data constructor `Q' Data/Derive/TH.hs:23:17: Not in scope: data constructor `Q' But Q is exported by Languave.Haskell.TH.Syntax !!! Any suggestions? Thanks, Joel -- http://wagerlabs.com/ ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
Joel Reymont wrote:
Folks,
I have very uniform Parsec code like this and I'm wondering if I can
derive it using TemplateHaskell or DrIFT or some other tool. Any ideas?
Others have given good answers on how to use code-generation. I am more
interested in whether code generation is actually necessary for this
example. Haskell has good data-manipulation tools, and parsers are a
kind of data...
First of all, the nullary commands. Here is an abbreviated version with
only them:
strCall =
choice [ do { reserved NewLine
; return NewLine
}
, do { reserved GetSymbolName
; return GetSymbolName
}
, do { reserved Description
; return Description
}
, do { reserved GetExchangeName
; return GetExchangeName
}
, do { reserved SymbolRoot
; return SymbolRoot
}
]
The 'do' syntax is unpleasantly verbose for such simple examples. As a
guideline, I personally only use 'do' syntax if there is at least one
result to 'capture' (bind) and use elsewhere. Already the code is easier
to read if we do something like this:
strCall =
choice [ reserved NewLine return NewLine
, reserved GetSymbolNamereturn GetSymbolName
, reserved Description return Description
, reserved GetExchangeName return GetExchangeName
, reserved SymbolRoot return SymbolRoot
]
Now this we can make simpler with the very basic 'metaprogramming' built
into the 'deriving Show' that haskell has:
nullary x = reserved (show x) return x
strCall = choice ( map nullary
[NewLine,GetSymbolName,Description,GetExchangeName,SymbolRoot] )
To do the same for unaries, we need to know which kind of parameter to
expect.
data paramType = JNum | JBool | JStr
paramParser JNum = numExpr
paramParser JBool = boolExpr
paramParser JStr = strExpr
unary x pt = reserved (quasiShow (x undefined)) parens (paramParser
pt) = return . x
strCall = choice ( map unary
[ELDateToString,TextGetString,LowerStr,UpperStr,Spaces] )
But what is 'quasiShow'? This is the function which maps these
constructors to their string representation, without inspecting the
argument (so I can safely pass undefined). This perhaps you do need
meta-programming for. Although, I think you can write the following:
quasiShow = takeWhile (/=' ') . show
Feels a bit ugly though :)
And now binaries are only slightly more complex (but now I will use 'do'
notation):
binary x pta ptb = reserved (quasiShow x undefined undefined)
parens $ do a - paramParser pta
comma
b - paramParser ptb
return x a b
I'm sure you can work out ternaries.
Of course if you want to automatically choose binary, ternary or unary
from the definition of the ADT then you're thoroughly back into the
world of metaprogramming.
The purpose of this message was not to discourage you from
metaprogamming, which is a powerful tool, but just to show that haskell
is capable of many things which in other languages would be
metaprogramming, either entirely without a meta part, or just using the
limited built in meta-facilities (i.e. derived instances).
Jules
___
Haskell-Cafe mailing list
Haskell-Cafe@haskell.org
http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
Jules Bean wrote: data paramType = JNum | JBool | JStr paramParser JNum = numExpr paramParser JBool = boolExpr paramParser JStr = strExpr unary x pt = reserved (quasiShow (x undefined)) parens (paramParser pt) = return . x strCall = choice ( map unary [ELDateToString,TextGetString,LowerStr,UpperStr,Spaces] ) Oops. unary (x,pt) = reserved (quasiShow (x undefined)) parens (paramParser pt) = return . x strCall = choice ( map unary [(ELDateToString,JNum),(TextGetString,JNum), (LowerStr,JStr),(UpperStr,JStr),(Spaces,JStr)] ) (have to specify the param types) Jules ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
With derive compiled and installed I thought I would change the code
a bit and try it...
ghci -fth -v0 -e '$( _derive_print_instance makeFunParser
Foo )' baz.hs
baz.hs:30:3: Not in scope: `a1'
Any help is appreciated!
Thanks, Joel
---
FunParser.hs:
module FunParser where
import Data.Derive
import Data.Derive.Peephole
import Data.List
import Text.ParserCombinators.Parsec ( CharParser )
makeFunParser = Derivation drv FunParser
drv dat@(DataDef name arity ctors) =
simple_instance FunParser dat [funN parse [ sclause [] body ] ]
where
body = l1 choice $ lst [ clause con | con - ctors ]
clause con = l1 reserved (lit (trim (ctorName con)))
: args con (ctorArity con)
trim = reverse . takeWhile (/= '.') . reverse
args ct 0 = return' (ctp ct 'a')
args ct k = l1 char (lit '(') : args' ct k 0
args' ct remn seen = l0 parse
=: (('a' : show seen)
-: args'' ct (remn-1) (seen+1))
args'' ct 0 seen = l1 char (lit ')') : return' (ctp ct 'a')
args'' ct k seen = l1 char (lit ',') : args' ct k seen
class FunParser a
where parse :: CharParser s a
baz.hs:
import Text.ParserCombinators.Parsec hiding ( parse )
import qualified Text.ParserCombinators.Parsec.Token as T
import Text.ParserCombinators.Parsec.Language( emptyDef )
import Data.Derive.TH
import FunParser
data NumExpr
= Int Integer
| Num Double
instance FunParser NumExpr where
parse = numExpr
data Foo
= Foo NumExpr
lexer = T.makeTokenParser emptyDef
identifier = T.identifier lexer
reserved = T.reserved lexer
integer = T.integer lexer
float = T.float lexer
numExpr :: GenParser Char a NumExpr
numExpr =
choice [ integer = return . Int
, float = return . Num
]
$( derive makeFunParser ''Foo )
--
http://wagerlabs.com/
___
Haskell-Cafe mailing list
Haskell-Cafe@haskell.org
http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
Here's the output from -ddump-splices (thanks Saizan for the tip).
It's returning a1 instead of a0.
ghci -fth -e '$( _derive_print_instance makeFunParser Foo )'
baz.hs -ddump-splices
baz.hs:1:0:
baz.hs:1:0: Splicing declarations
derive makeFunParser 'Foo
==
baz.hs:30:3-28
instance {FunParser Main.Foo} where
[]
{ parse = choice
[()
(reserved ['F', 'o', 'o'])
(()
(char '(') ((=) parse (\ a0 - ()
(char ')') (return (Main.Foo a1)] }
baz.hs:30:3: Not in scope: `a1'
--
http://wagerlabs.com/
___
Haskell-Cafe mailing list
Haskell-Cafe@haskell.org
http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
On Thu, Apr 05, 2007 at 02:47:21PM +0100, Joel Reymont wrote:
Here's the output from -ddump-splices (thanks Saizan for the tip).
It's returning a1 instead of a0.
ghci -fth -e '$( _derive_print_instance makeFunParser Foo )'
baz.hs -ddump-splices
baz.hs:1:0:
baz.hs:1:0: Splicing declarations
derive makeFunParser 'Foo
==
baz.hs:30:3-28
instance {FunParser Main.Foo} where
[]
{ parse = choice
[()
(reserved ['F', 'o', 'o'])
(()
(char '(') ((=) parse (\ a0 - ()
(char ')') (return (Main.Foo a1)] }
baz.hs:30:3: Not in scope: `a1'
Sorry for the late multiple reply, I just spent seven hours sleeping...
I am not the maintainer of Data.Derive, nor did I write the majority
of the nice code; Neil Mitchell did it, you can ask him why replace
DrIFT. However, using abstract syntax trees WAS my idea.
First, _derive_print_instance will never give you a TH splice error,
since it always evaluates to an empty list of declarations. It uses
the TH 'runIO' facility such that type-checking a file using
_derive_print_instance will emit the instances to standard output as a
side effect. So the error is coming from the $(derive) in baz.hs, if
you have more errors try commenting it out. (you'll get bogus code on
stdout, but at least it will be completly haskell!)
_derive_print_instance was not intended to be a debugging aid,
although it certainly works well in that capacity. The intent is that
it will be used when the standalone driver is rewritten to use TH,
which I intend to do not long after I can (Neil is out of
communication for a week with intent to continue hacking Derive; I'm
taking this as a repository lock).
Yes, we do use type classes to implement recursion across types. This
seems to be a very standard idiom in Haskell, used by Show, Read, Eq,
Ord, NFData, Arbitrary, and doubtless many more.
___
Haskell-Cafe mailing list
Haskell-Cafe@haskell.org
http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
On Thu, Apr 05, 2007 at 03:19:15PM +0100, Joel Reymont wrote: numExpr :: GenParser Char a NumExpr numExpr = choice [ integer = return . Int , float = return . Num ] Parsec's choice operator works by parsing the first, and only parsing the second if the first fails immediately. So, given the input 123.456: - Parsec parses 'integer = return . Int' - this is successful - numExpr returns (Int 123, .456) - we try to match . against ) and fail. The fix is to left-factor the grammar, or just use the existing factored choice operator: numExpr :: GenParser Char a NumExpr numExpr = do sg - lexeme sign nf - natOrFloat return $ either (Int . sg) (Nat . sg) nf It seems silly that there is no signed version of natOrFloat predefined, any Parsec experts? Stefan ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
Shouldn't this work just as well? numExpr = choice [ try $ float = return . Num , integer = return . Int ] It works on Foo(10.345) but not on Bar(10, 103.34). On Apr 5, 2007, at 4:09 PM, Stefan O'Rear wrote: numExpr :: GenParser Char a NumExpr numExpr = do sg - lexeme sign nf - natOrFloat return $ either (Int . sg) (Nat . sg) nf It seems silly that there is no signed version of natOrFloat predefined, any Parsec experts? Stefan -- http://wagerlabs.com/ ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
On Wed, Apr 04, 2007 at 04:48:56PM -0700, Stefan O'Rear wrote: Data.Derive can do this. In an attempt to avoid munging the relevent files they are attached. You might want to note that DrIFT used to be called derive before it (amicably) changed its name due to a conflict with a product of the same name. John -- John Meacham - ⑆repetae.net⑆john⑈ ___ Haskell-Cafe mailing list Haskell-Cafe@haskell.org http://www.haskell.org/mailman/listinfo/haskell-cafe
Re: [Haskell-cafe] Automatic derivation (TemplateHaskell?)
On Thu, Apr 05, 2007 at 12:14:52AM +0100, Joel Reymont wrote:
Folks,
I have very uniform Parsec code like this and I'm wondering if I can
derive it using TemplateHaskell or DrIFT or some other tool. Any ideas?
Note that
1) The reserved word matches the constructor
2) No arguments equals no parens
3) More than one argument is separated with a comma
4) For every invocation of numExpr, strExpr or boolExpr, the type of
the constructor argument is NumExpr, StrExpr and BoolExpr respectively.
This is just a handful of functions and I have to tackle about 100
more, thus my asking :-).
Thanks, Joel
Data.Derive can do this. In an attempt to avoid munging the relevent
files they are attached.
[EMAIL PROTECTED]:/tmp$ ghci -fth -v0 -i/usr/local/src/derive -e '$(
_derive_print_instance makeJoelR Foo )' Sample.hs
instance JoelR Main.Foo
where parse = choice [() (reserved ['A']) (() (char '(') ((=) parse
(\a0 - () (char ')') (return (Main.A a1),
() (reserved ['B']) (() (char '(') ((=) parse
(\a0 - () (char ',') ((=) parse (\a1 - ()
(char ')') (return (Main.B a1 a2))),
() (reserved ['C']) (return Main.C)]
Not pretty code, but it will work. (Future plans include adding a
prefix - infix translator to the optimizer.)
http://www.cs.york.ac.uk/fp/darcs/derive
Stefan
import Text.ParserCombinators.Parsec
import Data.Derive.JoelR
import Data.Derive.TH
class JoelR a where parse :: CharParser s a
data NumExpr = Dummy_ -- I don't know the constr
numExpr = undefined
instance JoelR NumExpr where parse = numExpr
data Foo = A NumExpr | B Foo Foo | C
module Data.Derive.JoelR where
import Data.Derive
import Data.Derive.Peephole
import Data.List
makeJoelR = Derivation drv JoelR
drv dat@(DataDef name arity ctors) =
simple_instance JoelR dat [funN parse [ sclause [] body ] ]
where
body = l1 choice $ lst [ clause con | con - ctors ]
clause con = l1 reserved (lit (trim (ctorName con))) : args con (ctorArity con)
trim = reverse . takeWhile (/= '.') . reverse
args ct 0 = return' (ctp ct 'a')
args ct k = l1 char (lit '(') : args' ct k 0
args' ct remn seen = l0 parse =: (('a' : show seen) -: args'' ct (remn-1) (seen+1))
args'' ct 0 seen = l1 char (lit ')') : return' (ctp ct 'a')
args'' ct k seen = l1 char (lit ',') : args' ct k seen
___
Haskell-Cafe mailing list
Haskell-Cafe@haskell.org
http://www.haskell.org/mailman/listinfo/haskell-cafe
