Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Wednesday 13 January 2016 20:10:30 Pavel Machek wrote: > On Wed 2016-01-13 20:07:36, Pavel Machek wrote: > > On Wed 2016-01-13 09:54:55, Pali Rohár wrote: > > > On Tuesday 12 January 2016 22:58:04 Pavel Machek wrote: > > > > Hi! > > > > > > > > > Next question is.. apparently there are some

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Mon, Jan 11, 2016 at 09:03:01PM +0100, Pali Rohár wrote: > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > The two features are not the same (and are handled differently by the > > firmware, for whatever reason), although they do serve the same > > purpose. I don't

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Tue, Jan 12, 2016 at 02:07:10PM -0200, Henrique de Moraes Holschuh wrote: > On Mon, Jan 11, 2016, at 19:12, Johannes Stezenbach wrote: > > > > I can confirm this, my x230 has both. FWIW, BIOS hotkey > > Fn+Space cycles through off, dim backlight, full backlight > > and full thinklight.

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Monday 04 January 2016 21:12:31 Pavel Machek wrote: > Hi1 > > > This patch adds support for controlling keyboard backlight via > > standard linux led class interface (::kbd_backlight). It uses ACPI > > HKEY device with MLCG and MLCS methods. > > > > Signed-off-by: Pali Rohár

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Tue, Jan 12, 2016 at 03:56:07PM -0200, Henrique de Moraes Holschuh wrote: > On Tue, Jan 12, 2016, at 14:35, Johannes Stezenbach wrote: > > But what to look out for? > > Well, you should familiarize yourself with ACPI AML a bit. Then, look > for the ACPI methods that thinkpad-acpi (and the

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Tuesday 12 January 2016 22:58:04 Pavel Machek wrote: > Hi! > > On Mon 2016-01-11 21:03:01, Pali Rohár wrote: > > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > > The two features are not the same (and are handled differently by the > > > firmware, for whatever

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Wednesday 30 December 2015 23:28:48 Pali Rohár wrote: > On Monday 28 December 2015 15:48:14 Pali Rohár wrote: > > > Also, is it working properly across suspend+resume? > > > > When doing resume from suspend or hibernate BIOS turning keyboard > > backlight automatically off. > > Fixed in v2. >

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Wed 2016-01-13 09:54:55, Pali Rohár wrote: > On Tuesday 12 January 2016 22:58:04 Pavel Machek wrote: > > Hi! > > > > On Mon 2016-01-11 21:03:01, Pali Rohár wrote: > > > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > > > The two features are not the same (and are

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Wed 2016-01-13 20:07:36, Pavel Machek wrote: > On Wed 2016-01-13 09:54:55, Pali Rohár wrote: > > On Tuesday 12 January 2016 22:58:04 Pavel Machek wrote: > > > Hi! > > > > > > Next question is.. apparently there are some keyboards that have > > > per-key RGB backlight... but maybe we can just

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On 01/12/2016 10:20 AM, Henrique de Moraes Holschuh wrote: > On Tue, Jan 12, 2016, at 16:11, Kevin Locke wrote: >> I looked through the DSDT and SSDT AML on the T430 (which also has both >> a keyboard backlight and ThinkLight) and couldn't deduce which method >> was being invoked for Fn+Space or

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Tue, Jan 12, 2016, at 14:59, Darren Hart wrote: > Gah, these two threads landed next to each other in my Inbox and I didn't > pick > up the split. Apologies. > > This is queued in testing (again). Thanks! -- "One disk to rule them all, One disk to find them. One disk to bring them all

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

Hi! On Mon 2016-01-11 21:03:01, Pali Rohár wrote: > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > The two features are not the same (and are handled differently by the > > firmware, for whatever reason), although they do serve the same > > purpose. I don't think a

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Mon, Jan 11, 2016, at 18:03, Pali Rohár wrote: > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > The two features are not the same (and are handled differently by the > > firmware, for whatever reason), although they do serve the same > > purpose. I don't think a

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Mon, Jan 11, 2016 at 05:28:00PM -0200, Henrique de Moraes Holschuh wrote: > > > Henrique, so are you taking back your Ack from 10 minutes prior? > > Hmm? No, the ACK stands. > > Pavel was talking about another feature altogether, apparently: older > thinkpads did not have "keyboard

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On mar., 2016-01-12 at 14:07 -0200, Henrique de Moraes Holschuh wrote: > We likely need to integrate better (future work) the new backlight > control with the thinklight control and the firmware interface in the > x230. Ok so I've just checked my work X230, and I was just wrong: no ThinkLight on

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Mon, Jan 11, 2016, at 19:12, Johannes Stezenbach wrote: > On Mon, Jan 11, 2016 at 09:03:01PM +0100, Pali Rohár wrote: > > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > > The two features are not the same (and are handled differently by the > > > firmware, for whatever

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Sat, Jan 09, 2016 at 03:46:41PM -0200, Henrique de Moraes Holschuh wrote: > On Sat, Jan 9, 2016, at 15:39, Henrique de Moraes Holschuh wrote: > > On Mon, Jan 4, 2016, at 18:12, Pavel Machek wrote: > > > > This patch adds support for controlling keyboard backlight via standard > > > > linux led

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Mon, Jan 11, 2016, at 17:04, Darren Hart wrote: > On Sat, Jan 09, 2016 at 03:46:41PM -0200, Henrique de Moraes Holschuh > wrote: > > On Sat, Jan 9, 2016, at 15:39, Henrique de Moraes Holschuh wrote: > > > On Mon, Jan 4, 2016, at 18:12, Pavel Machek wrote: > > > > > This patch adds support for

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

On Mon, Jan 4, 2016, at 18:12, Pavel Machek wrote: > > This patch adds support for controlling keyboard backlight via standard > > linux led class interface (::kbd_backlight). It uses ACPI HKEY device with > > MLCG and MLCS methods. > > > > Signed-off-by: Pali Rohár > >

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

Hi1 > This patch adds support for controlling keyboard backlight via standard > linux led class interface (::kbd_backlight). It uses ACPI HKEY device with > MLCG and MLCS methods. > > Signed-off-by: Pali Rohár > Tested-by: Fabio D'Urso On my