Re: [ibm-acpi-devel] nvram keys to userspace

2007-05-16 Thread Bastien Nocera
if needed. It seems crazy we are using infrastructure, if the infrastructure can't cope with the new demands. I'll see what i can do. It's new keys added to the input layer's input.h, nothing to do with user-space. Which keys would need to be added anyway? -- Bastien Nocera [EMAIL PROTECTED

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Bastien Nocera
). -- Bastien Nocera [EMAIL PROTECTED] - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-05-29 Thread Bastien Nocera
... -- Bastien Nocera [EMAIL PROTECTED] - This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http

[ibm-acpi-devel] Keyboard backlight support for Lenovo X1 Carbon Touch

2013-10-05 Thread Bastien Nocera
Heya, With Matthew Garrett's help, I've been able to detect and change the keyboard backlight on my laptop using software only. The laptop has 3 levels of backlight (with one of them being 'off') and can, under Linux, only be controlled using Fn+Space key combination. I wanted to control the

[ibm-acpi-devel] [PATCH 6/6] thinkpad_acpi: More Carbon X1 2014 keys

2015-02-18 Thread Bastien Nocera
Add support for newly added evdev keycodes. Signed-off-by: Bastien Nocera had...@hadess.net --- drivers/platform/x86/thinkpad_acpi.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c

[ibm-acpi-devel] [PATCH 3/6] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-18 Thread Bastien Nocera
Signed-off-by: Bastien Nocera had...@hadess.net --- drivers/platform/x86/thinkpad_acpi.c | 71 +++- 1 file changed, 62 insertions(+), 9 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index a6dd017..562d958

[ibm-acpi-devel] [PATCH 5/6] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-18 Thread Bastien Nocera
Signed-off-by: Bastien Nocera had...@hadess.net --- include/uapi/linux/input.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index b0a8130..affe40e 100644 --- a/include/uapi/linux/input.h +++ b/include/uapi/linux/input.h

[ibm-acpi-devel] [PATCH 1/6] thinkpad_acpi: Remember adaptive kbd presence

2015-02-18 Thread Bastien Nocera
Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is initialised. Signed-off-by: Bastien Nocera had...@hadess.net --- drivers/platform/x86/thinkpad_acpi.c | 38 ++-- 1 file changed, 19 insertions

Re: [ibm-acpi-devel] [PATCH 2/6] thinkpad_acpi: Factor out get/set adaptive kbd mode

2015-02-20 Thread Bastien Nocera
On Thu, 2015-02-19 at 21:22 -0800, Darren Hart wrote: On Wed, Feb 18, 2015 at 09:53:35PM +0100, Bastien Nocera wrote: Please provide a commit message. There is always something to say beyond what is in the subject. In this case, I suggest the motivation and justification for the change

Re: [ibm-acpi-devel] [PATCH 3/6] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-20 Thread Bastien Nocera
On Thu, 2015-02-19 at 21:28 -0800, Darren Hart wrote: On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote: Commit message please. Added. Signed-off-by: Bastien Nocera had...@hadess.net --- drivers/platform/x86/thinkpad_acpi.c | 71

[ibm-acpi-devel] [PATCH 3/7] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-20 Thread Bastien Nocera
Add a sysfs attribute to allow privileged users to change the keyboard mode. This could be used by desktop environments to change the keyboard mode depending on the application focused, as the Windows application does. Signed-off-by: Bastien Nocera had...@hadess.net --- drivers/platform/x86

[ibm-acpi-devel] More X1 Carbon (2nd gen) adaptive keyboard support

2015-01-13 Thread Bastien Nocera
Hey, I'm currently working on adding support for the extra adaptive keys for the X1 Carbon 2014 (2nd gen). Below is the (non-working) patch to add support for some of those keys. I'm working with Benjamin Tissoires to add the necessary, missing, Linux keycodes. A couple of questions though: -

Re: [ibm-acpi-devel] [patch 1/2] thinkpad_acpi: signedness bugs getting current_mode

2015-03-11 Thread Bastien Nocera
-By: Bastien Nocera had...@hadess.net -- Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software

[ibm-acpi-devel] [PATCH 3/4] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-03-02 Thread Bastien Nocera
Add a sysfs attribute to allow privileged users to change the keyboard mode. This could be used by desktop environments to change the keyboard mode depending on the application focused, as the Windows application does. Signed-off-by: Bastien Nocera had...@hadess.net --- Documentation/laptops

[ibm-acpi-devel] [PATCH] thinkpad_acpi: use DEVICE_ATTR_* macros

2015-03-02 Thread Bastien Nocera
Use the DEVICE_ATTR_* macros to reduce boiler plate. Signed-off-by: Bastien Nocera had...@hadess.net --- drivers/platform/x86/thinkpad_acpi.c | 72 ++-- 1 file changed, 20 insertions(+), 52 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers

Re: [ibm-acpi-devel] [PATCH 5/6] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-23 Thread Bastien Nocera
On Mon, 2015-02-23 at 07:49 -0300, Henrique de Moraes Holschuh wrote: On Mon, Feb 23, 2015, at 07:15, Bastien Nocera wrote: On Wed, 2015-02-18 at 21:34 -0200, Henrique de Moraes Holschuh wrote: On Wed, 18 Feb 2015, Bastien Nocera wrote: Signed-off-by: Bastien Nocera had...@hadess.net

Re: [ibm-acpi-devel] [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros

2015-02-23 Thread Bastien Nocera
On Mon, 2015-02-23 at 07:25 -0300, Henrique de Moraes Holschuh wrote: On Fri, Feb 20, 2015, at 11:44, Bastien Nocera wrote: Use the DEVICE_ATTR_RW macro to reduce boiler plate So far, so good, but you also used the DEVICE_ATTR_RO macro... and move the attribute declaration to get rid

Re: [ibm-acpi-devel] [PATCH 3/6] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-23 Thread Bastien Nocera
On Mon, 2015-02-23 at 14:00 -0300, Henrique de Moraes Holschuh wrote: On Fri, Feb 20, 2015, at 02:28, Darren Hart wrote: On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote: Commit message please. Signed-off-by: Bastien Nocera had...@hadess.net --- drivers/platform

Re: [ibm-acpi-devel] [PATCH 3/7] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-20 Thread Bastien Nocera
On Fri, 2015-02-20 at 17:27 +0200, Mika Westerberg wrote: On Fri, Feb 20, 2015 at 04:22:07PM +0100, Bastien Nocera wrote: On Fri, 2015-02-20 at 17:20 +0200, Mika Westerberg wrote: On Fri, Feb 20, 2015 at 03:44:22PM +0100, Bastien Nocera wrote: Add a sysfs attribute to allow privileged

[ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-20 Thread Bastien Nocera
Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is initialised. Signed-off-by: Bastien Nocera had...@hadess.net --- drivers/platform/x86/thinkpad_acpi.c | 37 ++-- 1 file changed, 18 insertions

[ibm-acpi-devel] [PATCH 4/7] thinkpad_acpi: Add support for more adaptive kbd buttons

2015-02-20 Thread Bastien Nocera
This commit adds new elements to the ThinkPad keymaps, and will send key events for keys for which an input.h declaration exists. Signed-off-by: Bastien Nocera had...@hadess.net --- drivers/platform/x86/thinkpad_acpi.c | 80 +++- 1 file changed, 79 insertions

[ibm-acpi-devel] [PATCH 5/7] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-20 Thread Bastien Nocera
Signed-off-by: Bastien Nocera had...@hadess.net --- include/uapi/linux/input.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index b0a8130..affe40e 100644 --- a/include/uapi/linux/input.h +++ b/include/uapi/linux/input.h

Re: [ibm-acpi-devel] [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys

2015-02-23 Thread Bastien Nocera
On Fri, 2015-02-20 at 11:27 -0800, Andy Lutomirski wrote: On 02/20/2015 06:44 AM, Bastien Nocera wrote: + KEY_MICCANCEL_MODE, /* Microphone cancellation */ What's this? We already have KEY_MICMUTE. Is this different? If so, can you improve the comment a bit? I don't think

[ibm-acpi-devel] [PATCH 2/7] thinkpad_acpi: Factor out get/set adaptive kbd mode

2015-02-20 Thread Bastien Nocera
Move the getting/setting of the adaptive keyboard mode to separate functions, so that we can reuse them later through sysfs attributes. Signed-off-by: Bastien Nocera had...@hadess.net --- drivers/platform/x86/thinkpad_acpi.c | 61 ++-- 1 file changed, 38

Re: [ibm-acpi-devel] [PATCH 4/6] thinkpad_acpi: Add support for more adaptive kbd buttons

2015-02-20 Thread Bastien Nocera
On Thu, 2015-02-19 at 21:35 -0800, Darren Hart wrote: On Wed, Feb 18, 2015 at 09:53:48PM +0100, Bastien Nocera wrote: This commit adds new elements to the ThinkPad keymaps, and will send key events for keys for which an input.h declaration exists. Signed-off-by: Bastien Nocera had

Re: [ibm-acpi-devel] [PATCH 5/7] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-20 Thread Bastien Nocera
Hey Dmitry, On Fri, 2015-02-20 at 10:40 -0800, Dmitry Torokhov wrote: On Fri, Feb 20, 2015 at 10:04:04AM -0500, Benjamin Tissoires wrote: On Fri, Feb 20, 2015 at 9:44 AM, Bastien Nocera had...@hadess.net wrote: Signed-off-by: Bastien Nocera had...@hadess.net --- include/uapi/linux

Re: [ibm-acpi-devel] adaptive keyboard off after suspend on linux kernel 4.4 and 4.5, (thinkpad x1 gen2)

2016-02-04 Thread Bastien Nocera
ges ;-) > > I will need your help to fix this, I don't have any thinkpad with an > adaptative keyboard to test. In fact, the adaptative keyboard code was a > contribution by Bastien Nocera. Added him to the CC. > > Bastien, can you help debug this issue? > > -- > "One di

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: support HKEY interface version 0x200

2016-04-19 Thread Bastien Nocera
On Tue, 2016-04-19 at 14:42 +0200, Bjørn Mork wrote: > Bastien Nocera <had...@hadess.net> writes: > > > > > From: Shuduo Sang <shuduo.s...@canonical.com> > > > > The Thinkpad X1 Carbon 2nd generation (2014) ships with BIOS that > > will > >

Re: [ibm-acpi-devel] [PATCH 3/3] platform/x86: thinkpad_acpi: Map Clipping tool hotkey to KEY_SELECTIVE_SCREENSHOT

2020-07-17 Thread Bastien Nocera
map this hotkey to the new > KEY_SELECTIVE_SCREENSHOT key-code. > > Signed-off-by: Hans de Goede Added 5 years ago for the Carbon X1 2014, and finally getting a keycode ;) Reviewed-by: Bastien Nocera > --- > drivers/platform/x86/thinkpad_acpi.c | 2 +- > 1 file changed, 1 insertion

Re: [ibm-acpi-devel] [External] Re: [PATCH v4] platform/x86: thinkpad_acpi: lap or desk mode interface

2020-07-27 Thread Bastien Nocera
- Original Message - > Hello Bastien > > >-Original Message----- > >From: Bastien Nocera > > >- Original Message - > >> Newer Lenovo Thinkpad platforms have support to identify whether the > >> system is on-lap or n

Re: [ibm-acpi-devel] [PATCH v4] platform/x86: thinkpad_acpi: lap or desk mode interface

2020-07-26 Thread Bastien Nocera
ed by userspace for thermal mode and WWAN > functionality > > Co-developed-by: Nitin Joshi > Signed-off-by: Nitin Joshi > Reviewed-by: Sugumaran > Signed-off-by: Mark Pearson You can add my: Reviewed-by: Bastien Nocera Cheers __