2
the icons are somewhat creative, which is why I ended up looking them up in
the user manual.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/thinkpad_acpi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b
by the kernel. Change the mapping done of
identical laptop key done by thinkpad_acpi to also send KEY_FILE for
consistency.
Cc: Jamie Lentin j...@lentin.co.uk
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1
in
video_detect.c in the first place.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/internal.h | 7 ---
drivers/acpi/osl.c | 6 ++
drivers/acpi/video_detect.c | 6 --
include/linux/acpi.h| 1 +
4 files changed, 7 insertions(+), 13 deletions
to the new backlight interface selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 01c8c46..98368cf 100644
--- a/drivers/acpi/video_detect.c
This results in a nice cleanup, as we can replace the complicated logic
from should_ignore_backlight_request() with a simple check for the type
being native.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/gpu/drm/i915/intel_opregion.c | 12 +---
1 file changed, 1 insertion
unregistering the
acpi_video backlight interface if it was registered before other drivers
which take priority over it are loaded, to video_detect.c where this
logic really belongs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 172
is not built in. This also changes
some select uses to depends on to avoid dependency loops.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/Makefile| 7 +++
drivers/acpi/video.c | 2 +-
drivers/acpi/video_detect.c | 40
Most of the patch is moving the dmi quirks for forcing use of the
acpi-video / the native backlight interface to video_detect.c.
What remains is a nice cleanup.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video.c| 178
and
it needlessly complicates the code.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video.c| 59 ++---
drivers/acpi/video_detect.c | 27 +
2 files changed, 29 insertions(+), 57 deletions(-)
diff --git a/drivers/acpi
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/asus-wmi.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/acer-wmi.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git
() call to acpi_video_register(),
so that we can be sure the dmi quirks have always been applied before
probing.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi
Hi All,
Here is the long promised rewrite / cleanup of the acpi-video
(and platform/x86) backlight interface selection logic.
Reviewers do not be alarmed by the large number of patches, the gist
of the series is in patches 6-13, the earlier ones are a few simple
prepararion patches, and the
acpi_video_get_capabilities() is only used inside video_detect.c so make
it static. While at it also remove the prototype for the non existent
acpi_video_display_switch_support function from acpi.h
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 3 +--
include
fix would be to dmi-blacklist the gmux
driver on that system.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/apple-gmux.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/apple-gmux.c
b/drivers/platform/x86/apple-gmux.c
index 45032ce..a7f6412
Remove the now unused acpi_video_dmi_demote_vendor() function, this was
never a proper counter part of acpi_video_dmi_promote_vendor() since
the calls to acpi_video_dmi_promote_vendor() are not counted.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 9
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/thinkpad_acpi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/samsung-laptop.c | 27 ---
1 file changed, 4 insertions(+), 23
acpi_video_unregister_backlight() is now only used by video_detect.c
which is part of the same acpi_video module as video.c, make
acpi_video_unregister_backlight() private to this module.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video.c| 1 -
drivers/acpi
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/fujitsu-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/fujitsu-laptop.c
b/drivers
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/intel_oaktrail.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/msi-wmi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/asus-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/eeepc-laptop.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/dell-laptop.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/dell-laptop.c
b/drivers
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/apple-gmux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/apple-gmux.c
b/drivers/platform/x86
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/compal-laptop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/compal-laptop.c
b/drivers
safe manner, this commit adds locking to make this thread safe.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video.c | 43 +--
1 file changed, 21 insertions(+), 22 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/dell-wmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/ideapad-laptop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/ideapad-laptop.c
b/drivers
Port the backlight selection logic to the new backlight interface
selection API.
Also fix a compiler warning about bt_present not being initialized.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/toshiba_acpi.c | 9 +++--
1 file changed, 3 insertions(+), 6
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/sony-laptop.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
Hi,
On 11-06-15 11:19, Pali Rohár wrote:
On Wednesday 10 June 2015 15:01:07 Hans de Goede wrote:
Currently we have 2 kernel commandline options + dmi-quirks in 3 places all
interacting (in interesting ways) to select which which backlight interface
to use. On the commandline we've
Hi,
On 11-06-15 11:00, Aaron Lu wrote:
On Wed, Jun 10, 2015 at 03:01:07PM +0200, Hans de Goede wrote:
Currently we have 2 kernel commandline options + dmi-quirks in 3 places all
interacting (in interesting ways) to select which which backlight interface
to use. On the commandline we've
Hi,
On 11-06-15 14:28, Jani Nikula wrote:
On Thu, 11 Jun 2015, Hans de Goede hdego...@redhat.com wrote:
Hi,
On 11-06-15 11:19, Pali Rohár wrote:
On Wednesday 10 June 2015 15:01:07 Hans de Goede wrote:
Currently we have 2 kernel commandline options + dmi-quirks in 3 places all
interacting
Hi,
On 06/14/2015 05:15 AM, Azael Avalos wrote:
Hi Hans,
Sorry for the late reply, I was out of town.
2015-06-12 5:23 GMT-06:00 Hans de Goede hdego...@redhat.com:
Port the backlight selection logic to the new backlight interface
selection API.
Also fix a compiler warning about bt_present
This results in a nice cleanup, as we can replace the complicated logic
from should_ignore_backlight_request() with a simple check for the type
being native.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/gpu/drm/i915/intel_opregion.c | 12 +---
1 file changed, 1 insertion
to the new backlight interface selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 0f9586b..d00c0f4 100644
--- a/drivers/acpi/video_detect.c
unregistering the
acpi_video backlight interface if it was registered before other drivers
which take priority over it are loaded, to video_detect.c where this
logic really belongs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 171
on CONFIG_ACPI_VIDEO.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/scan.c | 56 ++
drivers/acpi/video_detect.c | 60 -
include/linux/acpi.h| 8 ++
3 files changed, 58 insertions
Most of the patch is moving the dmi quirks for forcing use of the
acpi-video / the native backlight interface to video_detect.c.
What remains is a nice cleanup.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 172
and
it needlessly complicates the code.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 59 ++---
drivers/acpi/video_detect.c | 27 +
2 files changed, 29 insertions(+), 57 deletions(-)
diff --git a/drivers/acpi
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/asus-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Pali Rohár pali.ro...@gmail.com
---
drivers/platform/x86/dell-laptop.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers
safe manner, this commit adds locking to make this thread safe.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 43 +--
1 file changed, 21 insertions(+), 22 deletions(-)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Henrique de Moraes Holschuh h...@hmh.eng.br
---
drivers/platform/x86/thinkpad_acpi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Azael Avalos coproscef...@gmail.com
---
Changes in v3:
-Drop chunk fixing compiler warning, already fixed.
---
drivers/platform/x86/toshiba_acpi.c | 7
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/samsung-laptop.c | 27 ---
1 file changed, 4 insertions(+), 23
acpi_video_unregister_backlight() is now only used by video_detect.c
which is part of the same acpi_video module as video.c, make
acpi_video_unregister_backlight() private to this module.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 1 -
drivers/acpi
Hi Rafael,
As requested here is a rebased version of my acpi-video backlight interface
selection logic rewrite. This is based on linux-pm/linux-next.
I've also included 3 platform/x86 patches already queued up by Darren as you
will need those to apply some later patches without conflicts. These
in
video_detect.c in the first place.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/internal.h | 7 ---
drivers/acpi/osl.c | 6 ++
drivers/acpi/video_detect.c | 6 --
include/linux/acpi.h| 1 +
4 files changed, 7 insertions(+), 13 deletions
video bus is
the canonical source for brightness events I believe that the latter case
will needs to be handled on a case by case basis by filtering out the
duplicate keypresses at the other source for them.
Cc: Corentin Chary corentin.ch...@gmail.com
Signed-off-by: Hans de Goede hdego...@redhat.com
for brightness events I believe that the latter case
will needs to be handled on a case by case basis by filtering out the
duplicate keypresses at the other source for them.
Cc: Seth Forshee seth.fors...@canonical.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/apple-gmux.c
acpi_video_get_capabilities() is only used inside video_detect.c so make
it static. While at it also remove the prototype for the non existent
acpi_video_display_switch_support function from acpi.h
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 3 +--
include
Hi,
On 10-06-15 23:30, Mattia Dongili wrote:
On Wed, Jun 10, 2015 at 03:01:28PM +0200, Hans de Goede wrote:
Port the backlight selection logic to the new backlight interface
selection API.
This commit also removes various obsolete pr_xxx messages related to
backlight interface selection
in
video_detect.c in the first place.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/internal.h | 7 ---
drivers/acpi/osl.c | 6 ++
drivers/acpi/video_detect.c | 6 --
include/linux/acpi.h| 1 +
4 files changed, 7 insertions(+), 13 deletions
This commit also makes changes to drivers/platform/x86/Kconfig to ensure
that drivers which use acpi_video_backlight_support() from video_detect.c,
will not be built-in when acpi_video is not built in. This also changes
some select uses to depends on to avoid dependency loops.
Signed-off-by: Hans de
Hi All,
Here is v2 of my rewrite / cleanup of the acpi-video (and platform/x86)
backlight interface selection logic.
The major change in v2 of this set are 2 changes to the patch titled
acpi-video-detect: video: Make video_detect code part of the video module:
1) The __setup call for the
Remove the now unused acpi_video_dmi_demote_vendor() function, this was
never a proper counter part of acpi_video_dmi_promote_vendor() since
the calls to acpi_video_dmi_promote_vendor() are not counted.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 9
fix would be to dmi-blacklist the gmux
driver on that system.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/apple-gmux.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/apple-gmux.c
b/drivers/platform/x86/apple-gmux.c
index 45032ce..a7f6412
on CONFIG_ACPI_VIDEO.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/scan.c | 56 ++
drivers/acpi/video_detect.c | 60 -
include/linux/acpi.h| 8 ++
3 files changed, 58 insertions
unregistering the
acpi_video backlight interface if it was registered before other drivers
which take priority over it are loaded, to video_detect.c where this
logic really belongs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 171
Remove the old backlight interface selection API now that all drivers
have been ported to the new API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 31 ---
include/linux/acpi.h| 19 ---
2 files changed, 50
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Mattia Dongili malat...@linux.it
---
drivers/platform/x86/sony-laptop.c | 7 ++-
1 file changed, 2
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/msi-wmi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/samsung-laptop.c | 27 ---
1 file changed, 4 insertions(+), 23
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/msi-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
to the new backlight interface selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 1ae7536..2807bbf 100644
--- a/drivers/acpi/video_detect.c
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Jonathan Woithe jwoi...@just42.net
---
drivers/platform/x86/fujitsu-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Most of the patch is moving the dmi quirks for forcing use of the
acpi-video / the native backlight interface to video_detect.c.
What remains is a nice cleanup.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 178
This results in a nice cleanup, as we can replace the complicated logic
from should_ignore_backlight_request() with a simple check for the type
being native.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/gpu/drm/i915/intel_opregion.c | 12 +---
1 file changed, 1 insertion
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/ideapad-laptop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/ideapad-laptop.c
b/drivers
and
it needlessly complicates the code.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 59 ++---
drivers/acpi/video_detect.c | 27 +
2 files changed, 29 insertions(+), 57 deletions(-)
diff --git a/drivers/acpi
acpi_video_unregister_backlight() is now only used by video_detect.c
which is part of the same acpi_video module as video.c, make
acpi_video_unregister_backlight() private to this module.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 1 -
drivers/acpi
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/compal-laptop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/compal-laptop.c
b/drivers
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/apple-gmux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/apple-gmux.c
b/drivers/platform/x86
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/eeepc-laptop.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
Hi All,
This patch-set is the result of the discussion surrounding the
backlight issues on the Dell Vostro V131. The first 3 patches
cleanup how some platform/x86 drivers detect if acpi-video
is handling brightness key presses and that they should
not report duplicate events. This is a cleanup
.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 0bed473..f453d5d 100644
--- a/drivers/platfo
Hi,
On 28-12-15 00:08, Henrique de Moraes Holschuh wrote:
> On Tue, 22 Dec 2015, Hans de Goede wrote:
>> Use the new acpi_video_handles_brightness_key_presses function to check
>> if we should report brightness key-presses.
>>
>> This makes the code both easier to
7714687a2b2d ("thinkpad_acpi: Use
acpi_video_handles_brightness_key_presses()").
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/
Document that acpi_video_handles_brightness_key_presses()'s return value
may change over time and should not be cached.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
include/acpi/video.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/acpi/video.h b/include/acpi/v
aecbd9b1bff6 ("ACPI / video: driver must be registered
before checking for keypresses") fixing this.
This reintroduces a potential NULL pointer deref due to using an
uninitalized mutex, this is fixed differently in a follow-up patch.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
-
Hi,
On 01/24/2017 11:56 PM, Jacek Anaszewski wrote:
> Hi,
>
> On 01/24/2017 01:32 PM, Pavel Machek wrote:
>> Hi!
>>
> There might exist users that adjust LED brightness while having
> active trigger. The best example is default-on trigger - it sets
> brightness only on init, but
not want to put the notifier head in
either driver, as that will make the 2 drivers depend on each other.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
Changes in v2:
-This is a new patch in v2 of this patch-set
Changes in v3:
-No changes
---
drivers/platform/x86/dell-smbios.
Make dell-wmi call led_notify_brightness_change on the kbd_led led_classdev
registered by dell-laptop when the kbd backlight brightness changes.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
Changes in v2:
-Use the new dell_smbios*notify functionality
Changes in v3:
-Si
ect such autonomous changes.
This commit also updates the Documentation/ABI/testing/sysfs-class-led
documentation to document that userspace may now poll on the brightness
attribute.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
Changes in v2:
-Wakeup / notify userspace on any brightness changes,
Make thinkpad_acpi call led_notify_brightness_change on the kbd_led
led_classdev registered by thinkpad_acpi when the kbd backlight
brightness changes.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
Changes in v3:
-This is a new patch in v3 of this patch-set
---
drivers/platfo
anyways, so this
is not an issue and there is a work-around.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
Changes in v2:
-This is a new patch in v2 of my platform/x86/dell-* notifier set intended
to show how dell_smbios*notifier can be used to improve the dell-rbtn
integration too
C
Hi,
On 27-10-16 12:38, Pali Rohár wrote:
> On Wednesday 26 October 2016 19:41:18 Hans de Goede wrote:
>> Use dell_smbios*notifier for dell-laptop to listen to dell-rbtn slider
>> events, replace dell_rbtn_notifier_register() /
>> dell_rbtn_notifier_unregister() with a single
Hi,
On 27-10-16 13:59, Pali Rohár wrote:
> On Thursday 27 October 2016 13:46:33 Hans de Goede wrote:
>> Hi,
>>
>> On 27-10-16 12:38, Pali Rohár wrote:
>>> On Wednesday 26 October 2016 19:41:18 Hans de Goede wrote:
>>>> Use dell_smbios*notifier for
d by a
>> hardwired (firmware handled) hotkey. led_notify_brightness_change is
>> exported for use by drivers which can detect such autonomous changes.
>>
>> This commit also updates the Documentation/ABI/testing/sysfs-class-led
>> documentation to document that userspace
Hi,
On 08-11-16 14:08, Jacek Anaszewski wrote:
> On 11/08/2016 01:31 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 08-11-16 12:52, Jacek Anaszewski wrote:
>>> Hi Hans,
>>>
>>> I've tested it with userspace test application and it seems to work
Hi,
On 11-11-16 15:12, Pali Rohár wrote:
> On Tuesday 01 November 2016 14:37:46 Hans de Goede wrote:
>> Make thinkpad_acpi call led_notify_brightness_change on the kbd_led
>> led_classdev registered by thinkpad_acpi when the kbd backlight
>> brightness changes.
>>
>
Hi,
On 11-11-16 15:17, Pali Rohár wrote:
> On Tuesday 01 November 2016 14:37:47 Hans de Goede wrote:
>> @@ -43,4 +45,13 @@ void dell_smbios_release_buffer(void);
>> void dell_smbios_send_request(int class, int select);
>>
>> struct calling_interface_token *dell_sm
Hi,
On 25-11-16 11:01, Pavel Machek wrote:
> Hi!
>
>> In view of the above we could report hw brightness changes with POLLPRI
>> on brightness file, but unfortunately we can't because it is impossible
>> to guarantee that readout of brightness file will return the brightness
>> the POLLPRI was
HI,
On 18-11-16 17:03, Jacek Anaszewski wrote:
> Hi,
>
> On 11/18/2016 10:07 AM, Hans de Goede wrote:
>> Hi,
>>
>> On 18-11-16 09:55, Jacek Anaszewski wrote:
>>> Hi Hans,
>>>
>>> Thanks for the patch.
>>>
>>> I think we need
.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
Changes in v5:
-This is a new patch in v5 of this patch-set (replacing earlier attempts
at similar functionality)
---
Documentation/ABI/testing/sysfs-class-led | 15 +-
drivers/leds/led-triggers.c
Make dell-wmi call ledtrig_kbd_backlight() when the keyboard-backlight
brightness changes.
This will allow userspace to monitor (poll) for brightness changes on
these LEDs caused by the hotkey.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
Changes in v2:
-Use the new dell_smbios*
In some cases an LED is controlled through a hardwired (taken care of
in firmware outside of the kernels control) trigger.
Add an LED_TRIGGER_READ_ONLY flag for this and disallow user-space
changing the trigger when this flag is set.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
C
1 - 100 of 326 matches
Mail list logo
